diff options
| author | Bruce Richardson <bruce.richardson@intel.com> | 2019-04-08 10:46:38 +0100 |
|---|---|---|
| committer | Thomas Monjalon <thomas@monjalon.net> | 2019-04-23 00:15:10 +0200 |
| commit | 3f1b8bf9139ab94aa5ba1334499c3928ec630359 (patch) | |
| tree | 4d3e0f6d746431600d6b875b2dbab2c075d78b83 | |
| parent | 6fd5b5734faf2f902aebf57e966e5adb0499a1ff (diff) | |
net/i40e: fix dereference before null check in mbuf release
Coverity flags that the txq variable is used before it's checked for NULL.
Also fix typo in error message.
Coverity issue: 195023
Fixes: 24853544c84c ("net/i40e: fix mbuf free in vector Tx")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Rami Rosen <ramirose@gmail.com>
| -rw-r--r-- | drivers/net/i40e/i40e_rxtx.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 58ed8145db..1489552da4 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -2423,13 +2423,13 @@ i40e_tx_queue_release_mbufs(struct i40e_tx_queue *txq) struct rte_eth_dev *dev; uint16_t i; - dev = &rte_eth_devices[txq->port_id]; - if (!txq || !txq->sw_ring) { - PMD_DRV_LOG(DEBUG, "Pointer to rxq or sw_ring is NULL"); + PMD_DRV_LOG(DEBUG, "Pointer to txq or sw_ring is NULL"); return; } + dev = &rte_eth_devices[txq->port_id]; + /** * vPMD tx will not set sw_ring's mbuf to NULL after free, * so need to free remains more carefully. |