summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Schmidt <jan@centricular.com>2024-02-25 04:26:21 +1100
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>2024-03-07 01:35:09 +0000
commitdf34adae9e573fadad8bef2309e454a7ad4c001d (patch)
tree54ee2bb116f4460924228a9720743c47ea347163
parent1190761f7edc9cfbd927a4ba0aeaf902e097251a (diff)
gstsegment: Don't use g_return_val_if_fail()
Don't use g_return_val_if_fail() to catch the open-ended segment or empty segment cases in gst_segment_to_running_time_full() g_return_val_if_fail() is for programmer errors, and can be compiled out with a flag. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6279>
-rw-r--r--subprojects/gstreamer/gst/gstsegment.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/subprojects/gstreamer/gst/gstsegment.c b/subprojects/gstreamer/gst/gstsegment.c
index f3977072a3..a26b943e34 100644
--- a/subprojects/gstreamer/gst/gstsegment.c
+++ b/subprojects/gstreamer/gst/gstsegment.c
@@ -769,8 +769,8 @@ gst_segment_to_running_time_full (const GstSegment * segment, GstFormat format,
stop = segment->start + segment->duration;
/* cannot continue if no stop position set or invalid offset */
- g_return_val_if_fail (stop != -1, 0);
- g_return_val_if_fail (stop >= offset, 0);
+ if (stop == -1 || stop < offset)
+ return 0;
stop -= offset;