diff options
| author | Víctor Manuel Jáquez Leal <vjaquez@igalia.com> | 2019-05-03 10:31:52 +0200 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2019-05-09 01:05:31 +0200 |
| commit | 66992c38fc838b62a100dd4ceb5f1a29f0c61e90 (patch) | |
| tree | caec353e424ac3f1a877a0b12101f45d053bf67d | |
| parent | 1fb31192b9e070f3d661f4786d63cc99b87ff589 (diff) | |
libs: encoder: continue if roi meta is NULL
Coverity scan bug:
If the function actually returns a null value, a null pointer
dereference will occur.
In gst_vaapi_encoder_ensure_param_roi_regions(): Return value of
function which returns null is dereferenced without checking
| -rw-r--r-- | gst-libs/gst/vaapi/gstvaapiencoder.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/gst-libs/gst/vaapi/gstvaapiencoder.c b/gst-libs/gst/vaapi/gstvaapiencoder.c index caddb75478..d483f036d3 100644 --- a/gst-libs/gst/vaapi/gstvaapiencoder.c +++ b/gst-libs/gst/vaapi/gstvaapiencoder.c @@ -329,6 +329,8 @@ gst_vaapi_encoder_ensure_param_roi_regions (GstVaapiEncoder * encoder, roi = (GstVideoRegionOfInterestMeta *) gst_buffer_iterate_meta_filtered (input, &state, GST_VIDEO_REGION_OF_INTEREST_META_API_TYPE); + if (!roi) + continue; /* ignore roi if overflow */ if ((roi->x > G_MAXINT16) || (roi->y > G_MAXINT16) |