diff options
| author | Richard Barnes <rbarnes@meta.com> | 2024-01-17 14:08:07 -0800 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2024-01-17 14:08:07 -0800 |
| commit | 59ba1d200d657d328e91b18cc2a71cf7062a3745 (patch) | |
| tree | 4c39672c44a2f6cba2e18e1d15460efa4cd8430f | |
| parent | 65e162bf09e6d81d5de533539753d80c008717fd (diff) | |
Remove unused variables in internal_repo_rocksdb/repo/env/env_posix.cc (#12243)
Summary:
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12243
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.
This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.
- If you approve of this diff, please use the "Accept & Ship" button :-)
Reviewed By: jowlyzhang
Differential Revision: D52847993
fbshipit-source-id: 221da13c6ca9967e3b934f98f318a832a144df39
| -rw-r--r-- | env/env_posix.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/env/env_posix.cc b/env/env_posix.cc index 9a02a7d11..d3ad33e7c 100644 --- a/env/env_posix.cc +++ b/env/env_posix.cc @@ -86,9 +86,9 @@ namespace ROCKSDB_NAMESPACE { #if defined(OS_WIN) static const std::string kSharedLibExt = ".dll"; -static const char kPathSeparator = ';'; +[[maybe_unused]] static const char kPathSeparator = ';'; #else -static const char kPathSeparator = ':'; +[[maybe_unused]] static const char kPathSeparator = ':'; #if defined(OS_MACOSX) static const std::string kSharedLibExt = ".dylib"; #else |