diff options
| author | Hui Xiao <huixiao@fb.com> | 2024-07-16 12:37:50 -0700 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2024-07-16 12:37:50 -0700 |
| commit | 6870cc1187c12458b3c5b4d2ba2f4ac22d5b0049 (patch) | |
| tree | 5376636d9816bdb09b66fe53b0b328ede018aee0 | |
| parent | 9e4ee7f0c6aece9d9b2e8ddebf9511146048bc55 (diff) | |
Temporally disable log recycle with testing GetLiveFilesStorageInfo() (#12868)
Summary:
**Context/Summary:**
We recently discovered a case where `GetLiveFilesStorageInfo()` failed when `Options::recycle_log_file_num` > 0. Before fixing the incompatibility, we disable these combination in stress test.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12868
Test Plan: monitor CI
Reviewed By: jowlyzhang
Differential Revision: D59820802
Pulled By: hx235
fbshipit-source-id: 7b09063af6d72ae0ba187b4cf8887abd8a78e5e8
| -rw-r--r-- | db_stress_tool/db_stress_test_base.cc | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/db_stress_tool/db_stress_test_base.cc b/db_stress_tool/db_stress_test_base.cc index e2361b752..d6e5e5cac 100644 --- a/db_stress_tool/db_stress_test_base.cc +++ b/db_stress_tool/db_stress_test_base.cc @@ -1172,8 +1172,12 @@ void StressTest::OperateDb(ThreadState* thread) { ProcessStatus(shared, "GetLiveFiles", s_1); Status s_2 = TestGetLiveFilesMetaData(); ProcessStatus(shared, "GetLiveFilesMetaData", s_2); - Status s_3 = TestGetLiveFilesStorageInfo(); - ProcessStatus(shared, "GetLiveFilesStorageInfo", s_3); + // TODO: enable again after making `GetLiveFilesStorageInfo()` + // compatible with `Options::recycle_log_file_num` + if (FLAGS_recycle_log_file_num == 0) { + Status s_3 = TestGetLiveFilesStorageInfo(); + ProcessStatus(shared, "GetLiveFilesStorageInfo", s_3); + } } if (thread->rand.OneInOpt(FLAGS_get_all_column_family_metadata_one_in)) { |