diff options
| author | Hui Xiao <huixiao@fb.com> | 2024-07-16 10:55:08 -0700 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2024-07-16 10:55:08 -0700 |
| commit | 9e4ee7f0c6aece9d9b2e8ddebf9511146048bc55 (patch) | |
| tree | bfe59624e6525df61be28646d928babb90c9a3a7 | |
| parent | 5aa675457e44598dd6e5828954cecbfc2a1a4f41 (diff) | |
Fix non-okay status being ignored in write path under two_write_queues_ (#12866)
Summary:
Context/Summary: see above, though the impact is small.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12866
Test Plan: exiting UT
Reviewed By: anand1976
Differential Revision: D59782913
Pulled By: hx235
fbshipit-source-id: ec02843645cce49466bde602035d2e61c31965b8
| -rw-r--r-- | db/db_impl/db_impl_write.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/db/db_impl/db_impl_write.cc b/db/db_impl/db_impl_write.cc index 1595aa913..8eef125e9 100644 --- a/db/db_impl/db_impl_write.cc +++ b/db/db_impl/db_impl_write.cc @@ -658,7 +658,7 @@ Status DBImpl::WriteImpl(const WriteOptions& write_options, // Requesting sync with two_write_queues_ is expected to be very rare. We // hence provide a simple implementation that is not necessarily efficient. - if (two_write_queues_) { + if (status.ok() && two_write_queues_) { if (manual_wal_flush_) { status = FlushWAL(true); } else { |