diff options
| author | Igor Canadi <icanadi@fb.com> | 2015-06-10 10:35:19 -0700 |
|---|---|---|
| committer | Igor Canadi <icanadi@fb.com> | 2015-06-10 10:35:19 -0700 |
| commit | 4949ef08db89bdc63028679d1cc11312094e860e (patch) | |
| tree | 5b4688698a6633e7b8bb28543b991417eb0a78e5 /HISTORY.md | |
| parent | e409d3d745f627f8ce4539498c45e3631124310b (diff) | |
Re-generate WriteEntry on WBWIIterator::Entry()
Summary: If we don't do this, any calls to Entry() after WBWI mutation will result in undefined behavior. We need to re-fetch the offset from the skip list and regenerate the new pointer (because string's base pointer can change while mutating).
Test Plan: COMPILE_WITH_ASAN=1 make write_batch_with_index_test && ./write_batch_with_index_test
Reviewers: sdong
Reviewed By: sdong
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D39813
Diffstat (limited to 'HISTORY.md')
| -rw-r--r-- | HISTORY.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/HISTORY.md b/HISTORY.md index 290b613d9..559f942c1 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -11,6 +11,7 @@ * DB::CompactRange()'s parameter reduce_level is changed to change_level, to allow users to move levels to lower levels if allowed. It can be used to migrate a DB from options.level_compaction_dynamic_level_bytes=false to options.level_compaction_dynamic_level_bytes.true. * Change default value for options.compaction_filter_factory and options.compaction_filter_factory_v2 to nullptr instead of DefaultCompactionFilterFactory and DefaultCompactionFilterFactoryV2. * If CancelAllBackgroundWork is called without doing a flush after doing loads with WAL disabled, the changes which haven't been flushed before the call to CancelAllBackgroundWork will be lost. +* WBWIIterator::Entry() now returns WriteEntry instead of `const WriteEntry&` ## 3.11.0 (5/19/2015) ### New Features |