diff options
| author | Igor Canadi <icanadi@fb.com> | 2015-06-18 14:55:05 -0700 |
|---|---|---|
| committer | Igor Canadi <icanadi@fb.com> | 2015-06-18 14:55:05 -0700 |
| commit | 760e9a94de9ea1c3754c5d6a824ae3327d17ea7f (patch) | |
| tree | c0598ff1e94a5dbcc8ef93bf9f286d5c1fdf22d7 /HISTORY.md | |
| parent | 69bb210d58643af0843eb18234f9ddd25e3e6fe0 (diff) | |
Fail DB::Open() when the requested compression is not available
Summary:
Currently RocksDB silently ignores this issue and doesn't compress the data. Based on discussion, we agree that this is pretty bad because it can cause confusion for our users.
This patch fails DB::Open() if we don't support the compression that is specified in the options.
Test Plan: make check with LZ4 not present. If Snappy is not present all tests will just fail because Snappy is our default library. We should make Snappy the requirement, since without it our default DB::Open() fails.
Reviewers: sdong, MarkCallaghan, rven, yhchiang
Reviewed By: yhchiang
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D39687
Diffstat (limited to 'HISTORY.md')
| -rw-r--r-- | HISTORY.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/HISTORY.md b/HISTORY.md index ece785e24..980cd3db1 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -19,6 +19,7 @@ * DB::CompactRange() now accept CompactRangeOptions instead of multiple paramters. CompactRangeOptions is defined in include/rocksdb/options.h. * Add force_bottommost_level_compaction option to CompactRangeOptions, which prevent compaction from skipping compacting bottommost level. * Add Cache.GetPinnedUsage() to get the size of memory occupied by entries that are in use by the system. +* DB:Open() will fail if the compression specified in Options is not linked with the binary. If you see this failure, recompile RocksDB with compression libraries present on your system. Also, previously our default compression was snappy. This behavior is now changed. Now, the default compression is snappy only if it's available on the system. If it isn't we change the default to kNoCompression. ## 3.11.0 (5/19/2015) ### New Features |