diff options
| author | Igor Canadi <icanadi@fb.com> | 2015-07-14 20:51:36 +0200 |
|---|---|---|
| committer | Igor Canadi <icanadi@fb.com> | 2015-07-14 20:51:36 +0200 |
| commit | 8a9fca2619d0bbfeb3918fafae5a60bd7aa75033 (patch) | |
| tree | 2c2df7251e51898e8231ac40c09f1043076f0469 /HISTORY.md | |
| parent | 18d5e1bf88eb4c1ead14488ab3b358923866a3fe (diff) | |
Better error handling in BackupEngine
Summary:
Couple of changes here:
* NewBackupEngine() and NewReadOnlyBackupEngine() are now removed. They were deprecated since RocksDB 3.8. Changing these to new functions should be pretty straight-forward. As a followup, I'll fix all fbcode callsights
* Instead of initializing backup engine in the constructor, we initialize it in a separate function now. That way, we can catch all errors and return appropriate status code.
* We catch all errors during initializations and return them to the client properly.
* Added new tests to backupable_db_test, to make sure that we can't open BackupEngine when there are Env errors.
* Transitioned backupable_db_test to use BackupEngine rather than BackupableDB. From the two available APIs, judging by the current use-cases, it looks like BackupEngine API won. It's much more flexible since it doesn't require StackableDB.
Test Plan: Added a new unit test to backupable_db_test
Reviewers: yhchiang, sdong, AaronFeldman
Reviewed By: AaronFeldman
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D41925
Diffstat (limited to 'HISTORY.md')
| -rw-r--r-- | HISTORY.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/HISTORY.md b/HISTORY.md index a0b60f6ec..46097802d 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -2,9 +2,10 @@ ## Unreleased -### Public API changes +### Public API Changes * Deprecated WriteOptions::timeout_hint_us. We no longer support write timeout. If you really need this option, talk to us and we might consider returning it. * Deprecated purge_redundant_kvs_while_flush option. +* Removed BackupEngine::NewBackupEngine() and NewReadOnlyBackupEngine() that were deprecated in RocksDB 3.8. Please use BackupEngine::Open() instead. ## 3.12.0 (7/2/2015) ### New Features |