diff options
author | sdong <siying.d@fb.com> | 2020-02-20 12:07:53 -0800 |
---|---|---|
committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2020-02-20 12:09:57 -0800 |
commit | fdf882ded218344c136c97daf76dfb59e4bc155f (patch) | |
tree | 00237d163251ff53a7fe8cb7fbd5d7462fbc9e32 /db | |
parent | 4e33f1e1dc40be18f8233a913324b2978c6a46fa (diff) |
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
Summary:
When dynamically linking two binaries together, different builds of RocksDB from two sources might cause errors. To provide a tool for user to solve the problem, the RocksDB namespace is changed to a flag which can be overridden in build time.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6433
Test Plan: Build release, all and jtest. Try to build with ROCKSDB_NAMESPACE with another flag.
Differential Revision: D19977691
fbshipit-source-id: aa7f2d0972e1c31d75339ac48478f34f6cfcfb3e
Diffstat (limited to 'db')
194 files changed, 1587 insertions, 1541 deletions
diff --git a/db/arena_wrapped_db_iter.cc b/db/arena_wrapped_db_iter.cc index c2de8db9e..f43282a75 100644 --- a/db/arena_wrapped_db_iter.cc +++ b/db/arena_wrapped_db_iter.cc @@ -16,7 +16,7 @@ #include "table/iterator_wrapper.h" #include "util/user_comparator_wrapper.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { Status ArenaWrappedDBIter::GetProperty(std::string prop_name, std::string* prop) { @@ -103,4 +103,4 @@ ArenaWrappedDBIter* NewArenaWrappedDbIterator( return iter; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/arena_wrapped_db_iter.h b/db/arena_wrapped_db_iter.h index 6dbd64521..d0eedcb35 100644 --- a/db/arena_wrapped_db_iter.h +++ b/db/arena_wrapped_db_iter.h @@ -20,7 +20,7 @@ #include "rocksdb/iterator.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Arena; @@ -109,4 +109,4 @@ extern ArenaWrappedDBIter* NewArenaWrappedDbIterator( ReadCallback* read_callback, DBImpl* db_impl = nullptr, ColumnFamilyData* cfd = nullptr, bool allow_blob = false, bool allow_refresh = true); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/blob_index.h b/db/blob_index.h index eb23e223e..483a7b97b 100644 --- a/db/blob_index.h +++ b/db/blob_index.h @@ -12,7 +12,7 @@ #include "util/coding.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // BlobIndex is a pointer to the blob and metadata of the blob. The index is // stored in base DB as ValueType::kTypeBlobIndex. @@ -175,5 +175,5 @@ class BlobIndex { CompressionType compression_ = kNoCompression; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/builder.cc b/db/builder.cc index 1f25e1c6f..fdb814cbb 100644 --- a/db/builder.cc +++ b/db/builder.cc @@ -37,7 +37,7 @@ #include "test_util/sync_point.h" #include "util/stop_watch.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class TableFactory; @@ -260,4 +260,4 @@ Status BuildTable( return s; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/builder.h b/db/builder.h index 74012b337..062f1fb80 100644 --- a/db/builder.h +++ b/db/builder.h @@ -22,7 +22,7 @@ #include "rocksdb/types.h" #include "table/scoped_arena_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { struct Options; struct FileMetaData; @@ -85,4 +85,4 @@ extern Status BuildTable( Env::WriteLifeTimeHint write_hint = Env::WLTH_NOT_SET, const uint64_t file_creation_time = 0); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE @@ -46,74 +46,74 @@ #include <unordered_set> #include <map> -using rocksdb::BytewiseComparator; -using rocksdb::Cache; -using rocksdb::ColumnFamilyDescriptor; -using rocksdb::ColumnFamilyHandle; -using rocksdb::ColumnFamilyOptions; -using rocksdb::CompactionFilter; -using rocksdb::CompactionFilterFactory; -using rocksdb::CompactionFilterContext; -using rocksdb::CompactionOptionsFIFO; -using rocksdb::Comparator; -using rocksdb::CompressionType; -using rocksdb::WALRecoveryMode; -using rocksdb::DB; -using rocksdb::DBOptions; -using rocksdb::DbPath; -using rocksdb::Env; -using rocksdb::EnvOptions; -using rocksdb::InfoLogLevel; -using rocksdb::FileLock; -using rocksdb::FilterPolicy; -using rocksdb::FlushOptions; -using rocksdb::IngestExternalFileOptions; -using rocksdb::Iterator; -using rocksdb::Logger; -using rocksdb::MergeOperator; -using rocksdb::MergeOperators; -using rocksdb::NewBloomFilterPolicy; -using rocksdb::NewLRUCache; -using rocksdb::Options; -using rocksdb::BlockBasedTableOptions; -using rocksdb::CuckooTableOptions; -using rocksdb::RandomAccessFile; -using rocksdb::Range; -using rocksdb::ReadOptions; -using rocksdb::SequentialFile; -using rocksdb::Slice; -using rocksdb::SliceParts; -using rocksdb::SliceTransform; -using rocksdb::Snapshot; -using rocksdb::SstFileWriter; -using rocksdb::Status; -using rocksdb::WritableFile; -using rocksdb::WriteBatch; -using rocksdb::WriteBatchWithIndex; -using rocksdb::WriteOptions; -using rocksdb::LiveFileMetaData; -using rocksdb::BackupEngine; -using rocksdb::BackupableDBOptions; -using rocksdb::BackupInfo; -using rocksdb::BackupID; -using rocksdb::RestoreOptions; -using rocksdb::CompactRangeOptions; -using rocksdb::BottommostLevelCompaction; -using rocksdb::RateLimiter; -using rocksdb::NewGenericRateLimiter; -using rocksdb::PinnableSlice; -using rocksdb::TransactionDBOptions; -using rocksdb::TransactionDB; -using rocksdb::TransactionOptions; -using rocksdb::OptimisticTransactionDB; -using rocksdb::OptimisticTransactionOptions; -using rocksdb::Transaction; -using rocksdb::Checkpoint; -using rocksdb::TransactionLogIterator; -using rocksdb::BatchResult; -using rocksdb::PerfLevel; -using rocksdb::PerfContext; -using rocksdb::MemoryUtil; +using ROCKSDB_NAMESPACE::BackupableDBOptions; +using ROCKSDB_NAMESPACE::BackupEngine; +using ROCKSDB_NAMESPACE::BackupID; +using ROCKSDB_NAMESPACE::BackupInfo; +using ROCKSDB_NAMESPACE::BatchResult; +using ROCKSDB_NAMESPACE::BlockBasedTableOptions; +using ROCKSDB_NAMESPACE::BottommostLevelCompaction; +using ROCKSDB_NAMESPACE::BytewiseComparator; +using ROCKSDB_NAMESPACE::Cache; +using ROCKSDB_NAMESPACE::Checkpoint; +using ROCKSDB_NAMESPACE::ColumnFamilyDescriptor; +using ROCKSDB_NAMESPACE::ColumnFamilyHandle; +using ROCKSDB_NAMESPACE::ColumnFamilyOptions; +using ROCKSDB_NAMESPACE::CompactionFilter; +using ROCKSDB_NAMESPACE::CompactionFilterContext; +using ROCKSDB_NAMESPACE::CompactionFilterFactory; +using ROCKSDB_NAMESPACE::CompactionOptionsFIFO; +using ROCKSDB_NAMESPACE::CompactRangeOptions; +using ROCKSDB_NAMESPACE::Comparator; +using ROCKSDB_NAMESPACE::CompressionType; +using ROCKSDB_NAMESPACE::CuckooTableOptions; +using ROCKSDB_NAMESPACE::DB; +using ROCKSDB_NAMESPACE::DBOptions; +using ROCKSDB_NAMESPACE::DbPath; +using ROCKSDB_NAMESPACE::Env; +using ROCKSDB_NAMESPACE::EnvOptions; +using ROCKSDB_NAMESPACE::FileLock; +using ROCKSDB_NAMESPACE::FilterPolicy; +using ROCKSDB_NAMESPACE::FlushOptions; +using ROCKSDB_NAMESPACE::InfoLogLevel; +using ROCKSDB_NAMESPACE::IngestExternalFileOptions; +using ROCKSDB_NAMESPACE::Iterator; +using ROCKSDB_NAMESPACE::LiveFileMetaData; +using ROCKSDB_NAMESPACE::Logger; +using ROCKSDB_NAMESPACE::MemoryUtil; +using ROCKSDB_NAMESPACE::MergeOperator; +using ROCKSDB_NAMESPACE::MergeOperators; +using ROCKSDB_NAMESPACE::NewBloomFilterPolicy; +using ROCKSDB_NAMESPACE::NewGenericRateLimiter; +using ROCKSDB_NAMESPACE::NewLRUCache; +using ROCKSDB_NAMESPACE::OptimisticTransactionDB; +using ROCKSDB_NAMESPACE::OptimisticTransactionOptions; +using ROCKSDB_NAMESPACE::Options; +using ROCKSDB_NAMESPACE::PerfContext; +using ROCKSDB_NAMESPACE::PerfLevel; +using ROCKSDB_NAMESPACE::PinnableSlice; +using ROCKSDB_NAMESPACE::RandomAccessFile; +using ROCKSDB_NAMESPACE::Range; +using ROCKSDB_NAMESPACE::RateLimiter; +using ROCKSDB_NAMESPACE::ReadOptions; +using ROCKSDB_NAMESPACE::RestoreOptions; +using ROCKSDB_NAMESPACE::SequentialFile; +using ROCKSDB_NAMESPACE::Slice; +using ROCKSDB_NAMESPACE::SliceParts; +using ROCKSDB_NAMESPACE::SliceTransform; +using ROCKSDB_NAMESPACE::Snapshot; +using ROCKSDB_NAMESPACE::SstFileWriter; +using ROCKSDB_NAMESPACE::Status; +using ROCKSDB_NAMESPACE::Transaction; +using ROCKSDB_NAMESPACE::TransactionDB; +using ROCKSDB_NAMESPACE::TransactionDBOptions; +using ROCKSDB_NAMESPACE::TransactionLogIterator; +using ROCKSDB_NAMESPACE::TransactionOptions; +using ROCKSDB_NAMESPACE::WALRecoveryMode; +using ROCKSDB_NAMESPACE::WritableFile; +using ROCKSDB_NAMESPACE::WriteBatch; +using ROCKSDB_NAMESPACE::WriteBatchWithIndex; +using ROCKSDB_NAMESPACE::WriteOptions; using std::shared_ptr; using std::vector; @@ -452,7 +452,7 @@ struct rocksdb_slicetransform_t : public SliceTransform { }; struct rocksdb_universal_compaction_options_t { - rocksdb::CompactionOptionsUniversal *rep; + ROCKSDB_NAMESPACE::CompactionOptionsUniversal* rep; }; static bool SaveError(char** errptr, const Status& s) { @@ -494,8 +494,9 @@ rocksdb_t* rocksdb_open_with_ttl( const char* name, int ttl, char** errptr) { - rocksdb::DBWithTTL* db; - if (SaveError(errptr, rocksdb::DBWithTTL::Open(options->rep, std::string(name), &db, ttl))) { + ROCKSDB_NAMESPACE::DBWithTTL* db; + if (SaveError(errptr, ROCKSDB_NAMESPACE::DBWithTTL::Open( + options->rep, std::string(name), &db, ttl))) { return nullptr; } rocksdb_t* result = new rocksdb_t; @@ -664,7 +665,8 @@ void rocksdb_close(rocksdb_t* db) { } void rocksdb_options_set_uint64add_merge_operator(rocksdb_options_t* opt) { - opt->rep.merge_operator = rocksdb::MergeOperators::CreateUInt64AddOperator(); + opt->rep.merge_operator = + ROCKSDB_NAMESPACE::MergeOperators::CreateUInt64AddOperator(); } rocksdb_t* rocksdb_open_column_families( @@ -2078,7 +2080,7 @@ void rocksdb_options_set_block_based_table_factory( rocksdb_block_based_table_options_t* table_options) { if (table_options) { opt->rep.table_factory.reset( - rocksdb::NewBlockBasedTableFactory(table_options->rep)); + ROCKSDB_NAMESPACE::NewBlockBasedTableFactory(table_options->rep)); } } @@ -2122,7 +2124,7 @@ void rocksdb_options_set_cuckoo_table_factory( rocksdb_cuckoo_table_options_t* table_options) { if (table_options) { opt->rep.table_factory.reset( - rocksdb::NewCuckooTableFactory(table_options->rep)); + ROCKSDB_NAMESPACE::NewCuckooTableFactory(table_options->rep)); } } @@ -2312,7 +2314,7 @@ void rocksdb_options_set_max_bytes_for_level_multiplier_additional( } void rocksdb_options_enable_statistics(rocksdb_options_t* opt) { - opt->rep.statistics = rocksdb::CreateDBStatistics(); + opt->rep.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); } void rocksdb_options_set_skip_stats_update_on_db_open(rocksdb_options_t* opt, @@ -2468,16 +2470,20 @@ void rocksdb_options_set_access_hint_on_compaction_start( rocksdb_options_t* opt, int v) { switch(v) { case 0: - opt->rep.access_hint_on_compaction_start = rocksdb::Options::NONE; + opt->rep.access_hint_on_compaction_start = + ROCKSDB_NAMESPACE::Options::NONE; break; case 1: - opt->rep.access_hint_on_compaction_start = rocksdb::Options::NORMAL; + opt->rep.access_hint_on_compaction_start = + ROCKSDB_NAMESPACE::Options::NORMAL; break; case 2: - opt->rep.access_hint_on_compaction_start = rocksdb::Options::SEQUENTIAL; + opt->rep.access_hint_on_compaction_start = + ROCKSDB_NAMESPACE::Options::SEQUENTIAL; break; case 3: - opt->rep.access_hint_on_compaction_start = rocksdb::Options::WILLNEED; + opt->rep.access_hint_on_compaction_start = + ROCKSDB_NAMESPACE::Options::WILLNEED; break; } } @@ -2643,7 +2649,7 @@ void rocksdb_options_prepare_for_bulk_load(rocksdb_options_t* opt) { } void rocksdb_options_set_memtable_vector_rep(rocksdb_options_t *opt) { - opt->rep.memtable_factory.reset(new rocksdb::VectorRepFactory); + opt->rep.memtable_factory.reset(new ROCKSDB_NAMESPACE::VectorRepFactory); } void rocksdb_options_set_memtable_prefix_bloom_size_ratio( @@ -2659,26 +2665,29 @@ void rocksdb_options_set_memtable_huge_page_size(rocksdb_options_t* opt, void rocksdb_options_set_hash_skip_list_rep( rocksdb_options_t *opt, size_t bucket_count, int32_t skiplist_height, int32_t skiplist_branching_factor) { - rocksdb::MemTableRepFactory* factory = rocksdb::NewHashSkipListRepFactory( - bucket_count, skiplist_height, skiplist_branching_factor); + ROCKSDB_NAMESPACE::MemTableRepFactory* factory = + ROCKSDB_NAMESPACE::NewHashSkipListRepFactory( + bucket_count, skiplist_height, skiplist_branching_factor); opt->rep.memtable_factory.reset(factory); } void rocksdb_options_set_hash_link_list_rep( rocksdb_options_t *opt, size_t bucket_count) { - opt->rep.memtable_factory.reset(rocksdb::NewHashLinkListRepFactory(bucket_count)); + opt->rep.memtable_factory.reset( + ROCKSDB_NAMESPACE::NewHashLinkListRepFactory(bucket_count)); } void rocksdb_options_set_plain_table_factory( rocksdb_options_t *opt, uint32_t user_key_len, int bloom_bits_per_key, double hash_table_ratio, size_t index_sparseness) { - rocksdb::PlainTableOptions options; + ROCKSDB_NAMESPACE::PlainTableOptions options; options.user_key_len = user_key_len; options.bloom_bits_per_key = bloom_bits_per_key; options.hash_table_ratio = hash_table_ratio; options.index_sparseness = index_sparseness; - rocksdb::TableFactory* factory = rocksdb::NewPlainTableFactory(options); + ROCKSDB_NAMESPACE::TableFactory* factory = + ROCKSDB_NAMESPACE::NewPlainTableFactory(options); opt->rep.table_factory.reset(factory); } @@ -2708,7 +2717,8 @@ void rocksdb_options_set_report_bg_io_stats( } void rocksdb_options_set_compaction_style(rocksdb_options_t *opt, int style) { - opt->rep.compaction_style = static_cast<rocksdb::CompactionStyle>(style); + opt->rep.compaction_style = + static_cast<ROCKSDB_NAMESPACE::CompactionStyle>(style); } void rocksdb_options_set_universal_compaction_options(rocksdb_options_t *opt, rocksdb_universal_compaction_options_t *uco) { @@ -2722,7 +2732,7 @@ void rocksdb_options_set_fifo_compaction_options( } char *rocksdb_options_statistics_get_string(rocksdb_options_t *opt) { - rocksdb::Statistics *statistics = opt->rep.statistics.get(); + ROCKSDB_NAMESPACE::Statistics* statistics = opt->rep.statistics.get(); if (statistics) { return strdup(statistics->ToString().c_str()); } @@ -2762,7 +2772,7 @@ void rocksdb_set_perf_level(int v) { rocksdb_perfcontext_t* rocksdb_perfcontext_create() { rocksdb_perfcontext_t* context = new rocksdb_perfcontext_t; - context->rep = rocksdb::get_perf_context(); + context->rep = ROCKSDB_NAMESPACE::get_perf_context(); return context; } @@ -3064,11 +3074,12 @@ rocksdb_filterpolicy_t* rocksdb_filterpolicy_create_bloom_format(int bits_per_ke return rep_->KeyMayMatch(key, filter); } // No need to override GetFilterBitsBuilder if this one is overridden - rocksdb::FilterBitsBuilder* GetBuilderWithContext( - const rocksdb::FilterBuildingContext& context) const override { + ROCKSDB_NAMESPACE::FilterBitsBuilder* GetBuilderWithContext( + const ROCKSDB_NAMESPACE::FilterBuildingContext& context) + const override { return rep_->GetBuilderWithContext(context); } - rocksdb::FilterBitsReader* GetFilterBitsReader( + ROCKSDB_NAMESPACE::FilterBitsReader* GetFilterBitsReader( const Slice& contents) const override { return rep_->GetFilterBitsReader(contents); } @@ -3170,7 +3181,7 @@ void rocksdb_readoptions_set_iterate_lower_bound( void rocksdb_readoptions_set_read_tier( rocksdb_readoptions_t* opt, int v) { - opt->rep.read_tier = static_cast<rocksdb::ReadTier>(v); + opt->rep.read_tier = static_cast<ROCKSDB_NAMESPACE::ReadTier>(v); } void rocksdb_readoptions_set_tailing( @@ -3342,7 +3353,7 @@ rocksdb_env_t* rocksdb_create_default_env() { rocksdb_env_t* rocksdb_create_mem_env() { rocksdb_env_t* result = new rocksdb_env_t; - result->rep = rocksdb::NewMemEnv(Env::Default()); + result->rep = ROCKSDB_NAMESPACE::NewMemEnv(Env::Default()); result->is_default = false; return result; } @@ -3557,7 +3568,7 @@ struct Wrapper : public rocksdb_slicetransform_t { rocksdb_slicetransform_t* rocksdb_slicetransform_create_fixed_prefix(size_t prefixLen) { Wrapper* wrapper = new Wrapper; - wrapper->rep_ = rocksdb::NewFixedPrefixTransform(prefixLen); + wrapper->rep_ = ROCKSDB_NAMESPACE::NewFixedPrefixTransform(prefixLen); wrapper->state_ = nullptr; wrapper->destructor_ = &Wrapper::DoNothing; return wrapper; @@ -3565,7 +3576,7 @@ rocksdb_slicetransform_t* rocksdb_slicetransform_create_fixed_prefix(size_t pref rocksdb_slicetransform_t* rocksdb_slicetransform_create_noop() { Wrapper* wrapper = new Wrapper; - wrapper->rep_ = rocksdb::NewNoopTransform(); + wrapper->rep_ = ROCKSDB_NAMESPACE::NewNoopTransform(); wrapper->state_ = nullptr; wrapper->destructor_ = &Wrapper::DoNothing; return wrapper; @@ -3573,7 +3584,7 @@ rocksdb_slicetransform_t* rocksdb_slicetransform_create_noop() { rocksdb_universal_compaction_options_t* rocksdb_universal_compaction_options_create() { rocksdb_universal_compaction_options_t* result = new rocksdb_universal_compaction_options_t; - result->rep = new rocksdb::CompactionOptionsUniversal; + result->rep = new ROCKSDB_NAMESPACE::CompactionOptionsUniversal; return result; } @@ -3604,7 +3615,8 @@ void rocksdb_universal_compaction_options_set_compression_size_percent( void rocksdb_universal_compaction_options_set_stop_style( rocksdb_universal_compaction_options_t* uco, int style) { - uco->rep->stop_style = static_cast<rocksdb::CompactionStopStyle>(style); + uco->rep->stop_style = + static_cast<ROCKSDB_NAMESPACE::CompactionStopStyle>(style); } void rocksdb_universal_compaction_options_destroy( @@ -3634,7 +3646,7 @@ void rocksdb_options_set_min_level_to_compress(rocksdb_options_t* opt, int level assert(level <= opt->rep.num_levels); opt->rep.compression_per_level.resize(opt->rep.num_levels); for (int i = 0; i < level; i++) { - opt->rep.compression_per_level[i] = rocksdb::kNoCompression; + opt->rep.compression_per_level[i] = ROCKSDB_NAMESPACE::kNoCompression; } for (int i = level; i < opt->rep.num_levels; i++) { opt->rep.compression_per_level[i] = opt->rep.compression; @@ -4336,7 +4348,8 @@ const char* rocksdb_pinnableslice_value(const rocksdb_pinnableslice_t* v, return v->rep.data(); } -// container to keep databases and caches in order to use rocksdb::MemoryUtil +// container to keep databases and caches in order to use +// ROCKSDB_NAMESPACE::MemoryUtil struct rocksdb_memory_consumers_t { std::vector<rocksdb_t*> dbs; std::unordered_set<rocksdb_cache_t*> caches; @@ -4364,7 +4377,7 @@ void rocksdb_memory_consumers_destroy(rocksdb_memory_consumers_t* consumers) { delete consumers; } -// contains memory usage statistics provided by rocksdb::MemoryUtil +// contains memory usage statistics provided by ROCKSDB_NAMESPACE::MemoryUtil struct rocksdb_memory_usage_t { uint64_t mem_table_total; uint64_t mem_table_unflushed; @@ -4386,7 +4399,7 @@ rocksdb_memory_usage_t* rocksdb_approximate_memory_usage_create( cache_set.insert(const_cast<const Cache*>(cache->rep.get())); } - std::map<rocksdb::MemoryUtil::UsageType, uint64_t> usage_by_type; + std::map<ROCKSDB_NAMESPACE::MemoryUtil::UsageType, uint64_t> usage_by_type; auto status = MemoryUtil::GetApproximateMemoryUsageByType(dbs, cache_set, &usage_by_type); diff --git a/db/column_family.cc b/db/column_family.cc index 135f0c9b0..928a02a1f 100644 --- a/db/column_family.cc +++ b/db/column_family.cc @@ -36,7 +36,7 @@ #include "util/autovector.h" #include "util/compression.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { ColumnFamilyHandleImpl::ColumnFamilyHandleImpl( ColumnFamilyData* column_family_data, DBImpl* db, InstrumentedMutex* mutex) @@ -1520,4 +1520,4 @@ const Comparator* GetColumnFamilyUserComparator( return nullptr; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/column_family.h b/db/column_family.h index 351819839..fcc8ea2cf 100644 --- a/db/column_family.h +++ b/db/column_family.h @@ -27,7 +27,7 @@ #include "trace_replay/block_cache_tracer.h" #include "util/thread_local.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Version; class VersionSet; @@ -754,4 +754,4 @@ extern uint32_t GetColumnFamilyID(ColumnFamilyHandle* column_family); extern const Comparator* GetColumnFamilyUserComparator( ColumnFamilyHandle* column_family); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/column_family_test.cc b/db/column_family_test.cc index b289da731..24ff4e08b 100644 --- a/db/column_family_test.cc +++ b/db/column_family_test.cc @@ -30,7 +30,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static const int kValueSize = 1000; @@ -91,7 +91,7 @@ class ColumnFamilyTestBase : public testing::Test { column_families.push_back(cfdescriptor); } Close(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Destroy(column_families); delete env_; } @@ -595,14 +595,15 @@ TEST_P(ColumnFamilyTest, DontReuseColumnFamilyID) { TEST_P(ColumnFamilyTest, CreateCFRaceWithGetAggProperty) { Open(); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::WriteOptionsFile:1", "ColumnFamilyTest.CreateCFRaceWithGetAggProperty:1"}, {"ColumnFamilyTest.CreateCFRaceWithGetAggProperty:2", "DBImpl::WriteOptionsFile:2"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread thread([&] { CreateColumnFamilies({"one"}); }); + ROCKSDB_NAMESPACE::port::Thread thread( + [&] { CreateColumnFamilies({"one"}); }); TEST_SYNC_POINT("ColumnFamilyTest.CreateCFRaceWithGetAggProperty:1"); uint64_t pv; @@ -611,7 +612,7 @@ TEST_P(ColumnFamilyTest, CreateCFRaceWithGetAggProperty) { thread.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } #endif // !ROCKSDB_LITE @@ -1253,13 +1254,14 @@ TEST_P(ColumnFamilyTest, DifferentWriteBufferSizes) { // #endif // !ROCKSDB_LITE class TestComparator : public Comparator { - int Compare(const rocksdb::Slice& /*a*/, - const rocksdb::Slice& /*b*/) const override { + int Compare(const ROCKSDB_NAMESPACE::Slice& /*a*/, + const ROCKSDB_NAMESPACE::Slice& /*b*/) const override { return 0; } const char* Name() const override { return "Test"; } - void FindShortestSeparator(std::string* /*start*/, - const rocksdb::Slice& /*limit*/) const override {} + void FindShortestSeparator( + std::string* /*start*/, + const ROCKSDB_NAMESPACE::Slice& /*limit*/) const override {} void FindShortSuccessor(std::string* /*key*/) const override {} }; @@ -1427,11 +1429,11 @@ TEST_P(ColumnFamilyTest, MultipleManualCompactions) { AssertFilesPerLevel(ToString(i + 1), 1); } bool cf_1_1 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::MultiManual:4", "ColumnFamilyTest::MultiManual:1"}, {"ColumnFamilyTest::MultiManual:2", "ColumnFamilyTest::MultiManual:5"}, {"ColumnFamilyTest::MultiManual:2", "ColumnFamilyTest::MultiManual:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { TEST_SYNC_POINT("ColumnFamilyTest::MultiManual:4"); @@ -1440,7 +1442,7 @@ TEST_P(ColumnFamilyTest, MultipleManualCompactions) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::vector<port::Thread> threads; threads.emplace_back([&] { CompactRangeOptions compact_options; @@ -1483,8 +1485,8 @@ TEST_P(ColumnFamilyTest, MultipleManualCompactions) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); Close(); } @@ -1523,11 +1525,11 @@ TEST_P(ColumnFamilyTest, AutomaticAndManualCompactions) { dbfull()->TEST_write_controler().GetCompactionPressureToken(); bool cf_1_1 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::AutoManual:4", "ColumnFamilyTest::AutoManual:1"}, {"ColumnFamilyTest::AutoManual:2", "ColumnFamilyTest::AutoManual:5"}, {"ColumnFamilyTest::AutoManual:2", "ColumnFamilyTest::AutoManual:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { cf_1_1 = false; @@ -1535,7 +1537,7 @@ TEST_P(ColumnFamilyTest, AutomaticAndManualCompactions) { TEST_SYNC_POINT("ColumnFamilyTest::AutoManual:3"); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // SETUP column family "one" -- universal style for (int i = 0; i < one.level0_file_num_compaction_trigger; ++i) { PutRandomData(1, 10, 12000, true); @@ -1553,7 +1555,7 @@ TEST_P(ColumnFamilyTest, AutomaticAndManualCompactions) { WaitForFlush(2); AssertFilesPerLevel(ToString(i + 1), 2); } - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::port::Thread threads([&] { CompactRangeOptions compact_options; compact_options.exclusive_manual_compaction = false; ASSERT_OK( @@ -1580,8 +1582,8 @@ TEST_P(ColumnFamilyTest, AutomaticAndManualCompactions) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_P(ColumnFamilyTest, ManualAndAutomaticCompactions) { @@ -1627,11 +1629,11 @@ TEST_P(ColumnFamilyTest, ManualAndAutomaticCompactions) { } bool cf_1_1 = true; bool cf_1_2 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::ManualAuto:4", "ColumnFamilyTest::ManualAuto:1"}, {"ColumnFamilyTest::ManualAuto:5", "ColumnFamilyTest::ManualAuto:2"}, {"ColumnFamilyTest::ManualAuto:2", "ColumnFamilyTest::ManualAuto:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { TEST_SYNC_POINT("ColumnFamilyTest::ManualAuto:4"); @@ -1643,8 +1645,8 @@ TEST_P(ColumnFamilyTest, ManualAndAutomaticCompactions) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::port::Thread threads([&] { CompactRangeOptions compact_options; compact_options.exclusive_manual_compaction = false; ASSERT_OK( @@ -1679,8 +1681,8 @@ TEST_P(ColumnFamilyTest, ManualAndAutomaticCompactions) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_P(ColumnFamilyTest, SameCFManualManualCompactions) { @@ -1721,13 +1723,13 @@ TEST_P(ColumnFamilyTest, SameCFManualManualCompactions) { } bool cf_1_1 = true; bool cf_1_2 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::ManualManual:4", "ColumnFamilyTest::ManualManual:2"}, {"ColumnFamilyTest::ManualManual:4", "ColumnFamilyTest::ManualManual:5"}, {"ColumnFamilyTest::ManualManual:1", "ColumnFamilyTest::ManualManual:2"}, {"ColumnFamilyTest::ManualManual:1", "ColumnFamilyTest::ManualManual:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { TEST_SYNC_POINT("ColumnFamilyTest::ManualManual:4"); @@ -1739,8 +1741,8 @@ TEST_P(ColumnFamilyTest, SameCFManualManualCompactions) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::port::Thread threads([&] { CompactRangeOptions compact_options; compact_options.exclusive_manual_compaction = true; ASSERT_OK( @@ -1760,7 +1762,7 @@ TEST_P(ColumnFamilyTest, SameCFManualManualCompactions) { 1); } - rocksdb::port::Thread threads1([&] { + ROCKSDB_NAMESPACE::port::Thread threads1([&] { CompactRangeOptions compact_options; compact_options.exclusive_manual_compaction = false; ASSERT_OK( @@ -1781,8 +1783,8 @@ TEST_P(ColumnFamilyTest, SameCFManualManualCompactions) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactions) { @@ -1823,12 +1825,12 @@ TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactions) { } bool cf_1_1 = true; bool cf_1_2 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::ManualAuto:4", "ColumnFamilyTest::ManualAuto:2"}, {"ColumnFamilyTest::ManualAuto:4", "ColumnFamilyTest::ManualAuto:5"}, {"ColumnFamilyTest::ManualAuto:1", "ColumnFamilyTest::ManualAuto:2"}, {"ColumnFamilyTest::ManualAuto:1", "ColumnFamilyTest::ManualAuto:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { TEST_SYNC_POINT("ColumnFamilyTest::ManualAuto:4"); @@ -1840,8 +1842,8 @@ TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactions) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::port::Thread threads([&] { CompactRangeOptions compact_options; compact_options.exclusive_manual_compaction = false; ASSERT_OK( @@ -1874,8 +1876,8 @@ TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactions) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactionsLevel) { @@ -1916,14 +1918,14 @@ TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactionsLevel) { } bool cf_1_1 = true; bool cf_1_2 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::ManualAuto:4", "ColumnFamilyTest::ManualAuto:2"}, {"ColumnFamilyTest::ManualAuto:4", "ColumnFamilyTest::ManualAuto:5"}, {"ColumnFamilyTest::ManualAuto:3", "ColumnFamilyTest::ManualAuto:2"}, {"LevelCompactionPicker::PickCompactionBySize:0", "ColumnFamilyTest::ManualAuto:3"}, {"ColumnFamilyTest::ManualAuto:1", "ColumnFamilyTest::ManualAuto:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { TEST_SYNC_POINT("ColumnFamilyTest::ManualAuto:4"); @@ -1935,8 +1937,8 @@ TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactionsLevel) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::port::Thread threads([&] { CompactRangeOptions compact_options; compact_options.exclusive_manual_compaction = false; ASSERT_OK( @@ -1967,8 +1969,8 @@ TEST_P(ColumnFamilyTest, SameCFManualAutomaticCompactionsLevel) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } // In this test, we generate enough files to trigger automatic compactions. @@ -2008,12 +2010,12 @@ TEST_P(ColumnFamilyTest, SameCFAutomaticManualCompactions) { bool cf_1_1 = true; bool cf_1_2 = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"ColumnFamilyTest::AutoManual:4", "ColumnFamilyTest::AutoManual:2"}, {"ColumnFamilyTest::AutoManual:4", "ColumnFamilyTest::AutoManual:5"}, {"CompactionPicker::CompactRange:Conflict", "ColumnFamilyTest::AutoManual:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (cf_1_1) { TEST_SYNC_POINT("ColumnFamilyTest::AutoManual:4"); @@ -2025,7 +2027,7 @@ TEST_P(ColumnFamilyTest, SameCFAutomaticManualCompactions) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // SETUP column family "one" -- universal style for (int i = 0; i < one.level0_file_num_compaction_trigger; ++i) { @@ -2059,8 +2061,8 @@ TEST_P(ColumnFamilyTest, SameCFAutomaticManualCompactions) { ASSERT_NE("NOT_FOUND", Get(1, *key_iter)); key_iter++; } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } #endif // !ROCKSDB_LITE @@ -2415,7 +2417,7 @@ TEST_P(ColumnFamilyTest, FlushAndDropRaceCondition) { options.write_buffer_size = 100000; // small write buffer size Reopen({options, options}); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"VersionSet::LogAndApply::ColumnFamilyDrop:0", "FlushJob::WriteLevel0Table"}, {"VersionSet::LogAndApply::ColumnFamilyDrop:1", @@ -2423,7 +2425,7 @@ TEST_P(ColumnFamilyTest, FlushAndDropRaceCondition) { {"FlushJob::InstallResults", "VersionSet::LogAndApply::ColumnFamilyDrop:2"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); test::SleepingBackgroundTask sleeping_task; env_->Schedule(&test::SleepingBackgroundTask::DoSleepTask, &sleeping_task, @@ -2502,21 +2504,21 @@ TEST_P(ColumnFamilyTest, CreateAndDropRace) { auto main_thread_id = std::this_thread::get_id(); - rocksdb::SyncPoint::GetInstance()->SetCallBack("PersistRocksDBOptions:start", - [&](void* /*arg*/) { - auto current_thread_id = std::this_thread::get_id(); - // If it's the main thread hitting this sync-point, then it - // will be blocked until some other thread update the test_stage. - if (main_thread_id == current_thread_id) { - test_stage = kMainThreadStartPersistingOptionsFile; - while (test_stage < kChildThreadFinishDroppingColumnFamily && - !ordered_by_writethread) { - Env::Default()->SleepForMicroseconds(100); - } - } - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "PersistRocksDBOptions:start", [&](void* /*arg*/) { + auto current_thread_id = std::this_thread::get_id(); + // If it's the main thread hitting this sync-point, then it + // will be blocked until some other thread update the test_stage. + if (main_thread_id == current_thread_id) { + test_stage = kMainThreadStartPersistingOptionsFile; + while (test_stage < kChildThreadFinishDroppingColumnFamily && + !ordered_by_writethread) { + Env::Default()->SleepForMicroseconds(100); + } + } + }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WriteThread::EnterUnbatched:Wait", [&](void* /*arg*/) { // This means a thread doing DropColumnFamily() is waiting for // other thread to finish persisting options. @@ -2528,12 +2530,12 @@ TEST_P(ColumnFamilyTest, CreateAndDropRace) { Open({"default", "one", "two", "three"}, {cf_opts[0], cf_opts[1], cf_opts[2], cf_opts[3]}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Start a thread that will drop the first column family // and its comparator - rocksdb::port::Thread drop_cf_thread(DropSingleColumnFamily, this, 1, - &comparators); + ROCKSDB_NAMESPACE::port::Thread drop_cf_thread(DropSingleColumnFamily, this, + 1, &comparators); DropColumnFamilies({2}); @@ -2546,8 +2548,8 @@ TEST_P(ColumnFamilyTest, CreateAndDropRace) { } } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } #endif // !ROCKSDB_LITE @@ -2982,10 +2984,10 @@ TEST_P(ColumnFamilyTest, FlushCloseWALFiles) { ASSERT_OK(Put(0, "fodor", "mirko")); ASSERT_OK(Put(1, "fodor", "mirko")); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBImpl::BGWorkFlush:done", "FlushCloseWALFiles:0"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Block flush jobs from running test::SleepingBackgroundTask sleeping_task; @@ -3001,7 +3003,7 @@ TEST_P(ColumnFamilyTest, FlushCloseWALFiles) { sleeping_task.WakeUp(); sleeping_task.WaitUntilDone(); TEST_SYNC_POINT("FlushCloseWALFiles:0"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(1, env.num_open_wal_file_.load()); Reopen(); @@ -3079,14 +3081,14 @@ TEST_P(ColumnFamilyTest, IteratorCloseWALFile2) { ASSERT_OK(Put(0, "fodor", "mirko")); ASSERT_OK(Put(1, "fodor", "mirko")); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"ColumnFamilyTest::IteratorCloseWALFile2:0", "DBImpl::BGWorkPurge:start"}, {"ColumnFamilyTest::IteratorCloseWALFile2:2", "DBImpl::BackgroundCallFlush:start"}, {"DBImpl::BGWorkPurge:end", "ColumnFamilyTest::IteratorCloseWALFile2:1"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.sync = true; @@ -3104,7 +3106,7 @@ TEST_P(ColumnFamilyTest, IteratorCloseWALFile2) { TEST_SYNC_POINT("ColumnFamilyTest::IteratorCloseWALFile2:2"); WaitForFlush(1); ASSERT_EQ(1, env.num_open_wal_file_.load()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Reopen(); ASSERT_EQ("mirko", Get(0, "fodor")); @@ -3148,14 +3150,14 @@ TEST_P(ColumnFamilyTest, ForwardIteratorCloseWALFile) { ASSERT_OK(Put(0, "fodor", "mirko")); ASSERT_OK(Put(1, "fodor", "mirko")); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"ColumnFamilyTest::IteratorCloseWALFile2:0", "DBImpl::BGWorkPurge:start"}, {"ColumnFamilyTest::IteratorCloseWALFile2:2", "DBImpl::BackgroundCallFlush:start"}, {"DBImpl::BGWorkPurge:end", "ColumnFamilyTest::IteratorCloseWALFile2:1"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.sync = true; @@ -3179,7 +3181,7 @@ TEST_P(ColumnFamilyTest, ForwardIteratorCloseWALFile) { ASSERT_EQ(1, env.delete_count_.load()); delete it; - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Reopen(); ASSERT_EQ("mirko", Get(0, "fodor")); @@ -3199,15 +3201,15 @@ TEST_P(ColumnFamilyTest, LogSyncConflictFlush) { Put(0, "", ""); Put(1, "foo", "bar"); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::SyncWAL:BeforeMarkLogsSynced:1", "ColumnFamilyTest::LogSyncConflictFlush:1"}, {"ColumnFamilyTest::LogSyncConflictFlush:2", "DBImpl::SyncWAL:BeforeMarkLogsSynced:2"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread thread([&] { db_->SyncWAL(); }); + ROCKSDB_NAMESPACE::port::Thread thread([&] { db_->SyncWAL(); }); TEST_SYNC_POINT("ColumnFamilyTest::LogSyncConflictFlush:1"); Flush(1); @@ -3218,7 +3220,7 @@ TEST_P(ColumnFamilyTest, LogSyncConflictFlush) { thread.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Close(); } #endif @@ -3367,7 +3369,7 @@ TEST_P(ColumnFamilyTest, MultipleCFPathsTest) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS extern "C" { @@ -3378,7 +3380,7 @@ void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} #endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); diff --git a/db/compact_files_test.cc b/db/compact_files_test.cc index 4152cb379..948ada675 100644 --- a/db/compact_files_test.cc +++ b/db/compact_files_test.cc @@ -18,7 +18,7 @@ #include "test_util/testharness.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class CompactFilesTest : public testing::Test { public: @@ -81,11 +81,11 @@ TEST_F(CompactFilesTest, L0ConflictsFiles) { assert(s.ok()); assert(db); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"CompactFilesImpl:0", "BackgroundCallCompaction:0"}, {"BackgroundCallCompaction:1", "CompactFilesImpl:1"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // create couple files // Background compaction starts and waits in BackgroundCallCompaction:0 @@ -95,7 +95,7 @@ TEST_F(CompactFilesTest, L0ConflictsFiles) { db->Flush(FlushOptions()); } - rocksdb::ColumnFamilyMetaData meta; + ROCKSDB_NAMESPACE::ColumnFamilyMetaData meta; db->GetColumnFamilyMetaData(&meta); std::string file1; for (auto& file : meta.levels[0].files) { @@ -108,12 +108,12 @@ TEST_F(CompactFilesTest, L0ConflictsFiles) { // The background compaction then notices that there is an L0 compaction // already in progress and doesn't do an L0 compaction // Once the background compaction finishes, the compact files finishes - ASSERT_OK( - db->CompactFiles(rocksdb::CompactionOptions(), {file1, file2}, 0)); + ASSERT_OK(db->CompactFiles(ROCKSDB_NAMESPACE::CompactionOptions(), + {file1, file2}, 0)); break; } } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); delete db; } @@ -224,14 +224,14 @@ TEST_F(CompactFilesTest, CapturingPendingFiles) { auto l0_files = collector->GetFlushedFiles(); EXPECT_EQ(5, l0_files.size()); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"CompactFilesImpl:2", "CompactFilesTest.CapturingPendingFiles:0"}, {"CompactFilesTest.CapturingPendingFiles:1", "CompactFilesImpl:3"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Start compacting files. - rocksdb::port::Thread compaction_thread( + ROCKSDB_NAMESPACE::port::Thread compaction_thread( [&] { EXPECT_OK(db->CompactFiles(CompactionOptions(), l0_files, 1)); }); // In the meantime flush another file. @@ -242,7 +242,7 @@ TEST_F(CompactFilesTest, CapturingPendingFiles) { compaction_thread.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); delete db; @@ -296,12 +296,12 @@ TEST_F(CompactFilesTest, CompactionFilterWithGetSv) { db->Flush(FlushOptions()); // Compact all L0 files using CompactFiles - rocksdb::ColumnFamilyMetaData meta; + ROCKSDB_NAMESPACE::ColumnFamilyMetaData meta; db->GetColumnFamilyMetaData(&meta); for (auto& file : meta.levels[0].files) { std::string fname = file.db_path + "/" + file.name; ASSERT_OK( - db->CompactFiles(rocksdb::CompactionOptions(), {fname}, 0)); + db->CompactFiles(ROCKSDB_NAMESPACE::CompactionOptions(), {fname}, 0)); } @@ -347,7 +347,7 @@ TEST_F(CompactFilesTest, SentinelCompressionType) { compaction_opts.compression = CompressionType::kDisableCompressionOption; ASSERT_OK(db->CompactFiles(compaction_opts, l0_files, 1)); - rocksdb::TablePropertiesCollection all_tables_props; + ROCKSDB_NAMESPACE::TablePropertiesCollection all_tables_props; ASSERT_OK(db->GetPropertiesOfAllTables(&all_tables_props)); for (const auto& name_and_table_props : all_tables_props) { ASSERT_EQ(CompressionTypeToString(CompressionType::kZlibCompression), @@ -402,7 +402,7 @@ TEST_F(CompactFilesTest, GetCompactionJobInfo) { delete db; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/compacted_db_impl.cc b/db/compacted_db_impl.cc index 13cccbd77..47d6ecced 100644 --- a/db/compacted_db_impl.cc +++ b/db/compacted_db_impl.cc @@ -9,7 +9,7 @@ #include "db/version_set.h" #include "table/get_context.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { extern void MarkKeyMayExist(void* arg); extern bool SaveValue(void* arg, const ParsedInternalKey& parsed_key, @@ -156,5 +156,5 @@ Status CompactedDBImpl::Open(const Options& options, return s; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/compacted_db_impl.h b/db/compacted_db_impl.h index 8a57c5b77..7099566fc 100644 --- a/db/compacted_db_impl.h +++ b/db/compacted_db_impl.h @@ -9,7 +9,7 @@ #include <vector> #include "db/db_impl/db_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class CompactedDBImpl : public DBImpl { public: @@ -109,5 +109,5 @@ class CompactedDBImpl : public DBImpl { const Comparator* user_comparator_; LevelFilesBrief files_; }; -} +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/compaction/compaction.cc b/db/compaction/compaction.cc index f88450271..5c34fdcaa 100644 --- a/db/compaction/compaction.cc +++ b/db/compaction/compaction.cc @@ -16,7 +16,7 @@ #include "test_util/sync_point.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { const uint64_t kRangeTombstoneSentinel = PackSequenceAndType(kMaxSequenceNumber, kTypeRangeDeletion); @@ -561,4 +561,4 @@ int Compaction::GetInputBaseLevel() const { return input_vstorage_->base_level(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction.h b/db/compaction/compaction.h index dec5e607e..9358e50ff 100644 --- a/db/compaction/compaction.h +++ b/db/compaction/compaction.h @@ -13,7 +13,7 @@ #include "options/cf_options.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // The file contains class Compaction, as well as some helper functions // and data structures used by the class. @@ -381,4 +381,4 @@ class Compaction { // Return sum of sizes of all files in `files`. extern uint64_t TotalFileSize(const std::vector<FileMetaData*>& files); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_iteration_stats.h b/db/compaction/compaction_iteration_stats.h index ddb534622..963c1d8eb 100644 --- a/db/compaction/compaction_iteration_stats.h +++ b/db/compaction/compaction_iteration_stats.h @@ -5,6 +5,8 @@ #pragma once +#include "rocksdb/rocksdb_namespace.h" + struct CompactionIterationStats { // Compaction statistics diff --git a/db/compaction/compaction_iterator.cc b/db/compaction/compaction_iterator.cc index a5846349c..1bebfc717 100644 --- a/db/compaction/compaction_iterator.cc +++ b/db/compaction/compaction_iterator.cc @@ -28,7 +28,7 @@ ((seq) <= earliest_snapshot_ && \ (snapshot_checker_ == nullptr || LIKELY(IsInEarliestSnapshot(seq)))) -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { CompactionIterator::CompactionIterator( InternalIterator* input, const Comparator* cmp, MergeHelper* merge_helper, @@ -771,4 +771,4 @@ bool CompactionIterator::IsInEarliestSnapshot(SequenceNumber sequence) { return in_snapshot == SnapshotCheckerResult::kInSnapshot; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_iterator.h b/db/compaction/compaction_iterator.h index 1e08b407d..8be60eb9e 100644 --- a/db/compaction/compaction_iterator.h +++ b/db/compaction/compaction_iterator.h @@ -19,7 +19,7 @@ #include "options/cf_options.h" #include "rocksdb/compaction_filter.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class CompactionIterator { public: @@ -237,4 +237,4 @@ class CompactionIterator { manual_compaction_paused_->load(std::memory_order_relaxed); } }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_iterator_test.cc b/db/compaction/compaction_iterator_test.cc index 94f297961..0c50fb9ba 100644 --- a/db/compaction/compaction_iterator_test.cc +++ b/db/compaction/compaction_iterator_test.cc @@ -14,7 +14,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Expects no merging attempts. class NoMergingMergeOp : public MergeOperator { @@ -494,7 +494,7 @@ TEST_P(CompactionIteratorTest, ShuttingDownInFilter) { compaction_proxy_->key_not_exists_beyond_output_level = true; std::atomic<bool> seek_done{false}; - rocksdb::port::Thread compaction_thread([&] { + ROCKSDB_NAMESPACE::port::Thread compaction_thread([&] { c_iter_->SeekToFirst(); EXPECT_FALSE(c_iter_->Valid()); EXPECT_TRUE(c_iter_->status().IsShutdownInProgress()); @@ -531,7 +531,7 @@ TEST_P(CompactionIteratorTest, ShuttingDownInMerge) { compaction_proxy_->key_not_exists_beyond_output_level = true; std::atomic<bool> seek_done{false}; - rocksdb::port::Thread compaction_thread([&] { + ROCKSDB_NAMESPACE::port::Thread compaction_thread([&] { c_iter_->SeekToFirst(); ASSERT_FALSE(c_iter_->Valid()); ASSERT_TRUE(c_iter_->status().IsShutdownInProgress()); @@ -968,7 +968,7 @@ TEST_F(CompactionIteratorWithSnapshotCheckerTest, CompactionFilter_FullMerge) { compaction_filter.get()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/compaction/compaction_job.cc b/db/compaction/compaction_job.cc index dcebd7c74..576ec7b45 100644 --- a/db/compaction/compaction_job.cc +++ b/db/compaction/compaction_job.cc @@ -59,7 +59,7 @@ #include "util/stop_watch.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { const char* GetCompactionReasonString(CompactionReason compaction_reason) { switch (compaction_reason) { @@ -1697,4 +1697,4 @@ void CompactionJob::LogCompaction() { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_job.h b/db/compaction/compaction_job.h index e7da29f53..c15f502a1 100644 --- a/db/compaction/compaction_job.h +++ b/db/compaction/compaction_job.h @@ -44,7 +44,7 @@ #include "util/stop_watch.h" #include "util/thread_local.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Arena; class ErrorHandler; @@ -195,4 +195,4 @@ class CompactionJob { Env::Priority thread_pri_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_job_stats_test.cc b/db/compaction/compaction_job_stats_test.cc index f25a38ec6..51a665797 100644 --- a/db/compaction/compaction_job_stats_test.cc +++ b/db/compaction/compaction_job_stats_test.cc @@ -61,7 +61,7 @@ #if !defined(IOS_CROSS_COMPILE) #ifndef ROCKSDB_LITE -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static std::string RandomString(Random* rnd, int len, double ratio) { std::string r; @@ -110,9 +110,9 @@ class CompactionJobStatsTest : public testing::Test, } ~CompactionJobStatsTest() override { - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->LoadDependency({}); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({}); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); Close(); Options options; options.db_paths.emplace_back(dbname_, 0); @@ -801,7 +801,7 @@ TEST_P(CompactionJobStatsTest, CompactionJobStatsTest) { stats_checker->set_verify_next_comp_io_stats(true); std::atomic<bool> first_prepare_write(true); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WritableFileWriter::Append:BeforePrepareWrite", [&](void* /*arg*/) { if (first_prepare_write.load()) { options.env->SleepForMicroseconds(3); @@ -810,7 +810,7 @@ TEST_P(CompactionJobStatsTest, CompactionJobStatsTest) { }); std::atomic<bool> first_flush(true); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WritableFileWriter::Flush:BeforeAppend", [&](void* /*arg*/) { if (first_flush.load()) { options.env->SleepForMicroseconds(3); @@ -819,7 +819,7 @@ TEST_P(CompactionJobStatsTest, CompactionJobStatsTest) { }); std::atomic<bool> first_sync(true); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WritableFileWriter::SyncInternal:0", [&](void* /*arg*/) { if (first_sync.load()) { options.env->SleepForMicroseconds(3); @@ -828,14 +828,14 @@ TEST_P(CompactionJobStatsTest, CompactionJobStatsTest) { }); std::atomic<bool> first_range_sync(true); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WritableFileWriter::RangeSync:0", [&](void* /*arg*/) { if (first_range_sync.load()) { options.env->SleepForMicroseconds(3); first_range_sync.store(false); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Compact(1, smallest_key, largest_key); @@ -844,7 +844,7 @@ TEST_P(CompactionJobStatsTest, CompactionJobStatsTest) { ASSERT_TRUE(!first_flush.load()); ASSERT_TRUE(!first_sync.load()); ASSERT_TRUE(!first_range_sync.load()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } ASSERT_EQ(stats_checker->NumberOfUnverifiedStats(), 0U); } @@ -1019,10 +1019,10 @@ TEST_P(CompactionJobStatsTest, UniversalCompactionTest) { INSTANTIATE_TEST_CASE_P(CompactionJobStatsTest, CompactionJobStatsTest, ::testing::Values(1, 4)); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/compaction/compaction_job_test.cc b/db/compaction/compaction_job_test.cc index 31dae59b5..e7b46ef97 100644 --- a/db/compaction/compaction_job_test.cc +++ b/db/compaction/compaction_job_test.cc @@ -29,7 +29,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { @@ -1063,7 +1063,7 @@ TEST_F(CompactionJobTest, OldestBlobFileNumber) { /* expected_oldest_blob_file_number */ 19); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/compaction/compaction_picker.cc b/db/compaction/compaction_picker.cc index 0461ff32d..4355d4b91 100644 --- a/db/compaction/compaction_picker.cc +++ b/db/compaction/compaction_picker.cc @@ -23,7 +23,7 @@ #include "util/random.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { uint64_t TotalCompensatedFileSize(const std::vector<FileMetaData*>& files) { @@ -1128,4 +1128,4 @@ bool CompactionPicker::GetOverlappingL0Files( return true; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_picker.h b/db/compaction/compaction_picker.h index ae158059a..36d570e68 100644 --- a/db/compaction/compaction_picker.h +++ b/db/compaction/compaction_picker.h @@ -22,7 +22,7 @@ #include "rocksdb/options.h" #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // The file contains an abstract class CompactionPicker, and its two // sub-classes LevelCompactionPicker and NullCompactionPicker, as @@ -310,4 +310,4 @@ CompressionOptions GetCompressionOptions(const ImmutableCFOptions& ioptions, int level, const bool enable_compression = true); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_picker_fifo.cc b/db/compaction/compaction_picker_fifo.cc index cdf5e46da..030da619c 100644 --- a/db/compaction/compaction_picker_fifo.cc +++ b/db/compaction/compaction_picker_fifo.cc @@ -17,7 +17,7 @@ #include "logging/log_buffer.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { uint64_t GetTotalFilesSize(const std::vector<FileMetaData*>& files) { uint64_t total_size = 0; @@ -238,5 +238,5 @@ Compaction* FIFOCompactionPicker::CompactRange( return c; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/compaction/compaction_picker_fifo.h b/db/compaction/compaction_picker_fifo.h index 065faef13..eb786e5ac 100644 --- a/db/compaction/compaction_picker_fifo.h +++ b/db/compaction/compaction_picker_fifo.h @@ -12,7 +12,7 @@ #include "db/compaction/compaction_picker.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class FIFOCompactionPicker : public CompactionPicker { public: FIFOCompactionPicker(const ImmutableCFOptions& ioptions, @@ -49,5 +49,5 @@ class FIFOCompactionPicker : public CompactionPicker { VersionStorageInfo* version, LogBuffer* log_buffer); }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/compaction/compaction_picker_level.cc b/db/compaction/compaction_picker_level.cc index 4c2afa667..012edd080 100644 --- a/db/compaction/compaction_picker_level.cc +++ b/db/compaction/compaction_picker_level.cc @@ -15,7 +15,7 @@ #include "logging/log_buffer.h" #include "test_util/sync_point.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { bool LevelCompactionPicker::NeedsCompaction( const VersionStorageInfo* vstorage) const { @@ -555,4 +555,4 @@ Compaction* LevelCompactionPicker::PickCompaction( log_buffer, mutable_cf_options, ioptions_); return builder.PickCompaction(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_picker_level.h b/db/compaction/compaction_picker_level.h index c8d905ef9..b82070e14 100644 --- a/db/compaction/compaction_picker_level.h +++ b/db/compaction/compaction_picker_level.h @@ -11,7 +11,7 @@ #include "db/compaction/compaction_picker.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Picking compactions for leveled compaction. See wiki page // https://github.com/facebook/rocksdb/wiki/Leveled-Compaction // for description of Leveled compaction. @@ -29,4 +29,4 @@ class LevelCompactionPicker : public CompactionPicker { const VersionStorageInfo* vstorage) const override; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/compaction/compaction_picker_test.cc b/db/compaction/compaction_picker_test.cc index dbf9962fe..278bdb06a 100644 --- a/db/compaction/compaction_picker_test.cc +++ b/db/compaction/compaction_picker_test.cc @@ -17,7 +17,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class CountingLogger : public Logger { public: @@ -1733,7 +1733,7 @@ TEST_F(CompactionPickerTest, IntraL0ForEarliestSeqno) { ASSERT_EQ(0, compaction->output_level()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/compaction/compaction_picker_universal.cc b/db/compaction/compaction_picker_universal.cc index b1c9d0469..d8b63956e 100644 --- a/db/compaction/compaction_picker_universal.cc +++ b/db/compaction/compaction_picker_universal.cc @@ -23,7 +23,7 @@ #include "util/random.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { // A helper class that form universal compactions. The class is used by // UniversalCompactionPicker::PickCompaction(). @@ -1100,6 +1100,6 @@ Compaction* UniversalCompactionBuilder::PickPeriodicCompaction() { return c; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/compaction/compaction_picker_universal.h b/db/compaction/compaction_picker_universal.h index 150b6bd79..c3f55f5d3 100644 --- a/db/compaction/compaction_picker_universal.h +++ b/db/compaction/compaction_picker_universal.h @@ -12,7 +12,7 @@ #include "db/compaction/compaction_picker.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class UniversalCompactionPicker : public CompactionPicker { public: UniversalCompactionPicker(const ImmutableCFOptions& ioptions, @@ -27,5 +27,5 @@ class UniversalCompactionPicker : public CompactionPicker { virtual bool NeedsCompaction( const VersionStorageInfo* vstorage) const override; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/comparator_db_test.cc b/db/comparator_db_test.cc index 53322fd15..49f287a97 100644 --- a/db/comparator_db_test.cc +++ b/db/comparator_db_test.cc @@ -18,7 +18,7 @@ using std::unique_ptr; -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { static const Comparator* kTestComparator = nullptr; @@ -268,7 +268,7 @@ class ComparatorDBTest BlockBasedTableOptions toptions; toptions.format_version = GetParam(); last_options_.table_factory.reset( - rocksdb::NewBlockBasedTableFactory(toptions)); + ROCKSDB_NAMESPACE::NewBlockBasedTableFactory(toptions)); EXPECT_OK(DestroyDB(dbname_, last_options_)); } @@ -652,7 +652,7 @@ TEST_P(ComparatorDBTest, SeparatorSuccessorRandomizeTest) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/convenience.cc b/db/convenience.cc index 78396cf4a..206f1f875 100644 --- a/db/convenience.cc +++ b/db/convenience.cc @@ -11,7 +11,7 @@ #include "db/db_impl/db_impl.h" #include "util/cast_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { void CancelAllBackgroundWork(DB* db, bool wait) { (static_cast_with_check<DBImpl, DB>(db->GetRootDB())) @@ -72,6 +72,6 @@ Status VerifySstFileChecksum(const Options& options, return s; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/corruption_test.cc b/db/corruption_test.cc index 5cc0e574c..203c34fa4 100644 --- a/db/corruption_test.cc +++ b/db/corruption_test.cc @@ -33,7 +33,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static const int kValueSize = 1000; @@ -98,7 +98,7 @@ class CorruptionTest : public testing::Test { void RepairDB() { delete db_; db_ = nullptr; - ASSERT_OK(::rocksdb::RepairDB(dbname_, options_)); + ASSERT_OK(::ROCKSDB_NAMESPACE::RepairDB(dbname_, options_)); } void Build(int n, int flush_every = 0) { @@ -595,7 +595,7 @@ TEST_F(CorruptionTest, FileSystemStateCorrupted) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/cuckoo_table_db_test.cc b/db/cuckoo_table_db_test.cc index 2bdbaae88..9467840ff 100644 --- a/db/cuckoo_table_db_test.cc +++ b/db/cuckoo_table_db_test.cc @@ -15,7 +15,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class CuckooTableDBTest : public testing::Test { private: @@ -328,14 +328,13 @@ TEST_F(CuckooTableDBTest, AdaptiveTable) { ASSERT_EQ("v4", Get("key4")); ASSERT_EQ("v6", Get("key5")); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - if (rocksdb::port::kLittleEndian) { + if (ROCKSDB_NAMESPACE::port::kLittleEndian) { ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); - } - else { + } else { fprintf(stderr, "SKIPPED as Cuckoo table doesn't support Big Endian\n"); return 0; } diff --git a/db/db_basic_test.cc b/db/db_basic_test.cc index 5294c1a60..7573a01b4 100644 --- a/db/db_basic_test.cc +++ b/db/db_basic_test.cc @@ -17,7 +17,7 @@ #include "test_util/sync_point.h" #endif -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBBasicTest : public DBTestBase { public: @@ -27,8 +27,8 @@ class DBBasicTest : public DBTestBase { TEST_F(DBBasicTest, OpenWhenOpen) { Options options = CurrentOptions(); options.env = env_; - rocksdb::DB* db2 = nullptr; - rocksdb::Status s = DB::Open(options, dbname_, &db2); + ROCKSDB_NAMESPACE::DB* db2 = nullptr; + ROCKSDB_NAMESPACE::Status s = DB::Open(options, dbname_, &db2); ASSERT_EQ(Status::Code::kIOError, s.code()); ASSERT_EQ(Status::SubCode::kNone, s.subcode()); @@ -1048,8 +1048,8 @@ TEST_P(DBMultiGetTestWithParam, MultiGetMultiCF) { } int get_sv_count = 0; - rocksdb::DBImpl* db = reinterpret_cast<DBImpl*>(db_); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::DBImpl* db = reinterpret_cast<DBImpl*>(db_); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::MultiGet::AfterRefSV", [&](void* /*arg*/) { if (++get_sv_count == 2) { // After MultiGet refs a couple of CFs, flush all CFs so MultiGet @@ -1073,7 +1073,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetMultiCF) { } } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::vector<int> cfs; std::vector<std::string> keys; @@ -1139,12 +1139,12 @@ TEST_P(DBMultiGetTestWithParam, MultiGetMultiCFMutex) { int get_sv_count = 0; int retries = 0; bool last_try = false; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::MultiGet::LastTry", [&](void* /*arg*/) { last_try = true; - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::MultiGet::AfterRefSV", [&](void* /*arg*/) { if (last_try) { return; @@ -1160,7 +1160,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetMultiCFMutex) { } } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::vector<int> cfs; std::vector<std::string> keys; @@ -1198,8 +1198,8 @@ TEST_P(DBMultiGetTestWithParam, MultiGetMultiCFSnapshot) { } int get_sv_count = 0; - rocksdb::DBImpl* db = reinterpret_cast<DBImpl*>(db_); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::DBImpl* db = reinterpret_cast<DBImpl*>(db_); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::MultiGet::AfterRefSV", [&](void* /*arg*/) { if (++get_sv_count == 2) { for (int i = 0; i < 8; ++i) { @@ -1219,7 +1219,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetMultiCFSnapshot) { } } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::vector<int> cfs; std::vector<std::string> keys; @@ -1558,7 +1558,7 @@ TEST_P(DBMultiGetRowCacheTest, MultiGetBatched) { do { option_config_ = kRowCache; Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); CreateAndReopenWithCF({"pikachu"}, options); SetPerfLevel(kEnableCount); ASSERT_OK(Put(1, "k1", "v1")); @@ -1664,13 +1664,13 @@ TEST_F(DBBasicTest, GetAllKeyVersions) { ASSERT_OK(Delete(std::to_string(i))); } std::vector<KeyVersion> key_versions; - ASSERT_OK(rocksdb::GetAllKeyVersions(db_, Slice(), Slice(), - std::numeric_limits<size_t>::max(), - &key_versions)); + ASSERT_OK(ROCKSDB_NAMESPACE::GetAllKeyVersions( + db_, Slice(), Slice(), std::numeric_limits<size_t>::max(), + &key_versions)); ASSERT_EQ(kNumInserts + kNumDeletes + kNumUpdates, key_versions.size()); - ASSERT_OK(rocksdb::GetAllKeyVersions(db_, handles_[0], Slice(), Slice(), - std::numeric_limits<size_t>::max(), - &key_versions)); + ASSERT_OK(ROCKSDB_NAMESPACE::GetAllKeyVersions( + db_, handles_[0], Slice(), Slice(), std::numeric_limits<size_t>::max(), + &key_versions)); ASSERT_EQ(kNumInserts + kNumDeletes + kNumUpdates, key_versions.size()); // Check non-default column family @@ -1683,9 +1683,9 @@ TEST_F(DBBasicTest, GetAllKeyVersions) { for (size_t i = 0; i != kNumDeletes - 1; ++i) { ASSERT_OK(Delete(1, std::to_string(i))); } - ASSERT_OK(rocksdb::GetAllKeyVersions(db_, handles_[1], Slice(), Slice(), - std::numeric_limits<size_t>::max(), - &key_versions)); + ASSERT_OK(ROCKSDB_NAMESPACE::GetAllKeyVersions( + db_, handles_[1], Slice(), Slice(), std::numeric_limits<size_t>::max(), + &key_versions)); ASSERT_EQ(kNumInserts + kNumDeletes + kNumUpdates - 3, key_versions.size()); } #endif // !ROCKSDB_LITE @@ -2527,7 +2527,7 @@ TEST_P(DBBasicTestWithTimestampWithParam, PutAndGet) { INSTANTIATE_TEST_CASE_P(Timestamp, DBBasicTestWithTimestampWithParam, ::testing::Bool()); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS extern "C" { @@ -2538,7 +2538,7 @@ void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} #endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); diff --git a/db/db_blob_index_test.cc b/db/db_blob_index_test.cc index 30e44e5ba..24862f771 100644 --- a/db/db_blob_index_test.cc +++ b/db/db_blob_index_test.cc @@ -23,7 +23,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // kTypeBlobIndex is a value type used by BlobDB only. The base rocksdb // should accept the value type on write, and report not supported value @@ -427,10 +427,10 @@ TEST_F(DBBlobIndexTest, Iterate) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_block_cache_test.cc b/db/db_block_cache_test.cc index b89369c8f..3031e56bb 100644 --- a/db/db_block_cache_test.cc +++ b/db/db_block_cache_test.cc @@ -12,7 +12,7 @@ #include "port/stack_trace.h" #include "util/compression.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBBlockCacheTest : public DBTestBase { private: @@ -46,7 +46,7 @@ class DBBlockCacheTest : public DBTestBase { options.create_if_missing = true; options.avoid_flush_during_recovery = false; // options.compression = kNoCompression; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.table_factory.reset(new BlockBasedTableFactory(table_options)); return options; } @@ -292,7 +292,7 @@ TEST_F(DBBlockCacheTest, TestWithCompressedBlockCache) { TEST_F(DBBlockCacheTest, IndexAndFilterBlocksOfNewTableAddedToCache) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; table_options.filter_policy.reset(NewBloomFilterPolicy(20)); @@ -378,7 +378,7 @@ TEST_F(DBBlockCacheTest, FillCacheAndIterateDB) { TEST_F(DBBlockCacheTest, IndexAndFilterBlocksStats) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; LRUCacheOptions co; @@ -464,7 +464,7 @@ TEST_F(DBBlockCacheTest, IndexAndFilterBlocksCachePriority) { for (auto priority : {Cache::Priority::LOW, Cache::Priority::HIGH}) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; table_options.block_cache.reset(new MockCache()); @@ -520,7 +520,7 @@ TEST_F(DBBlockCacheTest, IndexAndFilterBlocksCachePriority) { TEST_F(DBBlockCacheTest, ParanoidFileChecks) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.level0_file_num_compaction_trigger = 2; options.paranoid_file_checks = true; BlockBasedTableOptions table_options; @@ -576,7 +576,7 @@ TEST_F(DBBlockCacheTest, CompressedCache) { for (int iter = 0; iter < 4; iter++) { Options options = CurrentOptions(); options.write_buffer_size = 64 * 1024; // small write buffer - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; switch (iter) { @@ -705,7 +705,7 @@ TEST_F(DBBlockCacheTest, CacheCompressionDict) { options.compression_opts.max_dict_bytes = 4096; options.create_if_missing = true; options.num_levels = 2; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.target_file_size_base = kNumEntriesPerFile * kNumBytesPerEntry; BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; @@ -752,10 +752,10 @@ TEST_F(DBBlockCacheTest, CacheCompressionDict) { #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_bloom_filter_test.cc b/db/db_bloom_filter_test.cc index 417552ad8..dcad00327 100644 --- a/db/db_bloom_filter_test.cc +++ b/db/db_bloom_filter_test.cc @@ -12,7 +12,7 @@ #include "rocksdb/perf_context.h" #include "table/block_based/filter_policy_internal.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { using BFP = BloomFilterPolicy; @@ -88,7 +88,7 @@ TEST_P(DBBloomFilterTestDefFormatVersion, KeyMayExist) { // indexes continue; } - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); CreateAndReopenWithCF({"pikachu"}, options); ASSERT_TRUE(!db_->KeyMayExist(ropts, handles_[1], "a", &value)); @@ -150,7 +150,7 @@ TEST_F(DBBloomFilterTest, GetFilterByPrefixBloomCustomPrefixExtractor) { Options options = last_options_; options.prefix_extractor = std::make_shared<SliceTransformLimitedDomainGeneric>(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); get_perf_context()->EnablePerLevelPerfContext(); BlockBasedTableOptions bbto; bbto.filter_policy.reset(NewBloomFilterPolicy(10, false)); @@ -216,7 +216,7 @@ TEST_F(DBBloomFilterTest, GetFilterByPrefixBloom) { for (bool partition_filters : {true, false}) { Options options = last_options_; options.prefix_extractor.reset(NewFixedPrefixTransform(8)); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); get_perf_context()->EnablePerLevelPerfContext(); BlockBasedTableOptions bbto; bbto.filter_policy.reset(NewBloomFilterPolicy(10, false)); @@ -267,7 +267,7 @@ TEST_F(DBBloomFilterTest, WholeKeyFilterProp) { for (bool partition_filters : {true, false}) { Options options = last_options_; options.prefix_extractor.reset(NewFixedPrefixTransform(3)); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); get_perf_context()->EnablePerLevelPerfContext(); BlockBasedTableOptions bbto; @@ -531,7 +531,7 @@ INSTANTIATE_TEST_CASE_P( TEST_F(DBBloomFilterTest, BloomFilterRate) { while (ChangeFilterOptions()) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); get_perf_context()->EnablePerLevelPerfContext(); CreateAndReopenWithCF({"pikachu"}, options); @@ -563,7 +563,7 @@ TEST_F(DBBloomFilterTest, BloomFilterRate) { TEST_F(DBBloomFilterTest, BloomFilterCompatibility) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.filter_policy.reset(NewBloomFilterPolicy(10, true)); options.table_factory.reset(NewBlockBasedTableFactory(table_options)); @@ -607,7 +607,7 @@ TEST_F(DBBloomFilterTest, BloomFilterCompatibility) { TEST_F(DBBloomFilterTest, BloomFilterReverseCompatibility) { for (bool partition_filters : {true, false}) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; if (partition_filters) { table_options.partition_filters = true; @@ -654,17 +654,18 @@ class TestingWrappedBlockBasedFilterPolicy : public FilterPolicy { return "TestingWrappedBlockBasedFilterPolicy"; } - void CreateFilter(const rocksdb::Slice* keys, int n, + void CreateFilter(const ROCKSDB_NAMESPACE::Slice* keys, int n, std::string* dst) const override { - std::unique_ptr<rocksdb::Slice[]> user_keys(new rocksdb::Slice[n]); + std::unique_ptr<ROCKSDB_NAMESPACE::Slice[]> user_keys( + new ROCKSDB_NAMESPACE::Slice[n]); for (int i = 0; i < n; ++i) { user_keys[i] = convertKey(keys[i]); } return filter_->CreateFilter(user_keys.get(), n, dst); } - bool KeyMayMatch(const rocksdb::Slice& key, - const rocksdb::Slice& filter) const override { + bool KeyMayMatch(const ROCKSDB_NAMESPACE::Slice& key, + const ROCKSDB_NAMESPACE::Slice& filter) const override { counter_++; return filter_->KeyMayMatch(convertKey(key), filter); } @@ -675,13 +676,16 @@ class TestingWrappedBlockBasedFilterPolicy : public FilterPolicy { const FilterPolicy* filter_; mutable uint32_t counter_; - rocksdb::Slice convertKey(const rocksdb::Slice& key) const { return key; } + ROCKSDB_NAMESPACE::Slice convertKey( + const ROCKSDB_NAMESPACE::Slice& key) const { + return key; + } }; } // namespace TEST_F(DBBloomFilterTest, WrappedBlockBasedFilterPolicy) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; TestingWrappedBlockBasedFilterPolicy* policy = @@ -797,7 +801,7 @@ class TestingContextCustomFilterPolicy TEST_F(DBBloomFilterTest, ContextCustomFilterPolicy) { for (bool fifo : {true, false}) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.compaction_style = fifo ? kCompactionStyleFIFO : kCompactionStyleLevel; @@ -896,7 +900,7 @@ class SliceTransformLimitedDomain : public SliceTransform { TEST_F(DBBloomFilterTest, PrefixExtractorFullFilter) { BlockBasedTableOptions bbto; // Full Filter Block - bbto.filter_policy.reset(rocksdb::NewBloomFilterPolicy(10, false)); + bbto.filter_policy.reset(ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, false)); bbto.whole_key_filtering = false; Options options = CurrentOptions(); @@ -925,7 +929,7 @@ TEST_F(DBBloomFilterTest, PrefixExtractorFullFilter) { TEST_F(DBBloomFilterTest, PrefixExtractorBlockFilter) { BlockBasedTableOptions bbto; // Block Filter Block - bbto.filter_policy.reset(rocksdb::NewBloomFilterPolicy(10, true)); + bbto.filter_policy.reset(ROCKSDB_NAMESPACE::NewBloomFilterPolicy(10, true)); Options options = CurrentOptions(); options.prefix_extractor = std::make_shared<SliceTransformLimitedDomain>(); @@ -964,7 +968,8 @@ TEST_F(DBBloomFilterTest, MemtableWholeKeyBloomFilter) { Options options = CurrentOptions(); options.memtable_prefix_bloom_size_ratio = static_cast<double>(kMemtablePrefixFilterSize) / kMemtableSize; - options.prefix_extractor.reset(rocksdb::NewFixedPrefixTransform(kPrefixLen)); + options.prefix_extractor.reset( + ROCKSDB_NAMESPACE::NewFixedPrefixTransform(kPrefixLen)); options.write_buffer_size = kMemtableSize; options.memtable_whole_key_filtering = false; Reopen(options); @@ -1042,7 +1047,8 @@ class BloomStatsTestWithParam partition_filters_ = std::get<1>(GetParam()); options_.create_if_missing = true; - options_.prefix_extractor.reset(rocksdb::NewFixedPrefixTransform(4)); + options_.prefix_extractor.reset( + ROCKSDB_NAMESPACE::NewFixedPrefixTransform(4)); options_.memtable_prefix_bloom_size_ratio = 8.0 * 1024.0 / static_cast<double>(options_.write_buffer_size); if (bfp_impl_ == BFP2::kPlainTable) { @@ -1323,7 +1329,7 @@ TEST_F(DBBloomFilterTest, OptimizeFiltersForHits) { bbto.whole_key_filtering = true; options.table_factory.reset(NewBlockBasedTableFactory(bbto)); options.optimize_filters_for_hits = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); get_perf_context()->Reset(); get_perf_context()->EnablePerLevelPerfContext(); CreateAndReopenWithCF({"mypikachu"}, options); @@ -1449,13 +1455,13 @@ TEST_F(DBBloomFilterTest, OptimizeFiltersForHits) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); CompactRangeOptions compact_options; compact_options.bottommost_level_compaction = @@ -1895,10 +1901,10 @@ TEST_F(DBBloomFilterTest, DynamicBloomFilterOptions) { #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_compaction_filter_test.cc b/db/db_compaction_filter_test.cc index 745d0d051..a708c0b1a 100644 --- a/db/db_compaction_filter_test.cc +++ b/db/db_compaction_filter_test.cc @@ -10,7 +10,7 @@ #include "db/db_test_util.h" #include "port/stack_trace.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static int cfilter_count = 0; static int cfilter_skips = 0; @@ -863,10 +863,10 @@ TEST_F(DBTestCompactionFilter, IgnoreSnapshotsFalse) { delete options.compaction_filter; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_compaction_test.cc b/db/db_compaction_test.cc index 17193b706..635aca135 100644 --- a/db/db_compaction_test.cc +++ b/db/db_compaction_test.cc @@ -18,7 +18,7 @@ #include "test_util/sync_point.h" #include "util/concurrent_task_limiter_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // SYNC_POINT is not supported in released Windows mode. #if !defined(ROCKSDB_LITE) @@ -417,7 +417,7 @@ TEST_F(DBCompactionTest, SkipStatsUpdateTest) { Close(); int update_acc_stats_called = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "VersionStorageInfo::UpdateAccumulatedStats", [&](void* /* arg */) { ++update_acc_stats_called; }); SyncPoint::GetInstance()->EnableProcessing(); @@ -451,7 +451,7 @@ TEST_F(DBCompactionTest, TestTableReaderForCompaction) { int num_table_cache_lookup = 0; int num_new_table_reader = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "TableCache::FindTable:0", [&](void* arg) { assert(arg != nullptr); bool no_io = *(reinterpret_cast<bool*>(arg)); @@ -460,10 +460,10 @@ TEST_F(DBCompactionTest, TestTableReaderForCompaction) { num_table_cache_lookup++; } }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "TableCache::GetTableReader:0", [&](void* /*arg*/) { num_new_table_reader++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); for (int k = 0; k < options.level0_file_num_compaction_trigger; ++k) { ASSERT_OK(Put(Key(k), Key(k))); @@ -533,7 +533,7 @@ TEST_F(DBCompactionTest, TestTableReaderForCompaction) { ASSERT_EQ(num_table_cache_lookup + old_num_table_cache_lookup2, 3); ASSERT_EQ(num_new_table_reader, 0); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_P(DBCompactionTestWithParam, CompactionDeletionTriggerReopen) { @@ -1023,10 +1023,10 @@ TEST_F(DBCompactionTest, RecoverDuringMemtableCompaction) { TEST_P(DBCompactionTestWithParam, TrivialMoveOneFile) { int32_t trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.write_buffer_size = 100000000; @@ -1074,19 +1074,19 @@ TEST_P(DBCompactionTestWithParam, TrivialMoveOneFile) { } ASSERT_EQ(trivial_move, 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBCompactionTestWithParam, TrivialMoveNonOverlappingFiles) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.disable_auto_compactions = true; @@ -1173,19 +1173,19 @@ TEST_P(DBCompactionTestWithParam, TrivialMoveNonOverlappingFiles) { ASSERT_EQ(trivial_move, 0); ASSERT_EQ(non_trivial_move, 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBCompactionTestWithParam, TrivialMoveTargetLevel) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.disable_auto_compactions = true; @@ -1238,10 +1238,10 @@ TEST_P(DBCompactionTestWithParam, TrivialMoveTargetLevel) { TEST_P(DBCompactionTestWithParam, ManualCompactionPartial) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); bool first = true; @@ -1249,11 +1249,11 @@ TEST_P(DBCompactionTestWithParam, ManualCompactionPartial) { // 4 -> 1: ensure the order of two non-trivial compactions // 5 -> 2 and 5 -> 3: ensure we do a check before two non-trivial compactions // are installed - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBCompaction::ManualPartial:4", "DBCompaction::ManualPartial:1"}, {"DBCompaction::ManualPartial:5", "DBCompaction::ManualPartial:2"}, {"DBCompaction::ManualPartial:5", "DBCompaction::ManualPartial:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (first) { first = false; @@ -1264,7 +1264,7 @@ TEST_P(DBCompactionTestWithParam, ManualCompactionPartial) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.write_buffer_size = 10 * 1024 * 1024; @@ -1329,7 +1329,7 @@ TEST_P(DBCompactionTestWithParam, ManualCompactionPartial) { ASSERT_EQ(trivial_move, 6); ASSERT_EQ(non_trivial_move, 0); - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::port::Thread threads([&] { compact_options.change_level = false; compact_options.exclusive_manual_compaction = false; std::string begin_string = Key(0); @@ -1383,18 +1383,18 @@ TEST_P(DBCompactionTestWithParam, ManualCompactionPartial) { TEST_F(DBCompactionTest, DISABLED_ManualPartialFill) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); bool first = true; bool second = true; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBCompaction::PartialFill:4", "DBCompaction::PartialFill:1"}, {"DBCompaction::PartialFill:2", "DBCompaction::PartialFill:3"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { if (first) { TEST_SYNC_POINT("DBCompaction::PartialFill:4"); @@ -1404,7 +1404,7 @@ TEST_F(DBCompactionTest, DISABLED_ManualPartialFill) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.write_buffer_size = 10 * 1024 * 1024; @@ -1465,7 +1465,7 @@ TEST_F(DBCompactionTest, DISABLED_ManualPartialFill) { ASSERT_EQ(trivial_move, 2); ASSERT_EQ(non_trivial_move, 0); - rocksdb::port::Thread threads([&] { + ROCKSDB_NAMESPACE::port::Thread threads([&] { compact_options.change_level = false; compact_options.exclusive_manual_compaction = false; std::string begin_string = Key(0); @@ -1507,7 +1507,7 @@ TEST_F(DBCompactionTest, DISABLED_ManualPartialFill) { } TEST_F(DBCompactionTest, ManualCompactionWithUnorderedWrite) { - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::WriteImpl:UnorderedWriteAfterWriteWAL", "DBCompactionTest::ManualCompactionWithUnorderedWrite:WaitWriteWAL"}, {"DBImpl::WaitForPendingWrites:BeforeBlock", @@ -1520,7 +1520,7 @@ TEST_F(DBCompactionTest, ManualCompactionWithUnorderedWrite) { ASSERT_OK(Flush()); Put("bar", "v1"); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); port::Thread writer([&]() { Put("foo", "v2"); }); TEST_SYNC_POINT( @@ -1831,13 +1831,13 @@ TEST_F(DBCompactionTest, DeleteFileRangeFileEndpointsOverlapBug) { TEST_P(DBCompactionTestWithParam, TrivialMoveToLastLevelWithFiles) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.write_buffer_size = 100000000; @@ -1886,7 +1886,7 @@ TEST_P(DBCompactionTestWithParam, TrivialMoveToLastLevelWithFiles) { ASSERT_EQ(Get(Key(i)), values[i]); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBCompactionTestWithParam, LevelCompactionThirdPath) { @@ -2399,12 +2399,12 @@ TEST_F(DBCompactionTest, L0_CompactionBug_Issue44_b) { TEST_F(DBCompactionTest, ManualAutoRace) { CreateAndReopenWithCF({"pikachu"}, CurrentOptions()); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::BGWorkCompaction", "DBCompactionTest::ManualAutoRace:1"}, {"DBImpl::RunManualCompaction:WaitScheduled", "BackgroundCallCompaction:0"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put(1, "foo", ""); Put(1, "bar", ""); @@ -2435,13 +2435,13 @@ TEST_F(DBCompactionTest, ManualAutoRace) { // Eventually the cancelled compaction will be rescheduled and executed. dbfull()->TEST_WaitForCompact(); ASSERT_EQ("0,1", FilesPerLevel(0)); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBCompactionTestWithParam, ManualCompaction) { Options options = CurrentOptions(); options.max_subcompactions = max_subcompactions_; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); CreateAndReopenWithCF({"pikachu"}, options); // iter - 0 with 7 levels @@ -2489,7 +2489,7 @@ TEST_P(DBCompactionTestWithParam, ManualCompaction) { options = CurrentOptions(); options.num_levels = 3; options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); CreateAndReopenWithCF({"pikachu"}, options); } @@ -2836,19 +2836,19 @@ TEST_P(DBCompactionTestWithParam, CompressLevelCompaction) { kZlibCompression}; int matches = 0, didnt_match = 0, trivial_move = 0, non_trivial = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Compaction::InputCompressionMatchesOutput:Matches", [&](void* /*arg*/) { matches++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Compaction::InputCompressionMatchesOutput:DidntMatch", [&](void* /*arg*/) { didnt_match++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Reopen(options); @@ -2909,7 +2909,7 @@ TEST_P(DBCompactionTestWithParam, CompressLevelCompaction) { ASSERT_EQ(trivial_move, 12); ASSERT_EQ(non_trivial, 8); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); for (int i = 0; i < key_idx; i++) { auto v = Get(Key(i)); @@ -2971,13 +2971,13 @@ TEST_F(DBCompactionTest, SuggestCompactRangeNoTwoLevel0Compactions) { } db_->CompactRange(CompactRangeOptions(), nullptr, nullptr); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"CompactionJob::Run():Start", "DBCompactionTest::SuggestCompactRangeNoTwoLevel0Compactions:1"}, {"DBCompactionTest::SuggestCompactRangeNoTwoLevel0Compactions:2", "CompactionJob::Run():End"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // trigger L0 compaction for (int num = 0; num < options.level0_file_num_compaction_trigger + 1; @@ -3013,25 +3013,26 @@ static std::string ShortKey(int i) { TEST_P(DBCompactionTestWithParam, ForceBottommostLevelCompaction) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // The key size is guaranteed to be <= 8 class ShortKeyComparator : public Comparator { - int Compare(const rocksdb::Slice& a, - const rocksdb::Slice& b) const override { + int Compare(const ROCKSDB_NAMESPACE::Slice& a, + const ROCKSDB_NAMESPACE::Slice& b) const override { assert(a.size() <= 8); assert(b.size() <= 8); return BytewiseComparator()->Compare(a, b); } const char* Name() const override { return "ShortKeyComparator"; } - void FindShortestSeparator(std::string* start, - const rocksdb::Slice& limit) const override { + void FindShortestSeparator( + std::string* start, + const ROCKSDB_NAMESPACE::Slice& limit) const override { return BytewiseComparator()->FindShortestSeparator(start, limit); } void FindShortSuccessor(std::string* key) const override { @@ -3108,7 +3109,7 @@ TEST_P(DBCompactionTestWithParam, ForceBottommostLevelCompaction) { ASSERT_EQ(Get(ShortKey(i)), values[i]); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBCompactionTestWithParam, IntraL0Compaction) { @@ -3123,10 +3124,10 @@ TEST_P(DBCompactionTestWithParam, IntraL0Compaction) { Random rnd(301); std::string value(RandomString(&rnd, kValueSize)); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"LevelCompactionPicker::PickCompactionBySize:0", "CompactionJob::Run():Start"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // index: 0 1 2 3 4 5 6 7 8 9 // size: 1MB 1MB 1MB 1MB 1MB 2MB 1MB 1MB 1MB 1MB @@ -3149,7 +3150,7 @@ TEST_P(DBCompactionTestWithParam, IntraL0Compaction) { ASSERT_OK(Flush()); } dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); std::vector<std::vector<FileMetaData>> level_to_files; dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(), @@ -3177,10 +3178,10 @@ TEST_P(DBCompactionTestWithParam, IntraL0CompactionDoesNotObsoleteDeletions) { Random rnd(301); std::string value(RandomString(&rnd, kValueSize)); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"LevelCompactionPicker::PickCompactionBySize:0", "CompactionJob::Run():Start"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // index: 0 1 2 3 4 5 6 7 8 9 // size: 1MB 1MB 1MB 1MB 1MB 1MB 1MB 1MB 1MB 1MB @@ -3206,7 +3207,7 @@ TEST_P(DBCompactionTestWithParam, IntraL0CompactionDoesNotObsoleteDeletions) { ASSERT_OK(Flush()); } dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); std::vector<std::vector<FileMetaData>> level_to_files; dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(), @@ -3259,7 +3260,7 @@ TEST_P(DBCompactionTestWithParam, FullCompactionInBottomPriThreadPool) { // Verify that size amplification did occur ASSERT_EQ(NumSortedRuns(), 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } Env::Default()->SetBackgroundThreads(0, Env::Priority::BOTTOM); } @@ -3270,7 +3271,7 @@ TEST_F(DBCompactionTest, OptimizedDeletionObsoleting) { const int kNumL0Files = 4; Options options = CurrentOptions(); options.level0_file_num_compaction_trigger = kNumL0Files; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); // put key 1 and 3 in separate L1, L2 files. @@ -3315,12 +3316,12 @@ TEST_F(DBCompactionTest, CompactFilesPendingL0Bug) { options.max_background_compactions = 2; DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"LevelCompactionPicker::PickCompaction:Return", "DBCompactionTest::CompactFilesPendingL0Bug:Picked"}, {"DBCompactionTest::CompactFilesPendingL0Bug:ManualCompacted", "DBImpl::BackgroundCompaction:NonTrivial:AfterRun"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); auto schedule_multi_compaction_token = dbfull()->TEST_write_controler().GetCompactionPressureToken(); @@ -3350,7 +3351,7 @@ TEST_F(DBCompactionTest, CompactFilesPendingL0Bug) { ->CompactFiles(CompactionOptions(), input_filenames, 0 /* output_level */)); TEST_SYNC_POINT("DBCompactionTest::CompactFilesPendingL0Bug:ManualCompacted"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBCompactionTest, CompactFilesOverlapInL0Bug) { @@ -3424,13 +3425,13 @@ TEST_F(DBCompactionTest, CompactBottomLevelFilesWithDeletions) { // file without changing file count. db_->ReleaseSnapshot(snapshot); ASSERT_EQ(kMaxSequenceNumber, dbfull()->bottommost_files_mark_threshold_); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); ASSERT_TRUE(compaction->compaction_reason() == CompactionReason::kBottommostFiles); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); dbfull()->TEST_WaitForCompact(); db_->GetLiveFilesMetaData(&post_release_metadata); ASSERT_EQ(pre_release_metadata.size(), post_release_metadata.size()); @@ -3444,7 +3445,7 @@ TEST_F(DBCompactionTest, CompactBottomLevelFilesWithDeletions) { // deletion markers/deleted keys. ASSERT_LT(post_file.size, pre_file.size); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBCompactionTest, LevelCompactExpiredTtlFiles) { @@ -3493,16 +3494,16 @@ TEST_F(DBCompactionTest, LevelCompactExpiredTtlFiles) { // compacted. ASSERT_OK(Put("a", "1")); Flush(); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); ASSERT_TRUE(compaction->compaction_reason() == CompactionReason::kTtl); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); dbfull()->TEST_WaitForCompact(); // All non-L0 files are deleted, as they contained only deleted data. ASSERT_EQ("1", FilesPerLevel()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); // Test dynamically changing ttl. @@ -3540,12 +3541,12 @@ TEST_F(DBCompactionTest, LevelCompactExpiredTtlFiles) { dbfull()->TEST_WaitForCompact(); ASSERT_EQ("1,2,0,2", FilesPerLevel()); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); ASSERT_TRUE(compaction->compaction_reason() == CompactionReason::kTtl); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Dynamically change ttl to 10 hours. // This should trigger a ttl compaction, as 12 hours have already passed. @@ -3553,7 +3554,7 @@ TEST_F(DBCompactionTest, LevelCompactExpiredTtlFiles) { dbfull()->TEST_WaitForCompact(); // All non-L0 files are deleted, as they contained only deleted data. ASSERT_EQ("1", FilesPerLevel()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) { @@ -3570,7 +3571,7 @@ TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) { options.max_open_files = 20; } // RocksDB sanitize max open files to at least 20. Modify it back. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) { int* max_open_files = static_cast<int*>(arg); *max_open_files = 2; @@ -3578,7 +3579,7 @@ TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) { // In the case where all files are opened and doing DB restart // forcing the oldest ancester time in manifest file to be 0 to // simulate the case of reading from an old version. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "VersionEdit::EncodeTo:VarintOldestAncesterTime", [&](void* arg) { if (if_restart && if_open_all_files) { std::string* encoded_fieled = static_cast<std::string*>(arg); @@ -3594,7 +3595,7 @@ TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) { DestroyAndReopen(options); int ttl_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); auto compaction_reason = compaction->compaction_reason(); @@ -3602,7 +3603,7 @@ TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) { ttl_compactions++; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Add two L6 files with key ranges: [1 .. 100], [101 .. 200]. Random rnd(301); @@ -3697,7 +3698,7 @@ TEST_F(DBCompactionTest, LevelTtlCascadingCompactions) { ASSERT_EQ("1,0,0,0,0,0,1", FilesPerLevel()); ASSERT_GE(ttl_compactions, 6); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } } @@ -3717,7 +3718,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompaction) { options.max_open_files = 20; } // RocksDB sanitize max open files to at least 20. Modify it back. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) { int* max_open_files = static_cast<int*>(arg); *max_open_files = 0; @@ -3725,7 +3726,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompaction) { // In the case where all files are opened and doing DB restart // forcing the file creation time in manifest file to be 0 to // simulate the case of reading from an old version. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "VersionEdit::EncodeTo:VarintFileCreationTime", [&](void* arg) { if (if_restart && if_open_all_files) { std::string* encoded_fieled = static_cast<std::string*>(arg); @@ -3741,7 +3742,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompaction) { DestroyAndReopen(options); int periodic_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); auto compaction_reason = compaction->compaction_reason(); @@ -3749,7 +3750,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompaction) { periodic_compactions++; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int i = 0; i < kNumLevelFiles; ++i) { @@ -3801,7 +3802,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompaction) { // + 4. ASSERT_EQ(9, periodic_compactions); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } } @@ -3825,7 +3826,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithOldDB) { int periodic_compactions = 0; bool set_file_creation_time_to_zero = true; bool set_creation_time_to_zero = true; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); auto compaction_reason = compaction->compaction_reason(); @@ -3833,7 +3834,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithOldDB) { periodic_compactions++; } }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "PropertyBlockBuilder::AddTableProperty:Start", [&](void* arg) { TableProperties* props = reinterpret_cast<TableProperties*>(arg); if (set_file_creation_time_to_zero) { @@ -3843,7 +3844,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithOldDB) { props->creation_time = 0; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int i = 0; i < kNumFiles; ++i) { @@ -3876,7 +3877,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithOldDB) { // Make sure that all files go through periodic compaction. ASSERT_EQ(kNumFiles, periodic_compactions); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBCompactionTest, LevelPeriodicAndTtlCompaction) { @@ -3896,7 +3897,7 @@ TEST_F(DBCompactionTest, LevelPeriodicAndTtlCompaction) { int periodic_compactions = 0; int ttl_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); auto compaction_reason = compaction->compaction_reason(); @@ -3906,7 +3907,7 @@ TEST_F(DBCompactionTest, LevelPeriodicAndTtlCompaction) { ttl_compactions++; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int i = 0; i < kNumLevelFiles; ++i) { @@ -3957,7 +3958,7 @@ TEST_F(DBCompactionTest, LevelPeriodicAndTtlCompaction) { ASSERT_EQ(6, periodic_compactions); ASSERT_EQ(6, ttl_compactions); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBCompactionTest, LevelPeriodicCompactionWithCompactionFilters) { @@ -4010,7 +4011,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithCompactionFilters) { dbfull()->GetOptions().periodic_compaction_seconds); int periodic_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); auto compaction_reason = compaction->compaction_reason(); @@ -4018,7 +4019,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithCompactionFilters) { periodic_compactions++; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); for (int i = 0; i < kNumLevelFiles; ++i) { for (int j = 0; j < kNumKeysPerFile; ++j) { @@ -4042,7 +4043,7 @@ TEST_F(DBCompactionTest, LevelPeriodicCompactionWithCompactionFilters) { // The two old files go through the periodic compaction process ASSERT_EQ(2, periodic_compactions); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -4068,16 +4069,17 @@ TEST_F(DBCompactionTest, CompactRangeDelayedByL0FileCount) { if (i == 0) { // ensure the auto compaction doesn't finish until manual compaction has // had a chance to be delayed. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait", "CompactionJob::Run():End"}}); } else { // ensure the auto-compaction doesn't finish until manual compaction has // continued without delay. - rocksdb::SyncPoint::GetInstance()->LoadDependency( - {{"DBImpl::FlushMemTable:StallWaitDone", "CompactionJob::Run():End"}}); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( + {{"DBImpl::FlushMemTable:StallWaitDone", + "CompactionJob::Run():End"}}); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int j = 0; j < kNumL0FilesLimit - 1; ++j) { @@ -4096,7 +4098,7 @@ TEST_F(DBCompactionTest, CompactRangeDelayedByL0FileCount) { dbfull()->TEST_WaitForCompact(); ASSERT_EQ(0, NumTableFilesAtLevel(0)); ASSERT_GT(NumTableFilesAtLevel(1), 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -4122,17 +4124,17 @@ TEST_F(DBCompactionTest, CompactRangeDelayedByImmMemTableCount) { if (i == 0) { // ensure the flush doesn't finish until manual compaction has had a // chance to be delayed. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait", "FlushJob::WriteLevel0Table"}}); } else { // ensure the flush doesn't finish until manual compaction has continued // without delay. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::FlushMemTable:StallWaitDone", "FlushJob::WriteLevel0Table"}}); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int j = 0; j < kNumImmMemTableLimit - 1; ++j) { @@ -4153,7 +4155,7 @@ TEST_F(DBCompactionTest, CompactRangeDelayedByImmMemTableCount) { dbfull()->TEST_WaitForFlushMemTable(); ASSERT_EQ(0, NumTableFilesAtLevel(0)); ASSERT_GT(NumTableFilesAtLevel(1), 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -4174,12 +4176,12 @@ TEST_F(DBCompactionTest, CompactRangeShutdownWhileDelayed) { // The calls to close CF/DB wait until the manual compaction stalls. // The auto-compaction waits until the manual compaction finishes to ensure // the signal comes from closing CF/DB, not from compaction making progress. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait", "DBCompactionTest::CompactRangeShutdownWhileDelayed:PreShutdown"}, {"DBCompactionTest::CompactRangeShutdownWhileDelayed:PostManual", "CompactionJob::Run():End"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int j = 0; j < kNumL0FilesLimit - 1; ++j) { @@ -4212,7 +4214,7 @@ TEST_F(DBCompactionTest, CompactRangeShutdownWhileDelayed) { TEST_SYNC_POINT( "DBCompactionTest::CompactRangeShutdownWhileDelayed:PostManual"); dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -4231,13 +4233,13 @@ TEST_F(DBCompactionTest, CompactRangeSkipFlushAfterDelay) { // The manual flush includes the memtable that was active when CompactRange // began. So it unblocks CompactRange and precludes its flush. Throughout the // test, stall conditions are upheld via high L0 file count. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::WaitUntilFlushWouldNotStallWrites:StallWait", "DBCompactionTest::CompactRangeSkipFlushAfterDelay:PreFlush"}, {"DBCompactionTest::CompactRangeSkipFlushAfterDelay:PostFlush", "DBImpl::FlushMemTable:StallWaitDone"}, {"DBImpl::FlushMemTable:StallWaitDone", "CompactionJob::Run():End"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); //used for the delayable flushes FlushOptions flush_opts; @@ -4267,7 +4269,7 @@ TEST_F(DBCompactionTest, CompactRangeSkipFlushAfterDelay) { db_->GetProperty(DB::Properties::kNumEntriesActiveMemTable, &num_keys_in_memtable); ASSERT_EQ(ToString(1), num_keys_in_memtable); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBCompactionTest, CompactRangeFlushOverlappingMemtable) { @@ -4509,29 +4511,29 @@ TEST_F(DBCompactionTest, CompactionLimiter) { port::Mutex mutex; - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::BackgroundCompaction:BeforeCompaction", [&](void* arg) { - const auto& cf_name = static_cast<ColumnFamilyData*>(arg)->GetName(); - auto iter = cf_to_limiter.find(cf_name); - if (iter != cf_to_limiter.end()) { - MutexLock l(&mutex); - ASSERT_GE(iter->second->limit_tasks, ++iter->second->tasks); - iter->second->max_tasks = std::max(iter->second->max_tasks, - iter->second->limit_tasks); - } - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::BackgroundCompaction:BeforeCompaction", [&](void* arg) { + const auto& cf_name = static_cast<ColumnFamilyData*>(arg)->GetName(); + auto iter = cf_to_limiter.find(cf_name); + if (iter != cf_to_limiter.end()) { + MutexLock l(&mutex); + ASSERT_GE(iter->second->limit_tasks, ++iter->second->tasks); + iter->second->max_tasks = + std::max(iter->second->max_tasks, iter->second->limit_tasks); + } + }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::BackgroundCompaction:AfterCompaction", [&](void* arg) { - const auto& cf_name = static_cast<ColumnFamilyData*>(arg)->GetName(); - auto iter = cf_to_limiter.find(cf_name); - if (iter != cf_to_limiter.end()) { - MutexLock l(&mutex); - ASSERT_GE(--iter->second->tasks, 0); - } - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::BackgroundCompaction:AfterCompaction", [&](void* arg) { + const auto& cf_name = static_cast<ColumnFamilyData*>(arg)->GetName(); + auto iter = cf_to_limiter.find(cf_name); + if (iter != cf_to_limiter.end()) { + MutexLock l(&mutex); + ASSERT_GE(--iter->second->tasks, 0); + } + }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Block all compact threads in thread pool. const size_t kTotalFlushTasks = kMaxBackgroundThreads / 4; @@ -4869,12 +4871,10 @@ TEST_F(DBCompactionTest, CompactionDuringShutdown) { Flush(); } - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:BeforeRun", - [&](void* /*arg*/) { - dbfull()->shutting_down_.store(true); - }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + [&](void* /*arg*/) { dbfull()->shutting_down_.store(true); }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr); ASSERT_OK(dbfull()->error_handler_.GetBGError()); } @@ -4960,7 +4960,7 @@ TEST_F(DBCompactionTest, ConsistencyFailTest) { Options options = CurrentOptions(); DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "VersionBuilder::CheckConsistency", [&](void* arg) { auto p = reinterpret_cast<std::pair<FileMetaData**, FileMetaData**>*>(arg); @@ -4971,7 +4971,7 @@ TEST_F(DBCompactionTest, ConsistencyFailTest) { *(p->second) = temp; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); for (int k = 0; k < 2; ++k) { ASSERT_OK(Put("foo", "bar")); @@ -4979,7 +4979,7 @@ TEST_F(DBCompactionTest, ConsistencyFailTest) { } ASSERT_NOK(Put("foo", "bar")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } void IngestOneKeyValue(DBImpl* db, const std::string& key, @@ -4987,7 +4987,7 @@ void IngestOneKeyValue(DBImpl* db, const std::string& key, ExternalSstFileInfo info; std::string f = test::PerThreadDBPath("sst_file" + key); EnvOptions env; - rocksdb::SstFileWriter writer(env, options); + ROCKSDB_NAMESPACE::SstFileWriter writer(env, options); auto s = writer.Open(f); ASSERT_OK(s); // ASSERT_OK(writer.Put(Key(), "")); @@ -5014,14 +5014,14 @@ TEST_P(DBCompactionTestWithParam, std::atomic<int> pick_intra_l0_count(0); std::string value(RandomString(&rnd, kValueSize)); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBCompactionTestWithParam::FlushAfterIntraL0:1", "CompactionJob::Run():Start"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "FindIntraL0Compaction", [&](void* /*arg*/) { pick_intra_l0_count.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // prevents trivial move for (int i = 0; i < 10; ++i) { @@ -5056,7 +5056,7 @@ TEST_P(DBCompactionTestWithParam, ASSERT_OK(Put(Key(2), "b")); ASSERT_EQ(10, NumTableFilesAtLevel(0)); dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); std::vector<std::vector<FileMetaData>> level_to_files; dbfull()->TEST_GetFilesMetaData(dbfull()->DefaultColumnFamily(), &level_to_files); @@ -5093,13 +5093,13 @@ TEST_P(DBCompactionTestWithParam, ASSERT_EQ(0, NumTableFilesAtLevel(0)); std::atomic<int> pick_intra_l0_count(0); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBCompactionTestWithParam::IntraL0CompactionAfterFlush:1", "CompactionJob::Run():Start"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "FindIntraL0Compaction", [&](void* /*arg*/) { pick_intra_l0_count.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Make 6 L0 sst. for (int i = 0; i < 6; ++i) { if (i % 2 == 0) { @@ -5137,7 +5137,7 @@ TEST_P(DBCompactionTestWithParam, sleeping_tasks.WaitUntilDone(); TEST_SYNC_POINT("DBCompactionTestWithParam::IntraL0CompactionAfterFlush:1"); dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); uint64_t error_count = 0; db_->GetIntProperty("rocksdb.background-errors", &error_count); @@ -5152,11 +5152,11 @@ TEST_P(DBCompactionTestWithParam, } #endif // !defined(ROCKSDB_LITE) -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { #if !defined(ROCKSDB_LITE) - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); #else diff --git a/db/db_dynamic_level_test.cc b/db/db_dynamic_level_test.cc index 8fac82851..c26657701 100644 --- a/db/db_dynamic_level_test.cc +++ b/db/db_dynamic_level_test.cc @@ -16,7 +16,7 @@ #include "port/port.h" #include "port/stack_trace.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBTestDynamicLevel : public DBTestBase { public: DBTestDynamicLevel() : DBTestBase("/db_dynamic_level_test") {} @@ -221,10 +221,10 @@ TEST_F(DBTestDynamicLevel, DynamicLevelMaxBytesBase2) { // Make sure that the compaction starts before the last bit of data is // flushed, so that the base level isn't raised to L1. - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"CompactionJob::Run():Start", "DynamicLevelMaxBytesBase2:0"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(dbfull()->SetOptions({ {"disable_auto_compactions", "false"}, @@ -235,20 +235,20 @@ TEST_F(DBTestDynamicLevel, DynamicLevelMaxBytesBase2) { dbfull()->TEST_WaitForCompact(); ASSERT_TRUE(db_->GetIntProperty("rocksdb.base-level", &int_prop)); ASSERT_EQ(2U, int_prop); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); // Write more data until the base level changes to L1. There will be // a manual compaction going on at the same time. - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"CompactionJob::Run():Start", "DynamicLevelMaxBytesBase2:1"}, {"DynamicLevelMaxBytesBase2:2", "CompactionJob::Run():End"}, {"DynamicLevelMaxBytesBase2:compact_range_finish", "FlushJob::WriteLevel0Table"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread thread([this] { + ROCKSDB_NAMESPACE::port::Thread thread([this] { TEST_SYNC_POINT("DynamicLevelMaxBytesBase2:compact_range_start"); ASSERT_OK(db_->CompactRange(CompactRangeOptions(), nullptr, nullptr)); TEST_SYNC_POINT("DynamicLevelMaxBytesBase2:compact_range_finish"); @@ -265,8 +265,8 @@ TEST_F(DBTestDynamicLevel, DynamicLevelMaxBytesBase2) { thread.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); ASSERT_TRUE(db_->GetIntProperty("rocksdb.base-level", &int_prop)); ASSERT_EQ(1U, int_prop); @@ -329,16 +329,16 @@ TEST_F(DBTestDynamicLevel, DynamicLevelMaxBytesCompactRange) { ASSERT_TRUE(db_->GetProperty("rocksdb.num-files-at-level2", &str_prop)); ASSERT_EQ("0", str_prop); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); std::set<int> output_levels; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionPicker::CompactRange:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); output_levels.insert(compaction->output_level()); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr); ASSERT_EQ(output_levels.size(), 2); @@ -373,10 +373,10 @@ TEST_F(DBTestDynamicLevel, DynamicLevelMaxBytesBaseInc) { DestroyAndReopen(options); int non_trivial = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* /*arg*/) { non_trivial++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); const int total_keys = 3000; @@ -388,7 +388,7 @@ TEST_F(DBTestDynamicLevel, DynamicLevelMaxBytesBaseInc) { } Flush(); dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(non_trivial, 0); @@ -457,7 +457,7 @@ TEST_F(DBTestDynamicLevel, DISABLED_MigrateToDynamicLevelMaxBytesBase) { compaction_finished = false; // Issue manual compaction in one thread and still verify DB state // in main thread. - rocksdb::port::Thread t([&]() { + ROCKSDB_NAMESPACE::port::Thread t([&]() { CompactRangeOptions compact_options; compact_options.change_level = true; compact_options.target_level = options.num_levels - 1; @@ -488,13 +488,13 @@ TEST_F(DBTestDynamicLevel, DISABLED_MigrateToDynamicLevelMaxBytesBase) { ASSERT_EQ(NumTableFilesAtLevel(1), 0); ASSERT_EQ(NumTableFilesAtLevel(2), 0); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !defined(ROCKSDB_LITE) int main(int argc, char** argv) { #if !defined(ROCKSDB_LITE) - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); #else diff --git a/db/db_encryption_test.cc b/db/db_encryption_test.cc index bc7274465..b1f3ce23f 100644 --- a/db/db_encryption_test.cc +++ b/db/db_encryption_test.cc @@ -12,7 +12,7 @@ #include <iostream> #include <string> -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBEncryptionTest : public DBTestBase { public: @@ -113,10 +113,10 @@ TEST_F(DBEncryptionTest, ReadEmptyFile) { #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_filesnapshot.cc b/db/db_filesnapshot.cc index 8717b3559..f0f22cb47 100644 --- a/db/db_filesnapshot.cc +++ b/db/db_filesnapshot.cc @@ -21,7 +21,7 @@ #include "test_util/sync_point.h" #include "util/mutexlock.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { Status DBImpl::DisableFileDeletions() { InstrumentedMutexLock l(&mutex_); @@ -172,6 +172,6 @@ Status DBImpl::GetCurrentWalFile(std::unique_ptr<LogFile>* current_log_file) { return wal_manager_.GetLiveWalFile(current_logfile_number, current_log_file); } -} +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/db_flush_test.cc b/db/db_flush_test.cc index 5a24226ea..bab206d3d 100644 --- a/db/db_flush_test.cc +++ b/db/db_flush_test.cc @@ -18,7 +18,7 @@ #include "util/cast_util.h" #include "util/mutexlock.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBFlushTest : public DBTestBase { public: @@ -775,10 +775,10 @@ INSTANTIATE_TEST_CASE_P(DBFlushDirectIOTest, DBFlushDirectIOTest, INSTANTIATE_TEST_CASE_P(DBAtomicFlushTest, DBAtomicFlushTest, testing::Bool()); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_impl/db_impl.cc b/db/db_impl/db_impl.cc index 404fd215d..c6fa3c16e 100644 --- a/db/db_impl/db_impl.cc +++ b/db/db_impl/db_impl.cc @@ -102,7 +102,7 @@ #include "util/stop_watch.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { const std::string kDefaultColumnFamilyName("default"); const std::string kPersistentStatsColumnFamilyName( @@ -644,7 +644,7 @@ void DBImpl::StartTimedTasks() { stats_dump_period_sec = mutable_db_options_.stats_dump_period_sec; if (stats_dump_period_sec > 0) { if (!thread_dump_stats_) { - thread_dump_stats_.reset(new rocksdb::RepeatableThread( + thread_dump_stats_.reset(new ROCKSDB_NAMESPACE::RepeatableThread( [this]() { DBImpl::DumpStats(); }, "dump_st", env_, static_cast<uint64_t>(stats_dump_period_sec) * kMicrosInSecond)); } @@ -652,7 +652,7 @@ void DBImpl::StartTimedTasks() { stats_persist_period_sec = mutable_db_options_.stats_persist_period_sec; if (stats_persist_period_sec > 0) { if (!thread_persist_stats_) { - thread_persist_stats_.reset(new rocksdb::RepeatableThread( + thread_persist_stats_.reset(new ROCKSDB_NAMESPACE::RepeatableThread( [this]() { DBImpl::PersistStats(); }, "pst_st", env_, static_cast<uint64_t>(stats_persist_period_sec) * kMicrosInSecond)); } @@ -1043,7 +1043,7 @@ Status DBImpl::SetDBOptions( mutex_.Lock(); } if (new_options.stats_dump_period_sec > 0) { - thread_dump_stats_.reset(new rocksdb::RepeatableThread( + thread_dump_stats_.reset(new ROCKSDB_NAMESPACE::RepeatableThread( [this]() { DBImpl::DumpStats(); }, "dump_st", env_, static_cast<uint64_t>(new_options.stats_dump_period_sec) * kMicrosInSecond)); @@ -1059,7 +1059,7 @@ Status DBImpl::SetDBOptions( mutex_.Lock(); } if (new_options.stats_persist_period_sec > 0) { - thread_persist_stats_.reset(new rocksdb::RepeatableThread( + thread_persist_stats_.reset(new ROCKSDB_NAMESPACE::RepeatableThread( [this]() { DBImpl::PersistStats(); }, "pst_st", env_, static_cast<uint64_t>(new_options.stats_persist_period_sec) * kMicrosInSecond)); @@ -4376,8 +4376,8 @@ Status DBImpl::VerifyChecksum(const ReadOptions& read_options) { const auto& fd = vstorage->LevelFilesBrief(i).files[j].fd; std::string fname = TableFileName(cfd->ioptions()->cf_paths, fd.GetNumber(), fd.GetPathId()); - s = rocksdb::VerifySstFileChecksum(opts, file_options_, read_options, - fname); + s = ROCKSDB_NAMESPACE::VerifySstFileChecksum(opts, file_options_, + read_options, fname); } } if (!s.ok()) { @@ -4539,4 +4539,4 @@ Status DBImpl::GetCreationTimeOfOldestFile(uint64_t* creation_time) { } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl.h b/db/db_impl/db_impl.h index 7041f7e65..119555cb4 100644 --- a/db/db_impl/db_impl.h +++ b/db/db_impl/db_impl.h @@ -62,7 +62,7 @@ #include "util/stop_watch.h" #include "util/thread_local.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Arena; class ArenaWrappedDBIter; @@ -2015,11 +2015,11 @@ class DBImpl : public DB { // handle for scheduling stats dumping at fixed intervals // REQUIRES: mutex locked - std::unique_ptr<rocksdb::RepeatableThread> thread_dump_stats_; + std::unique_ptr<ROCKSDB_NAMESPACE::RepeatableThread> thread_dump_stats_; // handle for scheduling stats snapshoting at fixed intervals // REQUIRES: mutex locked - std::unique_ptr<rocksdb::RepeatableThread> thread_persist_stats_; + std::unique_ptr<ROCKSDB_NAMESPACE::RepeatableThread> thread_persist_stats_; // When set, we use a separate queue for writes that dont write to memtable. // In 2PC these are the writes at Prepare phase. @@ -2104,4 +2104,4 @@ static void ClipToRange(T* ptr, V minvalue, V maxvalue) { if (static_cast<V>(*ptr) < minvalue) *ptr = minvalue; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_compaction_flush.cc b/db/db_impl/db_impl_compaction_flush.cc index 38172981c..c7b3510c3 100644 --- a/db/db_impl/db_impl_compaction_flush.cc +++ b/db/db_impl/db_impl_compaction_flush.cc @@ -22,7 +22,7 @@ #include "util/cast_util.h" #include "util/concurrent_task_limiter_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { bool DBImpl::EnoughRoomForCompaction( ColumnFamilyData* cfd, const std::vector<CompactionInputFiles>& inputs, @@ -3113,4 +3113,4 @@ void DBImpl::GetSnapshotContext( } *snapshot_seqs = snapshots_.GetAll(earliest_write_conflict_snapshot); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_debug.cc b/db/db_impl/db_impl_debug.cc index c3a4c3525..610b57d39 100644 --- a/db/db_impl/db_impl_debug.cc +++ b/db/db_impl/db_impl_debug.cc @@ -15,7 +15,7 @@ #include "monitoring/thread_status_updater.h" #include "util/cast_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { uint64_t DBImpl::TEST_GetLevel0TotalSize() { InstrumentedMutexLock l(&mutex_); return default_cf_handle_->cfd()->current()->storage_info()->NumLevelBytes(0); @@ -290,5 +290,5 @@ bool DBImpl::TEST_IsPersistentStatsEnabled() const { size_t DBImpl::TEST_EstimateInMemoryStatsHistorySize() const { return EstimateInMemoryStatsHistorySize(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // NDEBUG diff --git a/db/db_impl/db_impl_experimental.cc b/db/db_impl/db_impl_experimental.cc index 97585c12d..f0c17ce95 100644 --- a/db/db_impl/db_impl_experimental.cc +++ b/db/db_impl/db_impl_experimental.cc @@ -17,7 +17,7 @@ #include "db/version_set.h" #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE Status DBImpl::SuggestCompactRange(ColumnFamilyHandle* column_family, @@ -148,4 +148,4 @@ Status DBImpl::PromoteL0(ColumnFamilyHandle* column_family, int target_level) { } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_files.cc b/db/db_impl/db_impl_files.cc index b52500fc6..c5d07dd01 100644 --- a/db/db_impl/db_impl_files.cc +++ b/db/db_impl/db_impl_files.cc @@ -17,7 +17,7 @@ #include "file/sst_file_manager_impl.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { uint64_t DBImpl::MinLogNumberToKeep() { if (allow_2pc()) { @@ -664,4 +664,4 @@ uint64_t PrecomputeMinLogNumberToKeep( return min_log_number_to_keep; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_open.cc b/db/db_impl/db_impl_open.cc index de703138f..6ae4ead54 100644 --- a/db/db_impl/db_impl_open.cc +++ b/db/db_impl/db_impl_open.cc @@ -23,7 +23,7 @@ #include "test_util/sync_point.h" #include "util/rate_limiter.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { Options SanitizeOptions(const std::string& dbname, const Options& src) { auto db_options = SanitizeOptions(dbname, DBOptions(src)); ImmutableDBOptions immutable_db_options(db_options); @@ -1648,4 +1648,4 @@ Status DBImpl::Open(const DBOptions& db_options, const std::string& dbname, } return s; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_readonly.cc b/db/db_impl/db_impl_readonly.cc index 8a8a9c9d0..a4242bfe1 100644 --- a/db/db_impl/db_impl_readonly.cc +++ b/db/db_impl/db_impl_readonly.cc @@ -12,7 +12,7 @@ #include "db/merge_context.h" #include "monitoring/perf_context_imp.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE @@ -218,4 +218,4 @@ Status DB::OpenForReadOnly( } #endif // !ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_readonly.h b/db/db_impl/db_impl_readonly.h index 9f7ad17a4..04d06b4a1 100644 --- a/db/db_impl/db_impl_readonly.h +++ b/db/db_impl/db_impl_readonly.h @@ -11,7 +11,7 @@ #include <vector> #include "db/db_impl/db_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBImplReadOnly : public DBImpl { public: @@ -132,6 +132,6 @@ class DBImplReadOnly : public DBImpl { private: friend class DB; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/db_impl/db_impl_secondary.cc b/db/db_impl/db_impl_secondary.cc index 937b6e90e..f0ec27c32 100644 --- a/db/db_impl/db_impl_secondary.cc +++ b/db/db_impl/db_impl_secondary.cc @@ -13,7 +13,7 @@ #include "monitoring/perf_context_imp.h" #include "util/cast_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE DBImplSecondary::DBImplSecondary(const DBOptions& db_options, @@ -668,4 +668,4 @@ Status DB::OpenAsSecondary( } #endif // !ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_impl_secondary.h b/db/db_impl/db_impl_secondary.h index cde664c58..24f2e7767 100644 --- a/db/db_impl/db_impl_secondary.h +++ b/db/db_impl/db_impl_secondary.h @@ -11,7 +11,7 @@ #include <vector> #include "db/db_impl/db_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // A wrapper class to hold log reader, log reporter, log status. class LogReaderContainer { @@ -328,6 +328,6 @@ class DBImplSecondary : public DBImpl { std::unordered_map<ColumnFamilyData*, uint64_t> cfd_to_current_log_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/db_impl/db_impl_write.cc b/db/db_impl/db_impl_write.cc index 08468935d..8f6f685e4 100644 --- a/db/db_impl/db_impl_write.cc +++ b/db/db_impl/db_impl_write.cc @@ -15,7 +15,7 @@ #include "options/options_helper.h" #include "test_util/sync_point.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Convenience methods Status DBImpl::Put(const WriteOptions& o, ColumnFamilyHandle* column_family, const Slice& key, const Slice& val) { @@ -1836,4 +1836,4 @@ Status DB::Merge(const WriteOptions& opt, ColumnFamilyHandle* column_family, } return Write(opt, &batch); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_impl/db_secondary_test.cc b/db/db_impl/db_secondary_test.cc index c04f6e66f..0b34181de 100644 --- a/db/db_impl/db_secondary_test.cc +++ b/db/db_impl/db_secondary_test.cc @@ -13,7 +13,7 @@ #include "test_util/fault_injection_test_env.h" #include "test_util/sync_point.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE class DBSecondaryTest : public DBTestBase { @@ -860,10 +860,10 @@ TEST_F(DBSecondaryTest, CheckConsistencyWhenOpen) { } #endif //! ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_info_dumper.cc b/db/db_info_dumper.cc index 7ab7e3337..7008ca6ff 100644 --- a/db/db_info_dumper.cc +++ b/db/db_info_dumper.cc @@ -14,7 +14,7 @@ #include "file/filename.h" #include "rocksdb/env.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { void DumpDBFileSummary(const ImmutableDBOptions& options, const std::string& dbname) { @@ -120,4 +120,4 @@ void DumpDBFileSummary(const ImmutableDBOptions& options, Header(options.info_log, "Write Ahead Log file in %s: %s\n", options.wal_dir.c_str(), wal_info.c_str()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_info_dumper.h b/db/db_info_dumper.h index acff8f1b8..91404cbd7 100644 --- a/db/db_info_dumper.h +++ b/db/db_info_dumper.h @@ -8,7 +8,7 @@ #include "options/db_options.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { void DumpDBFileSummary(const ImmutableDBOptions& options, const std::string& dbname); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_inplace_update_test.cc b/db/db_inplace_update_test.cc index c1f1b51e3..26405864e 100644 --- a/db/db_inplace_update_test.cc +++ b/db/db_inplace_update_test.cc @@ -9,7 +9,7 @@ #include "db/db_test_util.h" #include "port/stack_trace.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBTestInPlaceUpdate : public DBTestBase { public: @@ -73,7 +73,7 @@ TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackSmallerSize) { options.env = env_; options.write_buffer_size = 100000; options.inplace_callback = - rocksdb::DBTestInPlaceUpdate::updateInPlaceSmallerSize; + ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceSmallerSize; options.allow_concurrent_memtable_write = false; Reopen(options); CreateAndReopenWithCF({"pikachu"}, options); @@ -102,7 +102,7 @@ TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackSmallerVarintSize) { options.env = env_; options.write_buffer_size = 100000; options.inplace_callback = - rocksdb::DBTestInPlaceUpdate::updateInPlaceSmallerVarintSize; + ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceSmallerVarintSize; options.allow_concurrent_memtable_write = false; Reopen(options); CreateAndReopenWithCF({"pikachu"}, options); @@ -131,7 +131,7 @@ TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackLargeNewValue) { options.env = env_; options.write_buffer_size = 100000; options.inplace_callback = - rocksdb::DBTestInPlaceUpdate::updateInPlaceLargerSize; + ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceLargerSize; options.allow_concurrent_memtable_write = false; Reopen(options); CreateAndReopenWithCF({"pikachu"}, options); @@ -158,7 +158,7 @@ TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackNoAction) { options.env = env_; options.write_buffer_size = 100000; options.inplace_callback = - rocksdb::DBTestInPlaceUpdate::updateInPlaceNoAction; + ROCKSDB_NAMESPACE::DBTestInPlaceUpdate::updateInPlaceNoAction; options.allow_concurrent_memtable_write = false; Reopen(options); CreateAndReopenWithCF({"pikachu"}, options); @@ -168,10 +168,10 @@ TEST_F(DBTestInPlaceUpdate, InPlaceUpdateCallbackNoAction) { ASSERT_EQ(Get(1, "key"), "NOT_FOUND"); } while (ChangeCompactOptions()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_io_failure_test.cc b/db/db_io_failure_test.cc index ba8f19759..f8d562447 100644 --- a/db/db_io_failure_test.cc +++ b/db/db_io_failure_test.cc @@ -10,7 +10,7 @@ #include "db/db_test_util.h" #include "port/stack_trace.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBIOFailureTest : public DBTestBase { public: @@ -270,14 +270,14 @@ TEST_F(DBIOFailureTest, FlushSstRangeSyncError) { Status s; std::atomic<int> range_sync_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SpecialEnv::SStableFile::RangeSync", [&](void* arg) { if (range_sync_called.fetch_add(1) == 0) { Status* st = static_cast<Status*>(arg); *st = Status::IOError("range sync dummy error"); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); std::string rnd_str = @@ -302,7 +302,7 @@ TEST_F(DBIOFailureTest, FlushSstRangeSyncError) { ASSERT_NOK(Put(1, "foo2", "bar3")); ASSERT_EQ("bar", Get(1, "foo")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_GE(1, range_sync_called.load()); ReopenWithColumnFamilies({"default", "pikachu"}, options); @@ -350,14 +350,14 @@ TEST_F(DBIOFailureTest, CompactSstRangeSyncError) { dbfull()->TEST_WaitForFlushMemTable(handles_[1]); std::atomic<int> range_sync_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SpecialEnv::SStableFile::RangeSync", [&](void* arg) { if (range_sync_called.fetch_add(1) == 0) { Status* st = static_cast<Status*>(arg); *st = Status::IOError("range sync dummy error"); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(dbfull()->SetOptions(handles_[1], { @@ -369,7 +369,7 @@ TEST_F(DBIOFailureTest, CompactSstRangeSyncError) { ASSERT_NOK(Put(1, "foo2", "bar3")); ASSERT_EQ("bar", Get(1, "foo")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_GE(1, range_sync_called.load()); ReopenWithColumnFamilies({"default", "pikachu"}, options); @@ -389,7 +389,7 @@ TEST_F(DBIOFailureTest, FlushSstCloseError) { CreateAndReopenWithCF({"pikachu"}, options); Status s; std::atomic<int> close_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SpecialEnv::SStableFile::Close", [&](void* arg) { if (close_called.fetch_add(1) == 0) { Status* st = static_cast<Status*>(arg); @@ -397,7 +397,7 @@ TEST_F(DBIOFailureTest, FlushSstCloseError) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(Put(1, "foo", "bar")); ASSERT_OK(Put(1, "foo1", "bar1")); @@ -409,7 +409,7 @@ TEST_F(DBIOFailureTest, FlushSstCloseError) { ASSERT_EQ("bar2", Get(1, "foo")); ASSERT_EQ("bar1", Get(1, "foo1")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ReopenWithColumnFamilies({"default", "pikachu"}, options); ASSERT_EQ("bar2", Get(1, "foo")); @@ -441,7 +441,7 @@ TEST_F(DBIOFailureTest, CompactionSstCloseError) { dbfull()->TEST_WaitForCompact(); std::atomic<int> close_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SpecialEnv::SStableFile::Close", [&](void* arg) { if (close_called.fetch_add(1) == 0) { Status* st = static_cast<Status*>(arg); @@ -449,7 +449,7 @@ TEST_F(DBIOFailureTest, CompactionSstCloseError) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(dbfull()->SetOptions(handles_[1], { {"disable_auto_compactions", "false"}, @@ -460,7 +460,7 @@ TEST_F(DBIOFailureTest, CompactionSstCloseError) { ASSERT_NOK(Put(1, "foo2", "bar3")); ASSERT_EQ("bar3", Get(1, "foo")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ReopenWithColumnFamilies({"default", "pikachu"}, options); ASSERT_EQ("bar3", Get(1, "foo")); @@ -480,7 +480,7 @@ TEST_F(DBIOFailureTest, FlushSstSyncError) { CreateAndReopenWithCF({"pikachu"}, options); Status s; std::atomic<int> sync_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SpecialEnv::SStableFile::Sync", [&](void* arg) { if (sync_called.fetch_add(1) == 0) { Status* st = static_cast<Status*>(arg); @@ -488,7 +488,7 @@ TEST_F(DBIOFailureTest, FlushSstSyncError) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(Put(1, "foo", "bar")); ASSERT_OK(Put(1, "foo1", "bar1")); @@ -500,7 +500,7 @@ TEST_F(DBIOFailureTest, FlushSstSyncError) { ASSERT_EQ("bar2", Get(1, "foo")); ASSERT_EQ("bar1", Get(1, "foo1")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ReopenWithColumnFamilies({"default", "pikachu"}, options); ASSERT_EQ("bar2", Get(1, "foo")); @@ -533,7 +533,7 @@ TEST_F(DBIOFailureTest, CompactionSstSyncError) { dbfull()->TEST_WaitForCompact(); std::atomic<int> sync_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SpecialEnv::SStableFile::Sync", [&](void* arg) { if (sync_called.fetch_add(1) == 0) { Status* st = static_cast<Status*>(arg); @@ -541,7 +541,7 @@ TEST_F(DBIOFailureTest, CompactionSstSyncError) { } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(dbfull()->SetOptions(handles_[1], { {"disable_auto_compactions", "false"}, @@ -552,17 +552,17 @@ TEST_F(DBIOFailureTest, CompactionSstSyncError) { ASSERT_NOK(Put(1, "foo2", "bar3")); ASSERT_EQ("bar3", Get(1, "foo")); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ReopenWithColumnFamilies({"default", "pikachu"}, options); ASSERT_EQ("bar3", Get(1, "foo")); } #endif // !(defined NDEBUG) || !defined(OS_WIN) #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_iter.cc b/db/db_iter.cc index 0e181d9bf..4d850abee 100644 --- a/db/db_iter.cc +++ b/db/db_iter.cc @@ -31,7 +31,7 @@ #include "util/string_util.h" #include "util/user_comparator_wrapper.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #if 0 static void DumpInternalIter(Iterator* iter) { @@ -325,7 +325,7 @@ bool DBIter::FindNextUserEntryInternal(bool skipping_saved_key, ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index."); status_ = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); valid_ = false; return false; } @@ -497,7 +497,7 @@ bool DBIter::MergeValuesNewToOld() { ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index."); status_ = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); } else { status_ = Status::NotSupported("Blob DB does not support merge operator."); @@ -798,7 +798,7 @@ bool DBIter::FindValueForCurrentKey() { ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index."); status_ = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); } else { status_ = Status::NotSupported("Blob DB does not support merge operator."); @@ -821,7 +821,7 @@ bool DBIter::FindValueForCurrentKey() { ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index."); status_ = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); valid_ = false; return false; } @@ -892,7 +892,7 @@ bool DBIter::FindValueForCurrentKeyUsingSeek() { ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index."); status_ = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); valid_ = false; return false; } @@ -954,7 +954,7 @@ bool DBIter::FindValueForCurrentKeyUsingSeek() { ROCKS_LOG_ERROR(logger_, "Encounter unexpected blob index."); status_ = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); } else { status_ = Status::NotSupported("Blob DB does not support merge operator."); @@ -1324,4 +1324,4 @@ Iterator* NewDBIterator(Env* env, const ReadOptions& read_options, return db_iter; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_iter.h b/db/db_iter.h index 39e52fe94..74430f0d3 100644 --- a/db/db_iter.h +++ b/db/db_iter.h @@ -20,7 +20,7 @@ #include "table/iterator_wrapper.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // This file declares the factory functions of DBIter, in its original form // or a wrapped form with class ArenaWrappedDBIter, which is defined here. @@ -342,4 +342,4 @@ extern Iterator* NewDBIterator( ReadCallback* read_callback, DBImpl* db_impl = nullptr, ColumnFamilyData* cfd = nullptr, bool allow_blob = false); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_iter_stress_test.cc b/db/db_iter_stress_test.cc index b864ac4ea..57cd9866e 100644 --- a/db/db_iter_stress_test.cc +++ b/db/db_iter_stress_test.cc @@ -29,7 +29,7 @@ bool FLAGS_verbose = false; #endif -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBIteratorStressTest : public testing::Test { public: @@ -645,7 +645,7 @@ TEST_F(DBIteratorStressTest, StressTest) { << "\n mutated on the fly: " << num_recently_removed << std::endl; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_iter_test.cc b/db/db_iter_test.cc index 150388644..ddbea8d17 100644 --- a/db/db_iter_test.cc +++ b/db/db_iter_test.cc @@ -22,7 +22,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static uint64_t TestGetTickerCount(const Options& options, Tickers ticker_type) { @@ -691,7 +691,7 @@ TEST_F(DBIteratorTest, DBIteratorEmpty) { TEST_F(DBIteratorTest, DBIteratorUseSkipCountSkips) { ReadOptions ro; Options options; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.merge_operator = MergeOperators::CreateFromStringId("stringappend"); TestIterator* internal_iter = new TestIterator(BytewiseComparator()); @@ -746,7 +746,7 @@ TEST_F(DBIteratorTest, DBIteratorUseSkip) { } internal_iter->Finish(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); std::unique_ptr<Iterator> db_iter(NewDBIterator( env_, ro, cf_options, mutable_cf_options, BytewiseComparator(), internal_iter, i + 2, options.max_sequential_skip_in_iterations, @@ -2481,7 +2481,7 @@ TEST_F(DBIteratorTest, DBIteratorTestDifferentialSnapshots) { ReadOptions ro; ro.iter_start_seqnum=5; Options options; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); TestIterator* internal_iter = new TestIterator(BytewiseComparator()); for (size_t i = 0; i < 10; ++i) { @@ -2516,7 +2516,7 @@ TEST_F(DBIteratorTest, DBIteratorTestDifferentialSnapshots) { ReadOptions ro; ro.iter_start_seqnum=5; Options options; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); TestIterator* internal_iter = new TestIterator(BytewiseComparator()); for (size_t i = 0; i < 10; ++i) { @@ -2661,10 +2661,10 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace1) { // Test call back inserts a key in the end of the mem table after // MergeIterator::Prev() realized the mem table iterator is at its end // and before an SeekToLast() is called. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* /*arg*/) { internal_iter2_->Add("z", kTypeValue, "7", 12u); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2683,7 +2683,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace1) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace2) { @@ -2697,12 +2697,12 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace2) { // Test call back inserts entries for update a key in the end of the // mem table after MergeIterator::Prev() realized the mem tableiterator is at // its end and before an SeekToLast() is called. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* /*arg*/) { internal_iter2_->Add("z", kTypeValue, "7", 12u); internal_iter2_->Add("z", kTypeValue, "7", 11u); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2721,7 +2721,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace2) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace3) { @@ -2735,7 +2735,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace3) { // Test call back inserts entries for update a key in the end of the // mem table after MergeIterator::Prev() realized the mem table iterator is at // its end and before an SeekToLast() is called. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* /*arg*/) { internal_iter2_->Add("z", kTypeValue, "7", 16u, true); internal_iter2_->Add("z", kTypeValue, "7", 15u, true); @@ -2744,7 +2744,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace3) { internal_iter2_->Add("z", kTypeValue, "7", 12u, true); internal_iter2_->Add("z", kTypeValue, "7", 11u, true); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2763,7 +2763,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace3) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace4) { @@ -2779,7 +2779,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace4) { // Test call back inserts entries for update a key before "z" in // mem table after MergeIterator::Prev() calls mem table iterator's // Seek() and before calling Prev() - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* arg) { IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg); if (it->key().starts_with("z")) { @@ -2791,7 +2791,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace4) { internal_iter2_->Add("x", kTypeValue, "7", 11u, true); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2814,7 +2814,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace4) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace5) { @@ -2830,7 +2830,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace5) { // Test call back inserts entries for update a key before "z" in // mem table after MergeIterator::Prev() calls mem table iterator's // Seek() and before calling Prev() - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* arg) { IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg); if (it->key().starts_with("z")) { @@ -2838,7 +2838,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace5) { internal_iter2_->Add("x", kTypeValue, "7", 15u, true); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2861,7 +2861,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace5) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace6) { @@ -2877,14 +2877,14 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace6) { // Test call back inserts an entry for update a key before "z" in // mem table after MergeIterator::Prev() calls mem table iterator's // Seek() and before calling Prev() - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* arg) { IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg); if (it->key().starts_with("z")) { internal_iter2_->Add("x", kTypeValue, "7", 16u, true); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2907,7 +2907,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace6) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace7) { @@ -2926,7 +2926,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace7) { // Test call back inserts entries for update a key before "z" in // mem table after MergeIterator::Prev() calls mem table iterator's // Seek() and before calling Prev() - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* arg) { IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg); if (it->key().starts_with("z")) { @@ -2938,7 +2938,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace7) { internal_iter2_->Add("x", kTypeValue, "7", 11u, true); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2961,7 +2961,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace7) { ASSERT_EQ(db_iter_->key().ToString(), "a"); ASSERT_EQ(db_iter_->value().ToString(), "4"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace8) { @@ -2979,7 +2979,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace8) { // Test call back inserts two keys before "z" in mem table after // MergeIterator::Prev() calls mem table iterator's Seek() and // before calling Prev() - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "MergeIterator::Prev:BeforePrev", [&](void* arg) { IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg); if (it->key().starts_with("z")) { @@ -2987,7 +2987,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace8) { internal_iter2_->Add("y", kTypeValue, "7", 17u, true); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); db_iter_->Prev(); ASSERT_TRUE(db_iter_->Valid()); @@ -2998,7 +2998,7 @@ TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace8) { ASSERT_EQ(db_iter_->key().ToString(), "d"); ASSERT_EQ(db_iter_->value().ToString(), "7"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } @@ -3167,7 +3167,7 @@ TEST_F(DBIteratorTest, ReverseToForwardWithDisappearingKeys) { EXPECT_LT(internal_iter->steps(), 20); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/db_iterator_test.cc b/db/db_iterator_test.cc index debb48eda..99ffb5ce4 100644 --- a/db/db_iterator_test.cc +++ b/db/db_iterator_test.cc @@ -18,7 +18,7 @@ #include "rocksdb/perf_context.h" #include "table/block_based/flush_block_policy.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // A dumb ReadCallback which saying every key is committed. class DummyReadCallback : public ReadCallback { @@ -109,7 +109,7 @@ TEST_P(DBIteratorTest, NonBlockingIteration) { do { ReadOptions non_blocking_opts, regular_opts; Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); non_blocking_opts.read_tier = kBlockCacheTier; CreateAndReopenWithCF({"pikachu"}, options); // write one kv to the database. @@ -535,7 +535,7 @@ TEST_P(DBIteratorTest, IterReseek) { Options options = CurrentOptions(options_override); options.max_sequential_skip_in_iterations = 3; options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); CreateAndReopenWithCF({"pikachu"}, options); @@ -1026,7 +1026,7 @@ TEST_P(DBIteratorTest, DBIteratorBoundMultiSeek) { Options options = CurrentOptions(); options.env = env_; options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.prefix_extractor = nullptr; DestroyAndReopen(options); ASSERT_OK(Put("a", "0")); @@ -1081,10 +1081,10 @@ TEST_P(DBIteratorTest, DBIteratorBoundOptimizationTest) { for (auto format_version : {2, 3, 4}) { int upper_bound_hits = 0; Options options = CurrentOptions(); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "BlockBasedTableIterator:out_of_bound", [&upper_bound_hits](void*) { upper_bound_hits++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); options.env = env_; options.create_if_missing = true; options.prefix_extractor = nullptr; @@ -1132,7 +1132,7 @@ TEST_P(DBIteratorTest, IndexWithFirstKey) { options.create_if_missing = true; options.prefix_extractor = nullptr; options.merge_operator = MergeOperators::CreateStringAppendOperator(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); Statistics* stats = options.statistics.get(); BlockBasedTableOptions table_options; table_options.index_type = @@ -1223,7 +1223,7 @@ TEST_P(DBIteratorTest, IndexWithFirstKeyGet) { options.create_if_missing = true; options.prefix_extractor = nullptr; options.merge_operator = MergeOperators::CreateStringAppendOperator(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); Statistics* stats = options.statistics.get(); BlockBasedTableOptions table_options; table_options.index_type = @@ -2012,7 +2012,7 @@ TEST_P(DBIteratorTest, IterPrevKeyCrossingBlocksRandomized) { TEST_P(DBIteratorTest, IteratorWithLocalStatistics) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); Random rnd(301); @@ -2110,7 +2110,7 @@ TEST_P(DBIteratorTest, ReadAhead) { options.env = env_; options.disable_auto_compactions = true; options.write_buffer_size = 4 << 20; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.block_size = 1024; table_options.no_block_cache = true; @@ -2188,7 +2188,7 @@ TEST_P(DBIteratorTest, DBIteratorSkipRecentDuplicatesTest) { options.max_sequential_skip_in_iterations = 3; options.prefix_extractor = nullptr; options.write_buffer_size = 1 << 27; // big enough to avoid flush - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); // Insert. @@ -2480,7 +2480,7 @@ TEST_P(DBIteratorTest, UpperBoundWithPrevReseek) { TEST_P(DBIteratorTest, SkipStatistics) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); int skip_count = 0; @@ -2989,10 +2989,10 @@ TEST_F(DBIteratorWithReadCallbackTest, ReadCallback) { delete iter; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_log_iter_test.cc b/db/db_log_iter_test.cc index 45642bc7a..1f9ff0d45 100644 --- a/db/db_log_iter_test.cc +++ b/db/db_log_iter_test.cc @@ -15,7 +15,7 @@ #include "db/db_test_util.h" #include "port/stack_trace.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBTestXactLogIterator : public DBTestBase { public: @@ -98,14 +98,14 @@ TEST_F(DBTestXactLogIterator, TransactionLogIteratorRace) { for (int test = 0; test < LOG_ITERATOR_RACE_TEST_COUNT; ++test) { // Setup sync point dependency to reproduce the race condition of // a log file moved to archived dir, in the middle of GetSortedWalFiles - rocksdb::SyncPoint::GetInstance()->LoadDependency( - { { sync_points[test][0], sync_points[test][1] }, - { sync_points[test][2], sync_points[test][3] }, - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ + {sync_points[test][0], sync_points[test][1]}, + {sync_points[test][2], sync_points[test][3]}, + }); do { - rocksdb::SyncPoint::GetInstance()->ClearTrace(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Options options = OptionsForLogIterTest(); DestroyAndReopen(options); Put("key1", DummyString(1024)); @@ -123,7 +123,7 @@ TEST_F(DBTestXactLogIterator, TransactionLogIteratorRace) { ExpectRecords(4, iter); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // trigger async flush, and log move. Well, log move will // wait until the GetSortedWalFiles:1 to reproduce the race // condition @@ -185,7 +185,7 @@ TEST_F(DBTestXactLogIterator, TransactionLogIteratorCorruptedLog) { dbfull()->Flush(FlushOptions()); dbfull()->FlushWAL(false); // Corrupt this log to create a gap - rocksdb::VectorLogPtr wal_files; + ROCKSDB_NAMESPACE::VectorLogPtr wal_files; ASSERT_OK(dbfull()->GetSortedWalFiles(wal_files)); const auto logfile_path = dbname_ + "/" + wal_files.front()->PathName(); if (mem_env_) { @@ -277,13 +277,13 @@ TEST_F(DBTestXactLogIterator, TransactionLogIteratorBlobs) { "Delete(0, key2)", handler.seen); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !defined(ROCKSDB_LITE) int main(int argc, char** argv) { #if !defined(ROCKSDB_LITE) - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); #else diff --git a/db/db_memtable_test.cc b/db/db_memtable_test.cc index d9ad649e7..a2f4e327c 100644 --- a/db/db_memtable_test.cc +++ b/db/db_memtable_test.cc @@ -13,7 +13,7 @@ #include "rocksdb/memtablerep.h" #include "rocksdb/slice_transform.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBMemTableTest : public DBTestBase { public: @@ -232,8 +232,8 @@ TEST_F(DBMemTableTest, ConcurrentMergeWrite) { value.clear(); // Write Merge concurrently - rocksdb::port::Thread write_thread1([&]() { - MemTablePostProcessInfo post_process_info1; + ROCKSDB_NAMESPACE::port::Thread write_thread1([&]() { + MemTablePostProcessInfo post_process_info1; std::string v1; for (int seq = 1; seq < num_ops / 2; seq++) { PutFixed64(&v1, seq); @@ -243,8 +243,8 @@ TEST_F(DBMemTableTest, ConcurrentMergeWrite) { v1.clear(); } }); - rocksdb::port::Thread write_thread2([&]() { - MemTablePostProcessInfo post_process_info2; + ROCKSDB_NAMESPACE::port::Thread write_thread2([&]() { + MemTablePostProcessInfo post_process_info2; std::string v2; for (int seq = num_ops / 2; seq < num_ops; seq++) { PutFixed64(&v2, seq); @@ -331,10 +331,10 @@ TEST_F(DBMemTableTest, ColumnFamilyId) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_merge_operand_test.cc b/db/db_merge_operand_test.cc index e6280ad8c..a0ab34e01 100644 --- a/db/db_merge_operand_test.cc +++ b/db/db_merge_operand_test.cc @@ -17,7 +17,7 @@ #include "utilities/merge_operators/sortlist.h" #include "utilities/merge_operators/string_append/stringappend2.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBMergeOperandTest : public DBTestBase { public: @@ -231,10 +231,10 @@ TEST_F(DBMergeOperandTest, GetMergeOperandsBasic) { ASSERT_EQ(values[2], "am"); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_merge_operator_test.cc b/db/db_merge_operator_test.cc index 8358ddb56..4f762468d 100644 --- a/db/db_merge_operator_test.cc +++ b/db/db_merge_operator_test.cc @@ -12,7 +12,7 @@ #include "utilities/merge_operators.h" #include "utilities/merge_operators/string_append/stringappend2.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class TestReadCallback : public ReadCallback { public: @@ -418,8 +418,8 @@ TEST_P(MergeOperatorPinningTest, TailingIterator) { delete iter; }; - rocksdb::port::Thread writer_thread(writer_func); - rocksdb::port::Thread reader_thread(reader_func); + ROCKSDB_NAMESPACE::port::Thread writer_thread(writer_func); + ROCKSDB_NAMESPACE::port::Thread reader_thread(reader_func); writer_thread.join(); reader_thread.join(); @@ -456,19 +456,19 @@ TEST_F(DBMergeOperatorTest, TailingIteratorMemtableUnrefedBySomeoneElse) { bool pushed_first_operand = false; bool stepped_to_next_operand = false; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBIter::MergeValuesNewToOld:PushedFirstOperand", [&](void*) { EXPECT_FALSE(pushed_first_operand); pushed_first_operand = true; db_->Flush(FlushOptions()); // Switch to SuperVersion B }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBIter::MergeValuesNewToOld:SteppedToNextOperand", [&](void*) { EXPECT_FALSE(stepped_to_next_operand); stepped_to_next_operand = true; someone_else.reset(); // Unpin SuperVersion A }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ReadOptions ro; ro.tailing = true; @@ -657,10 +657,10 @@ TEST_P(PerConfigMergeOperatorPinningTest, Randomized) { VerifyDBFromMap(true_data); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_options_test.cc b/db/db_options_test.cc index 0b4e2240f..383f66cbf 100644 --- a/db/db_options_test.cc +++ b/db/db_options_test.cc @@ -23,7 +23,7 @@ #include "test_util/testutil.h" #include "util/random.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBOptionsTest : public DBTestBase { public: @@ -134,19 +134,17 @@ TEST_F(DBOptionsTest, SetBytesPerSync) { int i = 0; const std::string kValue(kValueSize, 'v'); ASSERT_EQ(options.bytes_per_sync, dbfull()->GetDBOptions().bytes_per_sync); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "WritableFileWriter::RangeSync:0", [&](void* /*arg*/) { - counter++; - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "WritableFileWriter::RangeSync:0", [&](void* /*arg*/) { counter++; }); WriteOptions write_opts; // should sync approximately 40MB/1MB ~= 40 times. for (i = 0; i < 40; i++) { Put(Key(i), kValue, write_opts); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr)); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); low_bytes_per_sync = counter; ASSERT_GT(low_bytes_per_sync, 35); ASSERT_LT(low_bytes_per_sync, 45); @@ -160,7 +158,7 @@ TEST_F(DBOptionsTest, SetBytesPerSync) { for (i = 0; i < 40; i++) { Put(Key(i), kValue, write_opts); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(dbfull()->CompactRange(CompactRangeOptions(), nullptr, nullptr)); ASSERT_GT(counter, 5); ASSERT_LT(counter, 15); @@ -183,11 +181,9 @@ TEST_F(DBOptionsTest, SetWalBytesPerSync) { ASSERT_EQ(512, dbfull()->GetDBOptions().wal_bytes_per_sync); int counter = 0; int low_bytes_per_sync = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "WritableFileWriter::RangeSync:0", [&](void* /*arg*/) { - counter++; - }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "WritableFileWriter::RangeSync:0", [&](void* /*arg*/) { counter++; }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); const std::string kValue(kValueSize, 'v'); int i = 0; for (; i < 10; i++) { @@ -223,7 +219,7 @@ TEST_F(DBOptionsTest, WritableFileMaxBufferSize) { std::atomic<int> match_cnt(0); std::atomic<int> unmatch_cnt(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WritableFileWriter::WritableFileWriter:0", [&](void* arg) { int value = static_cast<int>(reinterpret_cast<uintptr_t>(arg)); if (value == buffer_size) { @@ -232,7 +228,7 @@ TEST_F(DBOptionsTest, WritableFileMaxBufferSize) { unmatch_cnt++; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); int i = 0; for (; i < 3; i++) { ASSERT_OK(Put("foo", ToString(i))); @@ -865,10 +861,10 @@ TEST_F(DBOptionsTest, FIFOTtlBackwardCompatible) { #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_properties_test.cc b/db/db_properties_test.cc index 57206f6ed..50dc3efef 100644 --- a/db/db_properties_test.cc +++ b/db/db_properties_test.cc @@ -22,7 +22,7 @@ #include "util/random.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBPropertiesTest : public DBTestBase { public: @@ -391,16 +391,16 @@ TEST_F(DBPropertiesTest, ReadLatencyHistogramByLevel) { options.max_bytes_for_level_base = 4500 << 10; options.target_file_size_base = 98 << 10; options.max_write_buffer_number = 2; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.max_open_files = 11; // Make sure no proloading of table readers // RocksDB sanitize max open files to at least 20. Modify it back. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) { int* max_open_files = static_cast<int*>(arg); *max_open_files = 11; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); BlockBasedTableOptions table_options; table_options.no_block_cache = true; @@ -448,7 +448,7 @@ TEST_F(DBPropertiesTest, ReadLatencyHistogramByLevel) { // Reopen and issue iterating. See thee latency tracked ReopenWithColumnFamilies({"default", "pikachu"}, options); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_TRUE(dbfull()->GetProperty("rocksdb.cf-file-histogram", &prop)); ASSERT_EQ(std::string::npos, prop.find("** Level 0 read latency histogram")); ASSERT_EQ(std::string::npos, prop.find("** Level 1 read latency histogram")); @@ -1702,10 +1702,10 @@ TEST_F(DBPropertiesTest, BlockCacheProperties) { } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_range_del_test.cc b/db/db_range_del_test.cc index 93a16a9cf..15225875d 100644 --- a/db/db_range_del_test.cc +++ b/db/db_range_del_test.cc @@ -9,7 +9,7 @@ #include "test_util/testutil.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBRangeDelTest : public DBTestBase { public: @@ -925,7 +925,8 @@ TEST_F(DBRangeDelTest, MemtableBloomFilter) { Options options = CurrentOptions(); options.memtable_prefix_bloom_size_ratio = static_cast<double>(kMemtablePrefixFilterSize) / kMemtableSize; - options.prefix_extractor.reset(rocksdb::NewFixedPrefixTransform(kPrefixLen)); + options.prefix_extractor.reset( + ROCKSDB_NAMESPACE::NewFixedPrefixTransform(kPrefixLen)); options.write_buffer_size = kMemtableSize; Reopen(options); @@ -1078,7 +1079,7 @@ TEST_F(DBRangeDelTest, RangeTombstoneEndKeyAsSstableUpperBound) { // endpoint (key000002#6,1) to disappear. ASSERT_EQ(value, Get(Key(2))); auto begin_str = Key(3); - const rocksdb::Slice begin = begin_str; + const ROCKSDB_NAMESPACE::Slice begin = begin_str; dbfull()->TEST_CompactRange(1, &begin, nullptr); ASSERT_EQ(1, NumTableFilesAtLevel(1)); ASSERT_EQ(2, NumTableFilesAtLevel(2)); @@ -1097,7 +1098,7 @@ TEST_F(DBRangeDelTest, RangeTombstoneEndKeyAsSstableUpperBound) { // [key000001#5,1, key000002#72057594037927935,15] // [key000002#6,1, key000004#72057594037927935,15] auto begin_str = Key(0); - const rocksdb::Slice begin = begin_str; + const ROCKSDB_NAMESPACE::Slice begin = begin_str; dbfull()->TEST_CompactRange(1, &begin, &begin); ASSERT_EQ(0, NumTableFilesAtLevel(1)); ASSERT_EQ(3, NumTableFilesAtLevel(2)); @@ -1650,10 +1651,10 @@ TEST_F(DBRangeDelTest, OverlappedKeys) { #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_sst_test.cc b/db/db_sst_test.cc index 589a5915b..e0ecfb641 100644 --- a/db/db_sst_test.cc +++ b/db/db_sst_test.cc @@ -13,7 +13,7 @@ #include "port/stack_trace.h" #include "rocksdb/sst_file_manager.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBSSTTest : public DBTestBase { public: @@ -283,13 +283,14 @@ TEST_F(DBSSTTest, DBWithSstFileManager) { int files_added = 0; int files_deleted = 0; int files_moved = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SstFileManagerImpl::OnAddFile", [&](void* /*arg*/) { files_added++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "SstFileManagerImpl::OnDeleteFile", [&](void* /*arg*/) { files_deleted++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "SstFileManagerImpl::OnDeleteFile", + [&](void* /*arg*/) { files_deleted++; }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SstFileManagerImpl::OnMoveFile", [&](void* /*arg*/) { files_moved++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.sst_file_manager = sst_file_manager; @@ -337,21 +338,21 @@ TEST_F(DBSSTTest, DBWithSstFileManager) { ASSERT_EQ(sfm->GetTrackedFiles(), files_in_db); ASSERT_EQ(sfm->GetTotalSize(), total_files_size); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBSSTTest, RateLimitedDelete) { Destroy(last_options_); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBSSTTest::RateLimitedDelete:1", "DeleteScheduler::BackgroundEmptyTrash"}, }); std::vector<uint64_t> penalties; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DeleteScheduler::BackgroundEmptyTrash:Wait", [&](void* arg) { penalties.push_back(*(static_cast<uint64_t*>(arg))); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "InstrumentedCondVar::TimedWaitInternal", [&](void* arg) { // Turn timed wait into a simulated sleep uint64_t* abs_time_us = static_cast<uint64_t*>(arg); @@ -372,7 +373,7 @@ TEST_F(DBSSTTest, RateLimitedDelete) { *abs_time_us = static_cast<uint64_t>(real_cur_time); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); env_->no_slowdown_ = true; env_->time_elapse_only_sleep_ = true; @@ -437,14 +438,14 @@ TEST_F(DBSSTTest, RateLimitedDelete) { ASSERT_GT(time_spent_deleting, expected_penlty * 0.9); ASSERT_LT(time_spent_deleting, expected_penlty * 1.1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBSSTTest, RateLimitedWALDelete) { Destroy(last_options_); std::vector<uint64_t> penalties; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DeleteScheduler::BackgroundEmptyTrash:Wait", [&](void* arg) { penalties.push_back(*(static_cast<uint64_t*>(arg))); }); @@ -465,7 +466,7 @@ TEST_F(DBSSTTest, RateLimitedWALDelete) { sfm->delete_scheduler()->SetMaxTrashDBRatio(3.1); ASSERT_OK(TryReopen(options)); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Create 4 files in L0 for (char v = 'a'; v <= 'd'; v++) { @@ -489,7 +490,7 @@ TEST_F(DBSSTTest, RateLimitedWALDelete) { sfm->WaitForEmptyTrash(); ASSERT_EQ(penalties.size(), 8); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } class DBWALTestWithParam @@ -627,14 +628,13 @@ TEST_F(DBSSTTest, OpenDBWithExistingTrash) { // files in the second path were not. TEST_F(DBSSTTest, DeleteSchedulerMultipleDBPaths) { std::atomic<int> bg_delete_file(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DeleteScheduler::DeleteTrashFile:DeleteFile", [&](void* /*arg*/) { bg_delete_file++; }); // The deletion scheduler sometimes skips marking file as trash according to // a heuristic. In that case the deletion will go through the below SyncPoint. - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DeleteScheduler::DeleteFile", - [&](void* /*arg*/) { bg_delete_file++; }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DeleteScheduler::DeleteFile", [&](void* /*arg*/) { bg_delete_file++; }); Options options = CurrentOptions(); options.disable_auto_compactions = true; @@ -652,7 +652,7 @@ TEST_F(DBSSTTest, DeleteSchedulerMultipleDBPaths) { auto sfm = static_cast<SstFileManagerImpl*>(options.sst_file_manager.get()); DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.disableWAL = true; @@ -700,15 +700,15 @@ TEST_F(DBSSTTest, DeleteSchedulerMultipleDBPaths) { sfm->WaitForEmptyTrash(); ASSERT_EQ(bg_delete_file, 10); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBSSTTest, DestroyDBWithRateLimitedDelete) { int bg_delete_file = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DeleteScheduler::DeleteTrashFile:DeleteFile", [&](void* /*arg*/) { bg_delete_file++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Status s; Options options = CurrentOptions(); @@ -793,15 +793,15 @@ TEST_F(DBSSTTest, CancellingCompactionsWorks) { DestroyAndReopen(options); int completed_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction():CancelledCompaction", [&](void* /*arg*/) { sfm->SetMaxAllowedSpaceUsage(0); ASSERT_EQ(sfm->GetCompactionsReservedSize(), 0); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial:AfterRun", [&](void* /*arg*/) { completed_compactions++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); @@ -828,7 +828,7 @@ TEST_F(DBSSTTest, CancellingCompactionsWorks) { ASSERT_EQ(sfm->GetCompactionsReservedSize(), 0); // Make sure the stat is bumped ASSERT_GT(dbfull()->immutable_db_options().statistics.get()->getTickerCount(COMPACTION_CANCELLED), 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBSSTTest, CancellingManualCompactionsWorks) { @@ -876,7 +876,7 @@ TEST_F(DBSSTTest, CancellingManualCompactionsWorks) { // Now make sure CompactFiles also gets cancelled auto l0_files = collector->GetFlushedFiles(); - dbfull()->CompactFiles(rocksdb::CompactionOptions(), l0_files, 0); + dbfull()->CompactFiles(ROCKSDB_NAMESPACE::CompactionOptions(), l0_files, 0); // Wait for manual compaction to get scheduled and finish dbfull()->TEST_WaitForCompact(true); @@ -890,17 +890,17 @@ TEST_F(DBSSTTest, CancellingManualCompactionsWorks) { // returns to normal sfm->SetMaxAllowedSpaceUsage(0); int completed_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactFilesImpl:End", [&](void* /*arg*/) { completed_compactions++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - dbfull()->CompactFiles(rocksdb::CompactionOptions(), l0_files, 0); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + dbfull()->CompactFiles(ROCKSDB_NAMESPACE::CompactionOptions(), l0_files, 0); dbfull()->TEST_WaitForCompact(true); ASSERT_EQ(sfm->GetCompactionsReservedSize(), 0); ASSERT_GT(completed_compactions, 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBSSTTest, DBWithMaxSpaceAllowedRandomized) { @@ -914,7 +914,7 @@ TEST_F(DBSSTTest, DBWithMaxSpaceAllowedRandomized) { std::atomic<int> reached_max_space_on_flush(0); std::atomic<int> reached_max_space_on_compaction(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::FlushMemTableToOutputFile:MaxAllowedSpaceReached", [&](void* arg) { Status* bg_error = static_cast<Status*>(arg); @@ -924,13 +924,13 @@ TEST_F(DBSSTTest, DBWithMaxSpaceAllowedRandomized) { *bg_error = Status::OK(); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction():CancelledCompaction", [&](void* arg) { bool* enough_room = static_cast<bool*>(arg); *enough_room = true; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::FinishCompactionOutputFile:MaxAllowedSpaceReached", [&](void* /*arg*/) { bg_error_set = true; @@ -939,8 +939,8 @@ TEST_F(DBSSTTest, DBWithMaxSpaceAllowedRandomized) { for (auto limit_mb : max_space_limits_mbs) { bg_error_set = false; - rocksdb::SyncPoint::GetInstance()->ClearTrace(); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::shared_ptr<SstFileManager> sst_file_manager(NewSstFileManager(env_)); auto sfm = static_cast<SstFileManagerImpl*>(sst_file_manager.get()); @@ -964,7 +964,7 @@ TEST_F(DBSSTTest, DBWithMaxSpaceAllowedRandomized) { uint64_t total_sst_files_size = 0; GetAllSSTFiles(&total_sst_files_size); ASSERT_GE(total_sst_files_size, limit_mb * 1024 * 1024); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } ASSERT_GT(reached_max_space_on_flush, 0); @@ -1218,10 +1218,10 @@ TEST_F(DBSSTTest, GetTotalSstFilesSizeVersionsFilesShared) { #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_statistics_test.cc b/db/db_statistics_test.cc index 31396a7bf..8fbbb96d5 100644 --- a/db/db_statistics_test.cc +++ b/db/db_statistics_test.cc @@ -10,7 +10,7 @@ #include "port/stack_trace.h" #include "rocksdb/statistics.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBStatisticsTest : public DBTestBase { public: @@ -45,7 +45,7 @@ TEST_F(DBStatisticsTest, CompressionStatsTest) { Options options = CurrentOptions(); options.compression = type; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.statistics->set_stats_level(StatsLevel::kExceptTimeForMutex); DestroyAndReopen(options); @@ -91,7 +91,7 @@ TEST_F(DBStatisticsTest, CompressionStatsTest) { TEST_F(DBStatisticsTest, MutexWaitStatsDisabledByDefault) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); CreateAndReopenWithCF({"pikachu"}, options); const uint64_t kMutexWaitDelay = 100; ThreadStatusUtil::TEST_SetStateDelay(ThreadStatus::STATE_MUTEX_WAIT, @@ -104,7 +104,7 @@ TEST_F(DBStatisticsTest, MutexWaitStatsDisabledByDefault) { TEST_F(DBStatisticsTest, MutexWaitStats) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.statistics->set_stats_level(StatsLevel::kAll); CreateAndReopenWithCF({"pikachu"}, options); const uint64_t kMutexWaitDelay = 100; @@ -118,7 +118,7 @@ TEST_F(DBStatisticsTest, MutexWaitStats) { TEST_F(DBStatisticsTest, ResetStats) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); for (int i = 0; i < 2; ++i) { // pick arbitrary ticker and histogram. On first iteration they're zero @@ -140,10 +140,10 @@ TEST_F(DBStatisticsTest, ResetStats) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_table_properties_test.cc b/db/db_table_properties_test.cc index 164042bc2..e3499df70 100644 --- a/db/db_table_properties_test.cc +++ b/db/db_table_properties_test.cc @@ -19,7 +19,7 @@ #ifndef ROCKSDB_LITE -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // A helper function that ensures the table properties returned in // `GetPropertiesOfAllTablesTest` is correct. @@ -325,12 +325,12 @@ TEST_F(DBTablePropertiesTest, DeletionTriggeredCompactionMarking) { } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_tailing_iter_test.cc b/db/db_tailing_iter_test.cc index 62e60758f..39988638b 100644 --- a/db/db_tailing_iter_test.cc +++ b/db/db_tailing_iter_test.cc @@ -16,7 +16,7 @@ #include "db/forward_iterator.h" #include "port/stack_trace.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBTestTailingIterator : public DBTestBase { public: @@ -98,8 +98,8 @@ TEST_F(DBTestTailingIterator, TailingIteratorSeekToNext) { ASSERT_TRUE(itern->Valid()); ASSERT_EQ(itern->key().compare(key), 0); } - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); for (int i = 2 * num_records; i > 0; --i) { char buf1[32]; char buf2[32]; @@ -143,25 +143,25 @@ TEST_F(DBTestTailingIterator, TailingIteratorTrimSeekToNext) { bool file_iters_deleted = false; bool file_iters_renewed_null = false; bool file_iters_renewed_copy = false; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ForwardIterator::SeekInternal:Return", [&](void* arg) { ForwardIterator* fiter = reinterpret_cast<ForwardIterator*>(arg); ASSERT_TRUE(!file_iters_deleted || fiter->TEST_CheckDeletedIters(&deleted_iters, &num_iters)); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ForwardIterator::Next:Return", [&](void* arg) { ForwardIterator* fiter = reinterpret_cast<ForwardIterator*>(arg); ASSERT_TRUE(!file_iters_deleted || fiter->TEST_CheckDeletedIters(&deleted_iters, &num_iters)); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ForwardIterator::RenewIterators:Null", [&](void* /*arg*/) { file_iters_renewed_null = true; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ForwardIterator::RenewIterators:Copy", [&](void* /*arg*/) { file_iters_renewed_copy = true; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); const int num_records = 1000; for (int i = 1; i < num_records; ++i) { char buf1[32]; @@ -413,14 +413,14 @@ TEST_F(DBTestTailingIterator, TailingIteratorUpperBound) { // This keeps track of the number of times NeedToSeekImmutable() was true. int immutable_seeks = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ForwardIterator::SeekInternal:Immutable", [&](void* /*arg*/) { ++immutable_seeks; }); // Seek to 13. This should not require any immutable seeks. - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); it->Seek("13"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_FALSE(it->Valid()); ASSERT_EQ(0, immutable_seeks); @@ -530,13 +530,13 @@ TEST_F(DBTestTailingIterator, SeekToFirstWithUpperBoundBug) { ASSERT_EQ(iter->key().ToString(), "aa"); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !defined(ROCKSDB_LITE) int main(int argc, char** argv) { #if !defined(ROCKSDB_LITE) - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); #else diff --git a/db/db_test.cc b/db/db_test.cc index b3234c766..60b4d60f4 100644 --- a/db/db_test.cc +++ b/db/db_test.cc @@ -68,7 +68,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBTest : public DBTestBase { public: @@ -232,14 +232,14 @@ TEST_F(DBTest, SkipDelay) { // the test flaky auto token = dbfull()->TEST_write_controler().GetDelayToken(1); std::atomic<int> sleep_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::DelayWrite:Sleep", [&](void* /*arg*/) { sleep_count.fetch_add(1); }); std::atomic<int> wait_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::DelayWrite:Wait", [&](void* /*arg*/) { wait_count.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.sync = sync; @@ -290,9 +290,8 @@ TEST_F(DBTest, MixedSlowdownOptions) { // the test flaky auto token = dbfull()->TEST_write_controler().GetDelayToken(1); std::atomic<int> sleep_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::DelayWrite:BeginWriteStallDone", - [&](void* /*arg*/) { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::DelayWrite:BeginWriteStallDone", [&](void* /*arg*/) { sleep_count.fetch_add(1); if (threads.empty()) { for (int i = 0; i < 2; ++i) { @@ -303,7 +302,7 @@ TEST_F(DBTest, MixedSlowdownOptions) { } } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.sync = false; @@ -345,9 +344,8 @@ TEST_F(DBTest, MixedSlowdownOptionsInQueue) { // the test flaky auto token = dbfull()->TEST_write_controler().GetDelayToken(1); std::atomic<int> sleep_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::DelayWrite:Sleep", - [&](void* /*arg*/) { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::DelayWrite:Sleep", [&](void* /*arg*/) { sleep_count.fetch_add(1); if (threads.empty()) { for (int i = 0; i < 2; ++i) { @@ -359,10 +357,10 @@ TEST_F(DBTest, MixedSlowdownOptionsInQueue) { } }); std::atomic<int> wait_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::DelayWrite:Wait", [&](void* /*arg*/) { wait_count.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.sync = false; @@ -414,9 +412,8 @@ TEST_F(DBTest, MixedSlowdownOptionsStop) { // the test flaky auto token = dbfull()->TEST_write_controler().GetStopToken(); std::atomic<int> wait_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::DelayWrite:Wait", - [&](void* /*arg*/) { + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::DelayWrite:Wait", [&](void* /*arg*/) { wait_count.fetch_add(1); if (threads.empty()) { for (int i = 0; i < 2; ++i) { @@ -432,7 +429,7 @@ TEST_F(DBTest, MixedSlowdownOptionsStop) { token.reset(); threads.emplace_back(wakeup_writer); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; wo.sync = false; @@ -2592,15 +2589,15 @@ TEST_F(DBTest, GroupCommitTest) { do { Options options = CurrentOptions(); options.env = env_; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); Reopen(options); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"WriteThread::JoinBatchGroup:BeganWaiting", "DBImpl::WriteImpl:BeforeLeaderEnters"}, - {"WriteThread::AwaitState:BlockingWaiting", + {"WriteThread::AwaitState:BlockingWaiting", "WriteThread::EnterAsBatchGroupLeader:End"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Start threads GCThread thread[kGCNumThreads]; @@ -2919,13 +2916,13 @@ class ModelDB : public DB { DBOptions GetDBOptions() const override { return options_; } using DB::Flush; - Status Flush(const rocksdb::FlushOptions& /*options*/, + Status Flush(const ROCKSDB_NAMESPACE::FlushOptions& /*options*/, ColumnFamilyHandle* /*column_family*/) override { Status ret; return ret; } Status Flush( - const rocksdb::FlushOptions& /*options*/, + const ROCKSDB_NAMESPACE::FlushOptions& /*options*/, const std::vector<ColumnFamilyHandle*>& /*column_families*/) override { return Status::OK(); } @@ -2958,8 +2955,8 @@ class ModelDB : public DB { Status DeleteFile(std::string /*name*/) override { return Status::OK(); } Status GetUpdatesSince( - rocksdb::SequenceNumber, - std::unique_ptr<rocksdb::TransactionLogIterator>*, + ROCKSDB_NAMESPACE::SequenceNumber, + std::unique_ptr<ROCKSDB_NAMESPACE::TransactionLogIterator>*, const TransactionLogIterator::ReadOptions& /*read_options*/ = TransactionLogIterator::ReadOptions()) override { return Status::NotSupported("Not supported in Model DB"); @@ -3219,12 +3216,12 @@ TEST_F(DBTest, BlockBasedTablePrefixIndexTotalOrderSeek) { options.prefix_extractor.reset(NewFixedPrefixTransform(1)); // RocksDB sanitize max open files to at least 20. Modify it back. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) { int* max_open_files = static_cast<int*>(arg); *max_open_files = 11; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Reopen(options); ASSERT_OK(Put("k1", "v1")); @@ -3257,7 +3254,7 @@ TEST_F(DBTest, BlockBasedTablePrefixIndexTotalOrderSeek) { ASSERT_TRUE(iter->Valid()); ASSERT_EQ("k1", iter->key().ToString()); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest, ChecksumTest) { @@ -3681,7 +3678,7 @@ TEST_F(DBTest, DISABLED_RateLimitingTest) { options.compression = kNoCompression; options.create_if_missing = true; options.env = env_; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.IncreaseParallelism(4); DestroyAndReopen(options); @@ -4007,10 +4004,10 @@ TEST_F(DBTest, DynamicMemtableOptions) { int count = 0; Random rnd(301); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::DelayWrite:Wait", [&](void* /*arg*/) { sleeping_task_low.WakeUp(); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); while (!sleeping_task_low.WokenUp() && count < 256) { ASSERT_OK(Put(Key(count), RandomString(&rnd, 1024), WriteOptions())); @@ -4068,7 +4065,7 @@ TEST_F(DBTest, DynamicMemtableOptions) { #endif sleeping_task_low.WaitUntilDone(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } #endif // ROCKSDB_LITE @@ -4177,11 +4174,11 @@ TEST_F(DBTest, ThreadStatusFlush) { options.enable_thread_tracking = true; options = CurrentOptions(options); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"FlushJob::FlushJob()", "DBTest::ThreadStatusFlush:1"}, {"DBTest::ThreadStatusFlush:2", "FlushJob::WriteLevel0Table"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); CreateAndReopenWithCF({"pikachu"}, options); VerifyOperationCount(env_, ThreadStatus::OP_FLUSH, 0); @@ -4206,7 +4203,7 @@ TEST_F(DBTest, ThreadStatusFlush) { // This second sync point is to ensure the flush job will not // be completed until we already perform VerifyOperationCount(). TEST_SYNC_POINT("DBTest::ThreadStatusFlush:2"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBTestWithParam, ThreadStatusSingleCompaction) { @@ -4229,15 +4226,15 @@ TEST_P(DBTestWithParam, ThreadStatusSingleCompaction) { options.level0_file_num_compaction_trigger = kNumL0Files; options.max_subcompactions = max_subcompactions_; - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBTest::ThreadStatusSingleCompaction:0", "DBImpl::BGWorkCompaction"}, {"CompactionJob::Run():Start", "DBTest::ThreadStatusSingleCompaction:1"}, {"DBTest::ThreadStatusSingleCompaction:2", "CompactionJob::Run():End"}, }); for (int tests = 0; tests < 2; ++tests) { DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->ClearTrace(); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); // The Put Phase. @@ -4276,7 +4273,7 @@ TEST_P(DBTestWithParam, ThreadStatusSingleCompaction) { // repeat the test with disabling thread tracking. options.enable_thread_tracking = false; - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -4373,7 +4370,7 @@ TEST_P(DBTestWithParam, PreShutdownMultipleCompaction) { std::vector<ThreadStatus> thread_list; // Delay both flush and compaction - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"FlushJob::FlushJob()", "CompactionJob::Run():Start"}, {"CompactionJob::Run():Start", "DBTest::PreShutdownMultipleCompaction:Preshutdown"}, @@ -4384,7 +4381,7 @@ TEST_P(DBTestWithParam, PreShutdownMultipleCompaction) { {"CompactionJob::Run():End", "DBTest::PreShutdownMultipleCompaction:VerifyPreshutdown"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Make rocksdb busy int key = 0; @@ -4462,7 +4459,7 @@ TEST_P(DBTestWithParam, PreShutdownCompactionMiddle) { std::vector<ThreadStatus> thread_list; // Delay both flush and compaction - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBTest::PreShutdownCompactionMiddle:Preshutdown", "CompactionJob::Run():Inprogress"}, {"CompactionJob::Run():Start", @@ -4471,7 +4468,7 @@ TEST_P(DBTestWithParam, PreShutdownCompactionMiddle) { {"CompactionJob::Run():End", "DBTest::PreShutdownCompactionMiddle:VerifyPreshutdown"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Make rocksdb busy int key = 0; @@ -4648,7 +4645,7 @@ TEST_F(DBTest, DynamicLevelCompressionPerLevel2) { std::atomic<int> num_zlib(0); std::atomic<int> num_lz4(0); std::atomic<int> num_no(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); if (compaction->output_level() == 4) { @@ -4656,13 +4653,13 @@ TEST_F(DBTest, DynamicLevelCompressionPerLevel2) { num_lz4.fetch_add(1); } }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "FlushJob::WriteLevel0Table:output_compression", [&](void* arg) { auto* compression = reinterpret_cast<CompressionType*>(arg); ASSERT_TRUE(*compression == kNoCompression); num_no.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); for (int i = 0; i < 100; i++) { std::string value = RandomString(&rnd, 200); @@ -4676,8 +4673,8 @@ TEST_F(DBTest, DynamicLevelCompressionPerLevel2) { Flush(); dbfull()->TEST_WaitForFlushMemTable(); dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); ASSERT_EQ(NumTableFilesAtLevel(1), 0); ASSERT_EQ(NumTableFilesAtLevel(2), 0); @@ -4690,7 +4687,7 @@ TEST_F(DBTest, DynamicLevelCompressionPerLevel2) { // After base level turn L4->L3, L3 becomes LZ4 and L4 becomes Zlib num_lz4.store(0); num_no.store(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "LevelCompactionPicker::PickCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); if (compaction->output_level() == 4 && compaction->start_level() == 3) { @@ -4701,13 +4698,13 @@ TEST_F(DBTest, DynamicLevelCompressionPerLevel2) { num_lz4.fetch_add(1); } }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "FlushJob::WriteLevel0Table:output_compression", [&](void* arg) { auto* compression = reinterpret_cast<CompressionType*>(arg); ASSERT_TRUE(*compression == kNoCompression); num_no.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); for (int i = 101; i < 500; i++) { std::string value = RandomString(&rnd, 200); @@ -4718,8 +4715,8 @@ TEST_F(DBTest, DynamicLevelCompressionPerLevel2) { } } - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(NumTableFilesAtLevel(1), 0); ASSERT_EQ(NumTableFilesAtLevel(2), 0); ASSERT_GT(NumTableFilesAtLevel(3), 0); @@ -5135,7 +5132,7 @@ TEST_F(DBTest, DynamicMiscOptions) { options.create_if_missing = true; options.max_sequential_skip_in_iterations = 16; options.compression = kNoCompression; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); auto assert_reseek_count = [this, &options](int key_start, int num_reseek) { @@ -5227,7 +5224,7 @@ TEST_F(DBTest, L0L1L2AndUpHitCounter) { options.max_write_buffer_number = 2; options.max_background_compactions = 8; options.max_background_flushes = 8; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); CreateAndReopenWithCF({"mypikachu"}, options); int numkeys = 20000; @@ -5330,7 +5327,7 @@ TEST_F(DBTest, CloseSpeedup) { env_->DeleteDir(dbname_); DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); env_->SetBackgroundThreads(1, Env::LOW); env_->SetBackgroundThreads(1, Env::HIGH); Random rnd(301); @@ -5385,7 +5382,7 @@ TEST_F(DBTest, MergeTestTime) { this->env_->time_elapse_only_sleep_ = true; this->env_->no_slowdown_ = true; Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.merge_operator.reset(new DelayedMergeOperator(this)); DestroyAndReopen(options); @@ -5426,7 +5423,7 @@ TEST_P(DBTestWithParam, MergeCompactionTimeTest) { SetPerfLevel(kEnableTime); Options options = CurrentOptions(); options.compaction_filter_factory = std::make_shared<KeepFilterFactory>(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.merge_operator.reset(new DelayedMergeOperator(this)); options.compaction_style = kCompactionStyleUniversal; options.max_subcompactions = max_subcompactions_; @@ -5448,7 +5445,7 @@ TEST_P(DBTestWithParam, FilterCompactionTimeTest) { std::make_shared<DelayFilterFactory>(this); options.disable_auto_compactions = true; options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.statistics->set_stats_level(kExceptTimeForMutex); options.max_subcompactions = max_subcompactions_; DestroyAndReopen(options); @@ -5712,16 +5709,16 @@ TEST_F(DBTest, AutomaticConflictsWithManualCompaction) { // schedule automatic compactions after the manual one starts, but before it // finishes to ensure conflict. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::BackgroundCompaction:Start", "DBTest::AutomaticConflictsWithManualCompaction:PrePuts"}, {"DBTest::AutomaticConflictsWithManualCompaction:PostPuts", "DBImpl::BackgroundCompaction:NonTrivial:AfterRun"}}); std::atomic<int> callback_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::MaybeScheduleFlushOrCompaction:Conflict", [&](void* /*arg*/) { callback_count.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int i = 0; i < 2; ++i) { @@ -5751,7 +5748,7 @@ TEST_F(DBTest, AutomaticConflictsWithManualCompaction) { for (int i = 0; i < 2; ++i) { ASSERT_NE("NOT_FOUND", Get(Key(i))); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); manual_compaction_thread.join(); dbfull()->TEST_WaitForCompact(); } @@ -5775,7 +5772,7 @@ TEST_F(DBTest, CompactFilesShouldTriggerAutoCompaction) { ASSERT_OK(Flush()); } - rocksdb::ColumnFamilyMetaData cf_meta_data; + ROCKSDB_NAMESPACE::ColumnFamilyMetaData cf_meta_data; db_->GetColumnFamilyMetaData(db_->DefaultColumnFamily(), &cf_meta_data); std::vector<std::string> input_files; @@ -5879,19 +5876,19 @@ TEST_F(DBTest, FlushesInParallelWithCompactRange) { } if (iter == 1) { - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::RunManualCompaction()::1", "DBTest::FlushesInParallelWithCompactRange:1"}, {"DBTest::FlushesInParallelWithCompactRange:2", "DBImpl::RunManualCompaction()::2"}}); } else { - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"CompactionJob::Run():Start", "DBTest::FlushesInParallelWithCompactRange:1"}, {"DBTest::FlushesInParallelWithCompactRange:2", "CompactionJob::Run():End"}}); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::vector<port::Thread> threads; threads.emplace_back([&]() { Compact("a", "z"); }); @@ -5910,7 +5907,7 @@ TEST_F(DBTest, FlushesInParallelWithCompactRange) { for (auto& t : threads) { t.join(); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -5976,7 +5973,7 @@ TEST_F(DBTest, DelayedWriteRate) { static_cast<int64_t>(estimated_sleep_time * 2)); env_->no_slowdown_ = false; - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); sleeping_task_low.WakeUp(); sleeping_task_low.WaitUntilDone(); } @@ -6005,12 +6002,12 @@ TEST_F(DBTest, HardLimit) { CreateAndReopenWithCF({"pikachu"}, options); std::atomic<int> callback_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack("DBImpl::DelayWrite:Wait", - [&](void* /*arg*/) { - callback_count.fetch_add(1); - sleeping_task_low.WakeUp(); - }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::DelayWrite:Wait", [&](void* /*arg*/) { + callback_count.fetch_add(1); + sleeping_task_low.WakeUp(); + }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); int key_idx = 0; @@ -6027,7 +6024,7 @@ TEST_F(DBTest, HardLimit) { } ASSERT_GE(callback_count.load(), 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); sleeping_task_low.WaitUntilDone(); } @@ -6099,7 +6096,7 @@ TEST_F(DBTest, SoftLimit) { "DBImpl::BackgroundCallFlush:ContextCleanedUp"); }; - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Reopen(options); @@ -6155,7 +6152,7 @@ TEST_F(DBTest, SoftLimit) { ASSERT_TRUE(listener->CheckCondition(WriteStallCondition::kNormal)); // Only allow one compactin going through. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "BackgroundCallCompaction:0", [&](void* /*arg*/) { // Schedule a sleeping task. sleeping_task_low.Reset(); @@ -6229,7 +6226,7 @@ TEST_F(DBTest, SoftLimit) { ASSERT_TRUE(listener->CheckCondition(WriteStallCondition::kDelayed)); sleeping_task_low.WaitUntilSleeping(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); sleeping_task_low.WakeUp(); sleeping_task_low.WaitUntilDone(); } @@ -6307,7 +6304,7 @@ TEST_F(DBTest, CreateColumnFamilyShouldFailOnIncompatibleOptions) { #ifndef ROCKSDB_LITE TEST_F(DBTest, RowCache) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.row_cache = NewLRUCache(8192); DestroyAndReopen(options); @@ -6326,7 +6323,7 @@ TEST_F(DBTest, RowCache) { TEST_F(DBTest, PinnableSliceAndRowCache) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.row_cache = NewLRUCache(8192); DestroyAndReopen(options); @@ -6356,12 +6353,12 @@ TEST_F(DBTest, PinnableSliceAndRowCache) { #endif // ROCKSDB_LITE TEST_F(DBTest, DeletingOldWalAfterDrop) { - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"Test:AllowFlushes", "DBImpl::BGWorkFlush"}, {"DBImpl::BGWorkFlush:done", "Test:WaitForFlush"}}); - rocksdb::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Options options = CurrentOptions(); options.max_total_wal_size = 8192; options.compression = kNoCompression; @@ -6371,7 +6368,7 @@ TEST_F(DBTest, DeletingOldWalAfterDrop) { options.level0_stop_writes_trigger = (1 << 30); options.disable_auto_compactions = true; DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); CreateColumnFamilies({"cf1", "cf2"}, options); ASSERT_OK(Put(0, "key1", DummyString(8192))); @@ -6509,7 +6506,7 @@ TEST_F(DBTest, CreationTimeOfOldestFile) { env_->GetCurrentTime(&time_2); const uint64_t uint_time_2 = static_cast<uint64_t>(time_2); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "PropertyBlockBuilder::AddTableProperty:Start", [&](void* arg) { TableProperties* props = reinterpret_cast<TableProperties*>(arg); if (set_file_creation_time_to_zero) { @@ -6530,12 +6527,12 @@ TEST_F(DBTest, CreationTimeOfOldestFile) { } }); // Set file creation time in manifest all to 0. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "FileMetaData::FileMetaData", [&](void* arg) { FileMetaData* meta = static_cast<FileMetaData*>(arg); meta->file_creation_time = 0; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int i = 0; i < kNumLevelFiles; ++i) { @@ -6585,12 +6582,12 @@ TEST_F(DBTest, CreationTimeOfOldestFile) { Status s3 = dbfull()->GetCreationTimeOfOldestFile(&ctime); ASSERT_EQ(s3, Status::NotSupported()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } #endif -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS extern "C" { @@ -6601,7 +6598,7 @@ void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} #endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); diff --git a/db/db_test2.cc b/db/db_test2.cc index f59b341de..f4e8e960a 100644 --- a/db/db_test2.cc +++ b/db/db_test2.cc @@ -18,7 +18,7 @@ #include "rocksdb/wal_filter.h" #include "test_util/fault_injection_test_env.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBTest2 : public DBTestBase { public: @@ -40,7 +40,7 @@ TEST_P(PrefixFullBloomWithReverseComparator, Options options = last_options_; options.comparator = ReverseBytewiseComparator(); options.prefix_extractor.reset(NewCappedPrefixTransform(3)); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions bbto; if (if_cache_filter_) { bbto.no_block_cache = false; @@ -132,7 +132,7 @@ TEST_F(DBTest2, IteratorPropertyVersionNumber) { TEST_F(DBTest2, CacheIndexAndFilterWithDBRestart) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; table_options.filter_policy.reset(NewBloomFilterPolicy(20)); @@ -151,7 +151,7 @@ TEST_F(DBTest2, CacheIndexAndFilterWithDBRestart) { TEST_F(DBTest2, MaxSuccessiveMergesChangeWithDBRecovery) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.max_successive_merges = 3; options.merge_operator = MergeOperators::CreatePutOperator(); options.disable_auto_compactions = true; @@ -185,19 +185,19 @@ TEST_P(DBTestSharedWriteBufferAcrossCFs, SharedWriteBufferAcrossCFs) { // Avoid undeterministic value by malloc_usable_size(); // Force arena block size to 1 - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Arena::Arena:0", [&](void* arg) { size_t* block_size = static_cast<size_t*>(arg); *block_size = 1; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Arena::AllocateNewBlock:0", [&](void* arg) { std::pair<size_t*, size_t*>* pair = static_cast<std::pair<size_t*, size_t*>*>(arg); *std::get<0>(*pair) = *std::get<1>(*pair); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // The total soft write buffer size is about 105000 std::shared_ptr<Cache> cache = NewLRUCache(4 * 1024 * 1024, 2); @@ -346,7 +346,7 @@ TEST_P(DBTestSharedWriteBufferAcrossCFs, SharedWriteBufferAcrossCFs) { last_options_.write_buffer_manager.reset(); ASSERT_LT(cache->GetUsage(), 256 * 1024); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } INSTANTIATE_TEST_CASE_P(DBTestSharedWriteBufferAcrossCFs, @@ -361,19 +361,19 @@ TEST_F(DBTest2, SharedWriteBufferLimitAcrossDB) { options.arena_block_size = 4096; // Avoid undeterministic value by malloc_usable_size(); // Force arena block size to 1 - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Arena::Arena:0", [&](void* arg) { size_t* block_size = static_cast<size_t*>(arg); *block_size = 1; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Arena::AllocateNewBlock:0", [&](void* arg) { std::pair<size_t*, size_t*>* pair = static_cast<std::pair<size_t*, size_t*>*>(arg); *std::get<0>(*pair) = *std::get<1>(*pair); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); options.write_buffer_size = 500000; // this is never hit // Use a write buffer total size so that the soft limit is about @@ -453,7 +453,7 @@ TEST_F(DBTest2, SharedWriteBufferLimitAcrossDB) { delete db2; ASSERT_OK(DestroyDB(dbname2, options)); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, TestWriteBufferNoLimitWithCache) { @@ -1114,7 +1114,7 @@ TEST_F(DBTest2, PresetCompressionDict) { assert(false); } - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.table_factory.reset(NewBlockBasedTableFactory(table_options)); CreateAndReopenWithCF({"pikachu"}, options); Random rnd(301); @@ -1185,7 +1185,7 @@ TEST_F(DBTest2, PresetCompressionDictLocality) { options.compression = kZSTD; options.compression_opts.max_dict_bytes = 1 << 14; // 16KB options.compression_opts.zstd_max_train_bytes = 1 << 18; // 256KB - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.target_file_size_base = kNumEntriesPerFile * kNumBytesPerEntry; BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; @@ -1205,12 +1205,12 @@ TEST_F(DBTest2, PresetCompressionDictLocality) { // Store all the dictionaries generated during a full compaction. std::vector<std::string> compression_dicts; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "BlockBasedTableBuilder::WriteCompressionDictBlock:RawDict", [&](void* arg) { compression_dicts.emplace_back(static_cast<Slice*>(arg)->ToString()); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); CompactRangeOptions compact_range_opts; compact_range_opts.bottommost_level_compaction = BottommostLevelCompaction::kForceOptimized; @@ -1351,14 +1351,14 @@ class CompactionStallTestListener : public EventListener { }; TEST_F(DBTest2, CompactionStall) { - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::BGWorkCompaction", "DBTest2::CompactionStall:0"}, {"DBImpl::BGWorkCompaction", "DBTest2::CompactionStall:1"}, {"DBTest2::CompactionStall:2", "DBImpl::NotifyOnCompactionBegin::UnlockMutex"}, {"DBTest2::CompactionStall:3", "DBImpl::NotifyOnCompactionCompleted::UnlockMutex"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.level0_file_num_compaction_trigger = 4; @@ -1385,7 +1385,7 @@ TEST_F(DBTest2, CompactionStall) { // Clear "DBImpl::BGWorkCompaction" SYNC_POINT since we want to hold it again // at DBTest2::CompactionStall::1 - rocksdb::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); // Another 6 L0 files to trigger compaction again for (int i = 0; i < 6; i++) { @@ -1411,7 +1411,7 @@ TEST_F(DBTest2, CompactionStall) { 10 - options.level0_file_num_compaction_trigger); ASSERT_EQ(listener->compacting_files_cnt_.load(), listener->compacted_files_cnt_.load()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } #endif // ROCKSDB_LITE @@ -1480,7 +1480,7 @@ class PinL0IndexAndFilterBlocksTest options->max_open_files = -1; } options->create_if_missing = true; - options->statistics = rocksdb::CreateDBStatistics(); + options->statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; table_options.pin_l0_filter_and_index_blocks_in_cache = true; @@ -1520,7 +1520,7 @@ TEST_P(PinL0IndexAndFilterBlocksTest, options.max_open_files = -1; } options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions table_options; table_options.cache_index_and_filter_blocks = true; table_options.pin_l0_filter_and_index_blocks_in_cache = true; @@ -1606,20 +1606,20 @@ TEST_P(PinL0IndexAndFilterBlocksTest, DisablePrefetchingNonL0IndexAndFilter) { // so that preloading SST files won't happen. options.max_open_files = 13; // RocksDB sanitize max open files to at least 20. Modify it back. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) { int* max_open_files = static_cast<int*>(arg); *max_open_files = 13; }); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Reopen database. If max_open_files is set as -1, table readers will be // preloaded. This will trigger a BlockBasedTable::Open() and prefetch // L0 index and filter. Level 1's prefetching is disabled in DB::Open() TryReopenWithColumnFamilies({"default", "pikachu"}, options); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); if (!disallow_preload_) { // After reopen, cache miss are increased by one because we read (and only @@ -1759,8 +1759,8 @@ static void UniqueIdCallback(void* arg) { *result = 0; } - rocksdb::SyncPoint::GetInstance()->ClearTrace(); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "GetUniqueIdFromFile:FS_IOC_GETVERSION", UniqueIdCallback); } @@ -1768,8 +1768,8 @@ class MockPersistentCache : public PersistentCache { public: explicit MockPersistentCache(const bool is_compressed, const size_t max_size) : is_compressed_(is_compressed), max_size_(max_size) { - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "GetUniqueIdFromFile:FS_IOC_GETVERSION", UniqueIdCallback); } @@ -1841,10 +1841,10 @@ TEST_F(DBTest2, TestPerfContextGetCpuTime) { uint64_t kDummyAddonTime = uint64_t{1000000000000}; // Add time to NowNanos() reading. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "TableCache::FindTable:0", [&](void* /*arg*/) { env_->addon_time_.fetch_add(kDummyAddonTime); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); SetPerfLevel(PerfLevel::kEnableTimeAndCPUTimeExceptForMutex); ASSERT_EQ("bar", Get("foo")); @@ -1853,7 +1853,7 @@ TEST_F(DBTest2, TestPerfContextGetCpuTime) { ASSERT_GT(get_perf_context()->find_table_nanos, kDummyAddonTime); SetPerfLevel(PerfLevel::kDisable); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, TestPerfContextIterCpuTime) { @@ -1903,10 +1903,10 @@ TEST_F(DBTest2, TestPerfContextIterCpuTime) { uint64_t kDummyAddonTime = uint64_t{1000000000000}; // Add time to NowNanos() reading. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "TableCache::FindTable:0", [&](void* /*arg*/) { env_->addon_time_.fetch_add(kDummyAddonTime); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); SetPerfLevel(PerfLevel::kEnableTimeAndCPUTimeExceptForMutex); iter = db_->NewIterator(ReadOptions()); @@ -1937,7 +1937,7 @@ TEST_F(DBTest2, TestPerfContextIterCpuTime) { ASSERT_GT(get_perf_context()->find_table_nanos, kDummyAddonTime); SetPerfLevel(PerfLevel::kDisable); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); delete iter; } #endif // OS_LINUX @@ -1951,7 +1951,7 @@ TEST_F(DBTest2, PersistentCache) { Options options; options.write_buffer_size = 64 * 1024; // small write buffer - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options = CurrentOptions(options); auto bsizes = {/*no block cache*/ 0, /*1M*/ 1 * 1024 * 1024}; @@ -2019,7 +2019,7 @@ void CountSyncPoint() { TEST_F(DBTest2, SyncPointMarker) { std::atomic<int> sync_point_called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBTest2::MarkedPoint", [&](void* /*arg*/) { sync_point_called.fetch_add(1); }); @@ -2031,11 +2031,11 @@ TEST_F(DBTest2, SyncPointMarker) { // | MarkedPoint | | // | Thread1First | | // | | MarkedPoint | - rocksdb::SyncPoint::GetInstance()->LoadDependencyAndMarkers( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependencyAndMarkers( {{"DBTest2::SyncPointMarker:Thread1First", "DBTest2::MarkedPoint"}}, {{"DBTest2::SyncPointMarker:Marker", "DBTest2::MarkedPoint"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::function<void()> func1 = [&]() { CountSyncPoint(); @@ -2054,7 +2054,7 @@ TEST_F(DBTest2, SyncPointMarker) { // Callback is only executed once ASSERT_EQ(sync_point_called.load(), 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } #endif @@ -2079,7 +2079,7 @@ TEST_F(DBTest2, ReadAmpBitmap) { bbto.block_cache = NewLRUCache(1024 * 1024 * 1024); bbto.read_amp_bytes_per_bit = bytes_per_bit[k]; options.table_factory.reset(NewBlockBasedTableFactory(bbto)); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); const size_t kNumEntries = 10000; @@ -2176,7 +2176,7 @@ TEST_F(DBTest2, ReadAmpBitmapLiveInCacheAfterDBClose) { uint32_t bytes_per_bit[2] = {1, 16}; for (size_t k = 0; k < 2; k++) { std::shared_ptr<Cache> lru_cache = NewLRUCache(1024 * 1024 * 1024); - std::shared_ptr<Statistics> stats = rocksdb::CreateDBStatistics(); + std::shared_ptr<Statistics> stats = ROCKSDB_NAMESPACE::CreateDBStatistics(); Options options = CurrentOptions(); BlockBasedTableOptions bbto; @@ -2223,7 +2223,8 @@ TEST_F(DBTest2, ReadAmpBitmapLiveInCacheAfterDBClose) { options.statistics->getTickerCount(READ_AMP_TOTAL_READ_BYTES); Close(); - std::shared_ptr<Statistics> new_statistics = rocksdb::CreateDBStatistics(); + std::shared_ptr<Statistics> new_statistics = + ROCKSDB_NAMESPACE::CreateDBStatistics(); // Destroy old statistics obj that the blocks in lru_cache are pointing to options.statistics.reset(); // Use the statistics object that we just created @@ -2307,7 +2308,7 @@ TEST_F(DBTest2, AutomaticCompactionOverlapManualCompaction) { // While the compaction is running, we will create 2 new files that // can fit in L2, these 2 files will be moved to L2 and overlap with // the running compaction and break the LSM consistency. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():Start", [&](void* /*arg*/) { ASSERT_OK( dbfull()->SetOptions({{"level0_file_num_compaction_trigger", "2"}, @@ -2320,7 +2321,7 @@ TEST_F(DBTest2, AutomaticCompactionOverlapManualCompaction) { ASSERT_OK(Put(Key(9), "a")); ASSERT_OK(Flush()); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Run a manual compaction that will compact the 2 files in L2 // into 1 file in L2 @@ -2328,7 +2329,7 @@ TEST_F(DBTest2, AutomaticCompactionOverlapManualCompaction) { cro.bottommost_level_compaction = BottommostLevelCompaction::kForceOptimized; ASSERT_OK(db_->CompactRange(cro, nullptr, nullptr)); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); // Test that the stats GetMapProperty API reporting 1 file in L2 { @@ -2367,13 +2368,13 @@ TEST_F(DBTest2, ManualCompactionOverlapManualCompaction) { cro.exclusive_manual_compaction = false; ASSERT_OK(db_->CompactRange(cro, &k1s, &k2s)); }; - rocksdb::port::Thread bg_thread; + ROCKSDB_NAMESPACE::port::Thread bg_thread; // While the compaction is running, we will create 2 new files that // can fit in L1, these 2 files will be moved to L1 and overlap with // the running compaction and break the LSM consistency. std::atomic<bool> flag(false); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():Start", [&](void* /*arg*/) { if (flag.exchange(true)) { // We want to make sure to call this callback only once @@ -2393,7 +2394,7 @@ TEST_F(DBTest2, ManualCompactionOverlapManualCompaction) { // so it should wait until the first compaction finish env_->SleepForMicroseconds(1000000); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Run a manual compaction that will compact the 2 files in L1 // into 1 file in L1 @@ -2403,7 +2404,7 @@ TEST_F(DBTest2, ManualCompactionOverlapManualCompaction) { ASSERT_OK(db_->CompactRange(cro, nullptr, nullptr)); bg_thread.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, PausingManualCompaction1) { @@ -2426,14 +2427,14 @@ TEST_F(DBTest2, PausingManualCompaction1) { ASSERT_OK(Flush()); int manual_compactions_paused = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():PausingManualCompaction:1", [&](void* arg) { auto paused = reinterpret_cast<std::atomic<bool>*>(arg); ASSERT_FALSE(paused->load(std::memory_order_acquire)); paused->store(true, std::memory_order_release); manual_compactions_paused += 1; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::vector<std::string> files_before_compact, files_after_compact; // Remember file name before compaction is triggered @@ -2462,7 +2463,8 @@ TEST_F(DBTest2, PausingManualCompaction1) { manual_compactions_paused = 0; // Now make sure CompactFiles also not run - dbfull()->CompactFiles(rocksdb::CompactionOptions(), files_before_compact, 0); + dbfull()->CompactFiles(ROCKSDB_NAMESPACE::CompactionOptions(), + files_before_compact, 0); // Wait for manual compaction to get scheduled and finish dbfull()->TEST_WaitForCompact(true); @@ -2477,7 +2479,7 @@ TEST_F(DBTest2, PausingManualCompaction1) { // CompactFiles returns at entry point ASSERT_EQ(manual_compactions_paused, 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } // PausingManualCompaction does not affect auto compaction @@ -2532,10 +2534,10 @@ TEST_F(DBTest2, PausingManualCompaction3) { ASSERT_EQ("2,3,4,5,6,7,8", FilesPerLevel()); #endif // !ROCKSDB_LITE int run_manual_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():PausingManualCompaction:1", [&](void* /*arg*/) { run_manual_compactions++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); dbfull()->DisableManualCompaction(); dbfull()->CompactRange(compact_options, nullptr, nullptr); @@ -2546,7 +2548,7 @@ TEST_F(DBTest2, PausingManualCompaction3) { ASSERT_EQ("2,3,4,5,6,7,8", FilesPerLevel()); #endif // !ROCKSDB_LITE - rocksdb::SyncPoint::GetInstance()->ClearCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearCallBack( "CompactionJob::Run():PausingManualCompaction:1"); dbfull()->EnableManualCompaction(); dbfull()->CompactRange(compact_options, nullptr, nullptr); @@ -2555,7 +2557,7 @@ TEST_F(DBTest2, PausingManualCompaction3) { ASSERT_EQ("0,0,0,0,0,0,2", FilesPerLevel()); #endif // !ROCKSDB_LITE - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, PausingManualCompaction4) { @@ -2586,14 +2588,14 @@ TEST_F(DBTest2, PausingManualCompaction4) { ASSERT_EQ("2,3,4,5,6,7,8", FilesPerLevel()); #endif // !ROCKSDB_LITE int run_manual_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():PausingManualCompaction:2", [&](void* arg) { auto paused = reinterpret_cast<std::atomic<bool>*>(arg); ASSERT_FALSE(paused->load(std::memory_order_acquire)); paused->store(true, std::memory_order_release); run_manual_compactions++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); dbfull()->EnableManualCompaction(); dbfull()->CompactRange(compact_options, nullptr, nullptr); @@ -2603,7 +2605,7 @@ TEST_F(DBTest2, PausingManualCompaction4) { ASSERT_EQ("2,3,4,5,6,7,8", FilesPerLevel()); #endif // !ROCKSDB_LITE - rocksdb::SyncPoint::GetInstance()->ClearCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearCallBack( "CompactionJob::Run():PausingManualCompaction:2"); dbfull()->EnableManualCompaction(); dbfull()->CompactRange(compact_options, nullptr, nullptr); @@ -2612,7 +2614,7 @@ TEST_F(DBTest2, PausingManualCompaction4) { ASSERT_EQ("0,0,0,0,0,0,2", FilesPerLevel()); #endif // !ROCKSDB_LITE - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, OptimizeForPointLookup) { @@ -2667,13 +2669,13 @@ TEST_F(DBTest2, OptimizeForSmallDB) { TEST_F(DBTest2, GetRaceFlush1) { ASSERT_OK(Put("foo", "v1")); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::GetImpl:1", "DBTest2::GetRaceFlush:1"}, {"DBTest2::GetRaceFlush:2", "DBImpl::GetImpl:2"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread t1([&] { + ROCKSDB_NAMESPACE::port::Thread t1([&] { TEST_SYNC_POINT("DBTest2::GetRaceFlush:1"); ASSERT_OK(Put("foo", "v2")); Flush(); @@ -2684,17 +2686,17 @@ TEST_F(DBTest2, GetRaceFlush1) { // "v1" or "v2". ASSERT_NE("NOT_FOUND", Get("foo")); t1.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, GetRaceFlush2) { ASSERT_OK(Put("foo", "v1")); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::GetImpl:3", "DBTest2::GetRaceFlush:1"}, {"DBTest2::GetRaceFlush:2", "DBImpl::GetImpl:4"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); port::Thread t1([&] { TEST_SYNC_POINT("DBTest2::GetRaceFlush:1"); @@ -2707,7 +2709,7 @@ TEST_F(DBTest2, GetRaceFlush2) { // "v1" or "v2". ASSERT_NE("NOT_FOUND", Get("foo")); t1.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, DirectIO) { @@ -2807,17 +2809,17 @@ TEST_F(DBTest2, LowPriWrite) { std::atomic<int> rate_limit_count(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "GenericRateLimiter::Request:1", [&](void* arg) { rate_limit_count.fetch_add(1); int64_t* rate_bytes_per_sec = static_cast<int64_t*>(arg); ASSERT_EQ(1024 * 1024, *rate_bytes_per_sec); }); // Block compaction - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBTest.LowPriWrite:0", "DBImpl::BGWorkCompaction"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); WriteOptions wo; for (int i = 0; i < 6; i++) { wo.low_pri = false; @@ -2835,7 +2837,7 @@ TEST_F(DBTest2, LowPriWrite) { ASSERT_EQ(1, rate_limit_count.load()); TEST_SYNC_POINT("DBTest.LowPriWrite:0"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); dbfull()->TEST_WaitForCompact(); wo.low_pri = true; @@ -3050,16 +3052,16 @@ TEST_F(DBTest2, LiveFilesOmitObsoleteFiles) { // Instead, if we sleep for a second between Find and Purge, and ensure the // read attempt happens after purge, then the sequence of events will almost // certainly happen on the old code. - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBImpl::BackgroundCallFlush:FilesFound", "DBTest2::LiveFilesOmitObsoleteFiles:FlushTriggered"}, {"DBImpl::PurgeObsoleteFiles:End", "DBTest2::LiveFilesOmitObsoleteFiles:LiveFilesCaptured"}, }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::PurgeObsoleteFiles:Begin", [&](void* /*arg*/) { env_->SleepForMicroseconds(1000000); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put("key", "val"); FlushOptions flush_opts; @@ -3076,7 +3078,7 @@ TEST_F(DBTest2, LiveFilesOmitObsoleteFiles) { } db_->EnableFileDeletions(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, TestNumPread) { @@ -3598,7 +3600,7 @@ TEST_F(DBTest2, PinnableSliceAndMmapReads) { TEST_F(DBTest2, DISABLED_IteratorPinnedMemory) { Options options = CurrentOptions(); options.create_if_missing = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); BlockBasedTableOptions bbto; bbto.no_block_cache = false; bbto.cache_index_and_filter_blocks = false; @@ -3665,7 +3667,7 @@ TEST_F(DBTest2, DISABLED_IteratorPinnedMemory) { std::atomic<bool> finished(false); std::atomic<int> block_newed(0); std::atomic<int> block_destroyed(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Block::Block:0", [&](void* /*arg*/) { if (finished) { return; @@ -3675,7 +3677,7 @@ TEST_F(DBTest2, DISABLED_IteratorPinnedMemory) { EXPECT_LE(block_newed.load(), block_destroyed.load() + 1); block_newed.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "Block::~Block", [&](void* /*arg*/) { if (finished) { return; @@ -3685,10 +3687,10 @@ TEST_F(DBTest2, DISABLED_IteratorPinnedMemory) { EXPECT_LE(block_newed.load(), block_destroyed.load() + 2); block_destroyed.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run:BeforeVerify", [&](void* /*arg*/) { finished = true; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(db_->CompactRange(CompactRangeOptions(), nullptr, nullptr)); @@ -3696,21 +3698,21 @@ TEST_F(DBTest2, DISABLED_IteratorPinnedMemory) { ASSERT_EQ(8, block_newed.load()); ASSERT_EQ(8, block_destroyed.load()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBTest2, TestBBTTailPrefetch) { std::atomic<bool> called(false); size_t expected_lower_bound = 512 * 1024; size_t expected_higher_bound = 512 * 1024; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "BlockBasedTable::Open::TailPrefetchLen", [&](void* arg) { size_t* prefetch_size = static_cast<size_t*>(arg); EXPECT_LE(expected_lower_bound, *prefetch_size); EXPECT_GE(expected_higher_bound, *prefetch_size); called = true; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put("1", "1"); Put("9", "1"); @@ -3733,11 +3735,11 @@ TEST_F(DBTest2, TestBBTTailPrefetch) { ASSERT_TRUE(called.load()); called = false; - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); std::atomic<bool> first_call(true); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "BlockBasedTable::Open::TailPrefetchLen", [&](void* arg) { size_t* prefetch_size = static_cast<size_t*>(arg); if (first_call) { @@ -3748,7 +3750,7 @@ TEST_F(DBTest2, TestBBTTailPrefetch) { } called = true; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.max_file_opening_threads = 1; // one thread @@ -3777,19 +3779,19 @@ TEST_F(DBTest2, TestBBTTailPrefetch) { ASSERT_TRUE(called.load()); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_F(DBTest2, TestGetColumnFamilyHandleUnlocked) { // Setup sync point dependency to reproduce the race condition of // DBImpl::GetColumnFamilyHandleUnlocked - rocksdb::SyncPoint::GetInstance()->LoadDependency( - { {"TestGetColumnFamilyHandleUnlocked::GetColumnFamilyHandleUnlocked1", - "TestGetColumnFamilyHandleUnlocked::PreGetColumnFamilyHandleUnlocked2"}, - {"TestGetColumnFamilyHandleUnlocked::GetColumnFamilyHandleUnlocked2", - "TestGetColumnFamilyHandleUnlocked::ReadColumnFamilyHandle1"}, - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ + {"TestGetColumnFamilyHandleUnlocked::GetColumnFamilyHandleUnlocked1", + "TestGetColumnFamilyHandleUnlocked::PreGetColumnFamilyHandleUnlocked2"}, + {"TestGetColumnFamilyHandleUnlocked::GetColumnFamilyHandleUnlocked2", + "TestGetColumnFamilyHandleUnlocked::ReadColumnFamilyHandle1"}, + }); SyncPoint::GetInstance()->EnableProcessing(); CreateColumnFamilies({"test1", "test2"}, Options()); @@ -3815,15 +3817,15 @@ TEST_F(DBTest2, TestGetColumnFamilyHandleUnlocked) { user_thread1.join(); user_thread2.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } #ifndef ROCKSDB_LITE TEST_F(DBTest2, TestCompactFiles) { // Setup sync point dependency to reproduce the race condition of // DBImpl::GetColumnFamilyHandleUnlocked - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"TestCompactFiles::IngestExternalFile1", "TestCompactFiles::IngestExternalFile2"}, }); @@ -3836,7 +3838,8 @@ TEST_F(DBTest2, TestCompactFiles) { auto* handle = db_->DefaultColumnFamily(); ASSERT_EQ(db_->NumberLevels(handle), 2); - rocksdb::SstFileWriter sst_file_writer{rocksdb::EnvOptions(), options}; + ROCKSDB_NAMESPACE::SstFileWriter sst_file_writer{ + ROCKSDB_NAMESPACE::EnvOptions(), options}; std::string external_file1 = dbname_ + "/test_compact_files1.sst_t"; std::string external_file2 = dbname_ + "/test_compact_files2.sst_t"; std::string external_file3 = dbname_ + "/test_compact_files3.sst_t"; @@ -3875,8 +3878,8 @@ TEST_F(DBTest2, TestCompactFiles) { user_thread1.join(); user_thread2.join(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } #endif // ROCKSDB_LITE @@ -3945,8 +3948,9 @@ class DummyOldStats : public Statistics { void measureTime(uint32_t /*histogram_type*/, uint64_t /*count*/) override { num_mt++; } - void histogramData(uint32_t /*histogram_type*/, - rocksdb::HistogramData* const /*data*/) const override {} + void histogramData( + uint32_t /*histogram_type*/, + ROCKSDB_NAMESPACE::HistogramData* const /*data*/) const override {} std::string getHistogramString(uint32_t /*type*/) const override { return ""; } @@ -4066,7 +4070,7 @@ TEST_F(DBTest2, PrefixBloomFilteredOut) { #ifndef ROCKSDB_LITE TEST_F(DBTest2, RowCacheSnapshot) { Options options = CurrentOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.row_cache = NewLRUCache(8 * 8192); DestroyAndReopen(options); @@ -4159,14 +4163,14 @@ TEST_F(DBTest2, CrashInRecoveryMultipleCF) { // Reopen and freeze the file system after the first manifest write. FaultInjectionTestEnv fit_env(options.env); options.env = &fit_env; - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( test_sync_point, [&](void* /*arg*/) { fit_env.SetFilesystemActive(false); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_NOK(TryReopenWithColumnFamilies( {kDefaultColumnFamilyName, "pikachu"}, options)); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); fit_env.SetFilesystemActive(true); // If we continue using failure ingestion Env, it will conplain something @@ -4213,7 +4217,8 @@ TEST_F(DBTest2, SeekFileRangeDeleteTail) { TEST_F(DBTest2, BackgroundPurgeTest) { Options options = CurrentOptions(); - options.write_buffer_manager = std::make_shared<rocksdb::WriteBufferManager>(1 << 20); + options.write_buffer_manager = + std::make_shared<ROCKSDB_NAMESPACE::WriteBufferManager>(1 << 20); options.avoid_unnecessary_blocking_io = true; DestroyAndReopen(options); size_t base_value = options.write_buffer_manager->memory_usage(); @@ -4672,7 +4677,7 @@ TEST_F(DBTest2, AutoPrefixMode1) { } } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS extern "C" { @@ -4683,7 +4688,7 @@ void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} #endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); diff --git a/db/db_test_util.cc b/db/db_test_util.cc index 4594ab9af..c73abde41 100644 --- a/db/db_test_util.cc +++ b/db/db_test_util.cc @@ -12,7 +12,7 @@ #include "rocksdb/env_encryption.h" #include "rocksdb/utilities/object_registry.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Special Env used to delay background operations @@ -90,9 +90,9 @@ DBTestBase::DBTestBase(const std::string path) } DBTestBase::~DBTestBase() { - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->LoadDependency({}); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({}); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); Close(); Options options; options.db_paths.emplace_back(dbname_, 0); @@ -340,9 +340,10 @@ Options DBTestBase::GetOptions( bool set_block_based_table_factory = true; #if !defined(OS_MACOSX) && !defined(OS_WIN) && !defined(OS_SOLARIS) && \ !defined(OS_AIX) - rocksdb::SyncPoint::GetInstance()->ClearCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearCallBack( "NewRandomAccessFile:O_DIRECT"); - rocksdb::SyncPoint::GetInstance()->ClearCallBack("NewWritableFile:O_DIRECT"); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearCallBack( + "NewWritableFile:O_DIRECT"); #endif bool can_allow_mmap = IsMemoryMappedAccessSupported(); @@ -400,18 +401,18 @@ Options DBTestBase::GetOptions( options.compaction_readahead_size = 2 * 1024 * 1024; #if !defined(OS_MACOSX) && !defined(OS_WIN) && !defined(OS_SOLARIS) && \ !defined(OS_AIX) && !defined(OS_OPENBSD) - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "NewWritableFile:O_DIRECT", [&](void* arg) { int* val = static_cast<int*>(arg); *val &= ~O_DIRECT; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "NewRandomAccessFile:O_DIRECT", [&](void* arg) { int* val = static_cast<int*>(arg); *val &= ~O_DIRECT; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - #endif + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); +#endif break; } #endif // ROCKSDB_LITE @@ -1560,4 +1561,4 @@ uint64_t DBTestBase::GetNumberOfSstFilesForColumnFamily( } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_test_util.h b/db/db_test_util.h index 4b36783cc..eeabea9bd 100644 --- a/db/db_test_util.h +++ b/db/db_test_util.h @@ -52,7 +52,7 @@ #include "util/string_util.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace anon { class AtomicCounter { @@ -997,4 +997,4 @@ class DBTestBase : public testing::Test { } }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/db_universal_compaction_test.cc b/db/db_universal_compaction_test.cc index e7cf9c086..61531ae16 100644 --- a/db/db_universal_compaction_test.cc +++ b/db/db_universal_compaction_test.cc @@ -13,7 +13,7 @@ #include "rocksdb/utilities/table_properties_collectors.h" #include "test_util/sync_point.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static std::string CompressibleString(Random* rnd, int len) { std::string r; @@ -178,7 +178,7 @@ TEST_P(DBTestUniversalCompaction, OptimizeFiltersForHits) { bbto.whole_key_filtering = true; options.table_factory.reset(NewBlockBasedTableFactory(bbto)); options.optimize_filters_for_hits = true; - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.memtable_factory.reset(new SpecialSkipListFactory(3)); DestroyAndReopen(options); @@ -249,7 +249,7 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionTrigger) { DestroyAndReopen(options); CreateAndReopenWithCF({"pikachu"}, options); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBTestWritableFile.GetPreallocationStatus", [&](void* arg) { ASSERT_TRUE(arg != nullptr); size_t preallocation_size = *(static_cast<size_t*>(arg)); @@ -257,7 +257,7 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionTrigger) { ASSERT_LE(preallocation_size, options.target_file_size_base * 1.1); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); int key_idx = 0; @@ -335,7 +335,7 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionTrigger) { // All files at level 0 will be compacted into a single one. ASSERT_EQ(NumSortedRuns(1), 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_P(DBTestUniversalCompaction, UniversalCompactionSizeAmplification) { @@ -395,7 +395,7 @@ TEST_P(DBTestUniversalCompaction, DynamicUniversalCompactionSizeAmplification) { int total_picked_compactions = 0; int total_size_amp_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "UniversalCompactionBuilder::PickCompaction:Return", [&](void* arg) { if (arg) { total_picked_compactions++; @@ -406,7 +406,7 @@ TEST_P(DBTestUniversalCompaction, DynamicUniversalCompactionSizeAmplification) { } } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); MutableCFOptions mutable_cf_options; CreateAndReopenWithCF({"pikachu"}, options); @@ -476,7 +476,7 @@ TEST_P(DBTestUniversalCompaction, DynamicUniversalCompactionReadAmplification) { int total_picked_compactions = 0; int total_size_ratio_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "UniversalCompactionBuilder::PickCompaction:Return", [&](void* arg) { if (arg) { total_picked_compactions++; @@ -486,7 +486,7 @@ TEST_P(DBTestUniversalCompaction, DynamicUniversalCompactionReadAmplification) { } } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); MutableCFOptions mutable_cf_options; CreateAndReopenWithCF({"pikachu"}, options); @@ -704,17 +704,17 @@ TEST_P(DBTestUniversalCompactionMultiLevels, UniversalCompactionMultiLevels) { TEST_P(DBTestUniversalCompactionMultiLevels, UniversalCompactionTrivialMove) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* arg) { non_trivial_move++; ASSERT_TRUE(arg != nullptr); int output_level = *(static_cast<int*>(arg)); ASSERT_EQ(output_level, 0); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.compaction_style = kCompactionStyleUniversal; @@ -745,7 +745,7 @@ TEST_P(DBTestUniversalCompactionMultiLevels, UniversalCompactionTrivialMove) { ASSERT_GT(trivial_move, 0); ASSERT_GT(non_trivial_move, 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } INSTANTIATE_TEST_CASE_P(MultiLevels, DBTestUniversalCompactionMultiLevels, @@ -776,24 +776,24 @@ TEST_P(DBTestUniversalCompactionParallel, UniversalCompactionParallel) { // Delay every compaction so multiple compactions will happen. std::atomic<int> num_compactions_running(0); std::atomic<bool> has_parallel(false); - rocksdb::SyncPoint::GetInstance()->SetCallBack("CompactionJob::Run():Start", - [&](void* /*arg*/) { - if (num_compactions_running.fetch_add(1) > 0) { - has_parallel.store(true); - return; - } - for (int nwait = 0; nwait < 20000; nwait++) { - if (has_parallel.load() || num_compactions_running.load() > 1) { - has_parallel.store(true); - break; - } - env_->SleepForMicroseconds(1000); - } - }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "CompactionJob::Run():Start", [&](void* /*arg*/) { + if (num_compactions_running.fetch_add(1) > 0) { + has_parallel.store(true); + return; + } + for (int nwait = 0; nwait < 20000; nwait++) { + if (has_parallel.load() || num_compactions_running.load() > 1) { + has_parallel.store(true); + break; + } + env_->SleepForMicroseconds(1000); + } + }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():End", [&](void* /*arg*/) { num_compactions_running.fetch_add(-1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); options = CurrentOptions(options); ReopenWithColumnFamilies({"default", "pikachu"}, options); @@ -805,7 +805,7 @@ TEST_P(DBTestUniversalCompactionParallel, UniversalCompactionParallel) { } dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(num_compactions_running.load(), 0); ASSERT_TRUE(has_parallel.load()); @@ -834,7 +834,7 @@ TEST_P(DBTestUniversalCompactionParallel, PickByFileNumberBug) { UINT_MAX; DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBTestUniversalCompactionParallel::PickByFileNumberBug:0", "BackgroundCallCompaction:0"}, {"UniversalCompactionBuilder::PickCompaction:Return", @@ -843,14 +843,14 @@ TEST_P(DBTestUniversalCompactionParallel, PickByFileNumberBug) { "CompactionJob::Run():Start"}}); int total_picked_compactions = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "UniversalCompactionBuilder::PickCompaction:Return", [&](void* arg) { if (arg) { total_picked_compactions++; } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Write 7 files to trigger compaction int key_idx = 1; @@ -865,7 +865,7 @@ TEST_P(DBTestUniversalCompactionParallel, PickByFileNumberBug) { // Wait for the 1st background compaction process to start TEST_SYNC_POINT("DBTestUniversalCompactionParallel::PickByFileNumberBug:0"); TEST_SYNC_POINT("DBTestUniversalCompactionParallel::PickByFileNumberBug:1"); - rocksdb::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); // Write 3 files while 1st compaction is held // These 3 files have different sizes to avoid compacting based on size_ratio @@ -889,13 +889,13 @@ TEST_P(DBTestUniversalCompactionParallel, PickByFileNumberBug) { EXPECT_EQ(TotalTableFiles(), 4); // Stop SyncPoint and destroy the DB and reopen it again - rocksdb::SyncPoint::GetInstance()->ClearTrace(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); key_idx = 1; total_picked_compactions = 0; DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Write 7 files to trigger compaction for (int i = 1; i <= 70; i++) { @@ -909,7 +909,7 @@ TEST_P(DBTestUniversalCompactionParallel, PickByFileNumberBug) { // Wait for the 1st background compaction process to start TEST_SYNC_POINT("DBTestUniversalCompactionParallel::PickByFileNumberBug:0"); TEST_SYNC_POINT("DBTestUniversalCompactionParallel::PickByFileNumberBug:1"); - rocksdb::SyncPoint::GetInstance()->ClearTrace(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace(); // Write 8 files while 1st compaction is held // These 8 files have different sizes to avoid compacting based on size_ratio @@ -1161,17 +1161,17 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionCompressRatio2) { TEST_P(DBTestUniversalCompaction, UniversalCompactionTrivialMoveTest1) { int32_t trivial_move = 0; int32_t non_trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* arg) { non_trivial_move++; ASSERT_TRUE(arg != nullptr); int output_level = *(static_cast<int*>(arg)); ASSERT_EQ(output_level, 0); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.compaction_style = kCompactionStyleUniversal; @@ -1202,22 +1202,22 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionTrivialMoveTest1) { ASSERT_GT(trivial_move, 0); ASSERT_GT(non_trivial_move, 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } // Test that checks trivial move in universal compaction TEST_P(DBTestUniversalCompaction, UniversalCompactionTrivialMoveTest2) { int32_t trivial_move = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:TrivialMove", [&](void* /*arg*/) { trivial_move++; }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:NonTrivial", [&](void* arg) { ASSERT_TRUE(arg != nullptr); int output_level = *(static_cast<int*>(arg)); ASSERT_EQ(output_level, 0); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Options options = CurrentOptions(); options.compaction_style = kCompactionStyleUniversal; @@ -1247,7 +1247,7 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionTrivialMoveTest2) { ASSERT_GT(trivial_move, 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } #endif // ROCKSDB_VALGRIND_RUN @@ -1708,7 +1708,7 @@ TEST_P(DBTestUniversalCompaction, ConcurrentBottomPriLowPriCompactions) { options.compaction_options_universal.max_size_amplification_percent = 110; DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {// wait for the full compaction to be picked before adding files intended // for the second one. {"DBImpl::BackgroundCompaction:ForwardToBottomPriPool", @@ -1741,7 +1741,7 @@ TEST_P(DBTestUniversalCompaction, ConcurrentBottomPriLowPriCompactions) { ASSERT_EQ(NumSortedRuns(), 2); ASSERT_GT(NumTableFilesAtLevel(0), 0); ASSERT_GT(NumTableFilesAtLevel(num_levels_ - 1), 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); Env::Default()->SetBackgroundThreads(0, Env::Priority::BOTTOM); } @@ -1762,11 +1762,10 @@ TEST_P(DBTestUniversalCompaction, RecalculateScoreAfterPicking) { Reopen(options); std::atomic<int> num_compactions_attempted(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::BackgroundCompaction:Start", [&](void* /*arg*/) { - ++num_compactions_attempted; - }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::BackgroundCompaction:Start", + [&](void* /*arg*/) { ++num_compactions_attempted; }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); for (int num = 0; num < kNumFilesTrigger; num++) { @@ -1815,12 +1814,12 @@ TEST_P(DBTestUniversalCompaction, FinalSortedRunCompactFilesConflict) { std::string first_sst_filename = cf_meta.levels[num_levels_ - 1].files[0].name; - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"CompactFilesImpl:0", "DBTestUniversalCompaction:FinalSortedRunCompactFilesConflict:0"}, {"DBImpl::BackgroundCompaction():AfterPickCompaction", "CompactFilesImpl:1"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); port::Thread compact_files_thread([&]() { ASSERT_OK(dbfull()->CompactFiles(CompactionOptions(), default_cfh, @@ -2189,7 +2188,7 @@ TEST_F(DBTestUniversalCompaction2, PeriodicCompaction) { int periodic_compactions = 0; int start_level = -1; int output_level = -1; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "UniversalCompactionPicker::PickPeriodicCompaction:Return", [&](void* arg) { Compaction* compaction = reinterpret_cast<Compaction*>(arg); @@ -2200,7 +2199,7 @@ TEST_F(DBTestUniversalCompaction2, PeriodicCompaction) { output_level = compaction->output_level(); periodic_compactions++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Case 1: Oldest flushed file excceeds periodic compaction threshold. ASSERT_OK(Put("foo", "bar")); @@ -2238,13 +2237,13 @@ TEST_F(DBTestUniversalCompaction2, PeriodicCompaction) { ASSERT_EQ(4, output_level); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !defined(ROCKSDB_LITE) int main(int argc, char** argv) { #if !defined(ROCKSDB_LITE) - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); #else diff --git a/db/db_wal_test.cc b/db/db_wal_test.cc index 50c6f4258..ef81de803 100644 --- a/db/db_wal_test.cc +++ b/db/db_wal_test.cc @@ -15,7 +15,7 @@ #include "test_util/fault_injection_test_env.h" #include "test_util/sync_point.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBWALTest : public DBTestBase { public: DBWALTest() : DBTestBase("/db_wal_test") {} @@ -191,15 +191,15 @@ TEST_F(DBWALTest, SyncWALNotBlockWrite) { ASSERT_OK(Put("foo1", "bar1")); ASSERT_OK(Put("foo5", "bar5")); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"WritableFileWriter::SyncWithoutFlush:1", "DBWALTest::SyncWALNotBlockWrite:1"}, {"DBWALTest::SyncWALNotBlockWrite:2", "WritableFileWriter::SyncWithoutFlush:2"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread thread([&]() { ASSERT_OK(db_->SyncWAL()); }); + ROCKSDB_NAMESPACE::port::Thread thread([&]() { ASSERT_OK(db_->SyncWAL()); }); TEST_SYNC_POINT("DBWALTest::SyncWALNotBlockWrite:1"); ASSERT_OK(Put("foo2", "bar2")); @@ -218,20 +218,21 @@ TEST_F(DBWALTest, SyncWALNotBlockWrite) { ASSERT_EQ(Get("foo3"), "bar3"); ASSERT_EQ(Get("foo4"), "bar4"); ASSERT_EQ(Get("foo5"), "bar5"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBWALTest, SyncWALNotWaitWrite) { ASSERT_OK(Put("foo1", "bar1")); ASSERT_OK(Put("foo3", "bar3")); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"SpecialEnv::WalFile::Append:1", "DBWALTest::SyncWALNotWaitWrite:1"}, {"DBWALTest::SyncWALNotWaitWrite:2", "SpecialEnv::WalFile::Append:2"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread thread([&]() { ASSERT_OK(Put("foo2", "bar2")); }); + ROCKSDB_NAMESPACE::port::Thread thread( + [&]() { ASSERT_OK(Put("foo2", "bar2")); }); // Moving this to SyncWAL before the actual fsync // TEST_SYNC_POINT("DBWALTest::SyncWALNotWaitWrite:1"); ASSERT_OK(db_->SyncWAL()); @@ -242,7 +243,7 @@ TEST_F(DBWALTest, SyncWALNotWaitWrite) { ASSERT_EQ(Get("foo1"), "bar1"); ASSERT_EQ(Get("foo2"), "bar2"); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(DBWALTest, Recover) { @@ -293,7 +294,7 @@ TEST_F(DBWALTest, RecoverWithTableHandle) { // happen. options.max_open_files = kSmallMaxOpenFiles; // RocksDB sanitize max open files to at least 20. Modify it back. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SanitizeOptions::AfterChangeMaxOpenFiles", [&](void* arg) { int* max_open_files = static_cast<int*>(arg); *max_open_files = kSmallMaxOpenFiles; @@ -305,10 +306,10 @@ TEST_F(DBWALTest, RecoverWithTableHandle) { } else { options.max_open_files = -1; } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ReopenWithColumnFamilies({"default", "pikachu"}, options); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); std::vector<std::vector<FileMetaData>> files; dbfull()->TEST_GetFilesMetaData(handles_[1], &files); @@ -443,38 +444,38 @@ TEST_F(DBWALTest, PreallocateBlock) { DestroyAndReopen(options); std::atomic<int> called(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBTestWalFile.GetPreallocationStatus", [&](void* arg) { ASSERT_TRUE(arg != nullptr); size_t preallocation_size = *(static_cast<size_t*>(arg)); ASSERT_EQ(expected_preallocation_size, preallocation_size); called.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put("", ""); Flush(); Put("", ""); Close(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(2, called.load()); options.max_total_wal_size = 1000 * 1000; expected_preallocation_size = static_cast<size_t>(options.max_total_wal_size); Reopen(options); called.store(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBTestWalFile.GetPreallocationStatus", [&](void* arg) { ASSERT_TRUE(arg != nullptr); size_t preallocation_size = *(static_cast<size_t*>(arg)); ASSERT_EQ(expected_preallocation_size, preallocation_size); called.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put("", ""); Flush(); Put("", ""); Close(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(2, called.load()); options.db_write_buffer_size = 800 * 1000; @@ -482,19 +483,19 @@ TEST_F(DBWALTest, PreallocateBlock) { static_cast<size_t>(options.db_write_buffer_size); Reopen(options); called.store(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBTestWalFile.GetPreallocationStatus", [&](void* arg) { ASSERT_TRUE(arg != nullptr); size_t preallocation_size = *(static_cast<size_t*>(arg)); ASSERT_EQ(expected_preallocation_size, preallocation_size); called.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put("", ""); Flush(); Put("", ""); Close(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(2, called.load()); expected_preallocation_size = 700 * 1000; @@ -503,19 +504,19 @@ TEST_F(DBWALTest, PreallocateBlock) { options.write_buffer_manager = write_buffer_manager; Reopen(options); called.store(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBTestWalFile.GetPreallocationStatus", [&](void* arg) { ASSERT_TRUE(arg != nullptr); size_t preallocation_size = *(static_cast<size_t*>(arg)); ASSERT_EQ(expected_preallocation_size, preallocation_size); called.fetch_add(1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put("", ""); Flush(); Put("", ""); Close(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(2, called.load()); } #endif // !(defined NDEBUG) || !defined(OS_WIN) @@ -577,19 +578,19 @@ TEST_F(DBWALTest, FullPurgePreservesLogPendingReuse) { // The second flush can recycle the first log. Sync points enforce the // full purge happens after choosing the log to recycle and before it is // renamed. - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBImpl::CreateWAL:BeforeReuseWritableFile1", "DBWALTest::FullPurgePreservesLogPendingReuse:PreFullPurge"}, {"DBWALTest::FullPurgePreservesLogPendingReuse:PostFullPurge", "DBImpl::CreateWAL:BeforeReuseWritableFile2"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); - rocksdb::port::Thread thread([&]() { - TEST_SYNC_POINT( - "DBWALTest::FullPurgePreservesLogPendingReuse:PreFullPurge"); - ASSERT_OK(db_->EnableFileDeletions(true)); - TEST_SYNC_POINT( - "DBWALTest::FullPurgePreservesLogPendingReuse:PostFullPurge"); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::port::Thread thread([&]() { + TEST_SYNC_POINT( + "DBWALTest::FullPurgePreservesLogPendingReuse:PreFullPurge"); + ASSERT_OK(db_->EnableFileDeletions(true)); + TEST_SYNC_POINT( + "DBWALTest::FullPurgePreservesLogPendingReuse:PostFullPurge"); }); ASSERT_OK(Put("foo", "bar")); ASSERT_OK(Flush()); @@ -1576,10 +1577,10 @@ TEST_F(DBWALTest, WalTermTest) { ASSERT_EQ("bar", Get(1, "foo")); ASSERT_EQ("NOT_FOUND", Get(1, "foo2")); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/db_write_test.cc b/db/db_write_test.cc index 74a8c89fa..cc1aaac08 100644 --- a/db/db_write_test.cc +++ b/db/db_write_test.cc @@ -17,7 +17,7 @@ #include "test_util/sync_point.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Test variations of WriteImpl. class DBWriteTest : public DBTestBase, public testing::WithParamInterface<int> { @@ -79,18 +79,18 @@ TEST_P(DBWriteTest, WriteThreadHangOnWriteStall) { Flush(); Put("foo" + std::to_string(thread_num.fetch_add(1)), "bar"); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "WriteThread::JoinBatchGroup:Start", unblock_main_thread_func); - rocksdb::SyncPoint::GetInstance()->LoadDependency( - {{"DBWriteTest::WriteThreadHangOnWriteStall:1", - "DBImpl::BackgroundCallFlush:start"}, - {"DBWriteTest::WriteThreadHangOnWriteStall:2", - "DBImpl::WriteImpl:BeforeLeaderEnters"}, - // Make compaction start wait for the write stall to be detected and - // implemented by a write group leader - {"DBWriteTest::WriteThreadHangOnWriteStall:3", - "BackgroundCallCompaction:0"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "WriteThread::JoinBatchGroup:Start", unblock_main_thread_func); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( + {{"DBWriteTest::WriteThreadHangOnWriteStall:1", + "DBImpl::BackgroundCallFlush:start"}, + {"DBWriteTest::WriteThreadHangOnWriteStall:2", + "DBImpl::WriteImpl:BeforeLeaderEnters"}, + // Make compaction start wait for the write stall to be detected and + // implemented by a write group leader + {"DBWriteTest::WriteThreadHangOnWriteStall:3", + "BackgroundCallCompaction:0"}}); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Schedule creation of 4th L0 file without waiting. This will seal the // memtable and then wait for a sync point before writing the file. We need @@ -279,7 +279,7 @@ TEST_P(DBWriteTest, LockWalInEffect) { TEST_P(DBWriteTest, ConcurrentlyDisabledWAL) { Options options = GetOptions(); - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); options.statistics->set_stats_level(StatsLevel::kAll); Reopen(options); std::string wal_key_prefix = "WAL_KEY_"; @@ -292,14 +292,16 @@ TEST_P(DBWriteTest, ConcurrentlyDisabledWAL) { for (int t = 0; t < 10; t++) { threads[t] = std::thread([t, wal_key_prefix, wal_value, no_wal_key_prefix, no_wal_value, this] { for(int i = 0; i < 10; i++) { - rocksdb::WriteOptions write_option_disable; - write_option_disable.disableWAL = true; - rocksdb::WriteOptions write_option_default; - std::string no_wal_key = no_wal_key_prefix + std::to_string(t) + "_" + std::to_string(i); - this->Put(no_wal_key, no_wal_value, write_option_disable); - std::string wal_key = wal_key_prefix + std::to_string(i) + "_" + std::to_string(i); - this->Put(wal_key, wal_value, write_option_default); - dbfull()->SyncWAL(); + ROCKSDB_NAMESPACE::WriteOptions write_option_disable; + write_option_disable.disableWAL = true; + ROCKSDB_NAMESPACE::WriteOptions write_option_default; + std::string no_wal_key = no_wal_key_prefix + std::to_string(t) + + "_" + std::to_string(i); + this->Put(no_wal_key, no_wal_value, write_option_disable); + std::string wal_key = + wal_key_prefix + std::to_string(i) + "_" + std::to_string(i); + this->Put(wal_key, wal_value, write_option_default); + dbfull()->SyncWAL(); } return 0; }); @@ -307,7 +309,8 @@ TEST_P(DBWriteTest, ConcurrentlyDisabledWAL) { for (auto& t: threads) { t.join(); } - uint64_t bytes_num = options.statistics->getTickerCount(rocksdb::Tickers::WAL_FILE_BYTES); + uint64_t bytes_num = options.statistics->getTickerCount( + ROCKSDB_NAMESPACE::Tickers::WAL_FILE_BYTES); // written WAL size should less than 100KB (even included HEADER & FOOTER overhead) ASSERT_LE(bytes_num, 1024 * 100); } @@ -317,10 +320,10 @@ INSTANTIATE_TEST_CASE_P(DBWriteTestInstance, DBWriteTest, DBTestBase::kConcurrentWALWrites, DBTestBase::kPipelinedWrite)); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/dbformat.cc b/db/dbformat.cc index a20e2a02d..e10af2b85 100644 --- a/db/dbformat.cc +++ b/db/dbformat.cc @@ -15,7 +15,7 @@ #include "util/coding.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // kValueTypeForSeek defines the ValueType that should be passed when // constructing a ParsedInternalKey object for seeking to a particular @@ -194,4 +194,4 @@ void IterKey::EnlargeBuffer(size_t key_size) { buf_ = new char[key_size]; buf_size_ = key_size; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/dbformat.h b/db/dbformat.h index 090d8c133..de98be8df 100644 --- a/db/dbformat.h +++ b/db/dbformat.h @@ -26,7 +26,7 @@ #include "util/coding.h" #include "util/user_comparator_wrapper.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // The file declares data structures and functions that deal with internal // keys. @@ -668,4 +668,4 @@ struct ParsedInternalKeyComparator { const InternalKeyComparator* cmp; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/dbformat_test.cc b/db/dbformat_test.cc index 9ec1bc343..a2c67795a 100644 --- a/db/dbformat_test.cc +++ b/db/dbformat_test.cc @@ -11,7 +11,7 @@ #include "logging/logging.h" #include "test_util/testharness.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static std::string IKey(const std::string& user_key, uint64_t seq, @@ -199,7 +199,7 @@ TEST_F(FormatTest, RangeTombstoneSerializeEndKey) { ASSERT_LT(cmp.Compare(t.SerializeEndKey(), k), 0); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/deletefile_test.cc b/db/deletefile_test.cc index db6f945a7..f202388c0 100644 --- a/db/deletefile_test.cc +++ b/db/deletefile_test.cc @@ -27,7 +27,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DeleteFileTest : public DBTestBase { public: @@ -388,13 +388,13 @@ TEST_F(DeleteFileTest, BackgroundPurgeTestMultipleJobs) { // 5 sst files after 2 compactions with 2 live iterators CheckFileTypeCounts(dbname_, 0, 5, 1); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); // ~DBImpl should wait until all BGWorkPurge are finished - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::~DBImpl:WaitJob", "DBImpl::BGWorkPurge"}, {"DeleteFileTest::GuardFinish", "DeleteFileTest::BackgroundPurgeTestMultipleJobs:DBClose"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); delete itr1; env_->Schedule(&DeleteFileTest::DoSleep, this, Env::Priority::HIGH); @@ -542,7 +542,7 @@ TEST_F(DeleteFileTest, DeleteNonDefaultColumnFamily) { } } -} //namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS extern "C" { @@ -553,7 +553,7 @@ void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} #endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); diff --git a/db/error_handler.cc b/db/error_handler.cc index 317f00723..3ba4d9fd9 100644 --- a/db/error_handler.cc +++ b/db/error_handler.cc @@ -8,7 +8,7 @@ #include "db/event_helpers.h" #include "file/sst_file_manager_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Maps to help decide the severity of an error based on the // BackgroundErrorReason, Code, SubCode and whether db_options.paranoid_checks @@ -341,4 +341,4 @@ Status ErrorHandler::RecoverFromBGError(bool is_manual) { return bg_error_; #endif } -} +} // namespace ROCKSDB_NAMESPACE diff --git a/db/error_handler.h b/db/error_handler.h index c2af809fc..7276f6510 100644 --- a/db/error_handler.h +++ b/db/error_handler.h @@ -9,7 +9,7 @@ #include "rocksdb/listener.h" #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBImpl; @@ -72,4 +72,4 @@ class ErrorHandler { void RecoverFromNoSpace(); }; -} +} // namespace ROCKSDB_NAMESPACE diff --git a/db/error_handler_test.cc b/db/error_handler_test.cc index cbbd33efc..b9d78490c 100644 --- a/db/error_handler_test.cc +++ b/db/error_handler_test.cc @@ -17,7 +17,7 @@ #include "test_util/sync_point.h" #endif -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBErrorHandlingTest : public DBTestBase { public: @@ -165,7 +165,7 @@ TEST_F(DBErrorHandlingTest, FLushWriteError) { }); SyncPoint::GetInstance()->EnableProcessing(); s = Flush(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); SyncPoint::GetInstance()->DisableProcessing(); fault_env->SetFilesystemActive(true); s = dbfull()->Resume(); @@ -201,7 +201,7 @@ TEST_F(DBErrorHandlingTest, ManifestWriteError) { }); SyncPoint::GetInstance()->EnableProcessing(); s = Flush(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); SyncPoint::GetInstance()->ClearAllCallBacks(); SyncPoint::GetInstance()->DisableProcessing(); fault_env->SetFilesystemActive(true); @@ -242,12 +242,12 @@ TEST_F(DBErrorHandlingTest, DoubleManifestWriteError) { }); SyncPoint::GetInstance()->EnableProcessing(); s = Flush(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); fault_env->SetFilesystemActive(true); // This Resume() will attempt to create a new manifest file and fail again s = dbfull()->Resume(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); fault_env->SetFilesystemActive(true); SyncPoint::GetInstance()->ClearAllCallBacks(); SyncPoint::GetInstance()->DisableProcessing(); @@ -286,32 +286,29 @@ TEST_F(DBErrorHandlingTest, CompactionManifestWriteError) { s = Flush(); ASSERT_EQ(s, Status::OK()); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( // Wait for flush of 2nd L0 file before starting compaction {{"DBImpl::FlushMemTable:FlushMemTableFinished", "BackgroundCallCompaction:0"}, - // Wait for compaction to detect manifest write error - {"BackgroundCallCompaction:1", - "CompactionManifestWriteError:0"}, - // Make compaction thread wait for error to be cleared + // Wait for compaction to detect manifest write error + {"BackgroundCallCompaction:1", "CompactionManifestWriteError:0"}, + // Make compaction thread wait for error to be cleared {"CompactionManifestWriteError:1", "DBImpl::BackgroundCallCompaction:FoundObsoleteFiles"}, - // Wait for DB instance to clear bg_error before calling - // TEST_WaitForCompact - {"SstFileManagerImpl::ErrorCleared", - "CompactionManifestWriteError:2"}}); + // Wait for DB instance to clear bg_error before calling + // TEST_WaitForCompact + {"SstFileManagerImpl::ErrorCleared", "CompactionManifestWriteError:2"}}); // trigger manifest write failure in compaction thread - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "BackgroundCallCompaction:0", [&](void *) { - fail_manifest.store(true); - }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "VersionSet::LogAndApply:WriteManifest", [&](void *) { - if (fail_manifest.load()) { - fault_env->SetFilesystemActive(false, Status::NoSpace("Out of space")); - } + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "BackgroundCallCompaction:0", [&](void*) { fail_manifest.store(true); }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "VersionSet::LogAndApply:WriteManifest", [&](void*) { + if (fail_manifest.load()) { + fault_env->SetFilesystemActive(false, + Status::NoSpace("Out of space")); + } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put(Key(1), "val"); // This Flush will trigger a compaction, which will fail when appending to @@ -322,12 +319,12 @@ TEST_F(DBErrorHandlingTest, CompactionManifestWriteError) { TEST_SYNC_POINT("CompactionManifestWriteError:0"); // Clear all errors so when the compaction is retried, it will succeed fault_env->SetFilesystemActive(true); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); TEST_SYNC_POINT("CompactionManifestWriteError:1"); TEST_SYNC_POINT("CompactionManifestWriteError:2"); s = dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ASSERT_EQ(s, Status::OK()); new_manifest = GetManifestNameFromLiveFiles(); @@ -360,21 +357,21 @@ TEST_F(DBErrorHandlingTest, CompactionWriteError) { Status(Status::NoSpace(), Status::Severity::kHardError) ); listener->EnableAutoRecovery(false); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::FlushMemTable:FlushMemTableFinished", "BackgroundCallCompaction:0"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "BackgroundCallCompaction:0", [&](void *) { - fault_env->SetFilesystemActive(false, Status::NoSpace("Out of space")); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "BackgroundCallCompaction:0", [&](void*) { + fault_env->SetFilesystemActive(false, Status::NoSpace("Out of space")); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put(Key(1), "val"); s = Flush(); ASSERT_EQ(s, Status::OK()); s = dbfull()->TEST_WaitForCompact(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); fault_env->SetFilesystemActive(true); s = dbfull()->Resume(); @@ -397,21 +394,22 @@ TEST_F(DBErrorHandlingTest, CorruptionError) { s = Flush(); ASSERT_EQ(s, Status::OK()); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::FlushMemTable:FlushMemTableFinished", "BackgroundCallCompaction:0"}}); - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "BackgroundCallCompaction:0", [&](void *) { - fault_env->SetFilesystemActive(false, Status::Corruption("Corruption")); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "BackgroundCallCompaction:0", [&](void*) { + fault_env->SetFilesystemActive(false, Status::Corruption("Corruption")); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Put(Key(1), "val"); s = Flush(); ASSERT_EQ(s, Status::OK()); s = dbfull()->TEST_WaitForCompact(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kUnrecoverableError); + ASSERT_EQ(s.severity(), + ROCKSDB_NAMESPACE::Status::Severity::kUnrecoverableError); fault_env->SetFilesystemActive(true); s = dbfull()->Resume(); @@ -438,7 +436,7 @@ TEST_F(DBErrorHandlingTest, AutoRecoverFlushError) { }); SyncPoint::GetInstance()->EnableProcessing(); s = Flush(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); SyncPoint::GetInstance()->DisableProcessing(); fault_env->SetFilesystemActive(true); ASSERT_EQ(listener->WaitForRecovery(5000000), true); @@ -471,7 +469,7 @@ TEST_F(DBErrorHandlingTest, FailRecoverFlushError) { }); SyncPoint::GetInstance()->EnableProcessing(); s = Flush(); - ASSERT_EQ(s.severity(), rocksdb::Status::Severity::kHardError); + ASSERT_EQ(s.severity(), ROCKSDB_NAMESPACE::Status::Severity::kHardError); // We should be able to shutdown the database while auto recovery is going // on in the background Close(); @@ -854,10 +852,10 @@ TEST_F(DBErrorHandlingTest, MultiDBVariousErrors) { delete def_env; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/event_helpers.cc b/db/event_helpers.cc index f5345c755..57aa711fc 100644 --- a/db/event_helpers.cc +++ b/db/event_helpers.cc @@ -5,7 +5,7 @@ #include "db/event_helpers.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { template <class T> @@ -220,4 +220,4 @@ void EventHelpers::NotifyOnErrorRecoveryCompleted( #endif // ROCKSDB_LITE } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/event_helpers.h b/db/event_helpers.h index 820eb09be..87cc1cb8c 100644 --- a/db/event_helpers.h +++ b/db/event_helpers.h @@ -14,7 +14,7 @@ #include "rocksdb/listener.h" #include "rocksdb/table_properties.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class EventHelpers { public: @@ -52,4 +52,4 @@ class EventHelpers { const FileDescriptor& fd, const TableFileCreationInfo& info); }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/experimental.cc b/db/experimental.cc index 0c3c3335d..d12882c8f 100644 --- a/db/experimental.cc +++ b/db/experimental.cc @@ -7,7 +7,7 @@ #include "db/db_impl/db_impl.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace experimental { #ifndef ROCKSDB_LITE @@ -47,4 +47,4 @@ Status SuggestCompactRange(DB* db, const Slice* begin, const Slice* end) { } } // namespace experimental -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/external_sst_file_basic_test.cc b/db/external_sst_file_basic_test.cc index 43a003a85..b184df20e 100644 --- a/db/external_sst_file_basic_test.cc +++ b/db/external_sst_file_basic_test.cc @@ -12,7 +12,7 @@ #include "test_util/fault_injection_test_env.h" #include "test_util/testutil.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE class ExternalSSTFileBasicTest @@ -657,12 +657,12 @@ TEST_F(ExternalSSTFileBasicTest, FadviseTrigger) { const int kNumKeys = 10000; size_t total_fadvised_bytes = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "SstFileWriter::Rep::InvalidatePageCache", [&](void* arg) { size_t fadvise_size = *(reinterpret_cast<size_t*>(arg)); total_fadvised_bytes += fadvise_size; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); std::unique_ptr<SstFileWriter> sst_file_writer; @@ -689,7 +689,7 @@ TEST_F(ExternalSSTFileBasicTest, FadviseTrigger) { ASSERT_EQ(total_fadvised_bytes, sst_file_writer->FileSize()); ASSERT_GT(total_fadvised_bytes, 0); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(ExternalSSTFileBasicTest, SyncFailure) { @@ -1119,10 +1119,10 @@ INSTANTIATE_TEST_CASE_P(ExternalSSTFileBasicTest, ExternalSSTFileBasicTest, #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/external_sst_file_ingestion_job.cc b/db/external_sst_file_ingestion_job.cc index f703b9d9c..4cec5d376 100644 --- a/db/external_sst_file_ingestion_job.cc +++ b/db/external_sst_file_ingestion_job.cc @@ -24,7 +24,7 @@ #include "test_util/sync_point.h" #include "util/stop_watch.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { Status ExternalSstFileIngestionJob::Prepare( const std::vector<std::string>& external_files_paths, @@ -726,6 +726,6 @@ Status ExternalSstFileIngestionJob::SyncIngestedFile(TWritableFile* file) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/external_sst_file_ingestion_job.h b/db/external_sst_file_ingestion_job.h index f6733218d..7ddb6f3e8 100644 --- a/db/external_sst_file_ingestion_job.h +++ b/db/external_sst_file_ingestion_job.h @@ -19,7 +19,7 @@ #include "rocksdb/sst_file_writer.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Directories; @@ -177,4 +177,4 @@ class ExternalSstFileIngestionJob { bool files_overlap_{false}; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/external_sst_file_test.cc b/db/external_sst_file_test.cc index c949f2258..0b91910a1 100644 --- a/db/external_sst_file_test.cc +++ b/db/external_sst_file_test.cc @@ -14,7 +14,7 @@ #include "test_util/fault_injection_test_env.h" #include "test_util/testutil.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // A test environment that can be configured to fail the Link operation. class ExternalSSTTestEnv : public EnvWrapper { @@ -889,7 +889,7 @@ TEST_F(ExternalSSTFileTest, PurgeObsoleteFilesBug) { options.disable_auto_compactions = true; DestroyAndReopen(options); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ExternalSstFileIngestionJob::Prepare:FileAdded", [&](void* /* arg */) { ASSERT_OK(Put("aaa", "bbb")); ASSERT_OK(Flush()); @@ -897,7 +897,7 @@ TEST_F(ExternalSSTFileTest, PurgeObsoleteFilesBug) { ASSERT_OK(Flush()); db_->CompactRange(CompactRangeOptions(), nullptr, nullptr); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); s = DeprecatedAddFile({sst_file_path}); ASSERT_OK(s); @@ -908,7 +908,7 @@ TEST_F(ExternalSSTFileTest, PurgeObsoleteFilesBug) { ASSERT_EQ(Get(k), v); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(ExternalSSTFileTest, SkipSnapshot) { @@ -1099,25 +1099,25 @@ TEST_F(ExternalSSTFileTest, MultiThreaded) { TEST_F(ExternalSSTFileTest, OverlappingRanges) { Random rnd(301); SequenceNumber assigned_seqno = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "ExternalSstFileIngestionJob::Run", [&assigned_seqno](void* arg) { - ASSERT_TRUE(arg != nullptr); - assigned_seqno = *(static_cast<SequenceNumber*>(arg)); - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "ExternalSstFileIngestionJob::Run", [&assigned_seqno](void* arg) { + ASSERT_TRUE(arg != nullptr); + assigned_seqno = *(static_cast<SequenceNumber*>(arg)); + }); bool need_flush = false; - rocksdb::SyncPoint::GetInstance()->SetCallBack( - "DBImpl::IngestExternalFile:NeedFlush", [&need_flush](void* arg) { - ASSERT_TRUE(arg != nullptr); - need_flush = *(static_cast<bool*>(arg)); - }); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( + "DBImpl::IngestExternalFile:NeedFlush", [&need_flush](void* arg) { + ASSERT_TRUE(arg != nullptr); + need_flush = *(static_cast<bool*>(arg)); + }); bool overlap_with_db = false; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ExternalSstFileIngestionJob::AssignLevelAndSeqnoForIngestedFile", [&overlap_with_db](void* arg) { ASSERT_TRUE(arg != nullptr); overlap_with_db = *(static_cast<bool*>(arg)); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); do { Options options = CurrentOptions(); DestroyAndReopen(options); @@ -1246,14 +1246,14 @@ TEST_P(ExternalSSTFileTest, PickedLevel) { false, false, &true_data)); EXPECT_EQ(FilesPerLevel(), "0,0,1,1"); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"ExternalSSTFileTest::PickedLevel:0", "BackgroundCallCompaction:0"}, {"DBImpl::BackgroundCompaction:Start", "ExternalSSTFileTest::PickedLevel:1"}, {"ExternalSSTFileTest::PickedLevel:2", "DBImpl::BackgroundCompaction:NonTrivial:AfterRun"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Flush 4 files containing the same keys for (int i = 0; i < 4; i++) { @@ -1290,7 +1290,7 @@ TEST_P(ExternalSSTFileTest, PickedLevel) { size_t kcnt = 0; VerifyDBFromMap(true_data, &kcnt, false); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(ExternalSSTFileTest, PickedLevelBug) { @@ -1319,7 +1319,7 @@ TEST_F(ExternalSSTFileTest, PickedLevelBug) { // We have 2 overlapping files in L0 EXPECT_EQ(FilesPerLevel(), "2"); - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::AddFile:MutexLock", "ExternalSSTFileTest::PickedLevelBug:0"}, {"ExternalSSTFileTest::PickedLevelBug:1", "DBImpl::AddFile:MutexUnlock"}, {"ExternalSSTFileTest::PickedLevelBug:2", @@ -1328,20 +1328,20 @@ TEST_F(ExternalSSTFileTest, PickedLevelBug) { "DBImpl::RunManualCompaction:1"}}); std::atomic<bool> bg_compact_started(false); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BackgroundCompaction:Start", [&](void* /*arg*/) { bg_compact_started.store(true); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // While writing the MANIFEST start a thread that will ask for compaction - rocksdb::port::Thread bg_compact([&]() { + ROCKSDB_NAMESPACE::port::Thread bg_compact([&]() { ASSERT_OK(db_->CompactRange(CompactRangeOptions(), nullptr, nullptr)); }); TEST_SYNC_POINT("ExternalSSTFileTest::PickedLevelBug:2"); // Start a thread that will ingest a new file - rocksdb::port::Thread bg_addfile([&]() { + ROCKSDB_NAMESPACE::port::Thread bg_addfile([&]() { file_keys = {1, 2, 3}; ASSERT_OK(GenerateAndAddExternalFile(options, file_keys, 1)); }); @@ -1376,7 +1376,7 @@ TEST_F(ExternalSSTFileTest, PickedLevelBug) { delete iter; - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(ExternalSSTFileTest, IngestNonExistingFile) { @@ -1479,7 +1479,7 @@ TEST_F(ExternalSSTFileTest, PickedLevelDynamic) { DestroyAndReopen(options); std::map<std::string, std::string> true_data; - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"ExternalSSTFileTest::PickedLevelDynamic:0", "BackgroundCallCompaction:0"}, {"DBImpl::BackgroundCompaction:Start", @@ -1487,7 +1487,7 @@ TEST_F(ExternalSSTFileTest, PickedLevelDynamic) { {"ExternalSSTFileTest::PickedLevelDynamic:2", "DBImpl::BackgroundCompaction:NonTrivial:AfterRun"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Flush 4 files containing the same keys for (int i = 0; i < 4; i++) { @@ -1571,7 +1571,7 @@ TEST_F(ExternalSSTFileTest, PickedLevelDynamic) { VerifyDBFromMap(true_data, &kcnt, false); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(ExternalSSTFileTest, AddExternalSstFileWithCustomCompartor) { @@ -1645,7 +1645,7 @@ TEST_F(ExternalSSTFileTest, AddFileTrivialMoveBug) { ASSERT_OK(GenerateAndAddExternalFile(options, {20, 24}, 5)); // L3 ASSERT_OK(GenerateAndAddExternalFile(options, {22, 23}, 6)); // L2 - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "CompactionJob::Run():Start", [&](void* /*arg*/) { // fit in L3 but will overlap with compaction so will be added // to L2 but a compaction will trivially move it to L3 @@ -1657,7 +1657,7 @@ TEST_F(ExternalSSTFileTest, AddFileTrivialMoveBug) { ASSERT_OK(GenerateAndAddExternalFile(options, {15, 16}, 7)); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); CompactRangeOptions cro; cro.exclusive_manual_compaction = false; @@ -1665,7 +1665,7 @@ TEST_F(ExternalSSTFileTest, AddFileTrivialMoveBug) { dbfull()->TEST_WaitForCompact(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } TEST_F(ExternalSSTFileTest, CompactAddedFiles) { @@ -1948,16 +1948,16 @@ TEST_F(ExternalSSTFileTest, CompactionDeadlock) { // atomic conter of currently running bg threads std::atomic<int> running_threads(0); - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"DBImpl::DelayWrite:Wait", "ExternalSSTFileTest::DeadLock:0"}, {"ExternalSSTFileTest::DeadLock:1", "DBImpl::AddFile:Start"}, {"DBImpl::AddFile:MutexLock", "ExternalSSTFileTest::DeadLock:2"}, {"ExternalSSTFileTest::DeadLock:3", "BackgroundCallCompaction:0"}, }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // Start ingesting and extrnal file in the background - rocksdb::port::Thread bg_ingest_file([&]() { + ROCKSDB_NAMESPACE::port::Thread bg_ingest_file([&]() { running_threads += 1; ASSERT_OK(GenerateAndAddExternalFile(options, {5, 6})); running_threads -= 1; @@ -1977,7 +1977,7 @@ TEST_F(ExternalSSTFileTest, CompactionDeadlock) { // This thread will try to insert into the memtable but since we have 4 L0 // files this thread will be blocked and hold the writer thread - rocksdb::port::Thread bg_block_put([&]() { + ROCKSDB_NAMESPACE::port::Thread bg_block_put([&]() { running_threads += 1; ASSERT_OK(Put(Key(10), "memtable")); running_threads -= 1; @@ -2115,10 +2115,10 @@ TEST_P(ExternSSTFileLinkFailFallbackTest, LinkFailFallBackExternalSst) { ASSERT_OK(env_->GetFileSize(file_path, &file_size)); bool copyfile = false; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "ExternalSstFileIngestionJob::Prepare:CopyFile", [&](void* /* arg */) { copyfile = true; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); const Status s = db_->IngestExternalFile({file_path}, ifo); @@ -2156,7 +2156,7 @@ TEST_P(ExternSSTFileLinkFailFallbackTest, LinkFailFallBackExternalSst) { ASSERT_EQ(0, bytes_copied); } } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } class TestIngestExternalFileListener : public EventListener { @@ -2324,7 +2324,7 @@ TEST_F(ExternalSSTFileTest, SkipBloomFilter) { // Create external SST file and include bloom filters - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); { std::string file_path = sst_files_dir_ + "sst_with_bloom.sst"; @@ -2342,7 +2342,7 @@ TEST_F(ExternalSSTFileTest, SkipBloomFilter) { } // Create external SST file but skip bloom filters - options.statistics = rocksdb::CreateDBStatistics(); + options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); DestroyAndReopen(options); { std::string file_path = sst_files_dir_ + "sst_with_no_bloom.sst"; @@ -2375,10 +2375,10 @@ TEST_F(ExternalSSTFileTest, IngestFileWrittenWithCompressionDictionary) { DestroyAndReopen(options); std::atomic<int> num_compression_dicts(0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "BlockBasedTableBuilder::WriteCompressionDictBlock:RawDict", [&](void* /* arg */) { ++num_compression_dicts; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); Random rnd(301); std::vector<std::pair<std::string, std::string>> random_data; @@ -2811,10 +2811,10 @@ INSTANTIATE_TEST_CASE_P(ExternSSTFileLinkFailFallbackTest, std::make_tuple(true, true), std::make_tuple(false, false))); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/fault_injection_test.cc b/db/fault_injection_test.cc index 1d18569f2..f4ca3458a 100644 --- a/db/fault_injection_test.cc +++ b/db/fault_injection_test.cc @@ -28,7 +28,7 @@ #include "test_util/testutil.h" #include "util/mutexlock.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static const int kValueSize = 1000; static const int kMaxNumValues = 2000; @@ -84,8 +84,8 @@ class FaultInjectionTest db_(nullptr) {} ~FaultInjectionTest() override { - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } bool ChangeOptions() { @@ -436,14 +436,14 @@ TEST_P(FaultInjectionTest, UninstalledCompaction) { OpenDB(); if (!sequential_order_) { - rocksdb::SyncPoint::GetInstance()->LoadDependency({ + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency({ {"FaultInjectionTest::FaultTest:0", "DBImpl::BGWorkCompaction"}, {"CompactionJob::Run():End", "FaultInjectionTest::FaultTest:1"}, {"FaultInjectionTest::FaultTest:2", "DBImpl::BackgroundCompaction:NonTrivial:AfterRun"}, }); } - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); int kNumKeys = 1000; Build(WriteOptions(), 0, kNumKeys); @@ -456,22 +456,22 @@ TEST_P(FaultInjectionTest, UninstalledCompaction) { env_->SetFilesystemActive(false); TEST_SYNC_POINT("FaultInjectionTest::FaultTest:2"); CloseDB(); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ResetDBState(kResetDropUnsyncedData); std::atomic<bool> opened(false); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::Open:Opened", [&](void* /*arg*/) { opened.store(true); }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "DBImpl::BGWorkCompaction", [&](void* /*arg*/) { ASSERT_TRUE(opened.load()); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_OK(OpenDB()); ASSERT_OK(Verify(0, kNumKeys, FaultInjectionTest::kValExpectFound)); WaitCompactionFinish(); ASSERT_OK(Verify(0, kNumKeys, FaultInjectionTest::kValExpectFound)); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); - rocksdb::SyncPoint::GetInstance()->ClearAllCallBacks(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks(); } TEST_P(FaultInjectionTest, ManualLogSyncTest) { @@ -547,7 +547,7 @@ INSTANTIATE_TEST_CASE_P( std::make_tuple(false, kSyncWal, kEnd), std::make_tuple(true, kSyncWal, kEnd))); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/file_indexer.cc b/db/file_indexer.cc index fd0180992..523cb3c16 100644 --- a/db/file_indexer.cc +++ b/db/file_indexer.cc @@ -13,7 +13,7 @@ #include "db/version_edit.h" #include "rocksdb/comparator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { FileIndexer::FileIndexer(const Comparator* ucmp) : num_levels_(0), ucmp_(ucmp), level_rb_(nullptr) {} @@ -213,4 +213,4 @@ void FileIndexer::CalculateRB( } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/file_indexer.h b/db/file_indexer.h index 2091f8029..ad7553f2c 100644 --- a/db/file_indexer.h +++ b/db/file_indexer.h @@ -16,7 +16,7 @@ #include "port/port.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Comparator; struct FileMetaData; @@ -60,7 +60,7 @@ class FileIndexer { enum { // MSVC version 1800 still does not have constexpr for ::max() - kLevelMaxIndex = rocksdb::port::kMaxInt32 + kLevelMaxIndex = ROCKSDB_NAMESPACE::port::kMaxInt32 }; private: @@ -139,4 +139,4 @@ class FileIndexer { int32_t* level_rb_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/file_indexer_test.cc b/db/file_indexer_test.cc index 6942aa682..99ce93993 100644 --- a/db/file_indexer_test.cc +++ b/db/file_indexer_test.cc @@ -16,7 +16,7 @@ #include "test_util/testharness.h" #include "test_util/testutil.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class IntComparator : public Comparator { public: @@ -341,10 +341,10 @@ TEST_F(FileIndexerTest, mixed) { ClearFiles(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/filename_test.cc b/db/filename_test.cc index bc52e0eae..9a04542f6 100644 --- a/db/filename_test.cc +++ b/db/filename_test.cc @@ -14,7 +14,7 @@ #include "port/port.h" #include "test_util/testharness.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class FileNameTest : public testing::Test {}; @@ -172,7 +172,7 @@ TEST_F(FileNameTest, Construction) { ASSERT_EQ(kMetaDatabase, type); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/flush_job.cc b/db/flush_job.cc index 40dd82585..416715a33 100644 --- a/db/flush_job.cc +++ b/db/flush_job.cc @@ -49,7 +49,7 @@ #include "util/mutexlock.h" #include "util/stop_watch.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { const char* GetFlushReasonString (FlushReason flush_reason) { switch (flush_reason) { @@ -459,4 +459,4 @@ std::unique_ptr<FlushJobInfo> FlushJob::GetFlushJobInfo() const { } #endif // !ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/flush_job.h b/db/flush_job.h index 52161d261..1f4435f4c 100644 --- a/db/flush_job.h +++ b/db/flush_job.h @@ -43,7 +43,7 @@ #include "util/stop_watch.h" #include "util/thread_local.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBImpl; class MemTable; @@ -155,4 +155,4 @@ class FlushJob { Env::Priority thread_pri_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/flush_job_test.cc b/db/flush_job_test.cc index 6c53d2135..b77a4a2a9 100644 --- a/db/flush_job_test.cc +++ b/db/flush_job_test.cc @@ -21,7 +21,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // TODO(icanadi) Mock out everything else: // 1. VersionSet @@ -42,7 +42,7 @@ class FlushJobTest : public testing::Test { EXPECT_OK(env_->CreateDirIfMissing(dbname_)); db_options_.db_paths.emplace_back(dbname_, std::numeric_limits<uint64_t>::max()); - db_options_.statistics = rocksdb::CreateDBStatistics(); + db_options_.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics(); // TODO(icanadi) Remove this once we mock out VersionSet NewDB(); std::vector<ColumnFamilyDescriptor> column_families; @@ -490,7 +490,7 @@ TEST_F(FlushJobTest, Snapshots) { job_context.Clean(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/flush_scheduler.cc b/db/flush_scheduler.cc index e40366408..6f4d3e1a5 100644 --- a/db/flush_scheduler.cc +++ b/db/flush_scheduler.cc @@ -9,7 +9,7 @@ #include "db/column_family.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { void FlushScheduler::ScheduleWork(ColumnFamilyData* cfd) { #ifndef NDEBUG @@ -83,4 +83,4 @@ void FlushScheduler::Clear() { assert(head_.load(std::memory_order_relaxed) == nullptr); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/flush_scheduler.h b/db/flush_scheduler.h index 5ca85e88b..cbe17994f 100644 --- a/db/flush_scheduler.h +++ b/db/flush_scheduler.h @@ -11,7 +11,7 @@ #include <set> #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class ColumnFamilyData; @@ -51,4 +51,4 @@ class FlushScheduler { #endif // NDEBUG }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/forward_iterator.cc b/db/forward_iterator.cc index ae039db03..f2b882549 100644 --- a/db/forward_iterator.cc +++ b/db/forward_iterator.cc @@ -24,7 +24,7 @@ #include "test_util/sync_point.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Usage: // ForwardLevelIterator iter; @@ -970,6 +970,6 @@ void ForwardIterator::DeleteIterator(InternalIterator* iter, bool is_arena) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/forward_iterator.h b/db/forward_iterator.h index fb73f458e..8c671c75f 100644 --- a/db/forward_iterator.h +++ b/db/forward_iterator.h @@ -17,7 +17,7 @@ #include "rocksdb/options.h" #include "table/internal_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBImpl; class Env; @@ -156,5 +156,5 @@ class ForwardIterator : public InternalIterator { Arena arena_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/forward_iterator_bench.cc b/db/forward_iterator_bench.cc index 174a258a6..6f1223537 100644 --- a/db/forward_iterator_bench.cc +++ b/db/forward_iterator_bench.cc @@ -79,16 +79,17 @@ struct ShardState { Reader* reader; char pad2[128] __attribute__((__unused__)); std::atomic<uint64_t> last_read{0}; - std::unique_ptr<rocksdb::Iterator> it; - std::unique_ptr<rocksdb::Iterator> it_cacheonly; + std::unique_ptr<ROCKSDB_NAMESPACE::Iterator> it; + std::unique_ptr<ROCKSDB_NAMESPACE::Iterator> it_cacheonly; Key upper_bound; - rocksdb::Slice upper_bound_slice; + ROCKSDB_NAMESPACE::Slice upper_bound_slice; char pad3[128] __attribute__((__unused__)); }; struct Reader { public: - explicit Reader(std::vector<ShardState>* shard_states, rocksdb::DB* db) + explicit Reader(std::vector<ShardState>* shard_states, + ROCKSDB_NAMESPACE::DB* db) : shard_states_(shard_states), db_(db) { sem_init(&sem_, 0, 0); thread_ = port::Thread(&Reader::run, this); @@ -117,11 +118,11 @@ struct Reader { ShardState& state = (*shard_states_)[shard]; if (!state.it) { // Initialize iterators - rocksdb::ReadOptions options; + ROCKSDB_NAMESPACE::ReadOptions options; options.tailing = true; if (FLAGS_iterate_upper_bound) { state.upper_bound = Key(shard, std::numeric_limits<uint64_t>::max()); - state.upper_bound_slice = rocksdb::Slice( + state.upper_bound_slice = ROCKSDB_NAMESPACE::Slice( (const char*)&state.upper_bound, sizeof(state.upper_bound)); options.iterate_upper_bound = &state.upper_bound_slice; } @@ -129,13 +130,14 @@ struct Reader { state.it.reset(db_->NewIterator(options)); if (FLAGS_cache_only_first) { - options.read_tier = rocksdb::ReadTier::kBlockCacheTier; + options.read_tier = ROCKSDB_NAMESPACE::ReadTier::kBlockCacheTier; state.it_cacheonly.reset(db_->NewIterator(options)); } } const uint64_t upto = state.last_written.load(); - for (rocksdb::Iterator* it : {state.it_cacheonly.get(), state.it.get()}) { + for (ROCKSDB_NAMESPACE::Iterator* it : + {state.it_cacheonly.get(), state.it.get()}) { if (it == nullptr) { continue; } @@ -146,7 +148,7 @@ struct Reader { for (uint64_t seq = state.last_read.load() + 1; seq <= upto; ++seq) { if (need_seek) { Key from(shard, state.last_read.load() + 1); - it->Seek(rocksdb::Slice((const char*)&from, sizeof(from))); + it->Seek(ROCKSDB_NAMESPACE::Slice((const char*)&from, sizeof(from))); need_seek = false; } else { it->Next(); @@ -189,8 +191,8 @@ struct Reader { private: char pad1[128] __attribute__((__unused__)); std::vector<ShardState>* shard_states_; - rocksdb::DB* db_; - rocksdb::port::Thread thread_; + ROCKSDB_NAMESPACE::DB* db_; + ROCKSDB_NAMESPACE::port::Thread thread_; sem_t sem_; std::mutex queue_mutex_; std::bitset<MAX_SHARDS + 1> shards_pending_set_; @@ -200,7 +202,8 @@ struct Reader { }; struct Writer { - explicit Writer(std::vector<ShardState>* shard_states, rocksdb::DB* db) + explicit Writer(std::vector<ShardState>* shard_states, + ROCKSDB_NAMESPACE::DB* db) : shard_states_(shard_states), db_(db) {} void start() { thread_ = port::Thread(&Writer::run, this); } @@ -240,10 +243,10 @@ struct Writer { uint64_t seqno = state.last_written.load() + 1; Key key(shard, seqno); // fprintf(stderr, "Writing (%ld, %ld)\n", shard, seqno); - rocksdb::Status status = - db_->Put(rocksdb::WriteOptions(), - rocksdb::Slice((const char*)&key, sizeof(key)), - rocksdb::Slice(value)); + ROCKSDB_NAMESPACE::Status status = + db_->Put(ROCKSDB_NAMESPACE::WriteOptions(), + ROCKSDB_NAMESPACE::Slice((const char*)&key, sizeof(key)), + ROCKSDB_NAMESPACE::Slice(value)); assert(status.ok()); state.last_written.store(seqno); state.reader->onWrite(shard); @@ -259,13 +262,13 @@ struct Writer { private: char pad1[128] __attribute__((__unused__)); std::vector<ShardState>* shard_states_; - rocksdb::DB* db_; - rocksdb::port::Thread thread_; + ROCKSDB_NAMESPACE::DB* db_; + ROCKSDB_NAMESPACE::port::Thread thread_; char pad2[128] __attribute__((__unused__)); }; struct StatsThread { - explicit StatsThread(rocksdb::DB* db) + explicit StatsThread(ROCKSDB_NAMESPACE::DB* db) : db_(db), thread_(&StatsThread::run, this) {} void run() { @@ -307,10 +310,10 @@ struct StatsThread { } private: - rocksdb::DB* db_; + ROCKSDB_NAMESPACE::DB* db_; std::mutex cvm_; std::condition_variable cv_; - rocksdb::port::Thread thread_; + ROCKSDB_NAMESPACE::port::Thread thread_; std::atomic<bool> done_{false}; }; @@ -318,29 +321,32 @@ int main(int argc, char** argv) { GFLAGS_NAMESPACE::ParseCommandLineFlags(&argc, &argv, true); std::mt19937 rng{std::random_device()()}; - rocksdb::Status status; - std::string path = rocksdb::test::PerThreadDBPath("forward_iterator_test"); + ROCKSDB_NAMESPACE::Status status; + std::string path = + ROCKSDB_NAMESPACE::test::PerThreadDBPath("forward_iterator_test"); fprintf(stderr, "db path is %s\n", path.c_str()); - rocksdb::Options options; + ROCKSDB_NAMESPACE::Options options; options.create_if_missing = true; - options.compression = rocksdb::CompressionType::kNoCompression; - options.compaction_style = rocksdb::CompactionStyle::kCompactionStyleNone; + options.compression = ROCKSDB_NAMESPACE::CompressionType::kNoCompression; + options.compaction_style = + ROCKSDB_NAMESPACE::CompactionStyle::kCompactionStyleNone; options.level0_slowdown_writes_trigger = 99999; options.level0_stop_writes_trigger = 99999; options.use_direct_io_for_flush_and_compaction = true; options.write_buffer_size = FLAGS_memtable_size; - rocksdb::BlockBasedTableOptions table_options; - table_options.block_cache = rocksdb::NewLRUCache(FLAGS_block_cache_size); + ROCKSDB_NAMESPACE::BlockBasedTableOptions table_options; + table_options.block_cache = + ROCKSDB_NAMESPACE::NewLRUCache(FLAGS_block_cache_size); table_options.block_size = FLAGS_block_size; options.table_factory.reset( - rocksdb::NewBlockBasedTableFactory(table_options)); + ROCKSDB_NAMESPACE::NewBlockBasedTableFactory(table_options)); - status = rocksdb::DestroyDB(path, options); + status = ROCKSDB_NAMESPACE::DestroyDB(path, options); assert(status.ok()); - rocksdb::DB* db_raw; - status = rocksdb::DB::Open(options, path, &db_raw); + ROCKSDB_NAMESPACE::DB* db_raw; + status = ROCKSDB_NAMESPACE::DB::Open(options, path, &db_raw); assert(status.ok()); - std::unique_ptr<rocksdb::DB> db(db_raw); + std::unique_ptr<ROCKSDB_NAMESPACE::DB> db(db_raw); std::vector<ShardState> shard_states(FLAGS_shards + 1); std::deque<Reader> readers; diff --git a/db/import_column_family_job.cc b/db/import_column_family_job.cc index eb73ef644..15af1cf80 100644 --- a/db/import_column_family_job.cc +++ b/db/import_column_family_job.cc @@ -16,7 +16,7 @@ #include "table/table_builder.h" #include "util/stop_watch.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { Status ImportColumnFamilyJob::Prepare(uint64_t next_file_number, SuperVersion* sv) { @@ -271,6 +271,6 @@ Status ImportColumnFamilyJob::GetIngestedFileInfo( return status; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/import_column_family_job.h b/db/import_column_family_job.h index 1bdb4fb2b..160fd1247 100644 --- a/db/import_column_family_job.h +++ b/db/import_column_family_job.h @@ -14,7 +14,7 @@ #include "rocksdb/sst_file_writer.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Imports a set of sst files as is into a new column family. Logic is similar // to ExternalSstFileIngestionJob. @@ -69,4 +69,4 @@ class ImportColumnFamilyJob { std::vector<LiveFileMetaData> metadata_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/import_column_family_test.cc b/db/import_column_family_test.cc index 1138b16ba..a25560b7c 100644 --- a/db/import_column_family_test.cc +++ b/db/import_column_family_test.cc @@ -7,7 +7,7 @@ #include "rocksdb/sst_file_writer.h" #include "test_util/testutil.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class ImportColumnFamilyTest : public DBTestBase { public: @@ -546,10 +546,10 @@ TEST_F(ImportColumnFamilyTest, ImportColumnFamilyNegativeTest) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/internal_stats.cc b/db/internal_stats.cc index 28e9aae4e..f729ee7c7 100644 --- a/db/internal_stats.cc +++ b/db/internal_stats.cc @@ -22,7 +22,7 @@ #include "table/block_based/block_based_table_factory.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE @@ -1421,4 +1421,4 @@ const DBPropertyInfo* GetPropertyInfo(const Slice& /*property*/) { #endif // !ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/internal_stats.h b/db/internal_stats.h index aa4eda537..ce83be244 100644 --- a/db/internal_stats.h +++ b/db/internal_stats.h @@ -17,7 +17,7 @@ class ColumnFamilyData; -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DBImpl; class MemTableList; @@ -694,4 +694,4 @@ class InternalStats { }; #endif // !ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/job_context.h b/db/job_context.h index 3978fad33..31ff26c3a 100644 --- a/db/job_context.h +++ b/db/job_context.h @@ -15,7 +15,7 @@ #include "db/log_writer.h" #include "db/column_family.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class MemTable; struct SuperVersion; @@ -216,4 +216,4 @@ struct JobContext { } }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/listener_test.cc b/db/listener_test.cc index 0e8bae407..eb1a08a35 100644 --- a/db/listener_test.cc +++ b/db/listener_test.cc @@ -37,7 +37,7 @@ #ifndef ROCKSDB_LITE -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class EventListenerTest : public DBTestBase { public: @@ -54,24 +54,27 @@ class EventListenerTest : public DBTestBase { const size_t k110KB = 110 << 10; }; -struct TestPropertiesCollector : public rocksdb::TablePropertiesCollector { - rocksdb::Status AddUserKey(const rocksdb::Slice& /*key*/, - const rocksdb::Slice& /*value*/, - rocksdb::EntryType /*type*/, - rocksdb::SequenceNumber /*seq*/, - uint64_t /*file_size*/) override { +struct TestPropertiesCollector + : public ROCKSDB_NAMESPACE::TablePropertiesCollector { + ROCKSDB_NAMESPACE::Status AddUserKey( + const ROCKSDB_NAMESPACE::Slice& /*key*/, + const ROCKSDB_NAMESPACE::Slice& /*value*/, + ROCKSDB_NAMESPACE::EntryType /*type*/, + ROCKSDB_NAMESPACE::SequenceNumber /*seq*/, + uint64_t /*file_size*/) override { return Status::OK(); } - rocksdb::Status Finish( - rocksdb::UserCollectedProperties* properties) override { + ROCKSDB_NAMESPACE::Status Finish( + ROCKSDB_NAMESPACE::UserCollectedProperties* properties) override { properties->insert({"0", "1"}); return Status::OK(); } const char* Name() const override { return "TestTablePropertiesCollector"; } - rocksdb::UserCollectedProperties GetReadableProperties() const override { - rocksdb::UserCollectedProperties ret; + ROCKSDB_NAMESPACE::UserCollectedProperties GetReadableProperties() + const override { + ROCKSDB_NAMESPACE::UserCollectedProperties ret; ret["2"] = "3"; return ret; } @@ -912,10 +915,10 @@ TEST_F(EventListenerTest, BackgroundErrorListenerFailedFlushTest) { // the usual TEST_WaitForFlushMemTable() doesn't work for failed flushes, so // forge a custom one for the failed flush case. - rocksdb::SyncPoint::GetInstance()->LoadDependency( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->LoadDependency( {{"DBImpl::BGWorkFlush:done", "EventListenerTest:BackgroundErrorListenerFailedFlushTest:1"}}); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); env_->drop_writes_.store(true, std::memory_order_release); env_->no_slowdown_ = true; @@ -1029,7 +1032,7 @@ TEST_F(EventListenerTest, OnFileOperationTest) { ASSERT_GT(listener->file_reads_.load(), 0); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/log_format.h b/db/log_format.h index 5aeb5aa5f..c22e2b6bc 100644 --- a/db/log_format.h +++ b/db/log_format.h @@ -11,7 +11,10 @@ // See ../doc/log_format.txt for more detail. #pragma once -namespace rocksdb { + +#include "rocksdb/rocksdb_namespace.h" + +namespace ROCKSDB_NAMESPACE { namespace log { enum RecordType { @@ -42,4 +45,4 @@ static const int kHeaderSize = 4 + 2 + 1; static const int kRecyclableHeaderSize = 4 + 2 + 1 + 4; } // namespace log -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/log_reader.cc b/db/log_reader.cc index 3a71cbc42..c60a814b9 100644 --- a/db/log_reader.cc +++ b/db/log_reader.cc @@ -17,7 +17,7 @@ #include "util/crc32c.h" #include "util/util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace log { Reader::Reporter::~Reporter() { @@ -621,4 +621,4 @@ bool FragmentBufferedReader::TryReadFragment( } } // namespace log -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/log_reader.h b/db/log_reader.h index 299eca26e..293ae957c 100644 --- a/db/log_reader.h +++ b/db/log_reader.h @@ -17,7 +17,7 @@ #include "rocksdb/slice.h" #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Logger; namespace log { @@ -186,4 +186,4 @@ class FragmentBufferedReader : public Reader { }; } // namespace log -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/log_test.cc b/db/log_test.cc index b76e22118..849b89d8a 100644 --- a/db/log_test.cc +++ b/db/log_test.cc @@ -19,7 +19,7 @@ #include "util/crc32c.h" #include "util/random.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace log { // Construct a string of the specified length made out of the supplied @@ -920,7 +920,7 @@ TEST_P(RetriableLogTest, NonBlockingReadFullRecord) { INSTANTIATE_TEST_CASE_P(bool, RetriableLogTest, ::testing::Values(0, 2)); } // namespace log -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/log_writer.cc b/db/log_writer.cc index 53efc6c15..0222ee2a7 100644 --- a/db/log_writer.cc +++ b/db/log_writer.cc @@ -15,7 +15,7 @@ #include "util/coding.h" #include "util/crc32c.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace log { Writer::Writer(std::unique_ptr<WritableFileWriter>&& dest, uint64_t log_number, @@ -159,4 +159,4 @@ Status Writer::EmitPhysicalRecord(RecordType t, const char* ptr, size_t n) { } } // namespace log -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/log_writer.h b/db/log_writer.h index e5ed71a76..a7f952edd 100644 --- a/db/log_writer.h +++ b/db/log_writer.h @@ -16,7 +16,7 @@ #include "rocksdb/slice.h" #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class WritableFileWriter; @@ -111,4 +111,4 @@ class Writer { }; } // namespace log -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/logs_with_prep_tracker.cc b/db/logs_with_prep_tracker.cc index 1082dc102..ff98155c4 100644 --- a/db/logs_with_prep_tracker.cc +++ b/db/logs_with_prep_tracker.cc @@ -7,7 +7,7 @@ #include "port/likely.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { void LogsWithPrepTracker::MarkLogAsHavingPrepSectionFlushed(uint64_t log) { assert(log != 0); std::lock_guard<std::mutex> lock(prepared_section_completed_mutex_); @@ -64,4 +64,4 @@ uint64_t LogsWithPrepTracker::FindMinLogContainingOutstandingPrep() { // no such log found return 0; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/logs_with_prep_tracker.h b/db/logs_with_prep_tracker.h index 639d8f806..86c88012a 100644 --- a/db/logs_with_prep_tracker.h +++ b/db/logs_with_prep_tracker.h @@ -12,7 +12,9 @@ #include <unordered_map> #include <vector> -namespace rocksdb { +#include "rocksdb/rocksdb_namespace.h" + +namespace ROCKSDB_NAMESPACE { // This class is used to track the log files with outstanding prepare entries. class LogsWithPrepTracker { @@ -58,4 +60,4 @@ class LogsWithPrepTracker { std::mutex prepared_section_completed_mutex_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/lookup_key.h b/db/lookup_key.h index 1b0f6f562..51e5daed1 100644 --- a/db/lookup_key.h +++ b/db/lookup_key.h @@ -14,7 +14,7 @@ #include "rocksdb/slice.h" #include "rocksdb/types.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // A helper class useful for DBImpl::Get() class LookupKey { @@ -63,4 +63,4 @@ inline LookupKey::~LookupKey() { if (start_ != space_) delete[] start_; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/malloc_stats.cc b/db/malloc_stats.cc index 1dfe0d55b..12824e516 100644 --- a/db/malloc_stats.cc +++ b/db/malloc_stats.cc @@ -15,8 +15,7 @@ #include "port/jemalloc_helper.h" - -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifdef ROCKSDB_JEMALLOC @@ -51,5 +50,5 @@ void DumpMallocStats(std::string* stats) { #else void DumpMallocStats(std::string*) {} #endif // ROCKSDB_JEMALLOC -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // !ROCKSDB_LITE diff --git a/db/malloc_stats.h b/db/malloc_stats.h index a2f324ff1..18aff3ad0 100644 --- a/db/malloc_stats.h +++ b/db/malloc_stats.h @@ -13,7 +13,9 @@ #include <string> -namespace rocksdb { +#include "rocksdb/rocksdb_namespace.h" + +namespace ROCKSDB_NAMESPACE { void DumpMallocStats(std::string*); diff --git a/db/manual_compaction_test.cc b/db/manual_compaction_test.cc index 1a69a89de..22cd919b5 100644 --- a/db/manual_compaction_test.cc +++ b/db/manual_compaction_test.cc @@ -15,7 +15,7 @@ #include "rocksdb/write_batch.h" #include "test_util/testharness.h" -using namespace rocksdb; +using namespace ROCKSDB_NAMESPACE; namespace { @@ -40,8 +40,8 @@ class ManualCompactionTest : public testing::Test { public: ManualCompactionTest() { // Get rid of any state from an old run. - dbname_ = rocksdb::test::PerThreadDBPath("rocksdb_cbug_test"); - DestroyDB(dbname_, rocksdb::Options()); + dbname_ = ROCKSDB_NAMESPACE::test::PerThreadDBPath("rocksdb_cbug_test"); + DestroyDB(dbname_, ROCKSDB_NAMESPACE::Options()); } std::string dbname_; @@ -71,7 +71,7 @@ TEST_F(ManualCompactionTest, CompactTouchesAllKeys) { options.compaction_style = kCompactionStyleUniversal; } options.create_if_missing = true; - options.compression = rocksdb::kNoCompression; + options.compression = ROCKSDB_NAMESPACE::kNoCompression; options.compaction_filter = new DestroyAllCompactionFilter(); ASSERT_OK(DB::Open(options, dbname_, &db)); @@ -100,45 +100,46 @@ TEST_F(ManualCompactionTest, Test) { // Open database. Disable compression since it affects the creation // of layers and the code below is trying to test against a very // specific scenario. - rocksdb::DB* db; - rocksdb::Options db_options; + ROCKSDB_NAMESPACE::DB* db; + ROCKSDB_NAMESPACE::Options db_options; db_options.write_buffer_size = 1024; db_options.create_if_missing = true; - db_options.compression = rocksdb::kNoCompression; - ASSERT_OK(rocksdb::DB::Open(db_options, dbname_, &db)); + db_options.compression = ROCKSDB_NAMESPACE::kNoCompression; + ASSERT_OK(ROCKSDB_NAMESPACE::DB::Open(db_options, dbname_, &db)); // create first key range - rocksdb::WriteBatch batch; + ROCKSDB_NAMESPACE::WriteBatch batch; for (int i = 0; i < kNumKeys; i++) { batch.Put(Key1(i), "value for range 1 key"); } - ASSERT_OK(db->Write(rocksdb::WriteOptions(), &batch)); + ASSERT_OK(db->Write(ROCKSDB_NAMESPACE::WriteOptions(), &batch)); // create second key range batch.Clear(); for (int i = 0; i < kNumKeys; i++) { batch.Put(Key2(i), "value for range 2 key"); } - ASSERT_OK(db->Write(rocksdb::WriteOptions(), &batch)); + ASSERT_OK(db->Write(ROCKSDB_NAMESPACE::WriteOptions(), &batch)); // delete second key range batch.Clear(); for (int i = 0; i < kNumKeys; i++) { batch.Delete(Key2(i)); } - ASSERT_OK(db->Write(rocksdb::WriteOptions(), &batch)); + ASSERT_OK(db->Write(ROCKSDB_NAMESPACE::WriteOptions(), &batch)); // compact database std::string start_key = Key1(0); std::string end_key = Key1(kNumKeys - 1); - rocksdb::Slice least(start_key.data(), start_key.size()); - rocksdb::Slice greatest(end_key.data(), end_key.size()); + ROCKSDB_NAMESPACE::Slice least(start_key.data(), start_key.size()); + ROCKSDB_NAMESPACE::Slice greatest(end_key.data(), end_key.size()); // commenting out the line below causes the example to work correctly db->CompactRange(CompactRangeOptions(), &least, &greatest); // count the keys - rocksdb::Iterator* iter = db->NewIterator(rocksdb::ReadOptions()); + ROCKSDB_NAMESPACE::Iterator* iter = + db->NewIterator(ROCKSDB_NAMESPACE::ReadOptions()); int num_keys = 0; for (iter->SeekToFirst(); iter->Valid(); iter->Next()) { num_keys++; @@ -148,7 +149,7 @@ TEST_F(ManualCompactionTest, Test) { // close database delete db; - DestroyDB(dbname_, rocksdb::Options()); + DestroyDB(dbname_, ROCKSDB_NAMESPACE::Options()); } } // anonymous namespace diff --git a/db/memtable.cc b/db/memtable.cc index c19656ccd..45483ea09 100644 --- a/db/memtable.cc +++ b/db/memtable.cc @@ -38,7 +38,7 @@ #include "util/mutexlock.h" #include "util/util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { ImmutableMemTableOptions::ImmutableMemTableOptions( const ImmutableCFOptions& ioptions, @@ -127,10 +127,10 @@ MemTable::~MemTable() { } size_t MemTable::ApproximateMemoryUsage() { - autovector<size_t> usages = {arena_.ApproximateMemoryUsage(), - table_->ApproximateMemoryUsage(), - range_del_table_->ApproximateMemoryUsage(), - rocksdb::ApproximateMemoryUsage(insert_hints_)}; + autovector<size_t> usages = { + arena_.ApproximateMemoryUsage(), table_->ApproximateMemoryUsage(), + range_del_table_->ApproximateMemoryUsage(), + ROCKSDB_NAMESPACE::ApproximateMemoryUsage(insert_hints_)}; size_t total_usage = 0; for (size_t usage : usages) { // If usage + total_usage >= kMaxSizet, return kMaxSizet. @@ -668,7 +668,7 @@ static bool SaveValue(void* arg, const char* entry) { ROCKS_LOG_ERROR(s->logger, "Encounter unexpected blob index."); *(s->status) = Status::NotSupported( "Encounter unsupported blob value. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); } else if (*(s->merge_in_progress)) { *(s->status) = Status::NotSupported("Blob DB does not support merge operator."); @@ -1119,4 +1119,4 @@ uint64_t MemTable::GetMinLogContainingPrepSection() { return min_prep_log_referenced_.load(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/memtable.h b/db/memtable.h index 961707008..f4e4b98a9 100644 --- a/db/memtable.h +++ b/db/memtable.h @@ -30,7 +30,7 @@ #include "util/dynamic_bloom.h" #include "util/hash.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { struct FlushJobInfo; class Mutex; @@ -539,4 +539,4 @@ class MemTable { extern const char* EncodeKey(std::string* scratch, const Slice& target); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/memtable_list.cc b/db/memtable_list.cc index 3281c96d0..a8b358fa6 100644 --- a/db/memtable_list.cc +++ b/db/memtable_list.cc @@ -22,7 +22,7 @@ #include "test_util/sync_point.h" #include "util/coding.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class InternalKeyComparator; class Mutex; @@ -768,4 +768,4 @@ void MemTableList::RemoveOldMemTables(uint64_t log_number, ResetTrimHistoryNeeded(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/memtable_list.h b/db/memtable_list.h index cbf42ac08..a6acf6a32 100644 --- a/db/memtable_list.h +++ b/db/memtable_list.h @@ -25,7 +25,7 @@ #include "rocksdb/types.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class ColumnFamilyData; class InternalKeyComparator; @@ -419,4 +419,4 @@ extern Status InstallMemtableAtomicFlushResults( InstrumentedMutex* mu, const autovector<FileMetaData*>& file_meta, autovector<MemTable*>* to_delete, Directory* db_directory, LogBuffer* log_buffer); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/memtable_list_test.cc b/db/memtable_list_test.cc index 7df20674a..a92bc6c79 100644 --- a/db/memtable_list_test.cc +++ b/db/memtable_list_test.cc @@ -17,7 +17,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class MemTableListTest : public testing::Test { public: @@ -914,7 +914,7 @@ TEST_F(MemTableListTest, AtomicFlusTest) { } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/merge_context.h b/db/merge_context.h index 884682eec..e1869a341 100644 --- a/db/merge_context.h +++ b/db/merge_context.h @@ -10,7 +10,7 @@ #include <vector> #include "rocksdb/slice.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { const std::vector<Slice> empty_operand_list; @@ -131,4 +131,4 @@ class MergeContext { bool operands_reversed_ = true; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/merge_helper.cc b/db/merge_helper.cc index b5ae924ff..96fe79251 100644 --- a/db/merge_helper.cc +++ b/db/merge_helper.cc @@ -17,7 +17,7 @@ #include "table/format.h" #include "table/internal_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { MergeHelper::MergeHelper(Env* env, const Comparator* user_comparator, const MergeOperator* user_merge_operator, @@ -414,4 +414,4 @@ CompactionFilter::Decision MergeHelper::FilterMerge(const Slice& user_key, return ret; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/merge_helper.h b/db/merge_helper.h index 670cba598..c0534f08b 100644 --- a/db/merge_helper.h +++ b/db/merge_helper.h @@ -18,7 +18,7 @@ #include "rocksdb/slice.h" #include "util/stop_watch.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Comparator; class Iterator; @@ -191,4 +191,4 @@ class MergeOutputIterator { std::vector<Slice>::const_reverse_iterator it_values_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/merge_helper_test.cc b/db/merge_helper_test.cc index 3386f9bd0..117916c8f 100644 --- a/db/merge_helper_test.cc +++ b/db/merge_helper_test.cc @@ -14,7 +14,7 @@ #include "util/coding.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class MergeHelperTest : public testing::Test { public: @@ -282,7 +282,7 @@ TEST_F(MergeHelperTest, DontFilterMergeOperandsBeforeSnapshotTest) { ASSERT_FALSE(merge_output_iter.Valid()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/merge_operator.cc b/db/merge_operator.cc index 1981e65ba..75dea432c 100644 --- a/db/merge_operator.cc +++ b/db/merge_operator.cc @@ -9,7 +9,7 @@ #include "rocksdb/merge_operator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { bool MergeOperator::FullMergeV2(const MergeOperationInput& merge_in, MergeOperationOutput* merge_out) const { @@ -83,4 +83,4 @@ bool AssociativeMergeOperator::PartialMerge( return Merge(key, &left_operand, right_operand, new_value, logger); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/merge_test.cc b/db/merge_test.cc index 2965045d9..3f85f6464 100644 --- a/db/merge_test.cc +++ b/db/merge_test.cc @@ -20,7 +20,7 @@ #include "test_util/testharness.h" #include "utilities/merge_operators.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { bool use_compression; @@ -346,7 +346,7 @@ void testPartialMerge(Counters* counters, DB* db, size_t max_merge, // Test case 2: partial merge should not be called when a put is found. resetNumPartialMergeCalls(); tmp_sum = 0; - db->Put(rocksdb::WriteOptions(), "c", "10"); + db->Put(ROCKSDB_NAMESPACE::WriteOptions(), "c", "10"); for (size_t i = 1; i <= count; i++) { counters->assert_add("c", i); tmp_sum += i; @@ -490,15 +490,15 @@ TEST_F(MergeTest, MergeDbTtlTest) { } #endif // !ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { - rocksdb::use_compression = false; + ROCKSDB_NAMESPACE::use_compression = false; if (argc > 1) { - rocksdb::use_compression = true; + ROCKSDB_NAMESPACE::use_compression = true; } - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } diff --git a/db/obsolete_files_test.cc b/db/obsolete_files_test.cc index 096a50c1a..bf018a0e3 100644 --- a/db/obsolete_files_test.cc +++ b/db/obsolete_files_test.cc @@ -32,7 +32,7 @@ using std::cout; using std::endl; using std::flush; -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class ObsoleteFilesTest : public DBTestBase { public: @@ -193,7 +193,7 @@ TEST_F(ObsoleteFilesTest, DeleteObsoleteOptionsFile) { ASSERT_EQ(2, opts_file_count); } -} //namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #ifdef ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS extern "C" { @@ -204,7 +204,7 @@ void RegisterCustomObjects(int /*argc*/, char** /*argv*/) {} #endif // !ROCKSDB_UNITTESTS_WITH_CUSTOM_OBJECTS_FROM_STATIC_LIBS int main(int argc, char** argv) { - rocksdb::port::InstallStackTraceHandler(); + ROCKSDB_NAMESPACE::port::InstallStackTraceHandler(); ::testing::InitGoogleTest(&argc, argv); RegisterCustomObjects(argc, argv); return RUN_ALL_TESTS(); diff --git a/db/options_file_test.cc b/db/options_file_test.cc index b86ecefa9..00427de8a 100644 --- a/db/options_file_test.cc +++ b/db/options_file_test.cc @@ -12,7 +12,7 @@ #include "rocksdb/table.h" #include "test_util/testharness.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class OptionsFileTest : public testing::Test { public: OptionsFileTest() : dbname_(test::PerThreadDBPath("options_file_test")) {} @@ -98,7 +98,7 @@ TEST_F(OptionsFileTest, OptionsFileName) { ASSERT_EQ(type, kTempFile); ASSERT_EQ(number, kTempOptionsFileNum); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { #if !(defined NDEBUG) || !defined(OS_WIN) diff --git a/db/perf_context_test.cc b/db/perf_context_test.cc index 94eabff7f..86f2db7b6 100644 --- a/db/perf_context_test.cc +++ b/db/perf_context_test.cc @@ -31,9 +31,10 @@ int FLAGS_min_write_buffer_number_to_merge = 7; bool FLAGS_verbose = false; // Path to the database on file system -const std::string kDbName = rocksdb::test::PerThreadDBPath("perf_context_test"); +const std::string kDbName = + ROCKSDB_NAMESPACE::test::PerThreadDBPath("perf_context_test"); -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { std::shared_ptr<DB> OpenDb(bool read_only = false) { DB* db; @@ -47,7 +48,8 @@ std::shared_ptr<DB> OpenDb(bool read_only = false) { if (FLAGS_use_set_based_memetable) { #ifndef ROCKSDB_LITE - options.prefix_extractor.reset(rocksdb::NewFixedPrefixTransform(0)); + options.prefix_extractor.reset( + ROCKSDB_NAMESPACE::NewFixedPrefixTransform(0)); options.memtable_factory.reset(NewHashSkipListRepFactory()); #endif // ROCKSDB_LITE } @@ -585,7 +587,7 @@ TEST_F(PerfContextTest, DBMutexLockCounter) { for (int c = 0; c < 2; ++c) { InstrumentedMutex mutex(nullptr, Env::Default(), stats_code[c]); mutex.Lock(); - rocksdb::port::Thread child_thread([&] { + ROCKSDB_NAMESPACE::port::Thread child_thread([&] { SetPerfLevel(perf_level_test); get_perf_context()->Reset(); ASSERT_EQ(get_perf_context()->db_mutex_lock_nanos, 0); @@ -938,7 +940,7 @@ TEST_F(PerfContextTest, CPUTimer) { ASSERT_EQ(count, get_perf_context()->iter_seek_cpu_nanos); } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/pinned_iterators_manager.h b/db/pinned_iterators_manager.h index 7874eef6d..5e8ad51dd 100644 --- a/db/pinned_iterators_manager.h +++ b/db/pinned_iterators_manager.h @@ -11,7 +11,7 @@ #include "table/internal_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // PinnedIteratorsManager will be notified whenever we need to pin an Iterator // and it will be responsible for deleting pinned Iterators when they are @@ -84,4 +84,4 @@ class PinnedIteratorsManager : public Cleanable { std::vector<std::pair<void*, ReleaseFunction>> pinned_ptrs_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/plain_table_db_test.cc b/db/plain_table_db_test.cc index f5dcf0200..d80cc4f67 100644 --- a/db/plain_table_db_test.cc +++ b/db/plain_table_db_test.cc @@ -39,7 +39,7 @@ using std::unique_ptr; -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class PlainTableKeyDecoderTest : public testing::Test {}; TEST_F(PlainTableKeyDecoderTest, ReadNonMmap) { @@ -653,9 +653,9 @@ TEST_P(PlainTableDBTest, Immortal) { dbfull()->TEST_FlushMemTable(); int copied = 0; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "GetContext::SaveValue::PinSelf", [&](void* /*arg*/) { copied++; }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); ASSERT_EQ("b", Get("0000000000000bar")); ASSERT_EQ("v1", Get("1000000000000foo")); ASSERT_EQ(2, copied); @@ -672,7 +672,7 @@ TEST_P(PlainTableDBTest, Immortal) { } else { ASSERT_EQ(2, copied); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); } } @@ -1357,7 +1357,7 @@ TEST_P(PlainTableDBTest, AdaptiveTable) { INSTANTIATE_TEST_CASE_P(PlainTableDBTest, PlainTableDBTest, ::testing::Bool()); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/pre_release_callback.h b/db/pre_release_callback.h index e4167904f..b74be9537 100644 --- a/db/pre_release_callback.h +++ b/db/pre_release_callback.h @@ -7,7 +7,7 @@ #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DB; @@ -35,4 +35,4 @@ class PreReleaseCallback { uint64_t log_number, size_t index, size_t total) = 0; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/prefix_test.cc b/db/prefix_test.cc index 19f02f109..c61ec2a1e 100644 --- a/db/prefix_test.cc +++ b/db/prefix_test.cc @@ -53,9 +53,10 @@ DEFINE_int32(value_size, 40, ""); DEFINE_bool(enable_print, false, "Print options generated to console."); // Path to the database on file system -const std::string kDbName = rocksdb::test::PerThreadDBPath("prefix_test"); +const std::string kDbName = + ROCKSDB_NAMESPACE::test::PerThreadDBPath("prefix_test"); -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { struct TestKey { uint64_t prefix; @@ -871,7 +872,7 @@ TEST_F(PrefixTest, PrefixSeekModePrev3) { } } -} // end namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/range_del_aggregator.cc b/db/range_del_aggregator.cc index c8d33ffb3..1f6a7b139 100644 --- a/db/range_del_aggregator.cc +++ b/db/range_del_aggregator.cc @@ -20,7 +20,7 @@ #include "util/kv_map.h" #include "util/vector_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { TruncatedRangeDelIterator::TruncatedRangeDelIterator( std::unique_ptr<FragmentedRangeTombstoneIterator> iter, @@ -481,4 +481,4 @@ CompactionRangeDelAggregator::NewIterator(const Slice* lower_bound, kMaxSequenceNumber /* upper_bound */)); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/range_del_aggregator.h b/db/range_del_aggregator.h index c68d75d7f..b47cf31d3 100644 --- a/db/range_del_aggregator.h +++ b/db/range_del_aggregator.h @@ -27,7 +27,7 @@ #include "util/heap.h" #include "util/kv_map.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class TruncatedRangeDelIterator { public: @@ -438,4 +438,4 @@ class CompactionRangeDelAggregator : public RangeDelAggregator { const std::vector<SequenceNumber>* snapshots_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/range_del_aggregator_bench.cc b/db/range_del_aggregator_bench.cc index 97ba6ca4f..3f3135f2e 100644 --- a/db/range_del_aggregator_bench.cc +++ b/db/range_del_aggregator_bench.cc @@ -84,11 +84,12 @@ std::ostream& operator<<(std::ostream& os, const Stats& s) { return os; } -auto icmp = rocksdb::InternalKeyComparator(rocksdb::BytewiseComparator()); +auto icmp = ROCKSDB_NAMESPACE::InternalKeyComparator( + ROCKSDB_NAMESPACE::BytewiseComparator()); } // anonymous namespace -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { @@ -165,30 +166,31 @@ static std::string Key(int64_t val) { } // anonymous namespace -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ParseCommandLineFlags(&argc, &argv, true); Stats stats; - rocksdb::Random64 rnd(FLAGS_seed); + ROCKSDB_NAMESPACE::Random64 rnd(FLAGS_seed); std::default_random_engine random_gen(FLAGS_seed); std::normal_distribution<double> normal_dist(FLAGS_tombstone_width_mean, FLAGS_tombstone_width_stddev); - std::vector<std::vector<rocksdb::PersistentRangeTombstone> > + std::vector<std::vector<ROCKSDB_NAMESPACE::PersistentRangeTombstone> > all_persistent_range_tombstones(FLAGS_add_tombstones_per_run); for (int i = 0; i < FLAGS_add_tombstones_per_run; i++) { all_persistent_range_tombstones[i] = - std::vector<rocksdb::PersistentRangeTombstone>( + std::vector<ROCKSDB_NAMESPACE::PersistentRangeTombstone>( FLAGS_num_range_tombstones); } - auto mode = rocksdb::RangeDelPositioningMode::kForwardTraversal; + auto mode = ROCKSDB_NAMESPACE::RangeDelPositioningMode::kForwardTraversal; for (int i = 0; i < FLAGS_num_runs; i++) { - rocksdb::ReadRangeDelAggregator range_del_agg( - &icmp, rocksdb::kMaxSequenceNumber /* upper_bound */); + ROCKSDB_NAMESPACE::ReadRangeDelAggregator range_del_agg( + &icmp, ROCKSDB_NAMESPACE::kMaxSequenceNumber /* upper_bound */); - std::vector<std::unique_ptr<rocksdb::FragmentedRangeTombstoneList> > + std::vector< + std::unique_ptr<ROCKSDB_NAMESPACE::FragmentedRangeTombstoneList> > fragmented_range_tombstone_lists(FLAGS_add_tombstones_per_run); for (auto& persistent_range_tombstones : all_persistent_range_tombstones) { @@ -199,41 +201,43 @@ int main(int argc, char** argv) { uint64_t start = rnd.Uniform(FLAGS_tombstone_start_upper_bound); uint64_t end = static_cast<uint64_t>( std::round(start + std::max(1.0, normal_dist(random_gen)))); - persistent_range_tombstones[j] = rocksdb::PersistentRangeTombstone( - rocksdb::Key(start), rocksdb::Key(end), j); + persistent_range_tombstones[j] = + ROCKSDB_NAMESPACE::PersistentRangeTombstone( + ROCKSDB_NAMESPACE::Key(start), ROCKSDB_NAMESPACE::Key(end), j); } auto range_del_iter = - rocksdb::MakeRangeDelIterator(persistent_range_tombstones); + ROCKSDB_NAMESPACE::MakeRangeDelIterator(persistent_range_tombstones); fragmented_range_tombstone_lists.emplace_back( - new rocksdb::FragmentedRangeTombstoneList( - rocksdb::MakeRangeDelIterator(persistent_range_tombstones), + new ROCKSDB_NAMESPACE::FragmentedRangeTombstoneList( + ROCKSDB_NAMESPACE::MakeRangeDelIterator( + persistent_range_tombstones), icmp)); - std::unique_ptr<rocksdb::FragmentedRangeTombstoneIterator> + std::unique_ptr<ROCKSDB_NAMESPACE::FragmentedRangeTombstoneIterator> fragmented_range_del_iter( - new rocksdb::FragmentedRangeTombstoneIterator( + new ROCKSDB_NAMESPACE::FragmentedRangeTombstoneIterator( fragmented_range_tombstone_lists.back().get(), icmp, - rocksdb::kMaxSequenceNumber)); + ROCKSDB_NAMESPACE::kMaxSequenceNumber)); - rocksdb::StopWatchNano stop_watch_add_tombstones(rocksdb::Env::Default(), - true /* auto_start */); + ROCKSDB_NAMESPACE::StopWatchNano stop_watch_add_tombstones( + ROCKSDB_NAMESPACE::Env::Default(), true /* auto_start */); range_del_agg.AddTombstones(std::move(fragmented_range_del_iter)); stats.time_add_tombstones += stop_watch_add_tombstones.ElapsedNanos(); } - rocksdb::ParsedInternalKey parsed_key; + ROCKSDB_NAMESPACE::ParsedInternalKey parsed_key; parsed_key.sequence = FLAGS_num_range_tombstones / 2; - parsed_key.type = rocksdb::kTypeValue; + parsed_key.type = ROCKSDB_NAMESPACE::kTypeValue; uint64_t first_key = rnd.Uniform(FLAGS_should_delete_upper_bound - FLAGS_should_deletes_per_run + 1); for (int j = 0; j < FLAGS_should_deletes_per_run; j++) { - std::string key_string = rocksdb::Key(first_key + j); + std::string key_string = ROCKSDB_NAMESPACE::Key(first_key + j); parsed_key.user_key = key_string; - rocksdb::StopWatchNano stop_watch_should_delete(rocksdb::Env::Default(), - true /* auto_start */); + ROCKSDB_NAMESPACE::StopWatchNano stop_watch_should_delete( + ROCKSDB_NAMESPACE::Env::Default(), true /* auto_start */); range_del_agg.ShouldDelete(parsed_key, mode); uint64_t call_time = stop_watch_should_delete.ElapsedNanos(); diff --git a/db/range_del_aggregator_test.cc b/db/range_del_aggregator_test.cc index 7ce666326..0b8b5079c 100644 --- a/db/range_del_aggregator_test.cc +++ b/db/range_del_aggregator_test.cc @@ -14,7 +14,7 @@ #include "db/range_tombstone_fragmenter.h" #include "test_util/testutil.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class RangeDelAggregatorTest : public testing::Test {}; @@ -701,7 +701,7 @@ TEST_F(RangeDelAggregatorTest, {"f", "g", 8}}); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/range_tombstone_fragmenter.cc b/db/range_tombstone_fragmenter.cc index fe64623fe..58426248c 100644 --- a/db/range_tombstone_fragmenter.cc +++ b/db/range_tombstone_fragmenter.cc @@ -16,7 +16,7 @@ #include "util/kv_map.h" #include "util/vector_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { FragmentedRangeTombstoneList::FragmentedRangeTombstoneList( std::unique_ptr<InternalIterator> unfragmented_tombstones, @@ -436,4 +436,4 @@ FragmentedRangeTombstoneIterator::SplitBySnapshot( return splits; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/range_tombstone_fragmenter.h b/db/range_tombstone_fragmenter.h index 23a28396f..63ec24e64 100644 --- a/db/range_tombstone_fragmenter.h +++ b/db/range_tombstone_fragmenter.h @@ -16,7 +16,7 @@ #include "rocksdb/status.h" #include "table/internal_iterator.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { struct FragmentedRangeTombstoneList { public: @@ -253,4 +253,4 @@ class FragmentedRangeTombstoneIterator : public InternalIterator { mutable InternalKey current_start_key_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/range_tombstone_fragmenter_test.cc b/db/range_tombstone_fragmenter_test.cc index 11f357496..56234b1dd 100644 --- a/db/range_tombstone_fragmenter_test.cc +++ b/db/range_tombstone_fragmenter_test.cc @@ -9,7 +9,7 @@ #include "rocksdb/comparator.h" #include "test_util/testutil.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class RangeTombstoneFragmenterTest : public testing::Test {}; @@ -544,7 +544,7 @@ TEST_F(RangeTombstoneFragmenterTest, SeekOutOfBounds) { {{"", {}, true /* out of range */}, {"z", {"l", "n", 4}}}); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/read_callback.h b/db/read_callback.h index d8801e651..fbef1dd0d 100644 --- a/db/read_callback.h +++ b/db/read_callback.h @@ -7,7 +7,7 @@ #include "rocksdb/types.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class ReadCallback { public: @@ -50,4 +50,4 @@ class ReadCallback { const SequenceNumber min_uncommitted_ = kMinUnCommittedSeq; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/repair.cc b/db/repair.cc index 7091dd83f..383ffe3a4 100644 --- a/db/repair.cc +++ b/db/repair.cc @@ -83,7 +83,7 @@ #include "table/scoped_arena_iterator.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { @@ -686,6 +686,6 @@ Status RepairDB(const std::string& dbname, const Options& options) { return repairer.Run(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/repair_test.cc b/db/repair_test.cc index d9e0556c6..ba2bae3d0 100644 --- a/db/repair_test.cc +++ b/db/repair_test.cc @@ -17,7 +17,7 @@ #include "rocksdb/transaction_log.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE class RepairTest : public DBTestBase { @@ -351,7 +351,7 @@ TEST_F(RepairTest, DbNameContainsTrailingSlash) { ASSERT_EQ(Get("key"), "val"); } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/snapshot_checker.h b/db/snapshot_checker.h index 4d29b83c4..1d2c2c316 100644 --- a/db/snapshot_checker.h +++ b/db/snapshot_checker.h @@ -6,7 +6,7 @@ #pragma once #include "rocksdb/types.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { enum class SnapshotCheckerResult : int { kInSnapshot = 0, @@ -58,4 +58,4 @@ class WritePreparedSnapshotChecker : public SnapshotChecker { #endif // !ROCKSDB_LITE }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/snapshot_impl.cc b/db/snapshot_impl.cc index 032ef398a..b9228c797 100644 --- a/db/snapshot_impl.cc +++ b/db/snapshot_impl.cc @@ -7,7 +7,7 @@ #include "rocksdb/db.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { ManagedSnapshot::ManagedSnapshot(DB* db) : db_(db), snapshot_(db->GetSnapshot()) {} @@ -23,4 +23,4 @@ ManagedSnapshot::~ManagedSnapshot() { const Snapshot* ManagedSnapshot::snapshot() { return snapshot_;} -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/snapshot_impl.h b/db/snapshot_impl.h index f6ee47628..785f814f8 100644 --- a/db/snapshot_impl.h +++ b/db/snapshot_impl.h @@ -12,7 +12,7 @@ #include "rocksdb/db.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class SnapshotList; @@ -164,4 +164,4 @@ class SnapshotList { uint64_t count_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/table_cache.cc b/db/table_cache.cc index 5dc895d84..411959a33 100644 --- a/db/table_cache.cc +++ b/db/table_cache.cc @@ -29,7 +29,7 @@ #include "util/coding.h" #include "util/stop_watch.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { @@ -665,4 +665,4 @@ uint64_t TableCache::ApproximateSize( return result; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/table_cache.h b/db/table_cache.h index 8319901b2..b9de824ee 100644 --- a/db/table_cache.h +++ b/db/table_cache.h @@ -25,7 +25,7 @@ #include "table/table_reader.h" #include "trace_replay/block_cache_tracer.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Env; class Arena; @@ -223,4 +223,4 @@ class TableCache { BlockCacheTracer* const block_cache_tracer_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/table_properties_collector.cc b/db/table_properties_collector.cc index 4dbcd4cc4..d98ff5e9b 100644 --- a/db/table_properties_collector.cc +++ b/db/table_properties_collector.cc @@ -9,7 +9,7 @@ #include "util/coding.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { @@ -71,4 +71,4 @@ uint64_t GetMergeOperands(const UserCollectedProperties& props, props, TablePropertiesNames::kMergeOperands, property_present); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/table_properties_collector.h b/db/table_properties_collector.h index e4d621715..130eb64d4 100644 --- a/db/table_properties_collector.h +++ b/db/table_properties_collector.h @@ -12,7 +12,7 @@ #include <string> #include <vector> -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Base class for internal table properties collector. class IntTblPropCollector { @@ -104,4 +104,4 @@ class UserKeyTablePropertiesCollectorFactory std::shared_ptr<TablePropertiesCollectorFactory> user_collector_factory_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/table_properties_collector_test.cc b/db/table_properties_collector_test.cc index 9c8129570..5c202de81 100644 --- a/db/table_properties_collector_test.cc +++ b/db/table_properties_collector_test.cc @@ -25,7 +25,7 @@ #include "test_util/testutil.h" #include "util/coding.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class TablePropertiesTest : public testing::Test, public testing::WithParamInterface<bool> { @@ -507,7 +507,7 @@ INSTANTIATE_TEST_CASE_P(InternalKeyPropertiesCollector, TablePropertiesTest, INSTANTIATE_TEST_CASE_P(CustomizedTablePropertiesCollector, TablePropertiesTest, ::testing::Bool()); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/transaction_log_impl.cc b/db/transaction_log_impl.cc index 6c8f6dac8..56bc161a3 100644 --- a/db/transaction_log_impl.cc +++ b/db/transaction_log_impl.cc @@ -10,7 +10,7 @@ #include "db/write_batch_internal.h" #include "file/sequence_file_reader.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { TransactionLogIteratorImpl::TransactionLogIteratorImpl( const std::string& dir, const ImmutableDBOptions* options, @@ -311,5 +311,5 @@ Status TransactionLogIteratorImpl::OpenLogReader(const LogFile* log_file) { read_options_.verify_checksums_, log_file->LogNumber())); return Status::OK(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/transaction_log_impl.h b/db/transaction_log_impl.h index 7d6993d1d..eb53daf2b 100644 --- a/db/transaction_log_impl.h +++ b/db/transaction_log_impl.h @@ -17,7 +17,7 @@ #include "rocksdb/transaction_log.h" #include "rocksdb/types.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class LogFileImpl : public LogFile { public: @@ -123,5 +123,5 @@ class TransactionLogIteratorImpl : public TransactionLogIterator { void UpdateCurrentWriteBatch(const Slice& record); Status OpenLogReader(const LogFile* file); }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE #endif // ROCKSDB_LITE diff --git a/db/trim_history_scheduler.cc b/db/trim_history_scheduler.cc index 7451ba47d..d7ca0899f 100644 --- a/db/trim_history_scheduler.cc +++ b/db/trim_history_scheduler.cc @@ -9,7 +9,7 @@ #include "db/column_family.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { void TrimHistoryScheduler::ScheduleWork(ColumnFamilyData* cfd) { std::lock_guard<std::mutex> lock(checking_mutex_); @@ -51,4 +51,4 @@ void TrimHistoryScheduler::Clear() { assert(Empty()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/trim_history_scheduler.h b/db/trim_history_scheduler.h index e9013b964..b17f6170f 100644 --- a/db/trim_history_scheduler.h +++ b/db/trim_history_scheduler.h @@ -10,7 +10,7 @@ #include <mutex> #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class ColumnFamilyData; @@ -41,4 +41,4 @@ class TrimHistoryScheduler { std::mutex checking_mutex_; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_builder.cc b/db/version_builder.cc index f2d3acb50..4694218a1 100644 --- a/db/version_builder.cc +++ b/db/version_builder.cc @@ -29,7 +29,7 @@ #include "table/table_reader.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { bool NewestFirstBySeqNo(FileMetaData* a, FileMetaData* b) { if (a->fd.largest_seqno != b->fd.largest_seqno) { @@ -542,4 +542,4 @@ void VersionBuilder::MaybeAddFile(VersionStorageInfo* vstorage, int level, rep_->MaybeAddFile(vstorage, level, f); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_builder.h b/db/version_builder.h index ba38a2f2a..87415ed55 100644 --- a/db/version_builder.h +++ b/db/version_builder.h @@ -11,7 +11,7 @@ #include "rocksdb/file_system.h" #include "rocksdb/slice_transform.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class TableCache; class VersionStorageInfo; @@ -45,4 +45,4 @@ class VersionBuilder { }; extern bool NewestFirstBySeqNo(FileMetaData* a, FileMetaData* b); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_builder_test.cc b/db/version_builder_test.cc index 718e53ccc..2dda03f31 100644 --- a/db/version_builder_test.cc +++ b/db/version_builder_test.cc @@ -11,7 +11,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class VersionBuilderTest : public testing::Test { public: @@ -341,7 +341,7 @@ TEST_F(VersionBuilderTest, EstimatedActiveKeys) { (kEntriesPerFile - 2 * kDeletionsPerFile) * kNumFiles); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/version_edit.cc b/db/version_edit.cc index 7c39fb262..5d1714421 100644 --- a/db/version_edit.cc +++ b/db/version_edit.cc @@ -17,7 +17,7 @@ #include "util/coding.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // The unknown file checksum. const std::string kUnknownFileChecksum(""); // The unknown sst file checksum function name. @@ -799,4 +799,4 @@ std::string VersionEdit::DebugJSON(int edit_num, bool hex_key) const { return jw.Get(); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_edit.h b/db/version_edit.h index 3aabb9b46..6d1893f2a 100644 --- a/db/version_edit.h +++ b/db/version_edit.h @@ -19,7 +19,7 @@ #include "table/table_reader.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class VersionSet; @@ -435,4 +435,4 @@ class VersionEdit { uint32_t remaining_entries_ = 0; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_edit_test.cc b/db/version_edit_test.cc index 886935fab..8bc884df9 100644 --- a/db/version_edit_test.cc +++ b/db/version_edit_test.cc @@ -12,7 +12,7 @@ #include "test_util/testharness.h" #include "util/coding.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static void TestEncodeDecode(const VersionEdit& edit) { std::string encoded, encoded2; @@ -127,7 +127,7 @@ TEST_F(VersionEditTest, ForwardCompatibleNewFile4) { // Call back function to add extra customized builds. bool first = true; - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "VersionEdit::EncodeTo:NewFile4:CustomizeFields", [&](void* arg) { std::string* str = reinterpret_cast<std::string*>(arg); PutVarint32(str, 33); @@ -140,9 +140,9 @@ TEST_F(VersionEditTest, ForwardCompatibleNewFile4) { PutLengthPrefixedSlice(str, str2); } }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); edit.EncodeTo(&encoded); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); VersionEdit parsed; Status s = parsed.DecodeFrom(encoded); @@ -173,15 +173,15 @@ TEST_F(VersionEditTest, NewFile4NotSupportedField) { std::string encoded; // Call back function to add extra customized builds. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "VersionEdit::EncodeTo:NewFile4:CustomizeFields", [&](void* arg) { std::string* str = reinterpret_cast<std::string*>(arg); const std::string str1 = "s"; PutLengthPrefixedSlice(str, str1); }); - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); edit.EncodeTo(&encoded); - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); VersionEdit parsed; Status s = parsed.DecodeFrom(encoded); @@ -278,7 +278,7 @@ TEST_F(VersionEditTest, DbId) { TestEncodeDecode(edit); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/version_set.cc b/db/version_set.cc index 515e61fb0..b413ba50f 100644 --- a/db/version_set.cc +++ b/db/version_set.cc @@ -54,7 +54,7 @@ #include "util/string_util.h" #include "util/user_comparator_wrapper.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace { @@ -1859,7 +1859,7 @@ void Version::Get(const ReadOptions& read_options, const LookupKey& k, ROCKS_LOG_ERROR(info_log_, "Encounter unexpected blob index."); *status = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); return; } f = fp.GetNextFile(); @@ -2030,7 +2030,7 @@ void Version::MultiGet(const ReadOptions& read_options, MultiGetRange* range, ROCKS_LOG_ERROR(info_log_, "Encounter unexpected blob index."); *status = Status::NotSupported( "Encounter unexpected blob index. Please open DB with " - "rocksdb::blob_db::BlobDB instead."); + "ROCKSDB_NAMESPACE::blob_db::BlobDB instead."); file_range.MarkKeyDone(iter); continue; } @@ -6001,4 +6001,4 @@ Status ReactiveVersionSet::MaybeSwitchManifest( return s; } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_set.h b/db/version_set.h index 667fe56cb..2ab09a5f8 100644 --- a/db/version_set.h +++ b/db/version_set.h @@ -49,7 +49,7 @@ #include "table/multiget_context.h" #include "trace_replay/block_cache_tracer.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { namespace log { class Writer; @@ -279,7 +279,7 @@ class VersionStorageInfo { return files_[level]; } - const rocksdb::LevelFilesBrief& LevelFilesBrief(int level) const { + const ROCKSDB_NAMESPACE::LevelFilesBrief& LevelFilesBrief(int level) const { assert(level < static_cast<int>(level_files_brief_.size())); return level_files_brief_[level]; } @@ -443,7 +443,7 @@ class VersionStorageInfo { std::vector<uint64_t> level_max_bytes_; // A short brief metadata of files per level - autovector<rocksdb::LevelFilesBrief> level_files_brief_; + autovector<ROCKSDB_NAMESPACE::LevelFilesBrief> level_files_brief_; FileIndexer file_indexer_; Arena arena_; // Used to allocate space for file_levels_ @@ -1248,4 +1248,4 @@ class ReactiveVersionSet : public VersionSet { ReactiveVersionSet& operator=(const ReactiveVersionSet&); }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/version_set_test.cc b/db/version_set_test.cc index 3baf07e0a..03e0e26d2 100644 --- a/db/version_set_test.cc +++ b/db/version_set_test.cc @@ -16,7 +16,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class GenerateLevelFilesBriefTest : public testing::Test { public: @@ -1279,7 +1279,7 @@ INSTANTIATE_TEST_CASE_P( testing::Values(VersionSetTestBase::kColumnFamilyName1, VersionSetTestBase::kColumnFamilyName2, VersionSetTestBase::kColumnFamilyName3)); -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/wal_manager.cc b/db/wal_manager.cc index bb74ad03d..5b699274c 100644 --- a/db/wal_manager.cc +++ b/db/wal_manager.cc @@ -32,7 +32,7 @@ #include "util/mutexlock.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE @@ -507,4 +507,4 @@ Status WalManager::ReadFirstLine(const std::string& fname, } #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/wal_manager.h b/db/wal_manager.h index 6c387bf3a..783bfe99c 100644 --- a/db/wal_manager.h +++ b/db/wal_manager.h @@ -26,7 +26,7 @@ #include "rocksdb/transaction_log.h" #include "rocksdb/types.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { #ifndef ROCKSDB_LITE @@ -111,4 +111,4 @@ class WalManager { }; #endif // ROCKSDB_LITE -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/wal_manager_test.cc b/db/wal_manager_test.cc index 4763a6ba2..26bad368e 100644 --- a/db/wal_manager_test.cc +++ b/db/wal_manager_test.cc @@ -24,7 +24,7 @@ #include "test_util/testutil.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // TODO(icanadi) mock out VersionSet // TODO(icanadi) move other WalManager-specific tests from db_test here @@ -320,7 +320,7 @@ TEST_F(WalManagerTest, TransactionLogIteratorNewFileWhileScanning) { ASSERT_TRUE(iter->status().ok()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/write_batch.cc b/db/write_batch.cc index 43dbd995b..d578db59b 100644 --- a/db/write_batch.cc +++ b/db/write_batch.cc @@ -61,7 +61,7 @@ #include "util/string_util.h" #include "util/util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // anon namespace for file-local types namespace { @@ -2089,4 +2089,4 @@ size_t WriteBatchInternal::AppendedByteSize(size_t leftByteSize, } } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_batch_base.cc b/db/write_batch_base.cc index 5522c1ff7..e4c0e74bd 100644 --- a/db/write_batch_base.cc +++ b/db/write_batch_base.cc @@ -10,7 +10,7 @@ #include "rocksdb/slice.h" #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { // Simple implementation of SlicePart variants of Put(). Child classes // can override these method with more performant solutions if they choose. @@ -91,4 +91,4 @@ Status WriteBatchBase::Merge(const SliceParts& key, const SliceParts& value) { return Merge(key_slice, value_slice); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_batch_internal.h b/db/write_batch_internal.h index 3810c6722..30c489965 100644 --- a/db/write_batch_internal.h +++ b/db/write_batch_internal.h @@ -18,7 +18,7 @@ #include "rocksdb/write_batch.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class MemTable; class FlushScheduler; @@ -247,4 +247,4 @@ class LocalSavePoint { #endif }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_batch_test.cc b/db/write_batch_test.cc index a4c21cf62..84f9a45ec 100644 --- a/db/write_batch_test.cc +++ b/db/write_batch_test.cc @@ -21,7 +21,7 @@ #include "test_util/testharness.h" #include "util/string_util.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { static std::string PrintContents(WriteBatch* b) { InternalKeyComparator cmp(BytewiseComparator()); @@ -880,7 +880,7 @@ TEST_F(WriteBatchTest, MemoryLimitTest) { ASSERT_TRUE(s.IsMemoryLimit()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/write_callback.h b/db/write_callback.h index 6517a7c3a..106d02041 100644 --- a/db/write_callback.h +++ b/db/write_callback.h @@ -7,7 +7,7 @@ #include "rocksdb/status.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class DB; @@ -24,4 +24,4 @@ class WriteCallback { virtual bool AllowWriteBatching() = 0; }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_callback_test.cc b/db/write_callback_test.cc index 1ab97b045..df7d673aa 100644 --- a/db/write_callback_test.cc +++ b/db/write_callback_test.cc @@ -22,7 +22,7 @@ using std::string; -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class WriteCallbackTest : public testing::Test { public: @@ -185,7 +185,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) { std::atomic<uint64_t> seq(db_impl->GetLatestSequenceNumber()); ASSERT_EQ(db_impl->GetLatestSequenceNumber(), 0); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WriteThread::JoinBatchGroup:Start", [&](void*) { uint64_t cur_threads_joining = threads_joining.fetch_add(1); // Wait for the last joined writer to link to the queue. @@ -197,7 +197,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) { }); // Verification once writers call JoinBatchGroup. - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WriteThread::JoinBatchGroup:Wait", [&](void* arg) { uint64_t cur_threads_linked = threads_linked.fetch_add(1); bool is_leader = false; @@ -236,7 +236,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) { } }); - rocksdb::SyncPoint::GetInstance()->SetCallBack( + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( "WriteThread::JoinBatchGroup:DoneWaiting", [&](void* arg) { // check my state auto* writer = reinterpret_cast<WriteThread::Writer*>(arg); @@ -330,7 +330,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) { } }; - rocksdb::SyncPoint::GetInstance()->EnableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing(); // do all the writes std::vector<port::Thread> threads; @@ -341,7 +341,7 @@ TEST_F(WriteCallbackTest, WriteWithCallbackTest) { t.join(); } - rocksdb::SyncPoint::GetInstance()->DisableProcessing(); + ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); // check for keys string value; @@ -433,7 +433,7 @@ TEST_F(WriteCallbackTest, WriteCallBackTest) { DestroyDB(dbname, options); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/write_controller.cc b/db/write_controller.cc index 558aa7219..5480aabd1 100644 --- a/db/write_controller.cc +++ b/db/write_controller.cc @@ -10,7 +10,7 @@ #include <ratio> #include "rocksdb/env.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { std::unique_ptr<WriteControllerToken> WriteController::GetStopToken() { ++total_stopped_; @@ -125,4 +125,4 @@ CompactionPressureToken::~CompactionPressureToken() { assert(controller_->total_compaction_pressure_ >= 0); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_controller.h b/db/write_controller.h index 7c301ce7d..785ae6896 100644 --- a/db/write_controller.h +++ b/db/write_controller.h @@ -11,7 +11,7 @@ #include <memory> #include "rocksdb/rate_limiter.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class Env; class WriteControllerToken; @@ -141,4 +141,4 @@ class CompactionPressureToken : public WriteControllerToken { virtual ~CompactionPressureToken(); }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_controller_test.cc b/db/write_controller_test.cc index 919c2c118..72d116798 100644 --- a/db/write_controller_test.cc +++ b/db/write_controller_test.cc @@ -10,7 +10,7 @@ #include "rocksdb/env.h" #include "test_util/testharness.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class WriteControllerTest : public testing::Test {}; @@ -127,7 +127,7 @@ TEST_F(WriteControllerTest, SanityTest) { ASSERT_FALSE(controller.IsStopped()); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); diff --git a/db/write_thread.cc b/db/write_thread.cc index 98478e20d..5f50bba63 100644 --- a/db/write_thread.cc +++ b/db/write_thread.cc @@ -12,7 +12,7 @@ #include "test_util/sync_point.h" #include "util/random.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { WriteThread::WriteThread(const ImmutableDBOptions& db_options) : max_yield_usec_(db_options.enable_write_thread_adaptive_yield @@ -774,4 +774,4 @@ void WriteThread::WaitForMemTableWriters() { newest_memtable_writer_.store(nullptr); } -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE diff --git a/db/write_thread.h b/db/write_thread.h index e1db97066..878199714 100644 --- a/db/write_thread.h +++ b/db/write_thread.h @@ -24,7 +24,7 @@ #include "rocksdb/write_batch.h" #include "util/autovector.h" -namespace rocksdb { +namespace ROCKSDB_NAMESPACE { class WriteThread { public: @@ -428,4 +428,4 @@ class WriteThread { void CompleteFollower(Writer* w, WriteGroup& write_group); }; -} // namespace rocksdb +} // namespace ROCKSDB_NAMESPACE |