summaryrefslogtreecommitdiff
path: root/defs.bzl
diff options
context:
space:
mode:
authorYanqin Jin <yanqin@fb.com>2019-08-02 10:40:32 -0700
committerYanqin Jin <yanqin@fb.com>2019-09-06 10:16:19 -0700
commit3a10ffe9549edb5b70085f7351d11dffdb446f16 (patch)
tree5ae47fab729bd68b596a937f3f91f0400b2480ab /defs.bzl
parenta28b2cf9ed2c84b7db44455bb6f082d65f82a3f9 (diff)
Change buckifier to support parameterized dependencies (#5648)
Summary: Users may desire to specify extra dependencies via buck. This PR allows users to pass additional dependencies as a JSON object so that the buckifier script can generate TARGETS file with desired extra dependencies. Test plan (on dev server) ``` $python buckifier/buckify_rocksdb.py '{"fake": {"extra_deps": [":test_dep", "//fakes/module:mock1"], "extra_compiler_flags": ["-DROCKSDB_LITE", "-Os"]}}' Generating TARGETS Extra dependencies: {'': {'extra_compiler_flags': [], 'extra_deps': []}, 'test_dep1': {'extra_compiler_flags': ['-O2', '-DROCKSDB_LITE'], 'extra_deps': [':fake', '//dep1/mock']}} Generated TARGETS Summary: - 5 libs - 0 binarys - 296 tests ``` Verify the TARGETS file. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5648 Differential Revision: D16565043 Pulled By: riversand963 fbshipit-source-id: a6ef02274174fcf159692d7b846e828454d01e89
Diffstat (limited to 'defs.bzl')
-rw-r--r--defs.bzl8
1 files changed, 5 insertions, 3 deletions
diff --git a/defs.bzl b/defs.bzl
index a9f25ebcc..d5b7b6af7 100644
--- a/defs.bzl
+++ b/defs.bzl
@@ -12,7 +12,9 @@ def test_binary(
rocksdb_compiler_flags,
rocksdb_preprocessor_flags,
rocksdb_external_deps,
- rocksdb_os_deps):
+ rocksdb_os_deps,
+ extra_deps,
+ extra_compiler_flags):
TEST_RUNNER = native.package_name() + "/buckifier/rocks_test_runner.sh"
ttype = "gtest" if parallelism == "parallel" else "simple"
@@ -23,9 +25,9 @@ def test_binary(
srcs = [test_cc],
arch_preprocessor_flags = rocksdb_arch_preprocessor_flags,
os_preprocessor_flags = rocksdb_os_preprocessor_flags,
- compiler_flags = rocksdb_compiler_flags,
+ compiler_flags = rocksdb_compiler_flags + extra_compiler_flags,
preprocessor_flags = rocksdb_preprocessor_flags,
- deps = [":rocksdb_test_lib"],
+ deps = [":rocksdb_test_lib"] + extra_deps,
os_deps = rocksdb_os_deps,
external_deps = rocksdb_external_deps,
)