summaryrefslogtreecommitdiff
path: root/java
diff options
context:
space:
mode:
authorSiying Dong <siying.d@fb.com>2018-07-20 14:34:07 -0700
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>2018-07-20 14:43:38 -0700
commita5e851e113ba66fd82b651fd0d3b13750fb75a55 (patch)
tree5f5f73f527dbc288456bc245ca7b48b47495a004 /java
parent8425c8bd4db34788b70f10dfde416411a18dc653 (diff)
Reformatting some recent changes (#4161)
Summary: Lint is not happy with some new code recently committed. Format them. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4161 Differential Revision: D8940582 Pulled By: siying fbshipit-source-id: c9b43b1ef8c88b5e923911058b44eb77234b36b7
Diffstat (limited to 'java')
-rw-r--r--java/rocksjni/transaction.cc28
-rw-r--r--java/src/test/java/org/rocksdb/AbstractTransactionTest.java7
2 files changed, 17 insertions, 18 deletions
diff --git a/java/rocksjni/transaction.cc b/java/rocksjni/transaction.cc
index 62bf9e922..43be09560 100644
--- a/java/rocksjni/transaction.cc
+++ b/java/rocksjni/transaction.cc
@@ -18,7 +18,8 @@ using namespace std::placeholders;
#if defined(_MSC_VER)
#pragma warning(push)
-#pragma warning(disable : 4503) // identifier' : decorated name length exceeded, name was truncated
+#pragma warning(disable : 4503) // identifier' : decorated name length
+ // exceeded, name was truncated
#endif
/*
@@ -271,8 +272,8 @@ typedef std::function<std::vector<rocksdb::Status>(
void free_parts(
JNIEnv* env,
- std::vector<std::tuple<jbyteArray, jbyte*, jobject>> &parts_to_free) {
- for (auto &value : parts_to_free) {
+ std::vector<std::tuple<jbyteArray, jbyte*, jobject>>& parts_to_free) {
+ for (auto& value : parts_to_free) {
jobject jk;
jbyteArray jk_ba;
jbyte* jk_val;
@@ -671,10 +672,10 @@ void txn_write_kv_parts_helper(JNIEnv* env,
return;
}
- jparts_to_free.push_back(std::make_tuple(
- jba_key_part, jkey_part, jobj_key_part));
- jparts_to_free.push_back(std::make_tuple(
- jba_value_part, jvalue_part, jobj_value_part));
+ jparts_to_free.push_back(
+ std::make_tuple(jba_key_part, jkey_part, jobj_key_part));
+ jparts_to_free.push_back(
+ std::make_tuple(jba_value_part, jvalue_part, jobj_value_part));
key_parts.push_back(
rocksdb::Slice(reinterpret_cast<char*>(jkey_part), jkey_part_len));
@@ -684,8 +685,8 @@ void txn_write_kv_parts_helper(JNIEnv* env,
// call the write_multi function
rocksdb::Status s = fn_write_kv_parts(
- rocksdb::SliceParts(key_parts.data(), (int)key_parts.size()),
- rocksdb::SliceParts(value_parts.data(), (int)value_parts.size()));
+ rocksdb::SliceParts(key_parts.data(), (int)key_parts.size()),
+ rocksdb::SliceParts(value_parts.data(), (int)value_parts.size()));
// cleanup temporary memory
free_parts(env, jparts_to_free);
@@ -830,13 +831,11 @@ void Java_org_rocksdb_Transaction_delete__J_3BI(JNIEnv* env, jobject /*jobj*/,
typedef std::function<rocksdb::Status(const rocksdb::SliceParts&)>
FnWriteKParts;
-
// TODO(AR) consider refactoring to share this between here and rocksjni.cc
void txn_write_k_parts_helper(JNIEnv* env,
const FnWriteKParts& fn_write_k_parts,
const jobjectArray& jkey_parts,
const jint& jkey_parts_len) {
-
std::vector<rocksdb::Slice> key_parts;
std::vector<std::tuple<jbyteArray, jbyte*, jobject>> jkey_parts_to_free;
@@ -868,12 +867,13 @@ void txn_write_k_parts_helper(JNIEnv* env,
jkey_parts_to_free.push_back(std::tuple<jbyteArray, jbyte*, jobject>(
jba_key_part, jkey_part, jobj_key_part));
- key_parts.push_back(rocksdb::Slice(reinterpret_cast<char*>(jkey_part), jkey_part_len));
+ key_parts.push_back(
+ rocksdb::Slice(reinterpret_cast<char*>(jkey_part), jkey_part_len));
}
// call the write_multi function
- rocksdb::Status s =
- fn_write_k_parts(rocksdb::SliceParts(key_parts.data(), (int)key_parts.size()));
+ rocksdb::Status s = fn_write_k_parts(
+ rocksdb::SliceParts(key_parts.data(), (int)key_parts.size()));
// cleanup temporary memory
free_parts(env, jkey_parts_to_free);
diff --git a/java/src/test/java/org/rocksdb/AbstractTransactionTest.java b/java/src/test/java/org/rocksdb/AbstractTransactionTest.java
index 3a30b4b22..7cac3015b 100644
--- a/java/src/test/java/org/rocksdb/AbstractTransactionTest.java
+++ b/java/src/test/java/org/rocksdb/AbstractTransactionTest.java
@@ -686,13 +686,12 @@ public abstract class AbstractTransactionTest {
@Test
public void elapsedTime() throws RocksDBException, InterruptedException {
final long preStartTxnTime = System.currentTimeMillis();
- try(final DBContainer dbContainer = startDb();
- final Transaction txn = dbContainer.beginTransaction()) {
+ try (final DBContainer dbContainer = startDb();
+ final Transaction txn = dbContainer.beginTransaction()) {
Thread.sleep(2);
final long txnElapsedTime = txn.getElapsedTime();
- assertThat(txnElapsedTime).isLessThan(System.currentTimeMillis()
- - preStartTxnTime);
+ assertThat(txnElapsedTime).isLessThan(System.currentTimeMillis() - preStartTxnTime);
assertThat(txnElapsedTime).isGreaterThan(0);
}
}