diff options
| author | Andrew Kryczka <andrewkr@fb.com> | 2017-06-02 12:08:01 -0700 |
|---|---|---|
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2017-06-02 12:12:06 -0700 |
| commit | a4d9c02511d143d96a0c91e822449ec437f7483b (patch) | |
| tree | bd6e0bf6166abf3a930479d59fb71b2a162a8b01 /memtable | |
| parent | f68d88be51cc2ed7d9f0e4f09800b3b3320f2ffb (diff) | |
Pass CF ID to MemTableRepFactory
Summary:
Some users want to monitor column family activity in their custom memtable implementations. Previously there was no way to figure out with which column family a memtable is associated. This diff:
- adds an overload to MemTableRepFactory::CreateMemTableRep() that provides the CF ID. For compatibility, its default implementation calls the old overload.
- updates MemTable to create MemTableRep's using the new overload.
Closes https://github.com/facebook/rocksdb/pull/2346
Differential Revision: D5108061
Pulled By: ajkr
fbshipit-source-id: 3a1921214a348dd8ea0f54e1cab3b71c3d46d616
Diffstat (limited to 'memtable')
| -rw-r--r-- | memtable/hash_cuckoo_rep.h | 1 | ||||
| -rw-r--r-- | memtable/hash_linklist_rep.h | 1 | ||||
| -rw-r--r-- | memtable/hash_skiplist_rep.h | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/memtable/hash_cuckoo_rep.h b/memtable/hash_cuckoo_rep.h index 173a907b4..fdb977c24 100644 --- a/memtable/hash_cuckoo_rep.h +++ b/memtable/hash_cuckoo_rep.h @@ -28,6 +28,7 @@ class HashCuckooRepFactory : public MemTableRepFactory { virtual ~HashCuckooRepFactory() {} + using MemTableRepFactory::CreateMemTableRep; virtual MemTableRep* CreateMemTableRep( const MemTableRep::KeyComparator& compare, MemTableAllocator* allocator, const SliceTransform* transform, Logger* logger) override; diff --git a/memtable/hash_linklist_rep.h b/memtable/hash_linklist_rep.h index 5197e7cfb..f792b5b88 100644 --- a/memtable/hash_linklist_rep.h +++ b/memtable/hash_linklist_rep.h @@ -28,6 +28,7 @@ class HashLinkListRepFactory : public MemTableRepFactory { virtual ~HashLinkListRepFactory() {} + using MemTableRepFactory::CreateMemTableRep; virtual MemTableRep* CreateMemTableRep( const MemTableRep::KeyComparator& compare, MemTableAllocator* allocator, const SliceTransform* transform, Logger* logger) override; diff --git a/memtable/hash_skiplist_rep.h b/memtable/hash_skiplist_rep.h index 56a289c4b..e26e0f57b 100644 --- a/memtable/hash_skiplist_rep.h +++ b/memtable/hash_skiplist_rep.h @@ -25,6 +25,7 @@ class HashSkipListRepFactory : public MemTableRepFactory { virtual ~HashSkipListRepFactory() {} + using MemTableRepFactory::CreateMemTableRep; virtual MemTableRep* CreateMemTableRep( const MemTableRep::KeyComparator& compare, MemTableAllocator* allocator, const SliceTransform* transform, Logger* logger) override; |