diff options
| author | Peter Dillinger <peterd@fb.com> | 2022-01-21 13:03:15 -0800 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2022-01-21 13:04:19 -0800 |
| commit | e7ac7363b44163b9b59cd86b639cc05841196d4e (patch) | |
| tree | 46b647753ab884c3983c4927150c52f080af9aa4 /port/win | |
| parent | fc9d4071f0c504e107d7e1e11ed173175003a99b (diff) | |
Add to HISTORY and minor loose ends from #9294, #9254 (#9386)
Summary:
Loose ends relate to mmap on 32-bit systems. (Testing is more
complicated when the feature was completely disabled on 32-bit.)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9386
Test Plan: CI
Reviewed By: ajkr
Differential Revision: D33590715
Pulled By: pdillinger
fbshipit-source-id: f2637036a538a552200adee65b6765fce8cae27b
Diffstat (limited to 'port/win')
| -rw-r--r-- | port/win/env_win.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/port/win/env_win.cc b/port/win/env_win.cc index ac069d7f1..3108cf6e7 100644 --- a/port/win/env_win.cc +++ b/port/win/env_win.cc @@ -297,9 +297,9 @@ IOStatus WinFileSystem::NewRandomAccessFile( UniqueCloseHandlePtr fileGuard(hFile, CloseHandleFunc); - // CAUTION! This will map the entire file into the process address space - if (options.use_mmap_reads && sizeof(void*) >= 8) { - // Use mmap when virtual address-space is plentiful. + // CAUTION! This will map the entire file into the process address space. + // Not recommended for 32-bit platforms. + if (options.use_mmap_reads) { uint64_t fileSize; s = GetFileSize(fname, IOOptions(), &fileSize, dbg); |