summaryrefslogtreecommitdiff
path: root/src.mk
diff options
context:
space:
mode:
authorLevi Tamasi <ltamasi@fb.com>2019-07-23 15:57:43 -0700
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>2019-07-23 16:01:44 -0700
commit092f41703798011db3cc118d1b32c8ca5ddf9749 (patch)
treed898121fdf9a544c953c9cebad85134c5c87f5ee /src.mk
parent6b7fcc0d5f8c91f891f243906e6431969cfa8d11 (diff)
Move the uncompression dictionary object out of the block cache (#5584)
Summary: RocksDB has historically stored uncompression dictionary objects in the block cache as opposed to storing just the block contents. This neccesitated evicting the object upon table close. With the new code, only the raw blocks are stored in the cache, eliminating the need for eviction. In addition, the patch makes the following improvements: 1) Compression dictionary blocks are now prefetched/pinned similarly to index/filter blocks. 2) A copy operation got eliminated when the uncompression dictionary is retrieved. 3) Errors related to retrieving the uncompression dictionary are propagated as opposed to silently ignored. Note: the patch temporarily breaks the compression dictionary evicition stats. They will be fixed in a separate phase. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5584 Test Plan: make asan_check Differential Revision: D16344151 Pulled By: ltamasi fbshipit-source-id: 2962b295f5b19628f9da88a3fcebbce5a5017a7b
Diffstat (limited to 'src.mk')
-rw-r--r--src.mk1
1 files changed, 1 insertions, 0 deletions
diff --git a/src.mk b/src.mk
index 4d635173b..0f04fc739 100644
--- a/src.mk
+++ b/src.mk
@@ -121,6 +121,7 @@ LIB_SOURCES = \
table/block_based/full_filter_block.cc \
table/block_based/index_builder.cc \
table/block_based/partitioned_filter_block.cc \
+ table/block_based/uncompression_dict_reader.cc \
table/block_fetcher.cc \
table/bloom_block.cc \
table/cuckoo/cuckoo_table_builder.cc \