diff options
| author | Stephen Hemminger <stephen@networkplumber.org> | 2024-04-23 20:45:40 -0700 |
|---|---|---|
| committer | Jerin Jacob <jerinj@marvell.com> | 2024-05-30 12:28:49 +0200 |
| commit | 1844f4a0022a5d7eb771ec8bc5ef1a6fc7b91b55 (patch) | |
| tree | cad4aaab4ebc4b6a1e7cbbb00764877b55f815b7 | |
| parent | cef922c9e0c53b05a7b939116b386993570c9bf9 (diff) | |
event/sw: fix warning from useless snprintf
With GCC-14, this warning is generated:
drivers/event/sw/sw_evdev.c:263:3: warning:
snprintf' will always be truncated;
specified size is 12, but format string expands to at least 13
snprintf(buf, sizeof(buf), "sw%d_iq_%d_rob", dev_id, i);
^
Yet the whole printf to the buf is unnecessary. The type string argument
has never been implemented, and should just be NULL. Removing the
unnecessary snprintf, then means IQ_ROB_NAMESIZE can be removed.
Fixes: 5ffb2f142d95 ("event/sw: support event queues")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
| -rw-r--r-- | drivers/event/sw/iq_chunk.h | 2 | ||||
| -rw-r--r-- | drivers/event/sw/sw_evdev.c | 5 |
2 files changed, 1 insertions, 6 deletions
diff --git a/drivers/event/sw/iq_chunk.h b/drivers/event/sw/iq_chunk.h index 7a7a8782e6..e638142dbc 100644 --- a/drivers/event/sw/iq_chunk.h +++ b/drivers/event/sw/iq_chunk.h @@ -9,8 +9,6 @@ #include <stdbool.h> #include <rte_eventdev.h> -#define IQ_ROB_NAMESIZE 12 - struct __rte_cache_aligned sw_queue_chunk { struct rte_event events[SW_EVS_PER_Q_CHUNK]; struct sw_queue_chunk *next; diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 1c01b069fe..19a52afc7d 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/sw_evdev.c @@ -228,9 +228,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type, const struct rte_event_queue_conf *queue_conf) { unsigned int i; - int dev_id = sw->data->dev_id; int socket_id = sw->data->socket_id; - char buf[IQ_ROB_NAMESIZE]; struct sw_qid *qid = &sw->qids[idx]; /* Initialize the FID structures to no pinning (-1), and zero packets */ @@ -260,8 +258,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type, goto cleanup; } - snprintf(buf, sizeof(buf), "sw%d_iq_%d_rob", dev_id, i); - qid->reorder_buffer = rte_zmalloc_socket(buf, + qid->reorder_buffer = rte_zmalloc_socket(NULL, window_size * sizeof(qid->reorder_buffer[0]), 0, socket_id); if (!qid->reorder_buffer) { |