summaryrefslogtreecommitdiff
path: root/dts
diff options
context:
space:
mode:
authorJoshua Washington <joshwash@google.com>2023-11-13 15:12:06 -0800
committerFerruh Yigit <ferruh.yigit@amd.com>2023-11-14 15:49:54 +0100
commit835021a845f5d8ef5a22c31547f61c1af8505ced (patch)
tree4b083ad841c85f33ee1edb758ace19060cde3ec4 /dts
parentdd282c38290c77fb78389a8c646cb385b9a68931 (diff)
net/gve: fix Rx buffer size alignment
In GVE, both queue formats have RX buffer size alignment requirements which will not always be respected when a user specifies an mbuf size. Assuming that an mbuf size is greater than the DPDK recommended default (2048 + 128), if the buffer size is not properly aligned with what the device expects, the device will silently fail to create any transmit or receive queues. Because no queues are created, there is no network traffic for the DPDK program, and errors like the following are returned when attempting to destroy queues: gve_adminq_parse_err(): AQ command failed with status -11 gve_stop_tx_queues(): failed to destroy txqs gve_adminq_parse_err(): AQ command failed with status -11 gve_stop_rx_queues(): failed to destroy rxqs This change aims to remedy this by restricting the RX receive buffer sizes to valid sizes for their respective queue formats, including both alignment and minimum and maximum supported buffer sizes. Fixes: 4bec2d0b5572 ("net/gve: support queue operations") Fixes: 1dc00f4fc74b ("net/gve: add Rx queue setup for DQO") Cc: stable@dpdk.org Signed-off-by: Joshua Washington <joshwash@google.com> Reviewed-by: Rushil Gupta <rushilg@google.com> Acked-by: Junfeng Guo <junfeng.guo@intel.com>
Diffstat (limited to 'dts')
0 files changed, 0 insertions, 0 deletions