summaryrefslogtreecommitdiff
path: root/.github
diff options
context:
space:
mode:
authorEmil Ernerfeldt <emil.ernerfeldt@gmail.com>2024-04-25 17:24:50 +0200
committerGitHub <noreply@github.com>2024-04-25 17:24:50 +0200
commit2f508d6a6163c8b40ddded83eb2a7390d1e4c1e7 (patch)
treee34f038c7a2b05fa191c5385689708db184468e3 /.github
parentcee790681d10971afdbb94aa734db71fd9ce28e6 (diff)
Replace cargo-cranky with workspace lints (#4413)
Replace `cargo-cranky` (which has served us well) with workspace lints
Diffstat (limited to '.github')
-rw-r--r--.github/pull_request_template.md2
-rw-r--r--.github/workflows/rust.yml20
2 files changed, 6 insertions, 16 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index c3bc2392..98a3b496 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -6,7 +6,7 @@ Please read the "Making a PR" section of [`CONTRIBUTING.md`](https://github.com/
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to `egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for maintainers to add commits to your PR.
-* Remember to run `cargo fmt` and `cargo cranky`.
+* Remember to run `cargo fmt` and `cargo clippy`.
* Open the PR as a draft until you have self-reviewed it and run `./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 89983a2c..26404d29 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -40,11 +40,6 @@ jobs:
- name: Lint vertical spacing
run: ./scripts/lint.py
- - name: Install cargo-cranky
- uses: baptiste0928/cargo-install@v1
- with:
- crate: cargo-cranky
-
- name: check --all-features
run: cargo check --locked --all-features --all-targets
@@ -78,11 +73,11 @@ jobs:
- name: Test
run: cargo test --all-features
- - name: Cranky
- run: cargo cranky --all-targets --all-features -- -D warnings
+ - name: clippy
+ run: cargo clippy --all-targets --all-features -- -D warnings
- - name: Cranky release
- run: cargo cranky --all-targets --all-features --release -- -D warnings
+ - name: clippy release
+ run: cargo clippy --all-targets --all-features --release -- -D warnings
# ---------------------------------------------------------------------------
@@ -101,11 +96,6 @@ jobs:
- name: Set up cargo cache
uses: Swatinem/rust-cache@v2
- - name: Install cargo-cranky
- uses: baptiste0928/cargo-install@v1
- with:
- crate: cargo-cranky
-
- name: Check wasm32 egui_demo_app
run: cargo check -p egui_demo_app --lib --target wasm32-unknown-unknown
@@ -122,7 +112,7 @@ jobs:
- run: ./scripts/wasm_bindgen_check.sh --skip-setup
- - name: Cranky wasm32
+ - name: clippy wasm32
run: ./scripts/clippy_wasm.sh
# ---------------------------------------------------------------------------