summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim-Philipp Müller <tim@centricular.com>2024-06-19 02:10:29 +0100
committerBackport Bot <gitlab-backport-bot@gstreamer-foundation.org>2024-06-19 10:11:28 +0100
commitf6af34d3be9e295d53c561726269e3b18ae3759d (patch)
tree04828bebb6e0c83f7b573e2bed7fcf81aff77c76
parent02447fa0b2014ecd46444e8f15a7c3e979e9fa0e (diff)
rtpdtmfsrc: minor logging clean-up
Only serialise event structure for debug logging purposes if logging is actually enabled. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7062>
-rw-r--r--subprojects/gst-plugins-good/gst/dtmf/gstrtpdtmfsrc.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/subprojects/gst-plugins-good/gst/dtmf/gstrtpdtmfsrc.c b/subprojects/gst-plugins-good/gst/dtmf/gstrtpdtmfsrc.c
index 2fbcfbfed0..8d3e362f67 100644
--- a/subprojects/gst-plugins-good/gst/dtmf/gstrtpdtmfsrc.c
+++ b/subprojects/gst-plugins-good/gst/dtmf/gstrtpdtmfsrc.c
@@ -352,9 +352,7 @@ gst_rtp_dtmf_src_handle_custom_upstream (GstRTPDTMFSrc * dtmfsrc,
GstEvent * event)
{
gboolean result = FALSE;
- gchar *struct_str;
const GstStructure *structure;
-
GstState state;
GstStateChangeReturn ret;
@@ -364,11 +362,10 @@ gst_rtp_dtmf_src_handle_custom_upstream (GstRTPDTMFSrc * dtmfsrc,
goto ret;
}
- GST_DEBUG_OBJECT (dtmfsrc, "Received event is of our interest");
structure = gst_event_get_structure (event);
- struct_str = gst_structure_to_string (structure);
- GST_DEBUG_OBJECT (dtmfsrc, "Event has structure %s", struct_str);
- g_free (struct_str);
+
+ GST_DEBUG_OBJECT (dtmfsrc, "Received event: %" GST_PTR_FORMAT, structure);
+
if (structure && gst_structure_has_name (structure, "dtmf-event"))
result = gst_rtp_dtmf_src_handle_dtmf_event (dtmfsrc, structure);
@@ -384,7 +381,9 @@ gst_rtp_dtmf_src_handle_event (GstBaseSrc * basesrc, GstEvent * event)
dtmfsrc = GST_RTP_DTMF_SRC (basesrc);
- GST_DEBUG_OBJECT (dtmfsrc, "Received an event on the src pad");
+ GST_DEBUG_OBJECT (dtmfsrc, "Received %s event on the src pad",
+ GST_EVENT_TYPE_NAME (event));
+
if (GST_EVENT_TYPE (event) == GST_EVENT_CUSTOM_UPSTREAM) {
result = gst_rtp_dtmf_src_handle_custom_upstream (dtmfsrc, event);
}