summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrea Claudi <aclaudi@redhat.com>2023-05-26 19:27:20 +0200
committerStephen Hemminger <stephen@networkplumber.org>2023-05-26 12:00:30 -0700
commit33c3776b3ab652a231b36a5aa319874aebad3c59 (patch)
treeb786589b492cb37e48ea67228eb6876a196900da
parent72df7f7e25cb832ff4d6690984adb60b0f5882bb (diff)
bridge: vni: remove useless checks on vni
After the (d == NULL || vni == NULL) check, vni cannot be NULL anymore. This remove two useless conditional checks on vni value: - the first check cannot be true, so remove the whole conditional block - the second check is always true, so remove the check Signed-off-by: Andrea Claudi <aclaudi@redhat.com> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
-rw-r--r--bridge/vni.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/bridge/vni.c b/bridge/vni.c
index 940f251c..77328a4f 100644
--- a/bridge/vni.c
+++ b/bridge/vni.c
@@ -138,14 +138,8 @@ static int vni_modify(int cmd, int argc, char **argv)
return -1;
}
- if (!vni && group_present) {
- fprintf(stderr, "Group can only be specified with a vni\n");
- return -1;
- }
-
- if (vni)
- parse_vni_filter(vni, &req.n, sizeof(req),
- (group_present ? &daddr : NULL));
+ parse_vni_filter(vni, &req.n, sizeof(req),
+ (group_present ? &daddr : NULL));
req.tmsg.ifindex = ll_name_to_index(d);
if (req.tmsg.ifindex == 0) {