summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/net/nl_netdev.py
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2024-04-17 16:11:40 -0700
committerJakub Kicinski <kuba@kernel.org>2024-04-18 16:15:31 -0700
commit4fa6bd4b33ac9b914e3d1bb95848239ab8fdde1a (patch)
tree85488d7645d62a06b7c5a5a62d9e0c501a852182 /tools/testing/selftests/net/nl_netdev.py
parent655614ea2bd3b5774cdb95c7630d8327bf221934 (diff)
selftests: net: set the exit code correctly in Python tests
Test cases need to exit with non-zero status if they failed, we currently don't do that: # KTAP version 1 # 1..3 # # At /root/ksft-net-drv/drivers/net/./ping.py line 18: # # Check failed 1 != 2 # not ok 1 ping.test_v4 # ok 2 ping.test_v6 # ok 3 ping.test_tcp # # Totals: pass:2 fail:1 xfail:0 xpass:0 skip:0 error:0 ok 1 selftests: drivers/net: ping.py ^^^^ It's a bit tempting to make the exit part of ksft_run(), but that only works well for very trivial setups. We can revisit this later, if people forget to call ksft_exit(). Link: https://lore.kernel.org/r/20240417231146.2435572-3-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/testing/selftests/net/nl_netdev.py')
-rwxr-xr-xtools/testing/selftests/net/nl_netdev.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/nl_netdev.py b/tools/testing/selftests/net/nl_netdev.py
index 6909b1760739..93d9d914529b 100755
--- a/tools/testing/selftests/net/nl_netdev.py
+++ b/tools/testing/selftests/net/nl_netdev.py
@@ -2,7 +2,8 @@
# SPDX-License-Identifier: GPL-2.0
import time
-from lib.py import ksft_run, ksft_pr, ksft_eq, ksft_ge, ksft_busy_wait
+from lib.py import ksft_run, ksft_exit, ksft_pr
+from lib.py import ksft_eq, ksft_ge, ksft_busy_wait
from lib.py import NetdevFamily, NetdevSimDev, ip
@@ -90,6 +91,7 @@ def main() -> None:
nf = NetdevFamily()
ksft_run([empty_check, lo_check, page_pool_check],
args=(nf, ))
+ ksft_exit()
if __name__ == "__main__":