summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDarren Schroeder <343840+fdncred@users.noreply.github.com>2024-09-23 06:43:19 -0500
committerGitHub <noreply@github.com>2024-09-23 06:43:19 -0500
commitee877607fb5500d378e261a4a4f3495db8deec03 (patch)
treed9747e02c039cc68b8e15fe43265ba838a872cb8
parent93351b889a6603cd794ed96c52845879d9a6f3f4 (diff)
fix the ability to add a plugin by name instead of path (#13877)
# Description This plugin fixes the ability to do `plugin add nu_plugin_polars` and have nushell look in NU_PLUGINS_DIR to find the plugin and add it. closes #13040 # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
-rw-r--r--crates/nu-cmd-plugin/src/commands/plugin/add.rs6
1 files changed, 2 insertions, 4 deletions
diff --git a/crates/nu-cmd-plugin/src/commands/plugin/add.rs b/crates/nu-cmd-plugin/src/commands/plugin/add.rs
index fa0b599de..c12f48666 100644
--- a/crates/nu-cmd-plugin/src/commands/plugin/add.rs
+++ b/crates/nu-cmd-plugin/src/commands/plugin/add.rs
@@ -1,10 +1,9 @@
+use crate::util::{get_plugin_dirs, modify_plugin_file};
use nu_engine::command_prelude::*;
use nu_plugin_engine::{GetPlugin, PersistentPlugin};
use nu_protocol::{PluginGcConfig, PluginIdentity, PluginRegistryItem, RegisteredPlugin};
use std::sync::Arc;
-use crate::util::{get_plugin_dirs, modify_plugin_file};
-
#[derive(Clone)]
pub struct PluginAdd;
@@ -31,7 +30,7 @@ impl Command for PluginAdd {
)
.required(
"filename",
- SyntaxShape::Filepath,
+ SyntaxShape::String,
"Path to the executable for the plugin",
)
.category(Category::Plugin)
@@ -81,7 +80,6 @@ apparent the next time `nu` is next launched with that plugin registry file.
) -> Result<PipelineData, ShellError> {
let filename: Spanned<String> = call.req(engine_state, stack, 0)?;
let shell: Option<Spanned<String>> = call.get_flag(engine_state, stack, "shell")?;
-
let cwd = engine_state.cwd(Some(stack))?;
// Check the current directory, or fall back to NU_PLUGIN_DIRS