summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Dinh <andrewd@openssl.org>2024-08-16 20:55:16 +0700
committerNeil Horman <nhorman@openssl.org>2024-08-17 17:32:17 -0400
commit47645bf7c63aaf08b764bfeaaa611c6673bb03a8 (patch)
treea429a89e037d2070c7dfeec041c19a50f1324ff3
parent8d28402ce38842e8aca9e0ce26ae44fa10c7b62e (diff)
list_tls_signatures(): Avoid leak with zero length builtin_sigalgsHEADmaster
Fixes Coverity 1616307 Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/25219)
-rw-r--r--apps/list.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/apps/list.c b/apps/list.c
index 679a27c88b..fbfb4ae091 100644
--- a/apps/list.c
+++ b/apps/list.c
@@ -779,10 +779,12 @@ static void list_tls_signatures(void)
int tls_sigalg_listed = 0;
char *builtin_sigalgs = SSL_get1_builtin_sigalgs(app_get0_libctx());
- if (builtin_sigalgs != NULL && builtin_sigalgs[0] != 0) {
- BIO_printf(bio_out, "%s", builtin_sigalgs);
+ if (builtin_sigalgs != NULL) {
+ if (builtin_sigalgs[0] != 0) {
+ BIO_printf(bio_out, "%s", builtin_sigalgs);
+ tls_sigalg_listed = 1;
+ }
OPENSSL_free(builtin_sigalgs);
- tls_sigalg_listed = 1;
}
/* As built-in providers don't have this capability, never error */