diff options
author | slontis <shane.lontis@oracle.com> | 2023-02-27 16:35:41 +1000 |
---|---|---|
committer | Pauli <pauli@openssl.org> | 2023-03-01 09:36:49 +1100 |
commit | 3307338e26862070eaacad6ec7537a63a63b8a90 (patch) | |
tree | ec6925b678da022afd52227a9df98a9e6b00f5c0 /test/evp_extra_test2.c | |
parent | 5f820bd7535b871fdfdc0303c3af23ba4be901f0 (diff) |
Fix FFC mdprop setting bugs.
Coverage testing showed that ossl_ffc_params_fromdata() was not setting
OSSL_PKEY_PARAM_FFC_DIGEST_PROPS.
Adding a negative test also showed that ossl_ffc_params_copy() did not
do a shallow copy of the digest or digest property.
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20385)
Diffstat (limited to 'test/evp_extra_test2.c')
-rw-r--r-- | test/evp_extra_test2.c | 43 |
1 files changed, 43 insertions, 0 deletions
diff --git a/test/evp_extra_test2.c b/test/evp_extra_test2.c index effefdaa05..74a86c14e6 100644 --- a/test/evp_extra_test2.c +++ b/test/evp_extra_test2.c @@ -387,6 +387,7 @@ static int test_dh_paramgen(void) EVP_PKEY_free(pkey); return ret; } + #endif #ifndef OPENSSL_NO_EC @@ -1003,6 +1004,47 @@ err: OSSL_PARAM_free(to_params); return ret; } + +/* + * Test that OSSL_PKEY_PARAM_FFC_DIGEST_PROPS is set properly when using fromdata + * This test: + * checks for failure when the property query is bad (tstid == 0) + * checks for success when the property query is valid (tstid == 1) + */ +static int test_dsa_fromdata_digest_prop(int tstid) +{ + EVP_PKEY_CTX *ctx = NULL, *gctx = NULL; + EVP_PKEY *pkey = NULL, *pkey2 = NULL; + OSSL_PARAM params[4], *p = params; + int ret = 0; + int expected = (tstid == 0 ? 0 : 1); + unsigned int pbits = 512; /* minimum allowed for speed */ + + *p++ = OSSL_PARAM_construct_uint(OSSL_PKEY_PARAM_FFC_PBITS, &pbits); + *p++ = OSSL_PARAM_construct_utf8_string(OSSL_PKEY_PARAM_FFC_DIGEST, "SHA512", 0); + /* Setting a bad prop query here should fail during paramgen - when it tries to do a fetch */ + *p++ = OSSL_PARAM_construct_utf8_string(OSSL_PKEY_PARAM_FFC_DIGEST_PROPS, + tstid == 0 ? "provider=unknown" : "provider=default", 0); + *p++ = OSSL_PARAM_construct_end(); + + if (!TEST_ptr(ctx = EVP_PKEY_CTX_new_from_name(mainctx, "DSA", NULL)) + || !TEST_int_eq(EVP_PKEY_fromdata_init(ctx), 1) + || !TEST_int_eq(EVP_PKEY_fromdata(ctx, &pkey, EVP_PKEY_KEY_PARAMETERS, params), 1)) + goto err; + + if (!TEST_ptr(gctx = EVP_PKEY_CTX_new_from_pkey(mainctx, pkey, NULL)) + || !TEST_int_eq(EVP_PKEY_paramgen_init(gctx), 1) + || !TEST_int_eq(EVP_PKEY_paramgen(gctx, &pkey2), expected)) + goto err; + + ret = 1; +err: + EVP_PKEY_free(pkey2); + EVP_PKEY_free(pkey); + EVP_PKEY_CTX_free(ctx); + EVP_PKEY_CTX_free(gctx); + return ret; +} #endif /* OPENSSL_NO_DSA */ static int test_pkey_todata_null(void) @@ -1200,6 +1242,7 @@ int setup_tests(void) #ifndef OPENSSL_NO_DSA ADD_TEST(test_dsa_todata); ADD_TEST(test_dsa_tofrom_data_select); + ADD_ALL_TESTS(test_dsa_fromdata_digest_prop, 2); #endif #ifndef OPENSSL_NO_DH ADD_TEST(test_dh_tofrom_data_select); |