summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Dominik <carsten.dominik@gmail.com>2008-12-23 07:16:10 +0100
committerCarsten Dominik <carsten.dominik@gmail.com>2008-12-23 07:16:10 +0100
commit28c6318dbaf1ed7c85eb246f821ce6acc2823563 (patch)
tree0feaeb4aef76f4b97a5bb9ef487fbceaee23397c
parent76e18b30e9c54520439ef48f87fff1413b161361 (diff)
Remember: Safer way to access new buffer.release_6.16b
The remember handler was creating a buffer with `find-file-noselect', and then trying to find it back using `get-file-buffer'. Apparently there are situations where this can fail, to we now use directly the buffer returned by `find-file-noselect'.
-rwxr-xr-xlisp/ChangeLog3
-rw-r--r--lisp/org-remember.el3
2 files changed, 4 insertions, 2 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 65a33f3b9..9388d9dd0 100755
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,8 @@
2008-12-23 Carsten Dominik <carsten.dominik@gmail.com>
+ * org-remember.el (org-remember-handler): Safer way to get a new
+ buffer accessing the target file.
+
* org.el (org-refile-get-location): Handle case of current buffer
not having a file associated with it.
diff --git a/lisp/org-remember.el b/lisp/org-remember.el
index 2b1ae9636..4525bda3e 100644
--- a/lisp/org-remember.el
+++ b/lisp/org-remember.el
@@ -809,8 +809,7 @@ See also the variable `org-reverse-note-order'."
(move-marker org-remember-last-stored-marker (point)))
(throw 'quit t))
;; Find the file
- (if (not visiting) (find-file-noselect file))
- (with-current-buffer (or visiting (get-file-buffer file))
+ (with-current-buffer (or visiting (find-file-noselect file))
(unless (org-mode-p)
(error "Target files for remember notes must be in Org-mode"))
(save-excursion