summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJake Correnti <jakecorrenti+github@proton.me>2024-09-24 15:33:33 -0400
committerJake Correnti <jakecorrenti+github@proton.me>2024-09-24 15:36:14 -0400
commit9febd2c27ad6708f1b49326ab00758e499a66617 (patch)
tree6ffafc19f6c203f56e424584ffb26d4ce2fa3b0b
parente041f2a7b781ed93e18ef3db69eec4aeca50c18f (diff)
Move `DefaultMachineName` to `pkg/machine/define`
Moves the `DefaultMachineName` constant out of `pkg/machine` and into `pkg/machine/define`. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
-rw-r--r--cmd/podman/machine/init.go3
-rw-r--r--cmd/podman/machine/os/manager.go4
-rw-r--r--pkg/machine/config.go5
-rw-r--r--pkg/machine/define/config.go7
-rw-r--r--pkg/machine/machine_common.go5
5 files changed, 12 insertions, 12 deletions
diff --git a/cmd/podman/machine/init.go b/cmd/podman/machine/init.go
index 6f0579a97..69afdc02c 100644
--- a/cmd/podman/machine/init.go
+++ b/cmd/podman/machine/init.go
@@ -11,7 +11,6 @@ import (
"github.com/containers/podman/v5/cmd/podman/registry"
ldefine "github.com/containers/podman/v5/libpod/define"
"github.com/containers/podman/v5/libpod/events"
- "github.com/containers/podman/v5/pkg/machine"
"github.com/containers/podman/v5/pkg/machine/define"
"github.com/containers/podman/v5/pkg/machine/shim"
"github.com/containers/podman/v5/pkg/machine/vmconfigs"
@@ -34,7 +33,7 @@ var (
initOpts = define.InitOptions{}
initOptionalFlags = InitOptionalFlags{}
- defaultMachineName = machine.DefaultMachineName
+ defaultMachineName = define.DefaultMachineName
now bool
)
diff --git a/cmd/podman/machine/os/manager.go b/cmd/podman/machine/os/manager.go
index 1e028be23..234246cf1 100644
--- a/cmd/podman/machine/os/manager.go
+++ b/cmd/podman/machine/os/manager.go
@@ -9,7 +9,7 @@ import (
"strings"
machineconfig "github.com/containers/common/pkg/machine"
- pkgMachine "github.com/containers/podman/v5/pkg/machine"
+ "github.com/containers/podman/v5/pkg/machine/define"
"github.com/containers/podman/v5/pkg/machine/env"
pkgOS "github.com/containers/podman/v5/pkg/machine/os"
"github.com/containers/podman/v5/pkg/machine/provider"
@@ -47,7 +47,7 @@ func guestOSManager() (pkgOS.Manager, error) {
func machineOSManager(opts ManagerOpts, _ vmconfigs.VMProvider) (pkgOS.Manager, error) {
vmName := opts.VMName
if opts.VMName == "" {
- vmName = pkgMachine.DefaultMachineName
+ vmName = define.DefaultMachineName
}
p, err := provider.Get()
if err != nil {
diff --git a/pkg/machine/config.go b/pkg/machine/config.go
index 25a9aae69..046b94b0f 100644
--- a/pkg/machine/config.go
+++ b/pkg/machine/config.go
@@ -20,10 +20,7 @@ import (
"github.com/sirupsen/logrus"
)
-const (
- DefaultMachineName string = "podman-machine-default"
- apiUpTimeout = 20 * time.Second
-)
+const apiUpTimeout = 20 * time.Second
var (
ForwarderBinaryName = "gvproxy"
diff --git a/pkg/machine/define/config.go b/pkg/machine/define/config.go
index 90135f76f..b6c07342c 100644
--- a/pkg/machine/define/config.go
+++ b/pkg/machine/define/config.go
@@ -2,8 +2,11 @@ package define
import "os"
-const UserCertsTargetPath = "/etc/containers/certs.d"
-const DefaultIdentityName = "machine"
+const (
+ UserCertsTargetPath = "/etc/containers/certs.d"
+ DefaultIdentityName = "machine"
+ DefaultMachineName = "podman-machine-default"
+)
// MountTag is an identifier to mount a VirtioFS file system tag on a mount point in the VM.
// Ref: https://developer.apple.com/documentation/virtualization/running_intel_binaries_in_linux_vms_with_rosetta
diff --git a/pkg/machine/machine_common.go b/pkg/machine/machine_common.go
index 1afc3d15b..d2ba418b0 100644
--- a/pkg/machine/machine_common.go
+++ b/pkg/machine/machine_common.go
@@ -9,6 +9,7 @@ import (
"strings"
"github.com/containers/podman/v5/pkg/machine/connection"
+ "github.com/containers/podman/v5/pkg/machine/define"
"github.com/containers/storage/pkg/ioutils"
)
@@ -36,7 +37,7 @@ func WaitAPIAndPrintInfo(forwardState APIForwardingState, name, helper, forwardS
suffix := ""
var fmtString string
- if name != DefaultMachineName {
+ if name != define.DefaultMachineName {
suffix = " " + name
}
@@ -95,7 +96,7 @@ following command in your terminal session:
func PrintRootlessWarning(name string) {
suffix := ""
- if name != DefaultMachineName {
+ if name != define.DefaultMachineName {
suffix = " " + name
}