diff options
| author | Peter Dillinger <peterd@fb.com> | 2023-02-07 11:26:55 -0800 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2023-02-07 11:26:55 -0800 |
| commit | b5827c806ccbdd98a647a6c1b88227639e6d1ab4 (patch) | |
| tree | 6c978955d6899958131712e609b3deca8a8de9f4 /.circleci | |
| parent | 68fa90ca434257c66a543e3524cd79062ea51ced (diff) | |
Revert to LIB_MODE=static for optimized builds (#11195)
Summary:
Continuous performance testing indicates there's a small performance hit with shared library (-fPIC) builds, so while retaining the motivation for https://github.com/facebook/rocksdb/issues/11168, we set the default for DEBUG_LEVEL=0 Makefile builds back to LIB_MODE=static.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11195
Test Plan: CI, with some updated checks and removal of some now obsolete LIB_MODE overrides
Reviewed By: cbi42
Differential Revision: D43090576
Pulled By: pdillinger
fbshipit-source-id: 755fe5d07005f85caf24e16f90228ffd46a6e250
Diffstat (limited to '.circleci')
| -rw-r--r-- | .circleci/config.yml | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/.circleci/config.yml b/.circleci/config.yml index 091f76591..0a988df26 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -287,16 +287,20 @@ jobs: steps: - checkout # check out the code in the project directory - run: make V=1 -j32 LIB_MODE=shared release + - run: ls librocksdb.so # ensure shared lib built - run: ./db_stress --version # ensure with gflags - run: make clean - - run: make V=1 -j32 LIB_MODE=static release + - run: make V=1 -j32 release + - run: ls librocksdb.a # ensure static lib built - run: ./db_stress --version # ensure with gflags - run: make clean - run: apt-get remove -y libgflags-dev - run: make V=1 -j32 LIB_MODE=shared release + - run: ls librocksdb.so # ensure shared lib built - run: if ./db_stress --version; then false; else true; fi # ensure without gflags - run: make clean - - run: make V=1 -j32 LIB_MODE=static release + - run: make V=1 -j32 release + - run: ls librocksdb.a # ensure static lib built - run: if ./db_stress --version; then false; else true; fi # ensure without gflags - post-steps @@ -504,7 +508,7 @@ jobs: resource_class: 2xlarge steps: - pre-steps - - run: DEBUG_LEVEL=0 LIB_MODE=static make -j32 run_microbench # TODO: LIB_MODE only to work around unresolved linker failures + - run: DEBUG_LEVEL=0 make -j32 run_microbench - post-steps build-linux-mini-crashtest: |