diff options
| author | Jay Zhuang <zjay@fb.com> | 2021-02-15 09:43:11 -0800 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2021-02-15 09:45:23 -0800 |
| commit | 9df78a94f181545dfb1d867dbf11cdf11723c7f6 (patch) | |
| tree | e4556a878b73c2ec49cbd11090246a3590da7ed7 | |
| parent | 00519187a6e495f0be0bbc666cacd9da467a6c1e (diff) | |
Disable flaky error_handler_fs_test that could hang (#7964)
Summary:
The test is hang on https://github.com/facebook/rocksdb/blob/95013df278f399c5fb39aaee2b11f5b987c6e951/db/error_handler_fs_test.cc#L947
Seems db.mutex_ is lock twice in the test:
https://github.com/facebook/rocksdb/blob/cf160b98e1a9bd7b45f115337a923e6b6da7d9c2/db/db_impl/db_impl_compaction_flush.cc#L3208
https://github.com/facebook/rocksdb/blob/0a9a05ae12943b1529ef1eabbca5ce5a71c986bf/db/db_impl/db_impl.cc#L469
As it's just a test issue, disable it for now until the test is fixed.
The hang could be reproduced by:
`gtest-parallel ./error_handler_fs_test --gtest_filter=DBErrorHandlingFSTest.CompactionWriteFileScopeError -r 1000`
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7964
Reviewed By: zhichao-cao
Differential Revision: D26447325
Pulled By: jay-zhuang
fbshipit-source-id: 72f6a346458e059d10e9cc3347bd6bde040cf89e
| -rw-r--r-- | db/error_handler_fs_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/db/error_handler_fs_test.cc b/db/error_handler_fs_test.cc index bcb061bfd..00247c50c 100644 --- a/db/error_handler_fs_test.cc +++ b/db/error_handler_fs_test.cc @@ -864,7 +864,7 @@ TEST_F(DBErrorHandlingFSTest, CompactionWriteError) { Destroy(options); } -TEST_F(DBErrorHandlingFSTest, CompactionWriteRetryableError) { +TEST_F(DBErrorHandlingFSTest, DISABLED_CompactionWriteRetryableError) { std::shared_ptr<ErrorHandlerFSListener> listener( new ErrorHandlerFSListener()); Options options = GetDefaultOptions(); @@ -911,7 +911,7 @@ TEST_F(DBErrorHandlingFSTest, CompactionWriteRetryableError) { Destroy(options); } -TEST_F(DBErrorHandlingFSTest, CompactionWriteFileScopeError) { +TEST_F(DBErrorHandlingFSTest, DISABLED_CompactionWriteFileScopeError) { std::shared_ptr<ErrorHandlerFSListener> listener( new ErrorHandlerFSListener()); Options options = GetDefaultOptions(); |