diff options
| author | Peter Dillinger <peterd@fb.com> | 2020-05-21 08:10:43 -0700 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2020-05-21 08:12:51 -0700 |
| commit | c7aedf1b48d8dfd9a2726b20bec9daee7be833f4 (patch) | |
| tree | 1726a382135032b70a9d78a62ed4f8dccbaf65b9 /build_tools | |
| parent | eb04bb86c6e713230ab07ee7ab919feeb9f891e0 (diff) | |
Clean up some code related to file checksums (#6861)
Summary:
* Add missing unit test for schema stability of FileChecksumGenCrc32c
(previously was only comparing to itself)
* A lot of clarifying comments
* Add some assertions for preconditions
* Rename WritableFileWriter::CalculateFileChecksum -> UpdateFileChecksum
* Simplify FileChecksumGenCrc32c with shared functions
* Implement EndianSwapValue to replace unused EndianTransform
And incidentally since I had trouble with 'make check-format' GitHub action disagreeing with local run,
* Output full diagnostic information when 'make check-format' fails in CI
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6861
Test Plan: new unit test passes before & after other changes
Reviewed By: zhichao-cao
Differential Revision: D21667115
Pulled By: pdillinger
fbshipit-source-id: 6a99970f87605aa024fa540c78cd519ff322c3e6
Diffstat (limited to 'build_tools')
| -rwxr-xr-x | build_tools/format-diff.sh | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/build_tools/format-diff.sh b/build_tools/format-diff.sh index 6e3cbbd47..70da9a578 100755 --- a/build_tools/format-diff.sh +++ b/build_tools/format-diff.sh @@ -124,6 +124,10 @@ then elif [ $CHECK_ONLY ] then echo "Your change has unformatted code. Please run make format!" + if [ $VERBOSE_CHECK ]; then + clang-format --version + echo "$diffs" + fi exit 1 fi |