diff options
| author | Levi Tamasi <ltamasi@meta.com> | 2024-05-09 12:25:19 -0700 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2024-05-09 12:25:19 -0700 |
| commit | 97e70906fab2bdc2878f5e05864165526dca79fe (patch) | |
| tree | dc36c17d7cd0367c6df99bcc83c5f12484e56a16 /db/db_impl/db_impl.h | |
| parent | 1a3357648fa2357097330e2abede82be1a749909 (diff) | |
Improve the sanity checks in (Multi)GetEntity and friends (#12630)
Summary:
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12630
The patch cleans up, improves, and brings into sync (to the extent possible without API signature changes) the sanity checks around the `GetEntity` / `MultiGetEntity` family of APIs, including the read-your-own-writes (`WriteBatchWithIndex`) and transaction layers. The checks are centralized in two main sets of entry points, namely in `DB(Impl)` and the "main" `GetEntityFromBatchAndDB` / `MultiGetEntityFromBatchAndDB` overloads in `WriteBatchWithIndex`. This eliminates the need to duplicate the checks in the transaction classes.
Reviewed By: jaykorean
Differential Revision: D57125741
fbshipit-source-id: 4dd059ef644a9b173fbba767538943397e4cc6cd
Diffstat (limited to 'db/db_impl/db_impl.h')
| -rw-r--r-- | db/db_impl/db_impl.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/db/db_impl/db_impl.h b/db/db_impl/db_impl.h index f4a95b52b..a7f0ec0d1 100644 --- a/db/db_impl/db_impl.h +++ b/db/db_impl/db_impl.h @@ -291,6 +291,11 @@ class DBImpl : public DB { const Slice* keys, PinnableAttributeGroups* results) override; + void MultiGetEntityWithCallback( + const ReadOptions& read_options, ColumnFamilyHandle* column_family, + ReadCallback* callback, + autovector<KeyContext*, MultiGetContext::MAX_BATCH_SIZE>* sorted_keys); + Status CreateColumnFamily(const ColumnFamilyOptions& cf_options, const std::string& column_family, ColumnFamilyHandle** handle) override { |