diff options
| author | Peter Dillinger <peterd@meta.com> | 2024-02-02 14:14:43 -0800 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2024-02-02 14:14:43 -0800 |
| commit | 1d6dbfb8b73cb435b3548cfa12a624a6e8ae2c28 (patch) | |
| tree | ba89d54677d319b7a6c5e7b8f99979b43c789204 /db/repair.cc | |
| parent | 95b41eec6de1d77a07edb5a4ab2945cdf90f14d6 (diff) | |
Rename IntTblPropCollector -> InternalTblPropColl (#12320)
Summary:
I've always found this name difficult to read, because it sounds like it's for collecting int(eger)
table properties.
I'm fixing this now to set up for a change that I have stubbed out in the public API (table_properties.h):
a new adapter function `TablePropertiesCollector::AsInternal()` that allows RocksDB-provided
TablePropertiesCollectors (such as CompactOnDeletionCollector) to implement the easier-to-upgrade
internal interface while still (superficially) implementing the public interface. In addition to added flexibility,
this should be a performance improvement as the adapter class UserKeyTablePropertiesCollector can be
avoided for such cases where a RocksDB-provided collector is used (AsInternal() returns non-nullptr).
table_properties.h is the only file with changes that aren't simple find-replace renaming.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12320
Test Plan: existing tests, CI
Reviewed By: ajkr
Differential Revision: D53336945
Pulled By: pdillinger
fbshipit-source-id: 02535bcb30bbfb00e29e8478af62e5dad50a63b8
Diffstat (limited to 'db/repair.cc')
| -rw-r--r-- | db/repair.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/db/repair.cc b/db/repair.cc index bf409e22a..789454d36 100644 --- a/db/repair.cc +++ b/db/repair.cc @@ -468,7 +468,7 @@ class Repairer { TableBuilderOptions tboptions( *cfd->ioptions(), *cfd->GetLatestMutableCFOptions(), read_options, write_option, cfd->internal_comparator(), - cfd->int_tbl_prop_collector_factories(), kNoCompression, + cfd->internal_tbl_prop_coll_factories(), kNoCompression, default_compression, cfd->GetID(), cfd->GetName(), -1 /* level */, false /* is_bottommost */, TableFileCreationReason::kRecovery, 0 /* oldest_key_time */, 0 /* file_creation_time */, |