diff options
author | Peter Dillinger <peterd@fb.com> | 2019-10-24 13:18:48 -0700 |
---|---|---|
committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2019-10-24 13:20:35 -0700 |
commit | dd19014a7ac3358e1cb89180225039da88b39ea2 (patch) | |
tree | b4cb20a350e7a3d5d9cbd06ce07c3af148fa12e3 /src.mk | |
parent | 2837008525d8d473ba0798144d427465ae71715d (diff) |
FilterPolicy consolidation, part 1/2 (#5963)
Summary:
The parts that are used to implement FilterPolicy /
NewBloomFilterPolicy and not used other than for the block-based table
should be consolidated under table/block_based/filter_policy*. I don't
foresee sharing these APIs with e.g. the Plain Table because they don't
expose hashes for reuse in indexing.
This change is step 1 of 2:
(a) mv table/full_filter_bits_builder.h to
table/block_based/filter_policy_internal.h which I expect to expand
soon to internally reveal more implementation details for testing.
(b) consolidate eventual contents of table/block_based/filter_policy.cc
in util/bloom.cc, which has the most elaborate revision history
(see step 2 ...)
Step 2 soon to follow:
mv util/bloom.cc table/block_based/filter_policy.cc
This gets its own PR so that git has the best chance of following the
rename for blame purposes. Note that low-level shared implementation
details of Bloom filters are in util/bloom_impl.h.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5963
Test Plan: make check
Differential Revision: D18121199
Pulled By: pdillinger
fbshipit-source-id: 8f21732c3d8909777e3240e4ac3123d73140326a
Diffstat (limited to 'src.mk')
-rw-r--r-- | src.mk | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -166,7 +166,6 @@ LIB_SOURCES = \ util/concurrent_task_limiter_impl.cc \ util/crc32c.cc \ util/dynamic_bloom.cc \ - util/filter_policy.cc \ util/hash.cc \ util/murmurhash.cc \ util/random.cc \ |