diff options
| author | Yueh-Hsuan Chiang <yhchiang@fb.com> | 2014-06-23 17:09:24 -0600 |
|---|---|---|
| committer | Yueh-Hsuan Chiang <yhchiang@fb.com> | 2014-06-23 17:09:24 -0600 |
| commit | 96663410b073bdea26e61d8549427e37a0512e11 (patch) | |
| tree | 9f066f6074488b17b7184509a7e1d24e24f74aac /third-party | |
| parent | 854abaf7773d8a3a706c6475145fc5e2379a76f8 (diff) | |
Fix a rapidjson compile error in mac.
Summary:
This diff fixes the following compilation error in mac.
./third-party/rapidjson/reader.h:422:31: error: comparison of constant 256 with expression of type 'Ch' (aka 'char') is always true
[-Werror,-Wtautological-constant-out-of-range-compare]
if ((sizeof(Ch) == 1 || e < 256) && escape[(unsigned char)e])
~ ^ ~~~
1 error generated.
Test Plan: make db_test
Reviewers: haobo, sdong, igor, ljin
Reviewed By: ljin
Subscribers: leveldb
Differential Revision: https://reviews.facebook.net/D19245
Diffstat (limited to 'third-party')
| -rw-r--r-- | third-party/rapidjson/reader.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/third-party/rapidjson/reader.h b/third-party/rapidjson/reader.h index 96bbc6eb5..78391add3 100644 --- a/third-party/rapidjson/reader.h +++ b/third-party/rapidjson/reader.h @@ -419,7 +419,7 @@ private: Ch c = s.Take(); if (c == '\\') { // Escape Ch e = s.Take(); - if ((sizeof(Ch) == 1 || e < 256) && escape[(unsigned char)e]) + if ((sizeof(Ch) == 1 || (int)e < 256) && escape[(unsigned char)e]) RAPIDJSON_PUT(escape[(unsigned char)e]); else if (e == 'u') { // Unicode unsigned codepoint = ParseHex4(s); |