diff options
author | Sagar Vemuri <svemuri@fb.com> | 2020-05-11 13:28:16 -0700 |
---|---|---|
committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2020-05-11 13:30:00 -0700 |
commit | 2e9324718af4f26553da9cab044a37e8e120084b (patch) | |
tree | 5304562e0a195470cca5de904be26e2c926c570b /util | |
parent | f0e8731b72c254da2843d64d27dc7c419bef4bd0 (diff) |
Disable a few timer tests (#6833)
Summary:
Disable `TimerTest.SingleScheduleRepeatedlyTest` and `TimerTest.MultipleScheduleRepeatedlyTest`. This is to help people to not hit any hangs (https://github.com/facebook/rocksdb/issues/6698) during their development process while I investigate further; I could not reproduce the issue on my dev machine yet. Note that timer is not being utilized anywhere yet.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6833
Test Plan:
```
svemuri@devbig187 ~/rocksdb (timer-disable-test) $ TEST_TMPDIR=/dev/shm ./timer_test
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from TimerTest
[ RUN ] TimerTest.SingleScheduleOnceTest
[ OK ] TimerTest.SingleScheduleOnceTest (1 ms)
[ RUN ] TimerTest.MultipleScheduleOnceTest
[ OK ] TimerTest.MultipleScheduleOnceTest (0 ms)
[----------] 2 tests from TimerTest (1 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (1 ms total)
[ PASSED ] 2 tests.
YOU HAVE 2 DISABLED TESTS
```
Reviewed By: pdillinger
Differential Revision: D21502474
Pulled By: sagar0
fbshipit-source-id: ac67caee2011fd14ffb2476a8914a6286a4f9abe
Diffstat (limited to 'util')
-rw-r--r-- | util/timer_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/timer_test.cc b/util/timer_test.cc index 0c5a04710..d32dc9eb5 100644 --- a/util/timer_test.cc +++ b/util/timer_test.cc @@ -115,7 +115,7 @@ TEST_F(TimerTest, MultipleScheduleOnceTest) { ASSERT_EQ(5, count2); } -TEST_F(TimerTest, SingleScheduleRepeatedlyTest) { +TEST_F(TimerTest, DISABLED_SingleScheduleRepeatedlyTest) { const uint64_t kSecond = 1000000; // 1sec = 1000000us const int kIterations = 5; uint64_t time_counter = 0; @@ -153,7 +153,7 @@ TEST_F(TimerTest, SingleScheduleRepeatedlyTest) { ASSERT_EQ(5, count); } -TEST_F(TimerTest, MultipleScheduleRepeatedlyTest) { +TEST_F(TimerTest, DISABLED_MultipleScheduleRepeatedlyTest) { const uint64_t kSecond = 1000000; // 1sec = 1000000us uint64_t time_counter = 0; mock_env_->set_current_time(0); |