diff options
| author | liuhu <liuhu@bilibili.com> | 2024-04-12 10:47:13 -0700 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2024-04-12 10:47:13 -0700 |
| commit | 6fbd02f258b752738455d39fcf6805214c240742 (patch) | |
| tree | 8511ade30fd3deb727a9f4cf66810feed0d9c97c /utilities | |
| parent | b166ca8b74b91468e3ea0ffee0c1850eeaabec62 (diff) | |
Add dump all keys for cache dumper impl (#12500)
Summary:
Fixes https://github.com/facebook/rocksdb/issues/12501
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12500
Reviewed By: jowlyzhang
Differential Revision: D55922379
Pulled By: ajkr
fbshipit-source-id: 0759afcec148d256a2d1cd5ef76fd988fab4a9af
Diffstat (limited to 'utilities')
| -rw-r--r-- | utilities/cache_dump_load_impl.cc | 3 | ||||
| -rw-r--r-- | utilities/cache_dump_load_impl.h | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/utilities/cache_dump_load_impl.cc b/utilities/cache_dump_load_impl.cc index d70fb27c9..f0b2a7344 100644 --- a/utilities/cache_dump_load_impl.cc +++ b/utilities/cache_dump_load_impl.cc @@ -26,6 +26,7 @@ namespace ROCKSDB_NAMESPACE { // requirement. Status CacheDumperImpl::SetDumpFilter(std::vector<DB*> db_list) { Status s = Status::OK(); + dump_all_keys_ = false; for (size_t i = 0; i < db_list.size(); i++) { assert(i < db_list.size()); TablePropertiesCollection ptc; @@ -157,7 +158,7 @@ CacheDumperImpl::DumpOneBlockCallBack(std::string& buf) { } // based on the key prefix, check if the block should be filter out. - if (ShouldFilterOut(key)) { + if (!dump_all_keys_ && ShouldFilterOut(key)) { return; } diff --git a/utilities/cache_dump_load_impl.h b/utilities/cache_dump_load_impl.h index 0034a1453..ee892f474 100644 --- a/utilities/cache_dump_load_impl.h +++ b/utilities/cache_dump_load_impl.h @@ -126,6 +126,8 @@ class CacheDumperImpl : public CacheDumper { // Deadline for dumper in microseconds. std::chrono::microseconds deadline_; uint64_t dumped_size_bytes_; + // dump all keys of cache if user doesn't call SetDumpFilter + bool dump_all_keys_ = true; }; // The default implementation of CacheDumpedLoader |