diff options
| author | Peter Dillinger <peterd@fb.com> | 2021-04-29 06:59:53 -0700 |
|---|---|---|
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | 2021-04-29 07:00:50 -0700 |
| commit | 85becd94c169b311cbf73d9dacd38f4d38206084 (patch) | |
| tree | 8a69fa62484a340c93c5c29e55c161fcb3b3453e /utilities | |
| parent | a0e0feca6281e6f3c207757a15f6b99d3a67070d (diff) | |
Refactor: use TableBuilderOptions to reduce parameter lists (#8240)
Summary:
Greatly reduced the not-quite-copy-paste giant parameter lists
of rocksdb::NewTableBuilder, rocksdb::BuildTable,
BlockBasedTableBuilder::Rep ctor, and BlockBasedTableBuilder ctor.
Moved weird separate parameter `uint32_t column_family_id` of
TableFactory::NewTableBuilder into TableBuilderOptions.
Re-ordered parameters to TableBuilderOptions ctor, so that `uint64_t
target_file_size` is not randomly placed between uint64_t timestamps
(was easy to mix up).
Replaced a couple of fields of BlockBasedTableBuilder::Rep with a
FilterBuildingContext. The motivation for this change is making it
easier to pass along more data into new fields in FilterBuildingContext
(follow-up PR).
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8240
Test Plan: ASAN make check
Reviewed By: mrambacher
Differential Revision: D28075891
Pulled By: pdillinger
fbshipit-source-id: fddb3dbb8260a0e8bdcbb51b877ebabf9a690d4f
Diffstat (limited to 'utilities')
| -rw-r--r-- | utilities/options/options_util_test.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/utilities/options/options_util_test.cc b/utilities/options/options_util_test.cc index 5a249914b..c14872116 100644 --- a/utilities/options/options_util_test.cc +++ b/utilities/options/options_util_test.cc @@ -178,7 +178,6 @@ class DummyTableFactory : public TableFactory { TableBuilder* NewTableBuilder( const TableBuilderOptions& /*table_builder_options*/, - uint32_t /*column_family_id*/, WritableFileWriter* /*file*/) const override { return nullptr; } |