diff options
| author | Joe Birr-Pixton <jpixton@gmail.com> | 2024-06-27 14:05:47 +0100 |
|---|---|---|
| committer | Joe Birr-Pixton <jpixton@gmail.com> | 2024-07-05 15:23:11 +0000 |
| commit | c2d0db5b4ac69fb0e574844f26d9e56c4e1ca33f (patch) | |
| tree | 4e73b80ddb64b21137390241637657b9a3e39465 /.github | |
| parent | 85285ec6d5d6782960cbf326d3338878f81504fd (diff) | |
clippy: disable `incompatible_msrv` in CI
We rely on the msrv job for this check, and `clippy::incompatible_msrv`
has false positives around tests, and non-core-crate programs
like `bench`.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/build.yml | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6fe13bd2..afbca066 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -407,6 +407,11 @@ jobs: clippy: name: Clippy runs-on: ubuntu-latest + env: + # - we want to be free of any warnings, so deny them + # - disable incompatible_msrv as it does not understand that we apply our + # MSRV to the just the core crate. + CLIPPY_PARAMS: --deny warnings --allow clippy::incompatible_msrv steps: - name: Checkout sources uses: actions/checkout@v4 @@ -418,10 +423,10 @@ jobs: components: clippy # because examples enable rustls' features, `--workspace --no-default-features` is not # the same as `--package rustls --no-default-features` so run it separately - - run: cargo clippy --locked --package rustls --no-default-features --all-targets -- --deny warnings - - run: cargo clippy --locked --workspace --all-features --all-targets -- --deny warnings + - run: cargo clippy --locked --package rustls --no-default-features --all-targets -- $CLIPPY_PARAMS + - run: cargo clippy --locked --workspace --all-features --all-targets -- $CLIPPY_PARAMS # not part of the workspace - - run: cargo clippy --locked --manifest-path=fuzz/Cargo.toml --all-features --all-targets -- --deny warnings + - run: cargo clippy --locked --manifest-path=fuzz/Cargo.toml --all-features --all-targets -- $CLIPPY_PARAMS clippy-nightly: name: Clippy (Nightly) |